From patchwork Wed Jun 8 09:10:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Sayle X-Patchwork-Id: 1640401 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nextmovesoftware.com header.i=@nextmovesoftware.com header.a=rsa-sha256 header.s=default header.b=UOEKiwsd; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LJ1fH2Hg7z9s75 for ; Wed, 8 Jun 2022 19:10:31 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7626C383E692 for ; Wed, 8 Jun 2022 09:10:29 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id A57DE3857BAD for ; Wed, 8 Jun 2022 09:10:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A57DE3857BAD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Type:MIME-Version:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KTC0xq3+3FFA/DeQ+lp2Nh7H26oX6/muVFKb7i9ddBg=; b=UOEKiwsdHc5kGrIMF06SXXT3hW gCKHRgJklhsBOB1GX1B0y1ZvpkDjWEsYdaJthS96M1VuGxEDWQiOyU5Gg2eRUz8d8gInKlSbiDz4s 3JGgXf8QfwdcwF3jg/sXWUmth6oPkQ677wv1N1YOs4Lh3NS2aZVJJXZFS3nqElzH4ZviPCzNASQCZ w5MsAmZlewi8kocSu8QYF+YsWEh1LnApnrSdtcDVLjGFZSHtgLdi8aqoedmBdJ2yoCyW8U8wdFR+x L6Mj/DVkaQRO3ijABIim9cTLAg333k+InAxav7GGrP18WF4O0YzyMYAAhkmrNQ/k9Kxs4RiOm6L+g krb3Z5Jw==; Received: from [185.62.158.67] (port=58694 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nyrhg-0008Gx-JM for gcc-patches@gcc.gnu.org; Wed, 08 Jun 2022 05:10:16 -0400 From: "Roger Sayle" To: Subject: [Committed] Add -mno-avx2 to recent gcc.target/i386/xop-vpcmov3.c Date: Wed, 8 Jun 2022 10:10:14 +0100 Message-ID: <075d01d87b17$913036f0$b390a4d0$@nextmovesoftware.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: Adh7F1Ia1YVitm8yQ1ec77bTuroMQg== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Adding -march=cascadelake to the command line options of the recently added xop-vpcmov3.c test case causes problems as GCC then prefers to use AVX512's vpternlogd instruction, instead of the XOP vpcmov that the test is checking for. This is easily solved by adding an explicit -mno-avx512vl to the command line options. Committed to mainline as obvious (in hindsight). 2022-06-08 Roger Sayle gcc/testsuite/ChangeLog * gcc.target/i386/xop-pcmov3.c: Add -mno-avx512vl to dg-options. Roger --- > -----Original Message----- > From: skpandey@sc.intel.com > Sent: 07 June 2022 20:32 > To: gcc-patches@gcc.gnu.org; gcc-regression@gcc.gnu.org; > roger@nextmovesoftware.com > Subject: [r13-998 Regression] FAIL: gcc.target/i386/xop-pcmov3.c scan- > assembler vpcmov on Linux/x86_64 > > On Linux/x86_64, > > c4320bde42c6497b701e2e6b8f1c5069bed19818 is the first bad commit commit > c4320bde42c6497b701e2e6b8f1c5069bed19818 > Author: Roger Sayle > Date: Tue Jun 7 07:49:40 2022 +0100 > > Recognize vpcmov in combine with -mxop on x86. > > caused > > FAIL: gcc.target/i386/xop-pcmov3.c scan-assembler vpcmov > > with GCC configured with > > ../../gcc/configure --prefix=/local/skpandey/gccwork/toolwork/gcc-bisect- > master/master/r13-998/usr --enable-clocale=gnu --with-system-zlib --with- > demangler-in-ld --with-fpmath=sse --enable-languages=c,c++,fortran --enable- > cet --without-isl --enable-libmpx x86_64-linux --disable-bootstrap > > To reproduce: > > $ cd {build_dir}/gcc && make check > RUNTESTFLAGS="i386.exp=gcc.target/i386/xop-pcmov3.c -- > target_board='unix{-m32\ -march=cascadelake}'" > $ cd {build_dir}/gcc && make check > RUNTESTFLAGS="i386.exp=gcc.target/i386/xop-pcmov3.c -- > target_board='unix{-m64\ -march=cascadelake}'" > > (Please do not reply to this email, for question about this report, contact me at > skpgkp2 at gmail dot com) diff --git a/gcc/testsuite/gcc.target/i386/xop-pcmov3.c b/gcc/testsuite/gcc.target/i386/xop-pcmov3.c index 6c40f33a541..ea03d55a2e6 100644 --- a/gcc/testsuite/gcc.target/i386/xop-pcmov3.c +++ b/gcc/testsuite/gcc.target/i386/xop-pcmov3.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -mxop" } */ +/* { dg-options "-O2 -mxop -mno-avx512vl" } */ typedef int v4si __attribute__ ((vector_size (16))); v4si foo(v4si c, v4si t, v4si f)