From patchwork Tue May 31 18:29:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1637541 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ZW/PgK1j; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LCLRN08B2z9s09 for ; Wed, 1 Jun 2022 04:29:51 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 8B82A84090; Tue, 31 May 2022 18:29:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JQVJj5eF2Sn8; Tue, 31 May 2022 18:29:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id D0AC28405D; Tue, 31 May 2022 18:29:48 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 965B5C007C; Tue, 31 May 2022 18:29:48 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 69598C002D for ; Tue, 31 May 2022 18:29:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 57F9E8407E for ; Tue, 31 May 2022 18:29:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AfUJ6OQJi2Cv for ; Tue, 31 May 2022 18:29:46 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by smtp1.osuosl.org (Postfix) with ESMTPS id DBF0383F82 for ; Tue, 31 May 2022 18:29:46 +0000 (UTC) Received: by mail-pj1-x1029.google.com with SMTP id v5-20020a17090a7c0500b001df84fa82f8so3075968pjf.5 for ; Tue, 31 May 2022 11:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HFlaamvOxbftNY7r4PPyGpUl3P8yCTavIdpmfpLS/9c=; b=ZW/PgK1jVRojcqghfrd+y8dRM22kvKED863eqPobKotmtPUMoLlFjxboiB10gLLuFn bcSBqu5GjyMChba3qb3OCGuAzZqtuh8HoHD2tWM6LWE3SeoDypHK3+wlhHn/BCymfTfS lQfweAOizGECld+opds8gv73W3SD4gl+hSH0Bx8oT7ER3DkL5j1BYA+j4HZp6CqtK8vb 0593nzt4kt17UTshXRAPIpJyROg3qQ+3hUxQ9BwX3xv/reCAtdJJv2vZv0wPEpVbOMVb SkqW+S88qqAXluKrWEZjEUz95IBevg9Kxks2f4RR+3lW6HGHzkspIqxsHRS5vbkRsyuz b2WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HFlaamvOxbftNY7r4PPyGpUl3P8yCTavIdpmfpLS/9c=; b=deAZzGqAS1MOaoztjOvouGftLb9NarbVRtvV7YUXiD0MjHxaCH+PsSRrFmQJTwYu9i UP1MobQTsoDJsev+NOMm5h+11qBPENB+2BICHZQlFfV0A7We3o2hlTuVllVspynEnCSY D5O/yQxpvhXOqWC74iP0CTqyIF6kjGJTHaU2HiOp0vXgJEcr1H3QzYcEeSdBQShc2oaM 2MZJeQNccxbupd0Obn64n3VDNPAxPs+UOXAkSH/srvUnX98qoFK2awIi2rlqf6TLaat4 kqSYAY/hOwBMND1UWN5/33tPBHh6HgUdQyXTfb8YIr68NZh9+VBu+WwgUpHfTpzTazmP zqkA== X-Gm-Message-State: AOAM532VgCjijpyG9YIaNPiyijWr5R8+5HnKE6kcL43kDP4abO9ZGB9x YcP+4XLMVo+PFS7NI4sZlNZ/JFGnkbE= X-Google-Smtp-Source: ABdhPJy+cKQ+CY0wfGUU5U4TBACpEscUyr3rkqFmCFdkAZmtG2HYXnu9SPwwUyunyJtQ2SV3NfSqiA== X-Received: by 2002:a17:902:ec83:b0:161:ab37:7ad3 with SMTP id x3-20020a170902ec8300b00161ab377ad3mr61935554plg.114.1654021785840; Tue, 31 May 2022 11:29:45 -0700 (PDT) Received: from sc9-mailhost2.vmware.com ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id x3-20020a170902820300b001618383483fsm11387569pln.224.2022.05.31.11.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 11:29:45 -0700 (PDT) From: William Tu To: dev@openvswitch.org Date: Tue, 31 May 2022 11:29:27 -0700 Message-Id: <20220531182927.58-1-u9012063@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH] datapath-windows: Detect CT timeout. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" CT timeout is not supported in Windows datapath, but currently it incorrectly reports to ovs-vswitchd as supported blow "system@ovs-system: Datapath supports timeout policy in conntrack action". The patches detects it and returns not support. Cc: Alin-Gabriel Serdean Cc: Wilson Peng Signed-off-by: William Tu --- datapath-windows/ovsext/Conntrack.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c index 471bf961b..b33676cc1 100644 --- a/datapath-windows/ovsext/Conntrack.c +++ b/datapath-windows/ovsext/Conntrack.c @@ -1436,6 +1436,9 @@ OvsExecuteConntrackAction(OvsForwardingContext *fwdCtx, } } break; + case OVS_CT_ATTR_TIMEOUT: + return NDIS_STATUS_NOT_SUPPORTED; + break; default: OVS_LOG_TRACE("Invalid netlink attr type: %u", NlAttrType(ctAttr)); break;