From patchwork Fri Feb 23 15:06:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ganesh Goudar X-Patchwork-Id: 877139 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3znvhP3XlYz9sW3 for ; Sat, 24 Feb 2018 02:07:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbeBWPG6 (ORCPT ); Fri, 23 Feb 2018 10:06:58 -0500 Received: from stargate.chelsio.com ([12.32.117.8]:33605 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751902AbeBWPG5 (ORCPT ); Fri, 23 Feb 2018 10:06:57 -0500 Received: from localhost (victim.blr.asicdesigners.com [10.193.185.129]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id w1NF6qBl017903; Fri, 23 Feb 2018 07:06:53 -0800 From: Ganesh Goudar To: netdev@vger.kernel.org, davem@davemloft.net Cc: leedom@chelsio.com, nirranjan@chelsio.com, indranil@chelsio.com, venkatesh@chelsio.com, Arjun Vynipadath , Ganesh Goudar Subject: [PATCH net-next] cxgb4vf: Forcefully link up virtual interfaces Date: Fri, 23 Feb 2018 20:36:53 +0530 Message-Id: <1519398413-10461-1-git-send-email-ganeshgr@chelsio.com> X-Mailer: git-send-email 2.1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arjun Vynipadath The Virtual Interfaces are connected to an internal switch on the chip which allows VIs attached to the same port to talk to each other even when the port link is down. As a result, we generally want to always report a VI's link as being "up". Based on the original work by: Casey Leedom Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 26 ++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c index b7e79e6..7fe8763 100644 --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c @@ -92,6 +92,18 @@ module_param(msi, int, 0644); MODULE_PARM_DESC(msi, "whether to use MSI-X or MSI"); /* + * Logic controls. + * =============== + */ + +/* The Virtual Interfaces are connected to an internal switch on the chip + * which allows VIs attached to the same port to talk to each other even when + * the port link is down. As a result, we generally want to always report a + * VI's link as being "up". + */ +#define force_link_up 1 + +/* * Fundamental constants. * ====================== */ @@ -155,7 +167,8 @@ void t4vf_os_link_changed(struct adapter *adapter, int pidx, int link_ok) const char *fc; const struct port_info *pi = netdev_priv(dev); - netif_carrier_on(dev); + if (!force_link_up) + netif_carrier_on(dev); switch (pi->link_cfg.speed) { case 100: @@ -202,7 +215,9 @@ void t4vf_os_link_changed(struct adapter *adapter, int pidx, int link_ok) netdev_info(dev, "link up, %s, full-duplex, %s PAUSE\n", s, fc); } else { - netif_carrier_off(dev); + if (!force_link_up) + netif_carrier_off(dev); + netdev_info(dev, "link down\n"); } } @@ -278,6 +293,13 @@ static int link_start(struct net_device *dev) */ if (ret == 0) ret = t4vf_enable_vi(pi->adapter, pi->viid, true, true); + + /* If we didn't experience any error and we're always reporting the + * link as being "up", tell the OS that the link is up. + */ + if (ret == 0 && force_link_up) + netif_carrier_on(dev); + return ret; }