From patchwork Wed May 11 08:53:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaurav Jain X-Patchwork-Id: 1629482 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=bdycSWrq; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kypby4g61z9sFx for ; Wed, 11 May 2022 18:53:50 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A425A838F0; Wed, 11 May 2022 10:53:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="bdycSWrq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 633A284128; Wed, 11 May 2022 10:53:43 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062b.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1b::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CD15980029 for ; Wed, 11 May 2022 10:53:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=gaurav.jain@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHR6/mwUQx4YIzWgWIO+MuP1TKT+jnaAGWAWm2Fhucfx66J6t4r6ZlQORYcEwVfVYkM+U0B2iFEWeth33SvkcoTt7zxc7X394c4JLfkdK5/k4ysrbonqeWDm7LkNgZ9cKLAcM6eXqTyjMVPExLa+4sgno6MOpcSIy5tDECPmMIk/cSkSyVxQ2x9sl+7ibuj1RMxAjcKz5VulFCvbIAlLnWM3305IJRvgXuCQbXcUwzYWvwC2o86JzPa2XAhfMqpXwZx0aPIAUjxt/0k6O/dCmb1DSa4hewqJxwo7AswmZx9asyMMXokRPdkwR3fQPT43CWCDCME9hBHrRzwgW/F8+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2hgnwHMf42OxUIPmtyW+GJvSPkHFh57ZfWyfu9p4O6k=; b=FhKI1pJV/nimkyHXK6r+Wq44AdzgOS5zy5fee5/e6c4SG7jOto4xDPv/jW4UTLvIt3nKDs4nPCK+lmDyZUbKRcalv6dyucGaX8JHshNUFm3S390z5Z0/OUCm1OQa3QGG9RCsp9ZNBphgUs6VhOKIDBxwyNS4GCUf/20z4mT9PuMxxu/xxwk7Nj9UjnUauYabTynSX61aqxme1MKS/dc8YKyq+LEakv2D36q/BjqjizUlj7MWcimNjIvh2rV08P1bKWLVG+L/b9kTqww/xVL25T3jKArfya8YRhHcaqj2/05gQWTM1i1NV7525QqFxtj0iFiAphQ5ZM/S1aII8BfO6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2hgnwHMf42OxUIPmtyW+GJvSPkHFh57ZfWyfu9p4O6k=; b=bdycSWrqRxGGZgWlPfXyDzr3JOG5t5S03XNxZnlKs/eRgsD6zWDKuAvCHmrJxEL9jOltIygtngcDofHuuQuwXAnkPwcth4H2xVILp4dVgqUJnHo86bcIvFcRnMgLP7z3Y+muAXeAQ/H6w7LnA+cNlm1ly/HrR5p30Fr26Q5AdXg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5342.eurprd04.prod.outlook.com (2603:10a6:803:46::16) by DB8PR04MB5611.eurprd04.prod.outlook.com (2603:10a6:10:ae::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Wed, 11 May 2022 08:53:39 +0000 Received: from VI1PR04MB5342.eurprd04.prod.outlook.com ([fe80::8512:f51f:a027:ba71]) by VI1PR04MB5342.eurprd04.prod.outlook.com ([fe80::8512:f51f:a027:ba71%6]) with mapi id 15.20.5227.023; Wed, 11 May 2022 08:53:39 +0000 From: Gaurav Jain To: Stefano Babic , u-boot@lists.denx.de Cc: Fabio Estevam , Priyanka Jain , Ye Li , Horia Geanta , Silvano Di Ninno , Varun Sethi , Peng Fan , "NXP i . MX U-Boot Team" , Gaurav Jain Subject: [PATCH] crypto/fsl: fsl_hash: Fix dcache issue in caam_hash_finish Date: Wed, 11 May 2022 14:23:19 +0530 Message-Id: <20220511085319.1941861-1-gaurav.jain@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SGAP274CA0015.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::27) To VI1PR04MB5342.eurprd04.prod.outlook.com (2603:10a6:803:46::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c28beff6-a9b7-4bc2-cb41-08da332bbdea X-MS-TrafficTypeDiagnostic: DB8PR04MB5611:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H+djPRAP3Ywh+KKJBnqZe6IGpOj83n8Ka5le0T5zcob/OnrcbK9++qAkF7nmIwMlF4J2VNIotXC0PhFkT9/oM16qpKObk+p10m5YSk2fNRl6fh8Z0uL6sC6vMPWNZbHBskewcENQ3SSOmY9XWmk86z4Uf4yXUwarh5sNBw4X0xMnHFdoWBtvnIUeX+9UZOcJUZqaUlQhXDDjJjnRL7SQsklDiimtNTFavAlOKXri7khhXc95Dr08XuR24XhDHMKWlnQjX8EGCzuwsA/E3ngJXCTlnLk5ZcT+ByGLcR8B4MRrPR6p6Bkk5xafWLFPoaq67xvjLg2zBg5FwTHvs9D1EolUcexyFx+1YO3SVjzHbAUBOeZjJXBr8/OOVUwMK1+FH1rNTShAiEW0lq9fIJSjmozvi0eSVvbnC3VxQDPTZdKWN7HdOVcuFeUJo2TcVOAG8u91VW7cCBOZH8pdONCUIokd7cS4pkz4YGT2/vnKU6n8xjjPoge97HF6Sko6wk3z7+reD+KcKIubPAfAMUb2Eep1RU+oDpJuwr6KnXQ4tzp87KhJadpioXXeZAXWHog7pvdNg2HuRD5zckNnpOaLhFz649mLVA7y3exLC40zZ3pRQ/8ARQUJ2e0UB2o4GIPvbPb+HL7q1waeaQEzevzoBehV410nuKrwR7wXKjn3khHsbc06dZeXdwX/XYSghFTj0ocNw6rAmJdYAbaXyo47KA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5342.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(36756003)(316002)(6666004)(38100700002)(86362001)(83380400001)(66946007)(52116002)(8676002)(508600001)(4326008)(66476007)(44832011)(6486002)(1076003)(55236004)(8936002)(6506007)(66556008)(186003)(38350700002)(54906003)(2616005)(2906002)(5660300002)(26005)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: o33gNOU+5+RDkSd1kMl73C20gAqHPEVLtr0oERsRRoJSMGyMszdLz7igRrNktpDLPiDRSMRGGNnwEi261nYGKopbDdQmRQN0ZR4GhiAvQjV7Z9xrrOOw3ALgcLDwN939BvOdBpkshseA/a6A5suf7p9mZFF66RK6dXLwQ7toGbYYndWZNKH8ddFTrGcqm7T5jWAs4wzn5uGp2En4BhePEluGIxl3VOZyAuzXl/zDV/Z1wbtGbotPDq7rr/pJrdGLqJYmOMKoBRcpgG2rk0c1OOUIHMt93c56odrwQZJB9uwI2j9MKkKvMoSOrpMonXPVZHqafu0go7Q5JPIdPno8e6gdAN0+r65CuPrvHX1yd/FPpGS07YVWi8xAGdol+1EpYccsW9IpKgHK0zDdssEKKL7lEbPnrsEKgsDlOcQP0XseUq3G6nVM3sZFJDCuB4o2Bnio8CKGt1Fh8uZQUTCHGwyCyruOOaJKsl1+lWNDitUedjhssjTN9I9pYEX8o7MURkoYTM6I11pan90KB6zYRU6nnU4Gb72/ddP6s0dYJHb5zwrk3r0ZI5Z8JlDo2545BpdGXx5mvDOG8Cm1fFZwe3xYZsPy6FRMvq+/zK/6KYQJG49gig5vc+e65TxzxMgRA9iVk7AVWXwj0Lxs85SNp34kcTEiHLbpF1o2XTrotHNLfhZjmS53dj9psXKJl1n8uY/PWziit9vAIVYKtKB5/MmMqe75Ui932L1rG3wo26LoHFdkINdUUPD7C2/j/gDfIQfWq7sePDQVOqlqg6b3tD/pZCY4VEkHbkzvtxPsAncPA6hiDwc1AQdjpOW7CYOTCn++L2X+9t/My0MO6bNACf4752DyiOENRQakj5fN2pOgjXvJLH05kniNAhfmUQcHTczmwG0F26aywQTIllqH3d3Q9z08AVpph2zeki+q/hEZAE85FxUU+qvercZIYbiHpSHKUDTQExvGNKXVrAk/kU2lhF1LIciUX4651K6GD4Nm5/Syxj4vYDADU3XR6yfVio6C50TzO+6JA1uTRYF8p0y5+IXi+iEEgYYEHRc/++0E2RzKiyyaddEKzxNBpG8WljVeCOULmoDbsolBww8cAJVLTW2vVmnk0expbtO+E534dqQH0mKnrYuyxsLtNXlMslOhCwtLYVRoyQomtY/CqBev/w9d2vEIKGta8lwmyhM9/QYp3V3FxlrvIi54y3E5kernlPQvLb7Cp83ESFnkzP5T5AgRTqNJpBIfoJTtbHWlfmhiYwyj//0h1cefnlXXvMlEVl3UB0FOhm1Mx6SPPXv5PoTOU3ZsqSUTFNHgFd96JIjZwgs93Ft5Y2UDos1vqSP1L9f7xH1M/ECyL1FaagTB9P3OmdcB9AwViLpO2k8Y3f8zVP9opUe/+qFyXJqS9jJw8hMXhCb4Z4TdwS9C/r3e92hAPS9xUblGXYm1aRLs9Rq66JtqJF0MUH7uuXk8DJj4gEdUTQHCQaS7V4cwWDXNvjvpjsdqKr45Et3hgrSRM6kj+X82/FO39pmmeZC5GljWwUZQoyIwjDrc0QfR3XbIVT1AXW8ACe3CTsUzCBYVQtReG0LO4oDHWFO9CyFKIZVsCe9AdFHFcWh2eUM2l4BWmPCQjFxXlFRgvyNPVV5Aet8oC+ND8ESWr1FPFu/2GrToecwadbAUf07H8qnAL1RO4l8AF0OrM0B0DuRCrwvQ7v2d53CY9YI5zil3B3KtLf+xKgySwOXl1u+OqcoRyg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c28beff6-a9b7-4bc2-cb41-08da332bbdea X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5342.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 08:53:39.2831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g3Y7Ob59AQQWPt2BgeLoW9Z3jRpyeenlB7QLv96KcKrntDbDehYSFpDL65vwMYig7yWMLl6vOA2jcm0PofAr2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5611 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean HW accelerated hash operations are giving incorrect hash output. so add flush and invalidate for input/output hash buffers. Fixes: 94e3c8c4fd (crypto/fsl - Add progressive hashing support using hardware acceleration.) Signed-off-by: Gaurav Jain --- drivers/crypto/fsl/fsl_hash.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/crypto/fsl/fsl_hash.c b/drivers/crypto/fsl/fsl_hash.c index a52c4ac957..9e6829b7ad 100644 --- a/drivers/crypto/fsl/fsl_hash.c +++ b/drivers/crypto/fsl/fsl_hash.c @@ -149,12 +149,20 @@ static int caam_hash_finish(void *hash_ctx, void *dest_buf, driver_hash[caam_algo].digestsize, 1); + flush_dcache_range((ulong)ctx->sg_tbl, (ulong)(ctx->sg_tbl) + len); + flush_dcache_range((ulong)ctx->sha_desc, + (ulong)(ctx->sha_desc) + (sizeof(uint32_t) * MAX_CAAM_DESCSIZE)); + flush_dcache_range((ulong)ctx->hash, + (ulong)(ctx->hash) + driver_hash[caam_algo].digestsize); + ret = run_descriptor_jr(ctx->sha_desc); if (ret) { debug("Error %x\n", ret); return ret; } else { + invalidate_dcache_range((ulong)ctx->hash, + (ulong)(ctx->hash) + driver_hash[caam_algo].digestsize); memcpy(dest_buf, ctx->hash, sizeof(ctx->hash)); } free(ctx);