From patchwork Mon Apr 25 10:41:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaurav Jain X-Patchwork-Id: 1621869 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=jgumvl4c; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kn1mf56Pdz9s07 for ; Mon, 25 Apr 2022 20:42:24 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E3E1483953; Mon, 25 Apr 2022 12:42:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="jgumvl4c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D0E0080291; Mon, 25 Apr 2022 12:42:13 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0619.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe02::619]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 41C8F83A96 for ; Mon, 25 Apr 2022 12:42:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=gaurav.jain@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=am0ofMDTBDbbA7lcoipYy9PrY+PqpnGJxbuXj7XQm6eNUdVlzNb3ku9iLG1fyJKB5dOi7CrHf8nE7TLZ+sFmfpvTS553MZ5wV2q2RvTpBYYf1bvhO3yHroswOL7/7l48hlGh01Qr53gPgjzQEbddH8sSKjSKjYdR536768hNiAWediZUxKeNlJgI2OznYS2om5QSFClCeXiXFN3Xa1MpcSqifjGRFNrpbBX2q/1VgC4d15RABLmlud0vkfw6DWIqzoAjWVqfxme5VsOICMrUlQwi5Tn8uiKaoD6unBc19uqGichITcAYxlfv4+czxvsavHmG80XRmpU+78HQa8bS0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/UN5C90R03TTvRYL9EhGsQGVxvcqD0PUx/cuUXyhDG4=; b=aVNx534KnI1kPialkJuB7UJf9vX1GKbe6dSXILK8wUrKaxukqFnYwh+Nq5GeQy2d25pwTaTIVd2VC1oMYQfJwq8dC83ix4zoCS2A9Bft94Y4xSV9XfpbGODexrjJ0FCp6p5mnQGgx4Cx9+HMGd2bZ8Tr98S01khX4lI/KsShOBkFOXdu9Oeu9UHqs8kMXN/0aOAw1p17KvnpjupP/lz3BKEcX1fMxJHvBQrCCBegfWFupldQIsgrB8yhUoy3zFW85s3rsWfp+tV9iU9XQjbsoybcee++I6bBjJOdDTB/Y7N8rbM642hmnh0P3Ldf1YLFyRe2UEZ7iYCfgnIVuGV6ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/UN5C90R03TTvRYL9EhGsQGVxvcqD0PUx/cuUXyhDG4=; b=jgumvl4cJubwWJUImCxEwqh47w42ThXlu0kzJ8d0SlqMoD0iImMeDRqfYKCvBog969rrllb49giEE13ZH8F18ULfBRQoE7zxpDcNCD6ABtzdu+kxJ4ZZdOtuDoI6IM2hLBJOLIAby0c6+HLQipb4KOFvqtuF/3RRy6zBQlHp6sA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5342.eurprd04.prod.outlook.com (2603:10a6:803:46::16) by DB7PR04MB5419.eurprd04.prod.outlook.com (2603:10a6:10:88::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr 2022 10:42:07 +0000 Received: from VI1PR04MB5342.eurprd04.prod.outlook.com ([fe80::c587:139c:5129:6d02]) by VI1PR04MB5342.eurprd04.prod.outlook.com ([fe80::c587:139c:5129:6d02%7]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 10:42:07 +0000 From: Gaurav Jain To: Stefano Babic , u-boot@lists.denx.de Cc: Fabio Estevam , Priyanka Jain , Ye Li , Horia Geanta , Silvano Di Ninno , Varun Sethi , Peng Fan , "NXP i . MX U-Boot Team" , Gaurav Jain Subject: [PATCH] crypto/fsl: fsl_rsa: Fix dcache issue in the driver Date: Mon, 25 Apr 2022 16:11:45 +0530 Message-Id: <20220425104145.357814-1-gaurav.jain@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SGBP274CA0013.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::25) To VI1PR04MB5342.eurprd04.prod.outlook.com (2603:10a6:803:46::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eebee24d-8ff2-4441-bf96-08da26a83e86 X-MS-TrafficTypeDiagnostic: DB7PR04MB5419:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1HN2b85bUObLdlTalMAJNAEqek3s24LZWV8WdIFa3EKqSRASROx/5Uf3ajacbdMm7r0OZv1ow51GdTQXbCEcakOeAVGiIvxg1sJ7gOIHJv/bC5gTUZGIphd8DvlxXzPeH1cXnd4MN3It92ziwfPeqEeVawwJvAQM70puc7b7SyymlZR3rM07wHqnAGcEhQylzH8DsBbZtZXLQyp4buawPC0A/VmsPG5aRf7bE3jCWZ9atvmc1sIoNbECMCQ6kmYP+4cSCFjhQ25740jNGsdHmZirVgEAHcL7qDFf6PLVvwCrQOzQ/hrXrUF9f/cdiku+wSviINZPLBfkGsJV4Qy5/KFeTWZaBXQrkEzpygCXtQP0TghgIexvbdtQxaUbUwlQ8wh2ihD0RLS6tV42KwmdYETYNpuFa9hXj8BIFlR1zAaPLVGu6cE1Xgyz0O4IsNPqMvE8dU9GcOwWlfYzWmSkStHXJ0v4nsXktcOH45+y/RQYN5JaV++H779cxGT0YCMesBCtHxQmmPkt5rIKMkMeIL+BV7kxxV9Gqvbu0+QK+T6ai/Oaj3rhmyXPBd/WINypBJSJw0mhiC2eAJ4LTHeuJ5TS4M4RM8kR5nzCO7fXveP8CqxlidjwaCSTOwZcIrQEh4n0VkhRgErksHDJWoziPtJ4a9J8AMcpf3LXTBECFCDsSNjl7eim8TNT3H5mwF8MVmC5X3Lm7ovHlN70XmTjOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5342.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(38100700002)(6486002)(86362001)(2906002)(38350700002)(508600001)(66946007)(8676002)(4326008)(66556008)(66476007)(316002)(5660300002)(54906003)(44832011)(8936002)(26005)(83380400001)(6512007)(36756003)(6506007)(2616005)(186003)(55236004)(1076003)(52116002)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LERWsQ5BXTPKhTKzQKrVMMc0JUPwrTvvUGlqVyMFK27QISJM3rYIHBHwV5lK1VRsR1SnyQeNMNLA80fLexHt617pFbP5SP8AIKywLlc1etqKxFw0f7XuXFPMk9/0q1uzKTvCSfVT2UI2faT7rOprX6rXMP5Mmr49UuGhVUXxESkZHfw5QYxsLXLWToy9IOafwKbrG0ftHPCG88ZrvhWeCBWFVS89yeqq0Gbu4LNez8bz21eTxqajEifoo7lSHzF29sC2n1hkBIyh79w+CTL+etTvf4Xzz6xTEH9KELJ1cm6Hp1b3ZTuihyKFY7k48M9WjZ2y5xjhsxijYCnNk8fGlKPe3zaj/TLq6nMi8Ei+w59pj9uL0DMzNgjqj4eRa/djAk40X9zu3vCoYh/H/0/5Y2ZCn7sUd9XJWnK9KxvuDvrSV+a9bN222MYKC78P3OW/eTMveG5Za4x3iqhjS7R40SxaE07XFegKRlg5dnM14WwOiQc+sXg9ufcFtkNq7Di46kwuvygUixpv1YPvTuSj36Msd/SqeWh23U6ynzHqYtKBwANzoSCFDtsh/3/anlD0GnUlljOPIULT4cb42UuKY91eW7dYYLN8IVfwmoL3FUdmpejwRUu9IeSzld8QmOXVR3owbZWcB87VUS7ik3qiZ1Apna8/+JWhZbQZcTjMAh4jTHyqZY7LNgGu7NKzrYM91q+coiEn63CCP94Yn3vp/d8BmG4zhWy+P+vupX9lrGmNCi5fDjxuAMuq5vhX0mwErH8wd2QAqosci6VRf4gLVVcUjzc8pU9UF1wiiMEGT0igOsM3rL0dWTBPVkCHwpLxIgorSKNa13OS6cDn2D4ftdf2mrGxGe3jqSrh0PtFLS+Jj4WXEu4N0OMZgYxzPcWnS3NI5HKT1LbaXI634BtIS2iCBvOSCOWNMFhq+S1GjZnr3kpJjR3ud0UBfXit0la15TJ3XDY8FhCfkSYw2e3uSRgK21aqWcyTg2/Oh4fAOrVvjK6cXgPDMpHLxVlEgJJhpFKrmuWJWpbMu6hlev8kGFwyzZC2DYnUh9bQgOujbFaMerth/5g968lMNgDLoSHe/zoXB56Gq53QSbcy9AQh4GjteJ3jNBqeE5Lhq3TSO8cSP7Oo0wPxiHvgYU2hGHHyPLeRZ/YBEBEr12nd86gxOKhL/k0Dub+ML+vZ0e22glHzonnXVLk4wmlXoySc59P4G4ufKotpnp7+J5ku4OaDta/Mqz97axfUnIrxC0douHsD8sfejB0BLJgT+JWJ6fIk5P7DKJukwdmh0/ymQwTkJ7SyhVTxoskNDPALpCsaNZfhscoEja65WC8ri9pwA2cdw2c8AxS7XMBrJCXRoV0jkqOEAlKtShubb9JuoRYU5J2VN238ZE6p6cT9QIG9wSgmvrG9dxYd1FhKldwO5KT0iIhO0oCDDgv2gf8ACA0nnn9Kq+R744kuvBwIYxooNTzzNqtBfDU9nMdJlh2Vrswe3SVdFnX+qZJ1IVCkz47/6J7YgRU0iaLo04CvTdd1s8JHrAwkSTv5QPcJtOGrdnzEkwPRInXJA7sPcNJcxJkMftV5Ag85eOumim8QAFRz8Xb6B3gmBI9b1YVREqqT7K2DoyFbK/WN9mRXTZk8MR7jUwM/cRAu9qBOFcmOmMNKhnvYZka7gWT9NootWC0toQm2Je2SpGaKjR0GuTzAC2Bz6SpWs5WMnyQq+cIhf4TVw8er010UtQRXmkinRPXOp0Whvg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eebee24d-8ff2-4441-bf96-08da26a83e86 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5342.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 10:42:07.5007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OAfOwd8YK82dyY4MeDoEnp4QnNajE+flJoIFscorHAaPqV5C0Nwe0Q/JKuV8szeVxac7qpSn9NBruFL0/sUNKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5419 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean From: Ye Li issue: CAAM fails with key error when perform Modular Exponentiation using PKHA Block in CAAM Fix: add flush and invalidate dcache for keys, signature and output decrypted data processed by CAAM. Fixes: 34276478f7 (DM: crypto/fsl - Add Freescale rsa DM driver) Signed-off-by: Ye Li Reviewed-by: Gaurav Jain Acked-by: Peng Fan --- drivers/crypto/fsl/fsl_rsa.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/crypto/fsl/fsl_rsa.c b/drivers/crypto/fsl/fsl_rsa.c index 897ee855ea..7ea0c193f9 100644 --- a/drivers/crypto/fsl/fsl_rsa.c +++ b/drivers/crypto/fsl/fsl_rsa.c @@ -36,12 +36,21 @@ int fsl_mod_exp(struct udevice *dev, const uint8_t *sig, uint32_t sig_len, inline_cnstr_jobdesc_pkha_rsaexp(desc, &pkin, out, sig_len); + flush_dcache_range((ulong)sig, (ulong)(sig + sig_len)); + flush_dcache_range((ulong)prop->modulus, (ulong)(prop->modulus) + keylen); + flush_dcache_range((ulong)prop->public_exponent, + (ulong)(prop->public_exponent) + prop->exp_len); + flush_dcache_range((ulong)desc, (ulong)desc + (sizeof(uint32_t) * MAX_CAAM_DESCSIZE)); + flush_dcache_range((ulong)out, (ulong)out + sig_len); + ret = run_descriptor_jr(desc); if (ret) { debug("%s: RSA failed to verify: %d\n", __func__, ret); return -EFAULT; } + invalidate_dcache_range((ulong)out, (ulong)sig_len); + return 0; }