From patchwork Tue Apr 19 16:37:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Van Haaren, Harry" X-Patchwork-Id: 1619019 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=TEQ+BuP3; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KjTwm5x2Kz9s3q for ; Wed, 20 Apr 2022 02:37:11 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DBFF860BEB; Tue, 19 Apr 2022 16:37:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ed9crlloaBgv; Tue, 19 Apr 2022 16:37:08 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 2435C60B48; Tue, 19 Apr 2022 16:37:07 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E773FC002F; Tue, 19 Apr 2022 16:37:06 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id C5DBFC002C for ; Tue, 19 Apr 2022 16:37:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9F134842FB for ; Tue, 19 Apr 2022 16:37:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h7vuuRfhmlOq for ; Tue, 19 Apr 2022 16:37:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by smtp1.osuosl.org (Postfix) with ESMTPS id 01314842F8 for ; Tue, 19 Apr 2022 16:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650386223; x=1681922223; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=njPZuw3R2F+U1/dRbrpyX1uLtAJIGBg+flkNEH6Wy24=; b=TEQ+BuP3Ee0+OljffcUg6+i0Bp3/X8V7YcWLuYXDnc26l32alaP9k4re KC0R96jGdlDRtutOTZPY37ujECiGJdgqivA5QLQJfRMOVb1KHBzlymqF9 mmIbif3kBeT+5Ta9nShwHW/6vriZjQkWxxH06YU0+2WEyuAb9Uhc19Q/g yHZbjHuuwDeQh0u0AH9Yh29GMqDCiBTUsYGSWQO75w0w3DPAcbYnb7PmQ LPtFAGW9T4bLy1EdOlmtJ0bCas2klsq0+1g1DdEePhka8GsUcA8qFEZcb pU/mNRo841T6djRylw9COQN3K2viJQfM0oIfOqnhAd1I5+1AxVRNj776q Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="326710947" X-IronPort-AV: E=Sophos;i="5.90,273,1643702400"; d="scan'208";a="326710947" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 09:37:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,273,1643702400"; d="scan'208";a="647321070" Received: from silpixa00401120.ir.intel.com ([10.55.128.255]) by FMSMGA003.fm.intel.com with ESMTP; 19 Apr 2022 09:37:02 -0700 From: Harry van Haaren To: ovs-dev@openvswitch.org Date: Tue, 19 Apr 2022 16:37:00 +0000 Message-Id: <20220419163700.1465871-1-harry.van.haaren@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH] dpif-netdev/mfex avx512: fix ubsan shift on bitmask X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This commit ensures the compiler knows the 1 bit is an unsigned 32-bit wide 1 bit, keeping undefined sanitizer happy at runtime. Fixes: 250ceddcc ("dpif-netdev/mfex: Add AVX512 based optimized miniflow extract") Signed-off-by: Harry van Haaren --- lib/dpif-netdev-extract-avx512.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev-extract-avx512.c b/lib/dpif-netdev-extract-avx512.c index c1c1fefb6..8cd8b6c6e 100644 --- a/lib/dpif-netdev-extract-avx512.c +++ b/lib/dpif-netdev-extract-avx512.c @@ -619,7 +619,7 @@ mfex_avx512_process(struct dp_packet_batch *packets, }; /* This packet has its miniflow created, add to hitmask. */ - hitmask |= 1 << i; + hitmask |= 1ULL << i; } return hitmask;