From patchwork Tue Apr 12 09:27:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tombannink@gmail.com X-Patchwork-Id: 1616125 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=uclibc-ng.org (client-ip=2a00:1828:2000:679::23; helo=helium.openadk.org; envelope-from=devel-bounces@uclibc-ng.org; receiver=) Received: from helium.openadk.org (helium.openadk.org [IPv6:2a00:1828:2000:679::23]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kd0kV3QJDz9sGF for ; Tue, 12 Apr 2022 19:27:46 +1000 (AEST) Received: from helium.openadk.org (localhost [IPv6:::1]) by helium.openadk.org (Postfix) with ESMTP id 5DB8331E074C; Tue, 12 Apr 2022 11:27:40 +0200 (CEST) Received: from helium.openadk.org (localhost [IPv6:::1]) by helium.openadk.org (Postfix) with ESMTP id 4FF2431E043A for ; Tue, 12 Apr 2022 11:27:12 +0200 (CEST) MIME-Version: 1.0 From: tombannink@gmail.com To: devel@uclibc-ng.org Date: Tue, 12 Apr 2022 09:27:12 -0000 Message-ID: <164975563232.1938924.9962127554425949228@helium.openadk.org> In-Reply-To: <164975506987.1938924.10353007161218512362@helium.openadk.org> References: <164975506987.1938924.10353007161218512362@helium.openadk.org> User-Agent: HyperKitty on https://mailman.openadk.org/ Message-ID-Hash: PSRRXX5VYGQ6ZM7U7TJZOD2VXMVVDAB3 X-Message-ID-Hash: PSRRXX5VYGQ6ZM7U7TJZOD2VXMVVDAB3 X-MailFrom: tombannink@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Subject: [uclibc-ng-devel] Re: Bug in memset on ARM List-Id: uClibc-ng Development Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: It looks like I mixed up some tabs/spaces. Here is a patch where the tabs are consistent with the existing code: From 5e0845fc2dd20a3a7334663f55a1f349f98d4835 Mon Sep 17 00:00:00 2001 From: Tom Bannink Date: Tue, 12 Apr 2022 11:15:41 +0200 Subject: [PATCH] Fix bug in ARM memset implementation --- libc/string/arm/memset.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libc/string/arm/memset.S b/libc/string/arm/memset.S index 412270f50..f4b30b3dc 100644 --- a/libc/string/arm/memset.S +++ b/libc/string/arm/memset.S @@ -32,6 +32,7 @@ memset: cmp r2, #8 @ at least 8 bytes to do? bcc 2f + uxtb r1, r1 lsl r3, r1, #8 orr r1, r3 lsl r3, r1, #16 @@ -68,6 +69,7 @@ memset: mov a4, a1 cmp a3, $8 @ at least 8 bytes to do? blo 2f + uxtb a2, a2 orr a2, a2, a2, lsl $8 orr a2, a2, a2, lsl $16 1: