From patchwork Mon Mar 28 16:14:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1610317 X-Patchwork-Delegate: priyanka.jain@nxp.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.a=rsa-sha256 header.s=selector1 header.b=A5o+Wap2; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KRySf28Pnz9s5V for ; Tue, 29 Mar 2022 03:14:26 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AE3E083C8F; Mon, 28 Mar 2022 18:14:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="A5o+Wap2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5CDD583C91; Mon, 28 Mar 2022 18:14:18 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20610.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::610]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D991983B12 for ; Mon, 28 Mar 2022 18:14:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MEJHUg8HaPTqn2n/Zbe17EKYQiaJvboMTWOa1uC9i5hmw/B9yJbzBdmLcaaHJ0V1wLAF3GKApK3LyjO8SQ+QxHuzMC3sf9Q5VRpeyA1ML7JFEAks46affyXQ1gZviYU854m4/Z1P4td5vndpJS2v0OgNyn1b7uRmuMiKbp+aKj1aJOVZKIAlQbSoJ/AinWSC1exJXiPL5bykKceGOhTZNDvG+cxznCiLY1ANr1CFtvqLo0//jmu2JCpE7hbI3E9eR/3jaNiNMt/JPUnbutymhOVxFBQGvsTdhufRD61cPQ7FKbuUgcdJInDY7re26LW784MSvRUBvXq/ZXHXN6R66g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ozfi7vlGzGIvlA9Ef6j6nDo1UHuF69TfoDm9R5ww09c=; b=gt5bQG/WniZ3ASAAXXn1TTUurTrf0Qgn0OfzUe6ZYB33HE4EWEuQdj1JxdltzbOZrBzO6ktXDwTHA9142kTLCkJFyRRuZ6oaFg/1lHTmbZR+JYwiIveuWfNO5HUuP8NXAcEdai4oIFUdJWuKGxkniNYcfgONM2NBKAiTbjExNyV7kOZN+JROLNoAtgkwtBQs/cglQRKg0av8iWa6mo+EbdUgwfJIU4LpDJDbyBKm1s0nI4ZPyaWLXQ66BLwg3G/K9AUcItXBVmYKWWvbTrFDUefd+sasbZt/ktNZffAl8UK/PfJoJ84sDUcn2MvqDTQ5lNFLGi8/duQDjqZpLvHJPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ozfi7vlGzGIvlA9Ef6j6nDo1UHuF69TfoDm9R5ww09c=; b=A5o+Wap25Cg/9OWKj9ZYo9Grrm4coLQctHDFxfpHro9HUQ41aEgiXpvl4qS2PIC+f85Oy/vnIdJ6QyWRZHFKN2dGQIZgGspaTuzDG6pJ4TgnD8GkVcXRidMkbUqx91T9mew1CvrVH0rD8o0OH6Om2wlMQuyo1ROL/+ufAC1Nuaj2P80boz5aWeSly/Npk/fsrbWWuupldB+gg2s7jlsZYHUyvy8vLLBThhdSvGTWwEp89n+YONTUSwIakNfirFqEOw1qf0uG9hWVA4C2hJ+dbacSWfz9fbrctvHL/cB4TSkRyZyos43GYij5hgn1S00Lu8faJVOq+E65NG7XYg+/GA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) by VI1PR03MB3632.eurprd03.prod.outlook.com (2603:10a6:803:2d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.22; Mon, 28 Mar 2022 16:14:14 +0000 Received: from DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::356c:789f:d20f:92bc]) by DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::356c:789f:d20f:92bc%7]) with mapi id 15.20.5102.022; Mon, 28 Mar 2022 16:14:14 +0000 Subject: Layerscape DM_SERIAL (Was: Re: [PATCH v3 16/29] serial: Add semihosting driver) To: Tom Rini Cc: Simon Glass , Linus Walleij , Liviu Dudau , Andre Przywara , U-Boot Mailing List , Mingkai Hu , Priyanka Jain , Rajesh Bhagat References: <20220322205938.1721846-1-sean.anderson@seco.com> <20220322205938.1721846-17-sean.anderson@seco.com> <20220328160344.GA14476@bill-the-cat> From: Sean Anderson Message-ID: Date: Mon, 28 Mar 2022 12:14:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20220328160344.GA14476@bill-the-cat> Content-Language: en-US X-ClientProxiedBy: BL0PR05CA0029.namprd05.prod.outlook.com (2603:10b6:208:91::39) To DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d24d6c3c-d182-46b3-33d0-08da10d6003f X-MS-TrafficTypeDiagnostic: VI1PR03MB3632:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QS6FSh+w0BfU7LKSC3/xoG1upKxYUNhl2uKWnEAx5WyCKzJ8Lyuh6vEtEm0YPKWlNdm3NXCRtp7Ek4R6XYCu3hHXusvlJ8MSCJLqImQAo3B7t1sDzRYC9vvocnTzOSUNLsLLQG402v/KsiTwI6w5+ea2d3jwzBH/4bI4vh+iJpSnHTliTBiFEjMzTAmwbn0fUcMyVSo7tSu9dt2onwWf57+IpHoOMJkKNlAviZZQwU//DklFVkB6iQxhQFjWubPPK622Q23Pb0VY/HkCSOQ0Cuxh3AGxbWCm5ZWQnrtNokEMRGH55eyjPebRPaR7r6h1zOdBfp5MwqP4LshXhRj0GIikvnJxZCK9VRLzkWuq3WSJ4B371UjQ68xs6hSULtFNMLmeRWIGA8ZbU73lYJfYkPL4A3WIzul44KH0MrOR8PHBL1i2/lA+hryqyJlpA7g1KLrDLsbOX+hv71/+OaL7GOFv7op6ahz9sy8GujHM+9urHxdJjqtEiUmA8QmzHHrtyqyv0Z5PvWZGjureUjb8MEVru8epOejGrS6x/xmQOTLwCRZALeUS7aXhMm2rPCCNxMIac+CV8NUE1jHqzfFd8dC4gtN6IRFJ72MPThBvECpGHpbKIwPk4MeC6yya7vGHSAvaFnEBGcBa9RCnrUDmZHbQlkAl5TC6gt7kBXrqi046suz0bAUM3oPp03wnjA5ptmOsBsHtoXtSUdjXdQkGXbnoSaTkK+eCFlDjuzqBKBzIiC6p+ETu2iXmlvMScb+pBFVdxLIbMrwX5bshfwLz1fYE3aSCEJTTmRsTWuWTFwEvcM4x2XJjs/weHJdH4dHx X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4972.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38350700002)(6486002)(6916009)(26005)(186003)(508600001)(8676002)(38100700002)(54906003)(6506007)(66946007)(2616005)(6666004)(4326008)(31696002)(5660300002)(83380400001)(8936002)(66556008)(66476007)(36756003)(52116002)(86362001)(44832011)(2906002)(53546011)(6512007)(31686004)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?windows-1252?q?Sh/yJp9/OuNsHuqDQArfL?= =?windows-1252?q?wOubNkN3q1AVakP0vjD9ZtdfGU185k0YvEJ+Tr3dX+N6EOtXdOOWSQQKjM?= =?windows-1252?q?mFt1ulOV6Yr7VC81wBcXxgoF9vA52omTDvDhlor03zIW4DWV2BYKTb4xA+?= =?windows-1252?q?nvXV58NIJBnlwjIsV1ys424mTfwYaxb4R7bq/C/K/df1XNNxadz008+8eF?= =?windows-1252?q?IdVCGgi2huGwF/JmrsTCkNYw8nHsWCSI26Xc53SJ+gWr9rfuDx75k9FrCW?= =?windows-1252?q?I4MQXaTyMefTEZs3wOpd/MIqPgmddKaljqn9ltwgSbYBb6AOtsUm37GH6D?= =?windows-1252?q?Ikv5r0+v2XFDcXeUraTAngCBuUrC1wATUjjyzPRljLAGlr99Nz4E1g1Cnz?= =?windows-1252?q?xrZ1oyywHhoee/HY0A5N0dA1MHtD6ecDeWNrDHWyZQ6NpEvZHg4I4EeI6Y?= =?windows-1252?q?FJLRKDHMSE58vgszN1bLpCfSZlX3K9BdBZt74nEw5EywYWXnfR1bsmLqgD?= =?windows-1252?q?SBavVKpU8WnTv6YomMiW2db0WJRoAPXQ2+G+HIWvjEphSf5LX++hW2U5Kt?= =?windows-1252?q?OqVcZUjtjijiIrKxFCFA/aflWSwQ7pCFgyhfIJCCzXmMIag/FJWLnB2xTZ?= =?windows-1252?q?mMzh0VMFRNqIWG8nO8b6RuhK6nwIrs3NJdun02NxE+BhckkjC0RpHUcVGp?= =?windows-1252?q?IVFCl/yOU3gj6KIvSwyae2CMKOC82BEsbb+35h9NZhMxntzO+NgijlSPRu?= =?windows-1252?q?pnr7MwINDk35qW/yiVJAWuSA8mkpIxyMFjqnUNPlCfVC8RpxGDpKjG8m6U?= =?windows-1252?q?CQRZuzbSZfMEiIpZ+CCUtP8LSM5UlruopS5p6mPs2brmdMFIMoYrQ9zf9F?= =?windows-1252?q?bhlUOhWQDOQjgb6qEKbJMIXbRUZxgHfe3LTdBDvtUoEmvCQ2AjnzrVtdWy?= =?windows-1252?q?AiHC9GPAtJEJzMvOF3GMxq2P0EDSS5+aNZSivXR+vc9FlrrSE2eJjci2Mc?= =?windows-1252?q?F//vM0pqDbgyki/EHmEYKB3wkOnsAHYVTWOVLwfifBdklbBbCsyJYZRYBJ?= =?windows-1252?q?TAm565jXghRBd6CgEaeBAM8BCIJoeWehs7DI5wmLHg+1kq8/XXvOds/gjw?= =?windows-1252?q?wy2e2gnZIQK2/HfplOKik//cMXgdF2W9j2d/4G8ygbvpb25K6SuvfIEIO8?= =?windows-1252?q?lcMwOAhu8Do4ovdMVh+xzey6bS6AzR2YjMnjiMwGRf0xRin61KS8sNM6qd?= =?windows-1252?q?D+waKzPNUm9Tpe7JFeneqKCDzTZJgqIlEdPM56DhASrYlj60LXlDNyzWaq?= =?windows-1252?q?UwXYLVqrREY+ACehIuGX9MEhPCjACrOXXzT9BCemUqLY1aCaOHZhIiQL6m?= =?windows-1252?q?2RiTLQiaL5sN3ANoEAxE469Og5bhSIwJTveg3PTtNK7A/Jfoa455DODX5u?= =?windows-1252?q?Ctp65asgGPLXLlegyYieiv9L/1RHgh4GJfntqjuKjwNvsMhVEo8z1XZ/bD?= =?windows-1252?q?ZmM/YVrGXBXT3eZC4G3CRezU1vayr5MWDZJk7U2Zufxnv4dUcGu4sPEPaX?= =?windows-1252?q?1wdpuTQPAXEZN8LaYk2TerajFA+9O0trlzp+kkoI4SjQVi+EDuDjh/kfip?= =?windows-1252?q?r5hmnTISfWuAx2HluqkIZdVGZGCxeFdW3hiQsGY9OYg922cfJCF0u24pWA?= =?windows-1252?q?gJ+hk5brQiMSnqK8QJm3KlGLiOTqLdApYEXIuvZTLBrODwCwP6NK+TeTmH?= =?windows-1252?q?Kw2F/Lxu3ruBX5GtpL4kPnfclCmJ5TABzoFuReLA0POdwbvrT9j90FSNB1?= =?windows-1252?q?17XoGXE8C21FyycFw7ahxeYpKZvA/42hbL50fdSsb0sVxAx1JOf+yjehrk?= =?windows-1252?q?OvScmWIxHQ=3D?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: d24d6c3c-d182-46b3-33d0-08da10d6003f X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 16:14:14.0471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T08PVRFzkkFJXoomSWF4FjZNmHfvwUOF3hlNLfEouAIxmTzQi8GSkVPnfWYjmXFvA/iO4d9irCL2Vdp7DA/aZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB3632 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On 3/28/22 12:03 PM, Tom Rini wrote: > On Mon, Mar 28, 2022 at 11:36:46AM -0400, Sean Anderson wrote: >> On 3/28/22 2:35 AM, Simon Glass wrote: >> >> > But please can we drop the non-DM support? >> >> Unfortunately, Layerscape does not support DM serial. I tried converting >> it, but I ran into some unusual aborts. At the moment, I don't have time >> to debug things further. And I thought that non-DM serial was ok for >> SPL? > > It is OK for SPL, and it needs migration for non-SPL. Can you make > another thread with your conversion-that-fails for layerscape please? > Unfortunately, I didn't save my attempt. I believe it's just --- plus enabling the appropriate configs. I think I was using CONFIG_DM_SERIAL and possibly CONFIG_NS16550_DYNAMIC. --Sean diff --git a/include/configs/ls1046a_common.h b/include/configs/ls1046a_common.h index 7552610e03..f7aaddd98c 100644 --- a/include/configs/ls1046a_common.h +++ b/include/configs/ls1046a_common.h @@ -48,8 +48,10 @@ #define COUNTER_FREQUENCY 25000000 /* 25MHz */ /* Serial Port */ +#if !CONFIG_IS_ENABLED(DM_SERIAL) #define CONFIG_SYS_NS16550_SERIAL #define CONFIG_SYS_NS16550_REG_SIZE 1 +#endif #define CONFIG_SYS_NS16550_CLK (get_serial_clock()) /* SD boot SPL */