From patchwork Tue Feb 13 14:43:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Geyer X-Patchwork-Id: 872881 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zglf30Gyvz9t61 for ; Wed, 14 Feb 2018 01:43:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935348AbeBMOnh (ORCPT ); Tue, 13 Feb 2018 09:43:37 -0500 Received: from h1.radempa.de ([176.9.142.194]:55368 "EHLO mail.cosmopool.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935243AbeBMOnh (ORCPT ); Tue, 13 Feb 2018 09:43:37 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.cosmopool.net (Postfix) with ESMTP id 2F8A99026DD; Tue, 13 Feb 2018 15:43:35 +0100 (CET) Received: from mail.cosmopool.net ([127.0.0.1]) by localhost (mail.your-server.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K8quN4dPX1pg; Tue, 13 Feb 2018 15:43:32 +0100 (CET) Received: from huygens.ccbib.org (unknown [10.0.10.106]) by mail.cosmopool.net (Postfix) with SMTP id 8305F9013B5; Tue, 13 Feb 2018 15:43:31 +0100 (CET) Received: by huygens.ccbib.org (sSMTP sendmail emulation); Tue, 13 Feb 2018 14:43:31 +0000 From: Harald Geyer To: Mark Brown Cc: Liam Girdwood , devicetree@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, Harald Geyer Subject: [PATCH, RESEND2] regulator: fixed, gpio: dt: regulator-name is required property Date: Tue, 13 Feb 2018 14:43:08 +0000 Message-Id: <1518532988-10990-1-git-send-email-harald@ccbib.org> X-Mailer: git-send-email 2.1.4 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org These two drivers fail to probe if no name is provided. For details see: https://www.spinics.net/lists/kernel/msg2457515.html Signed-off-by: Harald Geyer Acked-by: Rob Herring --- This is already the second resend for this trivial device probing bug fix. It was written to your specification, got an ACK from devicetree and has no unaddressed review comments, so I can't see what might be holding it back. If there is still anything wrong with it, I'd appreciate actual feedback instead of a canned response or silence. BTW, it took me a bit to figure out that by "content free ping" you are refering to the quoting of the patch. Maybe you can reword your canned response to make it easier to understand. The ACK was added in the (first) resend. Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 + Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt index 4fae41d..0c2a6c8 100644 --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt @@ -2,6 +2,7 @@ Fixed Voltage regulators Required properties: - compatible: Must be "regulator-fixed"; +- regulator-name: Defined in regulator.txt as optional, but required here. Optional properties: - gpio: gpio to use for enable control diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt index dd1ed78..1f49615 100644 --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt @@ -2,6 +2,8 @@ GPIO controlled regulators Required properties: - compatible : Must be "regulator-gpio". +- regulator-name : Defined in regulator.txt as optional, but required + here. - states : Selection of available voltages and GPIO configs. if there are no states, then use a fixed regulator