From patchwork Thu Feb 8 04:31:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Donnellan X-Patchwork-Id: 870734 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zcQJ93C53z9sP9 for ; Thu, 8 Feb 2018 15:31:37 +1100 (AEDT) Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zcQJ91r1xzF16n for ; Thu, 8 Feb 2018 15:31:37 +1100 (AEDT) X-Original-To: snowpatch@lists.ozlabs.org Delivered-To: snowpatch@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=au1.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=andrew.donnellan@au1.ibm.com; receiver=) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zcQJ44tTRzF15f for ; Thu, 8 Feb 2018 15:31:32 +1100 (AEDT) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w184UbLw138103 for ; Wed, 7 Feb 2018 23:31:30 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g0du03efb-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 07 Feb 2018 23:31:29 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Feb 2018 04:31:27 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 8 Feb 2018 04:31:25 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w184VPwJ55705690; Thu, 8 Feb 2018 04:31:25 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E827A4C04A; Thu, 8 Feb 2018 04:25:14 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 962EB4C046; Thu, 8 Feb 2018 04:25:14 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 8 Feb 2018 04:25:14 +0000 (GMT) Received: from intelligence.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 3BF38A01C3; Thu, 8 Feb 2018 15:31:23 +1100 (AEDT) From: Andrew Donnellan To: snowpatch@lists.ozlabs.org Date: Thu, 8 Feb 2018 15:31:15 +1100 X-Mailer: git-send-email 2.11.0 X-TM-AS-GCONF: 00 x-cbid: 18020804-0040-0000-0000-0000040D8B79 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18020804-0041-0000-0000-000026113EFE Message-Id: <20180208043115.9191-1-andrew.donnellan@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-02-08_01:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802080040 Subject: [snowpatch] [PATCH] patchwork: Get rid of dummy URL for test results X-BeenThere: snowpatch@lists.ozlabs.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Continuous Integration for patch-based workflows List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: snowpatch-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "snowpatch" At some point, Patchwork didn't like it when we submitted a Check without a target_url attached, so we sent "no.url" as a default. That appears to have changed, so get rid of the dummy URL. Signed-off-by: Andrew Donnellan --- applies on top of current patchwork series, completely untested v1->v2: - remember to change branches before writing patch... --- src/patchwork.rs | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/patchwork.rs b/src/patchwork.rs index 17d72a2b91b0..c3c628609474 100644 --- a/src/patchwork.rs +++ b/src/patchwork.rs @@ -177,7 +177,6 @@ impl Default for TestState { #[derive(Serialize, Default, Clone)] pub struct TestResult { pub state: TestState, - #[serde(serialize_with = "TestResult::serialize_target_url")] pub target_url: Option, pub description: Option, #[serde(serialize_with = "TestResult::serialize_context")] @@ -185,15 +184,6 @@ pub struct TestResult { } impl TestResult { - fn serialize_target_url(target_url: &Option, ser: S) - -> Result where S: Serializer { - if target_url.is_none() { - serde::Serialize::serialize(&Some("http://no.url".to_string()), ser) - } else { - serde::Serialize::serialize(target_url, ser) - } - } - fn serialize_context(context: &Option, ser: S) -> Result where S: Serializer { if context.is_none() {