From patchwork Tue Nov 23 17:37:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladislav Odintsov X-Patchwork-Id: 1558660 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=R0PXebae; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzBCs6NjJz9t0k for ; Wed, 24 Nov 2021 04:37:13 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 927A140436; Tue, 23 Nov 2021 17:37:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HQwyGjYJteGF; Tue, 23 Nov 2021 17:37:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 87C364013D; Tue, 23 Nov 2021 17:37:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5235AC002E; Tue, 23 Nov 2021 17:37:09 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9BB62C0012 for ; Tue, 23 Nov 2021 17:37:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 907EF40140 for ; Tue, 23 Nov 2021 17:37:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V3eBbirDuoCP for ; Tue, 23 Nov 2021 17:37:06 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by smtp2.osuosl.org (Postfix) with ESMTPS id AF1144013D for ; Tue, 23 Nov 2021 17:37:06 +0000 (UTC) Received: by mail-qt1-x82a.google.com with SMTP id j17so30428qtx.2 for ; Tue, 23 Nov 2021 09:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MgghZ/OZVlCeAWvD62EsougjoLck+emntw88w01paN0=; b=R0PXebaew+rMRCgPuZlk7rCjNsg6dS3sqU+HA8X1IePb83R/a8/Wkh9j25OXK9bW8V eZ4xgFaOiV2Ol7kwHk2GQyE5kCsZ2hKmU4SSWqUBba285QGb903cfvX+96IzCWq4v8O5 bFe+dmP82k3/+pSLyLZHBILmuk7vBIly4clhFYmd7Dgq3KFY68YbdlICREr0hWm0sFDp KrRWwTO00F+iuIsWxpKasyo31K2H8zcxknyxl+qggr80/eVisKbopMFjxJgjw0//XRPi tma+j9+gRbwfP/yW/bhtSpYxEN4NIYN/leLdhJAkx51PgSWTyicm2YxzhbLM1iepfl9d w3vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MgghZ/OZVlCeAWvD62EsougjoLck+emntw88w01paN0=; b=GCZrqCybH3LhVi5dxr8ncUOW68UHIYgT14RCCgvWE7u36y6AEeWitl9N5nvUSUPVJg IxgrDHVxF38dosctgL1dz9hEOZ31QGN2UsCrgc0hIIwZ/1yQ2HW6rpAoHXKfR9xjP7uz ILBGs8ts/XHVzv7ffzhjRoRsnNLP4blLKennalEi0tlnbcBzDZjc7TLDw3B6jh5Bndth xzpR67Bg9X1PbXjolXzDhEiW7NtIDREm71rQLO+iFvEKDuuAaEjy/CRIYQvniy4mJD9z mJtjXlie6V4BUs1tVDAoJr8F4+cKLYSoAbsG3RwoPRSwxZK6xyme9N4GbxTPgOx1EW7c NUUA== X-Gm-Message-State: AOAM533U8wLfSm70QMkTb2WIcSm+6C0WDqBZ3+H3waYdEYYTsfqwqbBL 1gRIjKi2xH7lykdW93QMhlOk97QkDyp7jg== X-Google-Smtp-Source: ABdhPJyATQMnfChRg1sY/sS/PM53DA9+I2s+7h3NqXOu+ZaSXU2SreBrO2cBYxTIxdb6Rfnwhb6IKA== X-Received: by 2002:ac8:5f0c:: with SMTP id x12mr8347210qta.3.1637689025413; Tue, 23 Nov 2021 09:37:05 -0800 (PST) Received: from localhost.localdomain (109-252-131-59.dynamic.spd-mgts.ru. [109.252.131.59]) by smtp.gmail.com with ESMTPSA id c11sm6407418qtb.8.2021.11.23.09.37.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Nov 2021 09:37:05 -0800 (PST) From: Vladislav Odintsov To: dev@openvswitch.org Date: Tue, 23 Nov 2021 20:37:00 +0300 Message-Id: <20211123173700.87322-1-odivlad@gmail.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Cc: Vladislav Odintsov Subject: [ovs-dev] [PATCH ovn] tests: fix flaky VXLAN check port/datapath key space limits test X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" OVN requested-tnl-key VXLAN checks affect tunnel_key in datapath_binding record only on datapath tunnel key assigning. If a dp tnl key was already assigned and VXLAN-enabled chassis is added after that, the value would never be changed. The test didn't check the VXLAN-enabled chassis was created and thus test could fail like this: $ ovn.at:3777: waiting until test x`ovn-nbctl lsp-get-up lsp-bad` = xup... $ ovn.at:3777: wait succeeded immediately $ ./ovn.at:3777: ovn-sbctl get Datapath_Binding ls-bad tunnel_key $ --- - 2021-11-23 17:34:51.646403185 +0300 $ +++ /builddir/build/BUILD/ovn-21.09.90/tests/testsuite.dir/at-groups/104/stdout 2021-11-23 17:34:51.644406189 +0300 $ @@ -1,2 +1,2 @@ $ -1 $ +5000 This patch fixes such fail by adding await for chassis to be registered in SB DB. Signed-off-by: Vladislav Odintsov Signed-off-by: Vladislav Odintsov > Acked-by: Dumitru Ceara --- tests/ovn.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ovn.at b/tests/ovn.at index 965eed809..c39f3162e 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -3783,6 +3783,7 @@ check ovs-vsctl add-br br-phys check ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys ovn_attach net br-phys 192.168.0.1 24 vxlan check ovn-nbctl --wait=sb sync +OVS_WAIT_UNTIL([ovn-sbctl get chassis main _uuid]) check ovn-nbctl ls-add ls-bad -- \ set Logical_Switch ls-bad other_config:requested-tnl-key=5000