From patchwork Mon Feb 5 20:10:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 869525 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zZzHx0j3Tz9sP1 for ; Tue, 6 Feb 2018 07:11:25 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbeBEULQ (ORCPT ); Mon, 5 Feb 2018 15:11:16 -0500 Received: from sauhun.de ([88.99.104.3]:34245 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbeBEUK0 (ORCPT ); Mon, 5 Feb 2018 15:10:26 -0500 Received: from localhost (p54B337CF.dip0.t-ipconnect.de [84.179.55.207]) by pokefinder.org (Postfix) with ESMTPSA id 379B32C3267; Mon, 5 Feb 2018 21:10:25 +0100 (CET) From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Dan Carpenter , linux-renesas-soc@vger.kernel.org, Wolfram Sang , Tom Lendacky , netdev@vger.kernel.org Subject: [PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask Date: Mon, 5 Feb 2018 21:10:01 +0100 Message-Id: <20180205201002.23621-5-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180205201002.23621-1-wsa+renesas@sang-engineering.com> References: <20180205201002.23621-1-wsa+renesas@sang-engineering.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Due to a typo, the mask was destroyed by a comparison instead of a bit shift. Signed-off-by: Wolfram Sang Acked-by: Tom Lendacky --- Only build tested. To be applied individually per subsystem. drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c index 7a3ebfd236f5eb..100adee778dfd6 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -595,7 +595,7 @@ static void xgbe_isr_task(unsigned long data) reissue_mask = 1 << 0; if (!pdata->per_channel_irq) - reissue_mask |= 0xffff < 4; + reissue_mask |= 0xffff << 4; XP_IOWRITE(pdata, XP_INT_REISSUE_EN, reissue_mask); }