From patchwork Wed Nov 3 16:55:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Numan Siddique X-Patchwork-Id: 1550426 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HktDv1R81z9s1l for ; Thu, 4 Nov 2021 03:55:27 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id DDAA2400B5; Wed, 3 Nov 2021 16:55:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gOlhdDHQe5Dn; Wed, 3 Nov 2021 16:55:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id D88F540117; Wed, 3 Nov 2021 16:55:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AF9EEC0019; Wed, 3 Nov 2021 16:55:22 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 67B54C000E for ; Wed, 3 Nov 2021 16:55:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 57B044040C for ; Wed, 3 Nov 2021 16:55:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pg_Hv443POMB for ; Wed, 3 Nov 2021 16:55:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by smtp4.osuosl.org (Postfix) with ESMTPS id 91D024039E for ; Wed, 3 Nov 2021 16:55:20 +0000 (UTC) Received: (Authenticated sender: numans@ovn.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 2D73824000C; Wed, 3 Nov 2021 16:55:17 +0000 (UTC) From: numans@ovn.org To: dev@openvswitch.org Date: Wed, 3 Nov 2021 12:55:14 -0400 Message-Id: <20211103165514.1880082-1-numans@ovn.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH ovn v2] ci: Don't run unit tests for system-test job. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Numan Siddique system-test matrix first runs unit tests and then system tests. And if unit tests fail, system tests are not run. This patch now runs only system tests for system-test matrix. A new entry is added in the test matrix - 'gcc compiler with unit tests'. Signed-off-by: Numan Siddique Acked-by: Dumitru Ceara --- v1 -> v2 ---- * Addressed Ilya's comments. .ci/linux-build.sh | 22 +++++++++++----------- .github/workflows/test.yml | 2 ++ 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index 76a2ff459f..b0975685d4 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -49,17 +49,6 @@ else fi if [ "$TESTSUITE" ]; then - # 'distcheck' will reconfigure with required options. - # Now we only need to prepare the Makefile without sparse-wrapped CC. - configure_ovn - - export DISTCHECK_CONFIGURE_FLAGS="$OPTS" - if ! make distcheck -j4 TESTSUITEFLAGS="-j4" RECHECK=yes; then - # testsuite.log is necessary for debugging. - cat */_build/sub/tests/testsuite.log - exit 1 - fi - if [ "$TESTSUITE" = "system-test" ]; then # Reconfigure build with required OPTS, rebuild and run system tests. configure_ovn $OPTS @@ -69,6 +58,17 @@ if [ "$TESTSUITE" ]; then cat tests/system-kmod-testsuite.log exit 1 fi + else + # 'distcheck' will reconfigure with required options. + # Now we only need to prepare the Makefile without sparse-wrapped CC. + configure_ovn + + export DISTCHECK_CONFIGURE_FLAGS="$OPTS" + if ! make distcheck -j4 TESTSUITEFLAGS="-j4" RECHECK=yes; then + # testsuite.log is necessary for debugging. + cat */_build/sub/tests/testsuite.log + exit 1 + fi fi else configure_ovn $OPTS diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ce313690a6..280f0ffea0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -34,6 +34,8 @@ jobs: - compiler: clang opts: --disable-ssl + - compiler: gcc + testsuite: test - compiler: gcc testsuite: system-test - compiler: clang