From patchwork Tue Sep 21 12:50:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Zabel X-Patchwork-Id: 1530712 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@ozlabs.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=i4Wd0cG1; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4HDLs35vc9z9ssP for ; Tue, 21 Sep 2021 22:51:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vfNTsy2jR2P3R3JVspROjhIP7Lhco03C6NyHjnsBvas=; b=i4Wd0cG1F2g9zC xU3r1ZN9ABWIJEqUI6+yRo7yNCz4/+xxX9TAsIbidOUfwjysG06EgRIXnkrSv6bf50Ug6eDOW+MVT ju6WYE/LV1lNiiXaGQveTyJ3QGVv2nkBVlcJIHM3PEb/Gcgf+irq6jn/Jql2R9vHNA7+3qY0HDb23 fZ7zwhdBHOYVSwJUMt44mqb/imEAIZg6BMSLqMJlgUjezwOWvriN5Dih2X2W1eI9knBPnfR/6rKmi 5Ra30b5j6t19Fp6+CgXapDbFIprxLAPU03oSzsLWndlro8XbWda3/ThDGTob/Az9UHNZ/IxU+s+WU uzBa6ymhaU8CdW0Ra5TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSfEC-004UhY-UM; Tue, 21 Sep 2021 12:50:29 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSfE9-004Ugm-JX for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 12:50:27 +0000 Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.pengutronix.de.) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mSfE4-00054B-6R; Tue, 21 Sep 2021 14:50:20 +0200 From: Philipp Zabel To: linux-arm-kernel@lists.infradead.org Cc: Shawn Guo , kernel@pengutronix.de, Saravana Kannan Subject: [PATCH] ARM: imx: drop devlinks to reset-controller node Date: Tue, 21 Sep 2021 14:50:14 +0200 Message-Id: <20210921125015.6977-1-p.zabel@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::28 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_055025_682864_D8BFDDEC X-CRM114-Status: GOOD ( 13.48 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Starting with commit 6b2117ad65f1 ("of: property: fw_devlink: Add support for "resets" and "pwms""), the imx-drm driver fails to load due to forever dormant devlinks to the reset-controller node. This [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org Starting with commit 6b2117ad65f1 ("of: property: fw_devlink: Add support for "resets" and "pwms""), the imx-drm driver fails to load due to forever dormant devlinks to the reset-controller node. This node is never associated with a struct device. Drop those links, the reset controller is always available. Signed-off-by: Philipp Zabel Tested-by: Fabio Estevam --- arch/arm/mach-imx/src.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) base-commit: e4e737bb5c170df6135a127739a9e6148ee3da82 diff --git a/arch/arm/mach-imx/src.c b/arch/arm/mach-imx/src.c index 95fd1fbb0826..6924ac19a762 100644 --- a/arch/arm/mach-imx/src.c +++ b/arch/arm/mach-imx/src.c @@ -178,9 +178,17 @@ void __init imx_src_init(void) WARN_ON(!src_base); imx_reset_controller.of_node = np; - if (IS_ENABLED(CONFIG_RESET_CONTROLLER)) + if (IS_ENABLED(CONFIG_RESET_CONTROLLER)) { reset_controller_register(&imx_reset_controller); + /* + * The reset-controller node is never associated with a struct + * device, which trips up fw_devlink=on. As a workaround, drop + * all devlinks to/from this node. + */ + fw_devlink_purge_absent_suppliers(&np->fwnode); + } + /* * force warm reset sources to generate cold reset * for a more reliable restart