From patchwork Fri Aug 20 21:08:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Numan Siddique X-Patchwork-Id: 1519197 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GrvQC1QGmz9sW8 for ; Sat, 21 Aug 2021 07:09:06 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 878B361426; Fri, 20 Aug 2021 21:09:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JdjhspEh5dK2; Fri, 20 Aug 2021 21:09:00 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id D0DC161429; Fri, 20 Aug 2021 21:08:59 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9C6ADC001A; Fri, 20 Aug 2021 21:08:59 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8B78FC000E for ; Fri, 20 Aug 2021 21:08:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 75ECE81ABA for ; Fri, 20 Aug 2021 21:08:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YuQPlLhiBUqR for ; Fri, 20 Aug 2021 21:08:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by smtp1.osuosl.org (Postfix) with ESMTPS id E512581AA7 for ; Fri, 20 Aug 2021 21:08:53 +0000 (UTC) Received: (Authenticated sender: numans@ovn.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 12851240003; Fri, 20 Aug 2021 21:08:49 +0000 (UTC) From: numans@ovn.org To: dev@openvswitch.org Date: Fri, 20 Aug 2021 17:08:38 -0400 Message-Id: <20210820210838.1064085-1-numans@ovn.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH ovn] northd: Enable logical dp groups by default. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Numan Siddique Support for logical dp group is present since more than 2 releases now and its time to enable it as a default. Signed-off-by: Numan Siddique Acked-by: Mark Michelson Acked-by: Han Zhou --- NEWS | 2 ++ northd/ovn-northd.c | 2 +- northd/ovn_northd.dl | 2 +- tests/ovn-macros.at | 2 ++ 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 606ec6c77..6da59410d 100644 --- a/NEWS +++ b/NEWS @@ -6,6 +6,8 @@ Post-v21.06.0 - Introduced a new "label" field for "allow" and "allow-related" ACLs which helps in debugging/backtracking the ACL which allowed a particular connection. + - Enabled logical dp groups as a default. CMS should disable it if not + desired. OVN v21.06.0 - 18 Jun 2021 ------------------------- diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 3d8e21a4f..da443615e 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -14079,7 +14079,7 @@ ovnnb_db_run(struct northd_context *ctx, can_parallelize_hashes(false)); use_logical_dp_groups = smap_get_bool(&nb->options, - "use_logical_dp_groups", false); + "use_logical_dp_groups", true); use_ct_inv_match = smap_get_bool(&nb->options, "use_ct_inv_match", true); diff --git a/northd/ovn_northd.dl b/northd/ovn_northd.dl index 9cf4c373b..7e21af093 100644 --- a/northd/ovn_northd.dl +++ b/northd/ovn_northd.dl @@ -1687,7 +1687,7 @@ function stage_hint(_uuid: uuid): bit<32> { relation UseLogicalDatapathGroups[bool] UseLogicalDatapathGroups[use_logical_dp_groups] :- nb in nb::NB_Global(), - var use_logical_dp_groups = nb.options.get_bool_def("use_logical_dp_groups", false). + var use_logical_dp_groups = nb.options.get_bool_def("use_logical_dp_groups", true). UseLogicalDatapathGroups[false] :- Unit(), not nb in nb::NB_Global(). diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at index b5a01b2b5..f06f2e68e 100644 --- a/tests/ovn-macros.at +++ b/tests/ovn-macros.at @@ -249,6 +249,8 @@ ovn_start () { if test X$NORTHD_USE_DP_GROUPS = Xyes; then ovn-nbctl set NB_Global . options:use_logical_dp_groups=true + else + ovn-nbctl set NB_Global . options:use_logical_dp_groups=false fi if test X$NORTHD_USE_PARALLELIZATION = Xyes; then