From patchwork Tue Aug 10 16:15:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladislav Odintsov X-Patchwork-Id: 1515463 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=fq52JCV1; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GkdNX1jbnz9sRf for ; Wed, 11 Aug 2021 02:15:55 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 94999402EE; Tue, 10 Aug 2021 16:15:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c_8ST2GAbxme; Tue, 10 Aug 2021 16:15:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id E2234401FF; Tue, 10 Aug 2021 16:15:48 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B4E6BC001A; Tue, 10 Aug 2021 16:15:48 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5DD49C000E for ; Tue, 10 Aug 2021 16:15:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4A29C60672 for ; Tue, 10 Aug 2021 16:15:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83VlI-VYKo9w for ; Tue, 10 Aug 2021 16:15:43 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3F9F360638 for ; Tue, 10 Aug 2021 16:15:43 +0000 (UTC) Received: by mail-ej1-x632.google.com with SMTP id z20so13716113ejf.5 for ; Tue, 10 Aug 2021 09:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VP0NeHPjQiQTP6rysSokq0HTgWG9lax6+86n8i+kgGU=; b=fq52JCV1cZdKuXZzqibSCzKg7exIyx3zLoaZXEQp+tuu2gw328kcK1skgllyxkVSaF w/tTXFUxj0oCGPITCoBf0oZ/YBAl3lxKhvpJVYVX48qKKrD+iQtFPmDych8zC5p5w21L 5mXPWtg5hyghOCa1uKAvE1KwDscsBKlRv9pEb6FGOU7rsaigKwDkxatG8t/5crvI15bb 1N0ThOX09CQLeNS7G+L9wnjJsxtaBGj37KGqkX0G8R/aPva6p402JymEE8oBdV5VYHY1 AvZ7wvzMttJlfXeRsc5dhOAFTqsIDBITRH/0JhOu+PfHxk2tWgJtocD9KWCYWewgm0bu v2qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VP0NeHPjQiQTP6rysSokq0HTgWG9lax6+86n8i+kgGU=; b=hSJzvSHpQ0yb1jkpKMsVr+BGUeUXUtiqVtJymwv6nB2C/NXKieRMq6vO21DVa0OIuJ 0ira+r39XJ0XS2cIUGX+UxwT0KuKSE0MMRso6h5ijrxNz3c1/vU/3YfnE+ZOwgfGmW+a HxABD1Nlv+PJ1Y1Zth1dECjAXrAiOJQqTQscMil87T70LtrfXDEBRKSpXEQnpii1DweS qDCcRdkM7+sEDf0LSIWL1uUkeR2Hm6C+5syCB50tQ/u4r88u0J/vU/kH2naxIWpOKguM pjkV5TQhmhtPInRpQXNtFT61PSoIB6cP4Sg5mCWyFLDEyyiQ+cdhHOUZ5I9UBE23spg5 cmkw== X-Gm-Message-State: AOAM5300Z8kD8WFTXuDvedkDP9sHlBjKm1nMGE1T5y0EA2Lm6nWTvWo5 HUb/ITAhOeSgxSlG1fYs5LudrFRC4CU= X-Google-Smtp-Source: ABdhPJyx67g9t+I1NPDW50HQI9ULiPqEJGExeswVWhsLHZlIzVjO3hZAuDBNiyyrL08nEylu9db0bg== X-Received: by 2002:a17:906:95ce:: with SMTP id n14mr26885344ejy.130.1628612139956; Tue, 10 Aug 2021 09:15:39 -0700 (PDT) Received: from localhost.localdomain ([85.187.18.247]) by smtp.gmail.com with ESMTPSA id a4sm1512054edv.53.2021.08.10.09.15.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Aug 2021 09:15:39 -0700 (PDT) From: Vladislav Odintsov To: dev@openvswitch.org Date: Tue, 10 Aug 2021 19:15:37 +0300 Message-Id: <20210810161537.71692-1-odivlad@gmail.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Cc: Vladislav Odintsov Subject: [ovs-dev] [PATCH ovn] northd: fix xxreg{0, 1} registers usage description in router pipeline X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" XXREG0 and XXREG1 (128-bit registers), are currently used in router pipeline to store NEXT_HOP_IPV6 and SRC_IPV6 respectively. First time XXREG0 register is written - in stage lr_in_defrag. XXREG1 register is written first in lr_in_ip_routing. This patch updates documentation, where it was wrongly pointed to lr_in_ip_input router stage. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-August/386607.html Signed-off-by: Vladislav Odintsov --- northd/ovn-northd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 4c164a744..713d81e4c 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -312,7 +312,7 @@ enum ovn_stage { * +-----+--------------------------+ G | (< IP_INPUT) | X | | * | R1 | SRC_IPV4 for ARP-REQ | 0 | | R | | * | | (>= IP_INPUT) | | | E | NEXT_HOP_IPV6 | - * +-----+--------------------------+---+-----------------+ G | (>= IP_INPUT) | + * +-----+--------------------------+---+-----------------+ G | ( >= DEFRAG ) | * | R2 | UNUSED | X | | 0 | | * | | | R | | | | * +-----+--------------------------+ E | UNUSED | | | @@ -324,8 +324,8 @@ enum ovn_stage { * +-----+--------------------------+ E | UNUSED | X | | * | R5 | UNUSED | G | | X | | * | | | 2 | | R |SRC_IPV6 for NS| - * +-----+--------------------------+---+-----------------+ E | (>= IP_INPUT) | - * | R6 | UNUSED | X | | G | | + * +-----+--------------------------+---+-----------------+ E | ( >= | + * | R6 | UNUSED | X | | G | IN_IP_ROUTING)| * | | | R | | 1 | | * +-----+--------------------------+ E | UNUSED | | | * | R7 | UNUSED | G | | | |