From patchwork Fri Jul 23 02:41:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 1508942 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=HgClnjoR; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GWDB93C9gz9sV8 for ; Fri, 23 Jul 2021 12:42:25 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 073AB39B5D29 for ; Fri, 23 Jul 2021 02:42:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 073AB39B5D29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1627008142; bh=C/pMzr66n79J2tM/y+0rfeEkcOye1wr0h2PuGrjOlZk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=HgClnjoRnwGQ90wM0ySFWVfqc+IMfwdHxxzrq/k+kUF06F7wBoiyCGcj5Rev3QQIZ UIJzMpHftvqsK+LLNtx34V4yiLIi+pZ0U9yE107C+bvaLkN13ryzENrGIO194fdqqf tdklBmRm7waDG5V9J4os7QiHBr1zPErV14+7VvoU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id AA8713861857 for ; Fri, 23 Jul 2021 02:41:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AA8713861857 Received: by mail-pj1-x1036.google.com with SMTP id g23-20020a17090a5797b02901765d605e14so1864212pji.5 for ; Thu, 22 Jul 2021 19:41:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=C/pMzr66n79J2tM/y+0rfeEkcOye1wr0h2PuGrjOlZk=; b=RxGEjLJvnSCVmGyA2WNyJk74TMNoTqpp87kq+9Igx9MXCoupMogXpr3hBXDX6eclaH m7kMEX4CDACuW4T+PxX0V5jEzOV0tkvZWm1bmvAiN96GLAiTJaV8rcdo10U7CD+u9GNm z5RdQed1pW1qiv7KjtRBAGlIPUekHOMUdY8ciHJkU6QJaTrYZNcI0eA7Hi1kit0QMfNx dfuqVtRQHD7zNSsBAgAFVvnujkzLqpRs/JL/e8wTxPCuNujbaBjycfxYLno2vRJL+g4+ 0kQZfwQnhTYqN96j9koMp5bQxmUM93Ko/S6V9Zq1WZ3TxiDS9lnm44mDwNMCtk3vXcEJ ZByA== X-Gm-Message-State: AOAM532GlDApzRFn88J9/oVvcOvFxebA9sGp8o0vJJh1P4TqhsUo+a51 OdavEHmzrtgjhJ4YPHTXDLBTLQzvmng= X-Google-Smtp-Source: ABdhPJzse7kaSm5zmdU4ivJMPafTGpNn/tbWFrOfeNqbSWT90yUuFETsMRwrdDGtsRMZ6y1YPZZ53g== X-Received: by 2002:a17:90b:33cf:: with SMTP id lk15mr2486251pjb.153.1627008097615; Thu, 22 Jul 2021 19:41:37 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.58.38.240]) by smtp.gmail.com with ESMTPSA id w123sm31641837pfb.109.2021.07.22.19.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jul 2021 19:41:37 -0700 (PDT) Received: from gnu-tgl-2.localdomain (gnu-tgl-2 [192.168.1.34]) by gnu-cfl-2.localdomain (Postfix) with ESMTPS id AC082C006D; Thu, 22 Jul 2021 19:41:35 -0700 (PDT) Received: from gnu-tgl-2.lan (localhost [IPv6:::1]) by gnu-tgl-2.localdomain (Postfix) with ESMTP id 778A03004F5; Thu, 22 Jul 2021 19:41:25 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH v2] x86: Don't return hard register when LRA is in progress Date: Thu, 22 Jul 2021 19:41:25 -0700 Message-Id: <20210723024125.1297782-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3033.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SCC_5_SHORT_WORD_LINES, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Gcc-patches" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: liuhongt Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Don't return hard register in ix86_gen_scratch_sse_rtx when LRA is in progress to avoid ICE when there are no available hard registers for LRA. gcc/ PR target/101504 * config/i386/i386.c (ix86_gen_scratch_sse_rtx): Don't return hard register when LRA is in progress. gcc/testsuite/ PR target/101504 * gcc.target/i386/pr101504.c: New test. --- gcc/config/i386/i386.c | 2 +- gcc/testsuite/gcc.target/i386/pr101504.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr101504.c diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index ff96134fb37..876a19f4c1f 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -23180,7 +23180,7 @@ ix86_optab_supported_p (int op, machine_mode mode1, machine_mode, rtx ix86_gen_scratch_sse_rtx (machine_mode mode) { - if (TARGET_SSE) + if (TARGET_SSE && !lra_in_progress) return gen_rtx_REG (mode, (TARGET_64BIT ? LAST_REX_SSE_REG : LAST_SSE_REG)); diff --git a/gcc/testsuite/gcc.target/i386/pr101504.c b/gcc/testsuite/gcc.target/i386/pr101504.c new file mode 100644 index 00000000000..2ad0405dd7b --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr101504.c @@ -0,0 +1,23 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -march=skylake" } */ + +typedef unsigned int __attribute__((__vector_size__ (32))) U; +typedef unsigned char __attribute__((__vector_size__ (64))) V; + +V g; + +U +foo (void) +{ + V v = __builtin_shufflevector (g, g, + 0, 1, 2, 0, 5, 1, 0, 1, 3, 2, 3, 0, 4, 3, 1, 2, + 2, 0, 4, 2, 3, 1, 1, 2, 3, 4, 1, 1, 0, 0, 5, 2, + 0, 3, 3, 3, 3, 4, 5, 0, 1, 5, 2, 1, 0, 1, 1, 2, + 3, 2, 0, 5, 4, 5, 1, 0, 1, 4, 4, 3, 4, 5, 2, 0); + v ^= 255; + V w = v + g; + U u = ((union { V a; U b; }) w).b + ((union { V a; U b; }) w).b[1]; + return u; +} + +/* { dg-final { scan-assembler-not "\.byte\[ \t\]+-1\n" } } */