From patchwork Wed Jul 14 22:08:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew MacLeod X-Patchwork-Id: 1505449 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=vMBzMaiZ; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GQBVk3Hhfz9sWc for ; Thu, 15 Jul 2021 08:09:18 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 22DB2398B8B9 for ; Wed, 14 Jul 2021 22:09:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 22DB2398B8B9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1626300556; bh=Rv5fZPVFVrColsMi+sxCv1UQ5kEptw1yAOq7LHaAeRM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=vMBzMaiZ1ecXQWQQSVTe4XKJqnkrYwRjJfweY3bzlpv574+WHEx5ibDHVdDpZA5IO kxRlLzEgqTRbAmmy41WMPfDKLY7wjMyOi/Qjjw2Ge0rGhCBu8gu2naCe93QEgN0NkE KG4sHEaATykbor2w6AzxBJxrnr/xmM2k/MPHrBEk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 49BCA398B86E for ; Wed, 14 Jul 2021 22:08:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49BCA398B86E Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-4sVSDG2HOE6cyoAk7OxPng-1; Wed, 14 Jul 2021 18:08:53 -0400 X-MC-Unique: 4sVSDG2HOE6cyoAk7OxPng-1 Received: by mail-qt1-f198.google.com with SMTP id j16-20020ac855100000b029025bf786be09so2774470qtq.20 for ; Wed, 14 Jul 2021 15:08:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=Rv5fZPVFVrColsMi+sxCv1UQ5kEptw1yAOq7LHaAeRM=; b=d2xIFawaysB78yKdplc11XgXVjeRBzCuvVc6gMJ09a8f712Jho6LYq4SiL18Ip+tcC x7iZ184hrD0tYEKQkpz7x4VGPgvnBsml9MRHXY1eLkZQ1mBPdhIF90pLFJXgckSVqZ6F 6QltdsGZtWXCrdnR3GruZ8PbQJ/ljjdEhLyk4uoimgLIXoLEW6J06i2+kG/2m+bdmIi/ iK3/87JFz4Y2sV/2SHGhwZzbPqS1WOaY8sgHXcTQYc8hHtyT+/mFvn0+3MhBEiPuWQNz SJiipBi2KnW8CQct9qvTa6CUQO9cc/WLgCPJtwe28rcKCniAzOfrpE9if2mBxpmJJM/E 509A== X-Gm-Message-State: AOAM533d5MeeLf/rXmi/k6xGHpn/u6J8GpBqicgkr9rfq6ee7SSApdL0 Vu2vCKExylsUfYa/uz48Uky6+G4BRuASjZL7S95MNceBdOuDWwRHXTp/TcChW9Jq1fbGPrixPmV M8ETnzrTTdNWHlOwE+orLexWv6/gwvgnzWFQe/xrmjiLwrOWfL8KwNPTwA7Be9rUijzDaOA== X-Received: by 2002:ac8:7a98:: with SMTP id x24mr300088qtr.42.1626300532708; Wed, 14 Jul 2021 15:08:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPSJtbF2JdTi7Mva9Q206Pmwy+vID8LnN4UyBv/QE+Pb8KCAXVt20kXxEB/bsjA2zppbLM4g== X-Received: by 2002:ac8:7a98:: with SMTP id x24mr300073qtr.42.1626300532496; Wed, 14 Jul 2021 15:08:52 -0700 (PDT) Received: from [192.168.0.102] ([104.219.122.163]) by smtp.gmail.com with ESMTPSA id j8sm1322123qti.20.2021.07.14.15.08.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jul 2021 15:08:51 -0700 (PDT) To: gcc-patches Subject: [GCC 11] [COMMITTED] Disable poor value processing in ranger cache. Message-ID: <2dce94ec-fe4e-b7cb-2c49-aeb31f072fec@redhat.com> Date: Wed, 14 Jul 2021 18:08:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-CA X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew MacLeod via Gcc-patches From: Andrew MacLeod Reply-To: Andrew MacLeod Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" We have disabled the poor value cache in trunk as not providing enough benefit for the cost. do the same in gcc 11. Bootstrapped on x86_64-pc-linux-gnu with no regressions.  pushed. Andrew From 86534c07a390e240ffea51653945de85df7a3632 Mon Sep 17 00:00:00 2001 From: Andrew MacLeod Date: Wed, 23 Jun 2021 12:55:14 -0400 Subject: [PATCH 5/8] Disable poor value processing in ranger cache. * gimple-range-cache.cc (ranger_cache::push_poor_value): Disable poor value processing. --- gcc/gimple-range-cache.cc | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc index bc4b557b493..068905d4774 100644 --- a/gcc/gimple-range-cache.cc +++ b/gcc/gimple-range-cache.cc @@ -846,20 +846,9 @@ ranger_cache::register_dependency (tree name, tree dep) bool ranger_cache::push_poor_value (basic_block bb, tree name) { - if (m_poor_value_list.length ()) - { - // Don't push anything else to the same block. If there are multiple - // things required, another request will come during a later evaluation - // and this prevents oscillation building uneccessary depth. - if ((m_poor_value_list.last ()).bb == bb) - return false; - } - - struct update_record rec; - rec.bb = bb; - rec.calc = name; - m_poor_value_list.safe_push (rec); - return true; + // Disable poor value processing for GCC 11. It has been disabled in GCC 12 + // as adding too much churn/compile time for too little benefit. + return false; } // Provide lookup for the gori-computes class to access the best known range -- 2.17.2