From patchwork Fri Jul 2 12:23:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 1500042 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=a7FK0qOD; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=HkWjLbjf; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GGZ561D32z9shx for ; Fri, 2 Jul 2021 22:24:10 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232183AbhGBM0j (ORCPT ); Fri, 2 Jul 2021 08:26:39 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:42421 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232149AbhGBM0i (ORCPT ); Fri, 2 Jul 2021 08:26:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228646; x=1656764646; h=from:to:cc:subject:date:message-id; bh=iThrbaf/3eOT5wm4rBD4w/ehi8bk8I/n0po1O+9VxAA=; b=a7FK0qODlUYVMsi/582+Zbi74lA80BNyj84YbizNk1jPhb3+HyC9nIEc loDIbnpJAATBwG2ByALjWbfykxoVY4AN+vfChf7Rdbk8M6P6RW4mTfF+M Oi04inE4dJHSeOjgOweu95LFwmzJJtsaoJ0NeSNuLXLKUED+aLvN+v63I ZmFjDmn9Sa5HBOUsE9pZKAY5qrphRXk0kiLNPa11YYDfm74b7JejMHjuL QESokQOjht1f2riOqeTTLiSLReC1cEXhdUXbUMnhMR7NFV/0Pk7WCkk6z KDT7ySoWrO+O15h5u+srG+a+C6+VKnmyCRRwa8zxcqFXPajfqKkaTCbjk w==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252568" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Jul 2021 14:24:04 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 02 Jul 2021 14:24:04 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 02 Jul 2021 14:24:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228644; x=1656764644; h=from:to:cc:subject:date:message-id; bh=iThrbaf/3eOT5wm4rBD4w/ehi8bk8I/n0po1O+9VxAA=; b=HkWjLbjf7tJ+G8opwppg3jfX+4u/YwxFhEDePL+ThO4aDO0OxwWpN2rT cWBrPn/OqEzoXnBiq+vj3o0f92Hz8R73K4qb9ZhYedQYYZB4nrE++mftX ofjdhSGUuIygKWtPCb5XoQbtgCbW5ngb1HuknVhnZmPM7B2/kiZ6oy2z0 2b2j5PafztpVej/M/AU7w0IFrTrLueuzeDol6GxJkWRiQYTXhnnpzfk1a tmIgeIgfhloox6mEbRnjuMmogOdSdK/zCsB/Xg/Ka17Tp2/a9ta4T/iFf 1T6VBcgujN/AgWysji4/y5P/cPiX/tbcFm2eCIrzAZRDl6tdhn7ZA13QZ g==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252567" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Jul 2021 14:24:04 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 76F79280075; Fri, 2 Jul 2021 14:24:04 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v2 1/7] gpio: tqmx86: really make IRQ optional Date: Fri, 2 Jul 2021 14:23:47 +0200 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This causes warnings with newer kernels. Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a missing IRQ properly. Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller") Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: add Fixes line The "irq != -ENXIO" check can be removed again if platform_get_irq_optional() is modified to return 0 when no IRQ is found; the current code will work with both -ENXIO and 0 returns. drivers/gpio/gpio-tqmx86.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c index 5022e0ad0fae..0f5d17f343f1 100644 --- a/drivers/gpio/gpio-tqmx86.c +++ b/drivers/gpio/gpio-tqmx86.c @@ -238,8 +238,8 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) struct resource *res; int ret, irq; - irq = platform_get_irq(pdev, 0); - if (irq < 0) + irq = platform_get_irq_optional(pdev, 0); + if (irq < 0 && irq != -ENXIO) return irq; res = platform_get_resource(pdev, IORESOURCE_IO, 0); @@ -278,7 +278,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); - if (irq) { + if (irq > 0) { struct irq_chip *irq_chip = &gpio->irq_chip; u8 irq_status; From patchwork Fri Jul 2 12:23:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 1500044 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=CH7Fm6/5; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=DIqeqhKi; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GGZ566tdpz9snk for ; Fri, 2 Jul 2021 22:24:10 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232192AbhGBM0k (ORCPT ); Fri, 2 Jul 2021 08:26:40 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:42419 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232156AbhGBM0i (ORCPT ); Fri, 2 Jul 2021 08:26:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228647; x=1656764647; h=from:to:cc:subject:date:message-id; bh=x/cAfVv59ovK81IneX1hABOtGlTE/zThFenfoMr94bo=; b=CH7Fm6/5VJzR+9jxvp1+seSv3ZQvVWLbXMnXyAQpvc4V6C+XdfBdgzOS ClPTi9gmJbovrqzVEE+RDduBk5BOndWAXD+3lYKimh2otGm77ChzFmiov R0DDXY2xMDRHC1ciL8CChxUWeKoNGM97LXcl/7XeHVz12BNZlK/frzhL/ vDMNovR7ciRkTQ61/v2FcnThuxPP5+e0eujkXuVhP3Y6V2CgUROZD04Jb znhpxay3g5HZDmkZQipBH7IFdkelk+ofC6MQ7fEfPyI+G4L35Ld75DW2I MryujKVRALzd+zNkPNlGVwH7KtZwm4Q5cwj54tfHtTgM+PJNti8F1zdWl A==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252570" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Jul 2021 14:24:04 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 02 Jul 2021 14:24:04 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 02 Jul 2021 14:24:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228644; x=1656764644; h=from:to:cc:subject:date:message-id; bh=x/cAfVv59ovK81IneX1hABOtGlTE/zThFenfoMr94bo=; b=DIqeqhKiUQVrkuzvr+NFfAGf5daKySTR/8fvj49LbIUbOQht33UL7QOP lAep2cB+PejWF55MsR50WivARXx+xs8EYLN/+lQmrroodlodFMG53FBfR W1xM070qsZhAoZgydBUGL2CTIaTb5+uaHz9ake29hwEgSCefDSFoi4JLp DF1m847LYU3uk1he5E3SBDmwxzJEWwNsaozeSDOddJt40bLsPP63vm6r6 ph5wLZQXhjQ28h7z/Rj1eZlqVStAyBGcFjs1FpTok3onSbeSPrn1pZVOO 0GSHCWCqQRA3//2IoCWf8/qZ3NqzuJgebefD88b036seZGIOr4fBdF0/K A==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252569" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Jul 2021 14:24:04 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id A3490280078; Fri, 2 Jul 2021 14:24:04 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v2 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set Date: Fri, 2 Jul 2021 14:23:48 +0200 Message-Id: <25ee92527847b2fa15e2c82ca486a92b4fd1d44e.1625227382.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The driver was registering IRQ 0 when no IRQ was set. This leads to warnings with newer kernels. Clear the resource flags, so no resource is registered at all in this case. Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO") Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: add Fixes line Andy recommended to use IORESOURCE_DISABLED instead, but this doesn't have any effect for platform_get_irq(), so I'm resubmitting this patch without functional changes. Grepping for '\.flags = 0;' shows other drivers doing the same. drivers/mfd/tqmx86.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index ddddf08b6a4c..732013f40e4e 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -209,6 +209,8 @@ static int tqmx86_probe(struct platform_device *pdev) /* Assumes the IRQ resource is first. */ tqmx_gpio_resources[0].start = gpio_irq; + } else { + tqmx_gpio_resources[0].flags = 0; } ocores_platfom_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id); From patchwork Fri Jul 2 12:23:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 1500046 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=kK66Njxf; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=VR0APtBy; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GGZ590PSrz9srZ for ; Fri, 2 Jul 2021 22:24:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232215AbhGBM0l (ORCPT ); Fri, 2 Jul 2021 08:26:41 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:42421 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232144AbhGBM0k (ORCPT ); Fri, 2 Jul 2021 08:26:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228648; x=1656764648; h=from:to:cc:subject:date:message-id; bh=Q/64wyLAKZYuggBcQQiGTIRE0uQ5M5Ts91Z7qH6yqhc=; b=kK66NjxfmUcMdcKdzXkmVkrYC5y8lVRKTolf91BCyhzpBu+dk/j461ZJ VtyT5VIP7FAHS/6RKSRHJWIP8ZG4JnGijuNi/rwyqvvvkhTkyERZ+e+g2 xXkq8Il8acLB7nPvlVnoZG53Cbk877jx47WrnYwCPxE+BQYNWCOvx/ddy ZGDYr40oFUI8z9WOKlCtelTW1KneWlmc9T4w3sjvTCOAygcFsKmqUvllf XYoCGl/P4KjTcHbIzhO65RqKlKi20KWB4Gg9s7IiE+Zcg2JCIG9vlurmh RJ13HxdSjdxnSYvTTJzR2NOgk7jUoNnSp63NZgpSbhuHduW77d3O4j9/W w==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252572" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 02 Jul 2021 14:24:05 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 02 Jul 2021 14:24:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228645; x=1656764645; h=from:to:cc:subject:date:message-id; bh=Q/64wyLAKZYuggBcQQiGTIRE0uQ5M5Ts91Z7qH6yqhc=; b=VR0APtByvJisolLRAXi2Qg+61xjHowBb1TBT3TTPmNCoYjgJH77HDBPZ 2nQVxwBSvgNPsjf8yKK51AWy3SsHygQXsk5GlpK8QvTxSH3yEPIExWQ+Y 07fljPeFARyCH232LIMXW/KfZzu34kmjS/vqOzbZhTK7wZUcJWahT4hRT qpUbfaN7ZcgXkDycJOz29cIPke9fQOk+53irqP6EszTUsL50Lbg7UFb3N ugTLs3afaTnK0vmTpBjPGxjHIlsmNARwWoelQ2W8+knVhtU7F+jwyiqcx JzV6WdL52BSkFkj0Lai1Ep6LJgSK5783pIGamTdEMqPR8Wu7Z4sDAQaDF A==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252571" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id D340F280070; Fri, 2 Jul 2021 14:24:04 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v2 3/7] mfd: tqmx86: remove incorrect TQMx90UC board ID Date: Fri, 2 Jul 2021 14:23:49 +0200 Message-Id: <36046861067369c0569f3d955f7a390c136689b5.1625227382.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org No TQMx90UC exists at the moment, and it is undecided whether ID 10 will be used eventually (and if it is, how that SoM will be named). Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO") Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: new patch drivers/mfd/tqmx86.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index 732013f40e4e..9b65dbedc1bb 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -35,7 +35,6 @@ #define TQMX86_REG_BOARD_ID_E39x 7 #define TQMX86_REG_BOARD_ID_70EB 8 #define TQMX86_REG_BOARD_ID_80UC 9 -#define TQMX86_REG_BOARD_ID_90UC 10 #define TQMX86_REG_BOARD_REV 0x21 #define TQMX86_REG_IO_EXT_INT 0x26 #define TQMX86_REG_IO_EXT_INT_NONE 0 @@ -128,8 +127,6 @@ static const char *tqmx86_board_id_to_name(u8 board_id) return "TQMx70EB"; case TQMX86_REG_BOARD_ID_80UC: return "TQMx80UC"; - case TQMX86_REG_BOARD_ID_90UC: - return "TQMx90UC"; default: return "Unknown"; } @@ -142,7 +139,6 @@ static int tqmx86_board_id_to_clk_rate(u8 board_id) case TQMX86_REG_BOARD_ID_60EB: case TQMX86_REG_BOARD_ID_70EB: case TQMX86_REG_BOARD_ID_80UC: - case TQMX86_REG_BOARD_ID_90UC: return 24000; case TQMX86_REG_BOARD_ID_E39M: case TQMX86_REG_BOARD_ID_E39C: From patchwork Fri Jul 2 12:23:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 1500045 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=o6gxl2hC; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=njHDBg28; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GGZ574h0Cz9srX for ; Fri, 2 Jul 2021 22:24:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232212AbhGBM0l (ORCPT ); Fri, 2 Jul 2021 08:26:41 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:42419 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232180AbhGBM0k (ORCPT ); Fri, 2 Jul 2021 08:26:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228648; x=1656764648; h=from:to:cc:subject:date:message-id; bh=5eBKJK+/7yccBTR+CWndE21pD0OcZAqPQFk3FO/jEQU=; b=o6gxl2hCpS4OAihErLy9TLPm7t9oednOfoZb6LuSDsO2yymxtzbMklMR HF5RvMo0b0K4BhHr33zZ9IQkktHjt/Ww7S0EU6nNdcTTEMZ1SQpWPTURq +gbT2KfYGK+V8+FFnHD1qKeWTCQuQHsSD9/OodoxVtBHftKb7E5oNIyIU km6ehsP0kVPNwhgpObgg8c+lxwoEfW8XrSbZEWCJqeDEkge1h12aopAPR 9IEv4BSw1rqM6kRA/VjRgIrjcSxwJoCXCKPk9mdjGqmLG4zVAFaaTMFdq 3zfV6gX0nzVHs5K4hUSIbF8o/il2szviO8IGw/T/2rcHkOV7UgwWIVtrr A==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252574" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 02 Jul 2021 14:24:05 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 02 Jul 2021 14:24:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228645; x=1656764645; h=from:to:cc:subject:date:message-id; bh=5eBKJK+/7yccBTR+CWndE21pD0OcZAqPQFk3FO/jEQU=; b=njHDBg280tJ3Dt5zP7F0rsJrTqfOIqyRdkq1O8yc4E2VfWtwNl5TgdOy /oITv0viAAQ4GleWuXCKhRrdzeHZg8X05C6y/ePHw3zmVPSfJT1ti9kVh j+qCo9DSULVcQ6FHdlCplgs2hqEAc4YM499cmM9T+0Lyfbvt4fKshd9SO weXcq28XOcH7Hebi7h4U5CunggpJJAiryNSYNRhFWYdUMq0MBKe1JOxzh 5LOgq88ULUBJW+UjmnurTfCuDs+JT0ZUtpEgZHdR610v2hXKlgqxutZJG Xf3XEVgbbqxZxz4XzKwJz2PQeOv/2lkv25dqXBODkJKQyfpy3uRjn/xBw w==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252573" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 0CC53280075; Fri, 2 Jul 2021 14:24:05 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v2 4/7] mfd: tqmx86: fix typo in "platform" Date: Fri, 2 Jul 2021 14:23:50 +0200 Message-Id: <7c689191a76ddf0f18ff14989651038f509f1746.1625227382.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Rename variable from "ocores_platfom_data" to "ocores_platform_data". Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: new patch drivers/mfd/tqmx86.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index 9b65dbedc1bb..ff1bdb742e3f 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -76,7 +76,7 @@ static struct i2c_board_info tqmx86_i2c_devices[] = { }, }; -static struct ocores_i2c_platform_data ocores_platfom_data = { +static struct ocores_i2c_platform_data ocores_platform_data = { .num_devices = ARRAY_SIZE(tqmx86_i2c_devices), .devices = tqmx86_i2c_devices, }; @@ -84,8 +84,8 @@ static struct ocores_i2c_platform_data ocores_platfom_data = { static const struct mfd_cell tqmx86_i2c_soft_dev[] = { { .name = "ocores-i2c", - .platform_data = &ocores_platfom_data, - .pdata_size = sizeof(ocores_platfom_data), + .platform_data = &ocores_platform_data, + .pdata_size = sizeof(ocores_platform_data), .resources = tqmx_i2c_soft_resources, .num_resources = ARRAY_SIZE(tqmx_i2c_soft_resources), }, @@ -209,7 +209,7 @@ static int tqmx86_probe(struct platform_device *pdev) tqmx_gpio_resources[0].flags = 0; } - ocores_platfom_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id); + ocores_platform_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id); if (i2c_det == TQMX86_REG_I2C_DETECT_SOFT) { err = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, From patchwork Fri Jul 2 12:23:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 1500047 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=C2rxwIjX; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=M7946s96; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GGZ59543sz9svs for ; Fri, 2 Jul 2021 22:24:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232225AbhGBM0m (ORCPT ); Fri, 2 Jul 2021 08:26:42 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:42427 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232187AbhGBM0k (ORCPT ); Fri, 2 Jul 2021 08:26:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228649; x=1656764649; h=from:to:cc:subject:date:message-id; bh=0q1NI26zCrMekPqE1Que8c1L2fPhyX9256BI2bruGPk=; b=C2rxwIjXSW5QdgfuXHm32nm8ezrmmjqEF8yOl54Au5HUJGW+Su1VKTUK WjiBW5kMEgzD9vjOpzTNLLUAqFiu7CIt8bJ47oEaT3jkO/AXx2wPGVFoo uAWFHoY4L4m1AZYG6cP4Dgd4yglKKZ+5HbtJxWf/L3A4Xr/C6vvDDv+YB oqsrgDWCy/mPnAd22cyR/l0kzrELmVpkgoTSQ+ndkWNYm4VmvHvdaumFa OUv7iAguNOlagcXnm2mFFZcr+pb16IZx6UVDP7H6ks7V71PHfcxHxjWbd 4g8MObs0PrXu18x9uDf/hLWl4Vqx5RUDC5JkV0VmZPN6Ev7+BauXjXBA2 w==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252576" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 02 Jul 2021 14:24:05 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 02 Jul 2021 14:24:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228645; x=1656764645; h=from:to:cc:subject:date:message-id; bh=0q1NI26zCrMekPqE1Que8c1L2fPhyX9256BI2bruGPk=; b=M7946s96b3rBn2W78HBg6zhxH9+o6eJ6U4ughEE4HUp2kg4A1ZJBEsYG iZ5jjeJWAjOqNuv0v5VaWZ7xU9j6WEC/xRa3zkLJdzgSHMKK4tyAyBgM/ WzkCjXQPD73/F0TP5+1r764Di7r7UIujCuJA7kB8MWTOALZKweV0tkaLo lq9Srva4w9YhlMf55KkmpzdFaJXGJG5RSozy0mQz1F2g11K/6HFqSQOAq ftxh9B5SbJELQSNRn8o5Jx4c98tfb42/i/smik+/rkpY9qPPeGJPd03RD GsyJVmtrTyx5gcl1s6Us0+xWD90EVZ1pF921oHPPY6Rx/kPpAmv0Hc44N A==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252575" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 2ECD9280078; Fri, 2 Jul 2021 14:24:05 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v2 5/7] mfd: tqmx86: add support for TQMx110EB and TQMxE40x Date: Fri, 2 Jul 2021 14:23:51 +0200 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Add the board IDs for the TQMx110EB and the TQMxE40x family. All use a 24MHz LPC clock. Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: - add more new modules - explicitly list each module for LPC clock drivers/mfd/tqmx86.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index ff1bdb742e3f..9eb05b3ef573 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -35,6 +35,11 @@ #define TQMX86_REG_BOARD_ID_E39x 7 #define TQMX86_REG_BOARD_ID_70EB 8 #define TQMX86_REG_BOARD_ID_80UC 9 +#define TQMX86_REG_BOARD_ID_110EB 11 +#define TQMX86_REG_BOARD_ID_E40M 12 +#define TQMX86_REG_BOARD_ID_E40S 13 +#define TQMX86_REG_BOARD_ID_E40C1 14 +#define TQMX86_REG_BOARD_ID_E40C2 15 #define TQMX86_REG_BOARD_REV 0x21 #define TQMX86_REG_IO_EXT_INT 0x26 #define TQMX86_REG_IO_EXT_INT_NONE 0 @@ -127,6 +132,16 @@ static const char *tqmx86_board_id_to_name(u8 board_id) return "TQMx70EB"; case TQMX86_REG_BOARD_ID_80UC: return "TQMx80UC"; + case TQMX86_REG_BOARD_ID_110EB: + return "TQMx110EB"; + case TQMX86_REG_BOARD_ID_E40M: + return "TQMxE40M"; + case TQMX86_REG_BOARD_ID_E40S: + return "TQMxE40S"; + case TQMX86_REG_BOARD_ID_E40C1: + return "TQMxE40C1"; + case TQMX86_REG_BOARD_ID_E40C2: + return "TQMxE40C2"; default: return "Unknown"; } @@ -139,6 +154,11 @@ static int tqmx86_board_id_to_clk_rate(u8 board_id) case TQMX86_REG_BOARD_ID_60EB: case TQMX86_REG_BOARD_ID_70EB: case TQMX86_REG_BOARD_ID_80UC: + case TQMX86_REG_BOARD_ID_110EB: + case TQMX86_REG_BOARD_ID_E40M: + case TQMX86_REG_BOARD_ID_E40S: + case TQMX86_REG_BOARD_ID_E40C1: + case TQMX86_REG_BOARD_ID_E40C2: return 24000; case TQMX86_REG_BOARD_ID_E39M: case TQMX86_REG_BOARD_ID_E39C: From patchwork Fri Jul 2 12:23:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 1500048 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=Bug4UWkj; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=c38PSFpl; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GGZ5B4HRQz9sxS for ; Fri, 2 Jul 2021 22:24:14 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232100AbhGBM0o (ORCPT ); Fri, 2 Jul 2021 08:26:44 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:42421 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232203AbhGBM0l (ORCPT ); Fri, 2 Jul 2021 08:26:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228649; x=1656764649; h=from:to:cc:subject:date:message-id; bh=BpioOeLEu+qJSb8YvKVoIV3l4TxE6atJJi2U9xpCr4k=; b=Bug4UWkjg8algbavwd6O/gqfLXf/pHxpxJwXrmVGUmBO7hxSSEyQ5TvD cJTKitPT9UnU0o/ok1oTZS8VDm6P4akTinIXIw8XySvOX1kzd6RbAN2cX ICWk/Z2qgYbZAJJeGHV7/Qh3Nkp5DWLv7AxtkvshrUBC/84SWE+4jsfP/ vTTJgI0JDSkkx5utbhvf8j43XvLlnrGv9tmOlvR1zg4WiH7Y6NttsVuOF +4dIETML9dS7exa1DzyaOHZMUlqskxhAtG4cZXcHEyaEsptK521Fyov5a idpmw6OJCa2De0H4SbE1qfQQ0Y0LcO3OJA5v0NqUYhldFjFpIhBYzOSnX g==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252578" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 02 Jul 2021 14:24:05 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 02 Jul 2021 14:24:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228645; x=1656764645; h=from:to:cc:subject:date:message-id; bh=BpioOeLEu+qJSb8YvKVoIV3l4TxE6atJJi2U9xpCr4k=; b=c38PSFplvcL1/fv8MKvz2AgPtaeeuWs0nsFIAAFPLb9xLPTCl1qUHUIy 5I57iV+zXUf0AIx4hfYG1Q1mT/oyg+reZTSDKmBF0iyni5wadDtl5mKQ7 L+ey+PohCoGyDj80K4x9H1Sm5R7yJI+s9bJZuC3X7Qi2qyvqVwGswoCwz DD5/jAwW6oV73/sO0WjW1GRkpIDvqZF6hAMx/1B87ojLfMIRpsd4Dz1YY cgRL6cIFov3rhjFsa+jtrPkIGnsoVHeFJoWVAvhtYwqxXt0tJU3ytXWGS QI+KVtENgz4ocVA/SMEoQ+UGL+ffoCEntkiHqiFW2Lhd55FawJA+yx8N1 g==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252577" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 509FA280070; Fri, 2 Jul 2021 14:24:05 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v2 6/7] mfd: tqmx86: add support for TQ-Systems DMI IDs Date: Fri, 2 Jul 2021 14:23:52 +0200 Message-Id: <11bef2179e4745a4edcf579ff96185cb6987931d.1625227382.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Newer TQMx86 modules use TQ-Systems instead of TQ-Group as their vendor ID. Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: new patch drivers/mfd/tqmx86.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index 9eb05b3ef573..58f35c8b5a45 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -271,6 +271,14 @@ static const struct dmi_system_id tqmx86_dmi_table[] __initconst = { }, .callback = tqmx86_create_platform_device, }, + { + .ident = "TQMX86", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "TQ-Systems"), + DMI_MATCH(DMI_PRODUCT_NAME, "TQMx"), + }, + .callback = tqmx86_create_platform_device, + }, {} }; MODULE_DEVICE_TABLE(dmi, tqmx86_dmi_table); From patchwork Fri Jul 2 12:23:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 1500049 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=j6YGRFIU; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=OMi/e2jR; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GGZ5D3zMtz9t0k for ; Fri, 2 Jul 2021 22:24:16 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232249AbhGBM0q (ORCPT ); Fri, 2 Jul 2021 08:26:46 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:42419 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232206AbhGBM0l (ORCPT ); Fri, 2 Jul 2021 08:26:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228649; x=1656764649; h=from:to:cc:subject:date:message-id; bh=i1B2hVnhFg7bXOdNCkdVmlZaSpi0oK/SS9yg7qx3A4Y=; b=j6YGRFIUALAuS/ogy2sHvjrk+s0hLwGnxqOQSsup9nHWb6n9HwZnKE7A xnH5Ne8VBKiXMY7NGB2M6LLj/bGya8edytkiUIR3DCPEpVjJX3kMEJ5Y/ eLYTb6iaiXi3Jodo5lpWDKgIFSCQTwnFFaxiUYlIYSBNTaoiULRyKkaaV BjbDSVvhcbUcZ+o0ZWjR/Q5VvDpB6PpZ9DGJIFUYgg2mM4dsfPG+4iAUc kRE+toxR/bdROXIVjvo0/CrkllTuSNxwAcDS/tOH2n74RmF2js1HhWaSJ yoDHTCqAVO+ybuo7qTogvCgmOHeL5Pdy5WmSzKUCb9bZ2RA0phjSDedjp A==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252580" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 02 Jul 2021 14:24:05 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 02 Jul 2021 14:24:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1625228645; x=1656764645; h=from:to:cc:subject:date:message-id; bh=i1B2hVnhFg7bXOdNCkdVmlZaSpi0oK/SS9yg7qx3A4Y=; b=OMi/e2jR0tdf7cBKo/jTWQo33bPt0jhJSY/ZPfVLTJOvYSWq2mwthGV+ 2U4x2pa95XVo2zCbKCT07F1Azcq6wwoMuVx9acM1JgHoCXFTGoUMz7X7A i8va/uFBOQHBWnDvr6fAQS8UVc2OskZ1AhYb1gVCEvXXNBCzenAdSxsBB 1UFmPaiCugpMpHldM3c16ksdb2xKRRhB0DMKJzzZ0RK+GtyoWIIpi13er 11lvXqdKvLJjrD/fNdTRloQIp5byPfhBpPIiUbvMxA4uJBY/P02YS7wcc Jx3HTaasQS+LKTRexcDRvHm1eQDdKKHoFOwBaiFwP80NVDHWXsb0HyoEj Q==; X-IronPort-AV: E=Sophos;i="5.83,317,1616454000"; d="scan'208";a="18252579" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Jul 2021 14:24:05 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 7E5F4280075; Fri, 2 Jul 2021 14:24:05 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v2 7/7] mfd: tqmx86: assume 24MHz LPC clock for unknown boards Date: Fri, 2 Jul 2021 14:23:53 +0200 Message-Id: <384f4c0070fc95e4e688731876178f9299861aa7.1625227382.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org All future TQMx86 modules should use a 24MHz LPC clock. Warn about unknown boards, but assume this is the case. Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: - Separated from TQMxE40M support patch - Add warning for unknown boards drivers/mfd/tqmx86.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index 58f35c8b5a45..7ae906ff8e35 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -147,7 +147,7 @@ static const char *tqmx86_board_id_to_name(u8 board_id) } } -static int tqmx86_board_id_to_clk_rate(u8 board_id) +static int tqmx86_board_id_to_clk_rate(struct device *dev, u8 board_id) { switch (board_id) { case TQMX86_REG_BOARD_ID_50UC: @@ -168,7 +168,9 @@ static int tqmx86_board_id_to_clk_rate(u8 board_id) case TQMX86_REG_BOARD_ID_E38C: return 33000; default: - return 0; + dev_warn(dev, "unknown board %d, assuming 24MHz LPC clock\n", + board_id); + return 24000; } } @@ -229,7 +231,7 @@ static int tqmx86_probe(struct platform_device *pdev) tqmx_gpio_resources[0].flags = 0; } - ocores_platform_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id); + ocores_platform_data.clock_khz = tqmx86_board_id_to_clk_rate(dev, board_id); if (i2c_det == TQMX86_REG_I2C_DETECT_SOFT) { err = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,