From patchwork Wed Jun 9 07:22:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Schmitz X-Patchwork-Id: 1489713 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=XYT4/q4Q; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4G0JTG0yZXz9sCD for ; Wed, 9 Jun 2021 17:22:10 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237282AbhFIHYD (ORCPT ); Wed, 9 Jun 2021 03:24:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237250AbhFIHYC (ORCPT ); Wed, 9 Jun 2021 03:24:02 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86059C06175F; Wed, 9 Jun 2021 00:22:08 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id u126so13744547pfu.13; Wed, 09 Jun 2021 00:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=th/yRFh6gfC3XN94smE83n5qFBH52y8ewDss77XEIEg=; b=XYT4/q4QHhZ0wWhrUvpPmLFx4OvNNxdm/7xWP2gnM477D5dVPx+c8wTHN+IoPwqKvd W6e7eZ9iXzdjIkM84mlCD+lUmMGVXBFF6KEc69dBoBYHPl9cfRadza3ERDwfYBeOtN71 DuhYjJGHj3EKJ/AwLtWaT9id6mp+5dhV1DAsMWQiPMlBLa3taU0U1C3eP1DGnZspuH8W gqb5XmHsiORWB2f9mISrZPG79R813DTjNiB1ZKYI6SluMKMF0EBlF4Tq3p69WTblSpGP AALNO9p0w5TSe1OF21P8M6U2ryJTyvxs/WxPIpJEqirkbYJSt1B+3VsJ2iFovrgeK/uS 6wrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=th/yRFh6gfC3XN94smE83n5qFBH52y8ewDss77XEIEg=; b=Js3Z8IObFCbbcaVJ5QMOnGpw5Irla28oz9gJ7ac2/iBQkPjdqbaFGY3xOGua5Qs8Dv 3rDEzAaIPVPo9okfZ2DSLDLgnVzFEi0t+gQCZwNEcs3zLxW+9PX49iZw2yFxjAEL4I94 4W+I5f97tDuQtC9VDsM+OsgYng+LpQxaCIexDi7lADpPDOm0HBPVnf+RCqLKKF2FxwN0 EC2DE6BCmoYuSGnyHjEsqGRFGsoOREzDhgZ6ySOeDctQYSwtrjlCdhh4QVwyThfD4Khb GeP6h4cnlbNCvA/+P7PWS47U8JQfiWzfryD3BFnRhpSQpyhO7xvFYUhRIn6WxYqIJKE9 p4BQ== X-Gm-Message-State: AOAM532mQrEuLsytwaPWNRfPF/HBWbPhAs94sYpNqJ4eWWPlPbxFhFEv RVVKzYi/dG9tns3R8EOXlvA= X-Google-Smtp-Source: ABdhPJykbaTkq6yxbdRyUUnnyLfaxT6bg65PX0mcGnPoE54cT82x90G8KLlO1PHEF7eQbgvfmjcJ8A== X-Received: by 2002:a63:2f05:: with SMTP id v5mr2377555pgv.449.1623223328026; Wed, 09 Jun 2021 00:22:08 -0700 (PDT) Received: from xplor.waratah.dyndns.org (222-152-189-137-fibre.sparkbb.co.nz. [222.152.189.137]) by smtp.gmail.com with ESMTPSA id k9sm13364815pgq.27.2021.06.09.00.22.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Jun 2021 00:22:07 -0700 (PDT) Received: by xplor.waratah.dyndns.org (Postfix, from userid 1000) id DA3693603D8; Wed, 9 Jun 2021 19:22:03 +1200 (NZST) From: Michael Schmitz To: linux-m68k@vger.kernel.org, geert@linux-m68k.org Cc: linux-ide@vger.kernel.org, fthain@linux-m68k.org, Michael Schmitz Subject: [PATCH v2] m68k: io_mm.h: conditionalize ISA address translation on Atari Date: Wed, 9 Jun 2021 19:22:02 +1200 Message-Id: <1623223322-4242-1-git-send-email-schmitzmic@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1622957313-321-1-git-send-email-schmitzmic@gmail.com> References: <1622957313-321-1-git-send-email-schmitzmic@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Current io_mm.h uses address translation and ROM port IO primitives when port addresses are below 1024, and raw untranslated MMIO IO primitives else when CONFIG_ATARI_ROM_ISA is set. This is done regardless of the m68k machine type a multi-platform kernel runs on. As a consequence, the Q40 IDE driver in multiplatform kernels cannot work. Conversely, the Atari IDE driver uses wrong address translation if a multiplatform Q40 and Atari kernel does _not_ set CONFIG_ATARI_ROM_ISA. Replace MMIO by ISA IO primitives for addresses > 1024 (if isa_type is ISA_TYPE_ENEC), and change the ISA address translation used for Atari to a no-op for those addresses. Switch readb()/writeb() and readw()/writew() to their ISA equivalents also. Change the address translation functions to return the identity translation if CONFIG_ATARI_ROM_ISA is not defined, and set MULTI_ISA for kernels where Q40 and Atari are both configured so this can actually work (isa_type set to Q40 at compile time else). Fixes: 84b16b7b0d5c818f ("m68k/atari: ROM port ISA adapter support") Signed-off-by: Michael Schmitz --- Changes from v1: Geert Uytterhoeven; - fix Fixes tag - remove comment about isa_sex zero initialization - move default return outside switch statement in address translation functions to allow other code to break to default. - fix indentation in switch statement Changes from RFC: Geert Uytterhoeven; - drop setup_mm.c patch Finn Thain: - Add 'Fixes' tag - Annotate rationale for MULTI_ISA setting on Atari - Use fallthrough macro annotation in Atari address translation --- arch/m68k/include/asm/io_mm.h | 66 +++++++++++++++++++++++++++---------------- 1 file changed, 41 insertions(+), 25 deletions(-) diff --git a/arch/m68k/include/asm/io_mm.h b/arch/m68k/include/asm/io_mm.h index d41fa48..6eae9ec 100644 --- a/arch/m68k/include/asm/io_mm.h +++ b/arch/m68k/include/asm/io_mm.h @@ -52,7 +52,11 @@ #define Q40_ISA_MEM_B(madr) (q40_isa_mem_base+1+4*((unsigned long)(madr))) #define Q40_ISA_MEM_W(madr) (q40_isa_mem_base+ 4*((unsigned long)(madr))) +#ifdef CONFIG_ATARI +#define MULTI_ISA 1 /* Need MULTI_ISA if Atari drivers (IDE) present !! */ +#else #define MULTI_ISA 0 +#endif /* Atari */ #endif /* Q40 */ #ifdef CONFIG_AMIGA_PCMCIA @@ -135,10 +139,13 @@ static inline u8 __iomem *isa_itb(unsigned long addr) case ISA_TYPE_AG: return (u8 __iomem *)AG_ISA_IO_B(addr); #endif #ifdef CONFIG_ATARI_ROM_ISA - case ISA_TYPE_ENEC: return (u8 __iomem *)ENEC_ISA_IO_B(addr); + case ISA_TYPE_ENEC: + if (addr < 1024) + return (u8 __iomem *)ENEC_ISA_IO_B(addr); + break; /* not ROM port? fallback below! */ #endif - default: return NULL; /* avoid warnings, just in case */ } + return (u8 __iomem *)(addr); /* avoid warnings, just in case */ } static inline u16 __iomem *isa_itw(unsigned long addr) { @@ -151,10 +158,13 @@ static inline u16 __iomem *isa_itw(unsigned long addr) case ISA_TYPE_AG: return (u16 __iomem *)AG_ISA_IO_W(addr); #endif #ifdef CONFIG_ATARI_ROM_ISA - case ISA_TYPE_ENEC: return (u16 __iomem *)ENEC_ISA_IO_W(addr); + case ISA_TYPE_ENEC: + if (addr < 1024) + return (u16 __iomem *)ENEC_ISA_IO_W(addr); + break; /* not ROM port? fallback below! */ #endif - default: return NULL; /* avoid warnings, just in case */ } + return (u16 __iomem *)(addr); /* avoid warnings, just in case */ } static inline u32 __iomem *isa_itl(unsigned long addr) { @@ -163,8 +173,8 @@ static inline u32 __iomem *isa_itl(unsigned long addr) #ifdef CONFIG_AMIGA_PCMCIA case ISA_TYPE_AG: return (u32 __iomem *)AG_ISA_IO_W(addr); #endif - default: return 0; /* avoid warnings, just in case */ } + return 0; /* avoid warnings, just in case */ } static inline u8 __iomem *isa_mtb(unsigned long addr) { @@ -177,10 +187,13 @@ static inline u8 __iomem *isa_mtb(unsigned long addr) case ISA_TYPE_AG: return (u8 __iomem *)addr; #endif #ifdef CONFIG_ATARI_ROM_ISA - case ISA_TYPE_ENEC: return (u8 __iomem *)ENEC_ISA_MEM_B(addr); + case ISA_TYPE_ENEC: + if (addr < 1024) + return (u8 __iomem *)ENEC_ISA_MEM_B(addr); + break; /* not ROM port? fallback below! */ #endif - default: return NULL; /* avoid warnings, just in case */ } + return (u8 __iomem *)(addr); /* avoid warnings, just in case */ } static inline u16 __iomem *isa_mtw(unsigned long addr) { @@ -193,10 +206,13 @@ static inline u16 __iomem *isa_mtw(unsigned long addr) case ISA_TYPE_AG: return (u16 __iomem *)addr; #endif #ifdef CONFIG_ATARI_ROM_ISA - case ISA_TYPE_ENEC: return (u16 __iomem *)ENEC_ISA_MEM_W(addr); + case ISA_TYPE_ENEC: + if (addr < 1024) + return (u16 __iomem *)ENEC_ISA_MEM_W(addr); + break; /* not ROM port? fallback below! */ #endif - default: return NULL; /* avoid warnings, just in case */ } + return (u16 __iomem *)(addr); /* avoid warnings, just in case */ } @@ -344,31 +360,31 @@ static inline void isa_delay(void) * ROM port ISA and everything else regular ISA for IDE. read,write defined * below. */ -#define inb(port) ((port) < 1024 ? isa_rom_inb(port) : in_8(port)) -#define inb_p(port) ((port) < 1024 ? isa_rom_inb_p(port) : in_8(port)) -#define inw(port) ((port) < 1024 ? isa_rom_inw(port) : in_le16(port)) -#define inw_p(port) ((port) < 1024 ? isa_rom_inw_p(port) : in_le16(port)) +#define inb(port) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_inb(port) : isa_inb(port)) +#define inb_p(port) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_inb_p(port) : isa_inb_p(port)) +#define inw(port) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_inw(port) : isa_inw(port)) +#define inw_p(port) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_inw_p(port) : isa_inw_p(port)) #define inl isa_inl #define inl_p isa_inl_p -#define outb(val, port) ((port) < 1024 ? isa_rom_outb((val), (port)) : out_8((port), (val))) -#define outb_p(val, port) ((port) < 1024 ? isa_rom_outb_p((val), (port)) : out_8((port), (val))) -#define outw(val, port) ((port) < 1024 ? isa_rom_outw((val), (port)) : out_le16((port), (val))) -#define outw_p(val, port) ((port) < 1024 ? isa_rom_outw_p((val), (port)) : out_le16((port), (val))) +#define outb(val, port) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_outb((val), (port)) : isa_outb((val), (port))) +#define outb_p(val, port) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_outb_p((val), (port)) : isa_outb_p((val), (port))) +#define outw(val, port) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_outw((val), (port)) : isa_outw((val), (port))) +#define outw_p(val, port) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_outw_p((val), (port)) : isa_outw_p((val), (port))) #define outl isa_outl #define outl_p isa_outl_p -#define insb(port, buf, nr) ((port) < 1024 ? isa_rom_insb((port), (buf), (nr)) : isa_insb((port), (buf), (nr))) -#define insw(port, buf, nr) ((port) < 1024 ? isa_rom_insw((port), (buf), (nr)) : isa_insw((port), (buf), (nr))) +#define insb(port, buf, nr) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_insb((port), (buf), (nr)) : isa_insb((port), (buf), (nr))) +#define insw(port, buf, nr) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_insw((port), (buf), (nr)) : isa_insw((port), (buf), (nr))) #define insl isa_insl -#define outsb(port, buf, nr) ((port) < 1024 ? isa_rom_outsb((port), (buf), (nr)) : isa_outsb((port), (buf), (nr))) -#define outsw(port, buf, nr) ((port) < 1024 ? isa_rom_outsw((port), (buf), (nr)) : isa_outsw((port), (buf), (nr))) +#define outsb(port, buf, nr) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_outsb((port), (buf), (nr)) : isa_outsb((port), (buf), (nr))) +#define outsw(port, buf, nr) (((port) < 1024 && ISA_TYPE == ISA_TYPE_ENEC) ? isa_rom_outsw((port), (buf), (nr)) : isa_outsw((port), (buf), (nr))) #define outsl isa_outsl -#define readb(addr) in_8(addr) -#define writeb(val, addr) out_8((addr), (val)) -#define readw(addr) in_le16(addr) -#define writew(val, addr) out_le16((addr), (val)) +#define readb isa_readb +#define readw isa_readw +#define writeb isa_writeb +#define writew isa_writew #endif /* CONFIG_ATARI_ROM_ISA */ #define readl(addr) in_le32(addr)