From patchwork Tue Jun 8 21:49:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 1489650 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=u9hj/yoX; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4G03ms57cMz9sT6 for ; Wed, 9 Jun 2021 07:49:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234752AbhFHVvl (ORCPT ); Tue, 8 Jun 2021 17:51:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234782AbhFHVvl (ORCPT ); Tue, 8 Jun 2021 17:51:41 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40028C061574 for ; Tue, 8 Jun 2021 14:49:47 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id r5so34555494lfr.5 for ; Tue, 08 Jun 2021 14:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=BSS4C+Tof4hX7XOl0u8vZzIzOJkeQij5kHDcnOxRbtQ=; b=u9hj/yoXRsvtCUvpFePU7s2TiK+2tivLMfkX5m6iJFRZrIZzt8312bf7U0Qa4ahyuU MzeHFa/IuBbB2yBDJOaIowEMKVDd/SWB8SX0dig0uQdWFmzTg7IE3TMA6I0mJGxe/5Rc Y/dE85naosBmQxURJ8jbtHUAc2k3OrrKeT/4PRYsM41zALOb2A2B+MgIGaf3Ep3Qv03B q9FXCk5mLAPHgTv5Uut67j/EG3ERdXf1SJRHCP3J4RrHSKC5L94ys0ZMylzSe7tlJdpo K9dB51dj13JUev4f5ONQoHYd5wNtKQ7uE+E/+QcxrJjSefXcP3mjP7WFX2nuFziYS8/I up/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=BSS4C+Tof4hX7XOl0u8vZzIzOJkeQij5kHDcnOxRbtQ=; b=RMWw0kfFMLdLvUDm0QXQCrF7XpqXHA9fEUz+xG8nam9N/HxDdnFGdkzg07qMrTaCW+ 6pWaL3ZdqdjYGDUZBWkCK3bzN2kEHeoGXD0iTYexm/LbjSTu5OaogkeYMVEJ2qLG208w UAoDCC0+Vc6Ceuk8c+vEhHfYHohr2DmwaJxwKTOZyYx4Z3lEfFNX7sb4KR8UEenrzBos qtaJaQCuV7CBV0wGAsJ1pTtmIywfHt0zhzk7lxiBcrvers+fgCgu/X2ygOsaORzsbFZM 19+UYVfP8wWX2oRZCZQELhcu4yXINK456MIJs3KkUhdUtWqAOKECZmBHbCVIiY9DHlcQ YksA== X-Gm-Message-State: AOAM530fearMJmmazo2ex5kmgwBNjkIbfznw0xioycI0YZAG2IJFTQ/Q a/OnN09zIUDQd3htj+I1G0FQuYmju5z9Y2xc/9/v3p2JCks= X-Google-Smtp-Source: ABdhPJz0r+myW7wXzehh/u9I4qp8s9yNYWkKTuV6fXEQni7Q4eJ9LWDU3QSCbb3mlJBWaylwYcUS/XauJ4A1j+eritw= X-Received: by 2002:a05:6512:3694:: with SMTP id d20mr8645060lfs.184.1623188985306; Tue, 08 Jun 2021 14:49:45 -0700 (PDT) MIME-Version: 1.0 From: Steve French Date: Tue, 8 Jun 2021 16:49:34 -0500 Message-ID: Subject: [CIFS][PATCH] Enable extended stats by default To: CIFS Cc: samba-technical , COMMON INTERNET FILE SYSTEM SERVER Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Patch to enable CONFIG_CIFS_STATS2 by default From 7a6b6d5a5ffe9bae75bf130e2d82a34c39dbee65 Mon Sep 17 00:00:00 2001 From: Steve French Date: Tue, 8 Jun 2021 16:43:41 -0500 Subject: [PATCH] cifs: enable extended stats by default CONFIG_CIFS_STATS2 can be very useful since it shows latencies by command, and allows enabling the slow response dynamic tracepoint which can be useful to identify performance problems. For example: Total time spent processing by command. Time units are jiffies (1000 per second) SMB3 CMD Number Total Time Fastest Slowest -------- ------ ---------- ------- ------- 0 1 2 2 2 1 2 6 2 4 2 0 0 0 0 3 4 11 2 4 4 2 16 5 11 5 4546 34104 2 487 6 4421 32901 2 487 7 0 0 0 0 8 695 2781 2 39 9 391 1708 2 27 10 0 0 0 0 11 4 6 1 2 12 0 0 0 0 13 0 0 0 0 14 3887 17696 0 128 15 0 0 0 0 16 1471 9950 1 487 17 169 2695 9 116 18 80 381 2 10 1 2 6 2 4 2 0 0 0 0 3 4 11 2 4 4 2 16 5 11 5 4546 34104 2 487 6 4421 32901 2 487 7 0 0 0 0 8 695 2781 2 39 9 391 1708 2 27 10 0 0 0 0 11 4 6 1 2 12 0 0 0 0 13 0 0 0 0 14 3887 17696 0 128 15 0 0 0 0 16 1471 9950 1 487 17 169 2695 9 116 18 80 381 2 10 Signed-off-by: Steve French --- fs/cifs/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index 7de5c893c181..7364950a9ef4 100644 --- a/fs/cifs/Kconfig +++ b/fs/cifs/Kconfig @@ -59,6 +59,7 @@ config CIFS config CIFS_STATS2 bool "Extended statistics" depends on CIFS + default y help Enabling this option will allow more detailed statistics on SMB request timing to be displayed in /proc/fs/cifs/DebugData and also @@ -67,8 +68,7 @@ config CIFS_STATS2 for more details. These additional statistics may have a minor effect on performance and memory utilization. - Unless you are a developer or are doing network performance analysis - or tuning, say N. + If unsure, say Y. config CIFS_ALLOW_INSECURE_LEGACY bool "Support legacy servers which use less secure dialects" -- 2.30.2