From patchwork Thu Jun 3 07:52:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1487033 X-Patchwork-Delegate: andre.przywara@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=UUiRtJUr; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FwdRd5WDLz9sVb for ; Thu, 3 Jun 2021 17:53:01 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C2BA82F78; Thu, 3 Jun 2021 09:52:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="UUiRtJUr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 626AC82F7F; Thu, 3 Jun 2021 09:52:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BDA4082AF1 for ; Thu, 3 Jun 2021 09:52:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1622706768; bh=S4CCkLO+jvVb/otmuoJWJU0yXI4apTNwh5zOOjRf+4E=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=UUiRtJUrwDR86dpzIcmY6Ppq27vdRcEFUlfj+fFTOaB+7WXPdnZ0nQpuEBySztShJ TFgdJE0Wj4S9vjG7C43JxYjnGlLJUR3OrBW8KD00HzykzFzZ4YSzAQSbV0D2iV6eEp nCc+YI7GglvylV7vOt5QwrNSLTdUqix03w/IfCJU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from rpi2.fritz.box ([62.143.247.63]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MZCfJ-1ltVVB0uy9-00V5ii; Thu, 03 Jun 2021 09:52:48 +0200 From: Heinrich Schuchardt To: Joe Hershberger , Ramon Fried Cc: u-boot@lists.denx.de, Jagan Teki , Andre Przywara , Heinrich Schuchardt Subject: [PATCH 1/1] net: sun8i-emac: fix MDIO frequency Date: Thu, 3 Jun 2021 07:52:41 +0000 Message-Id: <20210603075242.96527-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:Mq2cU1xmmKIutCZt+QqOWn9sosG0CBH06D0f4gM1dmJ6zYlMFg9 mvSVdWa/YNJeu2TyMyMB0gXohDpvfX1s0LhZTD75wXgQZSqS2gh4scVWZp8qZi7h2oyNmW1 rT8kV6v0Npn64Dp9Yf+WL4n8ODmr3KEMo7NgFZWni3Tup43MjRV5Jq0lBDDzn10aSm6Gg1y GzVpj72e7fHLxBof0V0Bg== X-UI-Out-Filterresults: notjunk:1;V03:K0:/P7f/v5s4iU=:Eibbez+S0EbvLibVwFTSwx GSsla5YOGsZQ6HNhrq2ZEHyrULMX1stjyy9Z1G7+rOhSI232ub3rZMmgRExNVkawd7yRAuXZo 3v1o9wvhXJV+LrbvoaqqNEaQdNVnsBQnBoHhxbFvuU9ipBukISmWs1j0/epyHuUrq1poSkcXn SOUG3mp36usxii+YhouYhtQre0EfLwnCkTlNo+nkeXz+R7R/fxDM51kjx7L58C8R4W0q8zraW l72aslfsGR7OSV9TgyOhhk1V3MWzVTo0PE++vRquX622KmtwvILHv9A+rZLCqYlp189DtdpYm GQfgeN1YYkxQNYumqUrFbSvr71+tlSwJQ5JbZrJJ5tBJjrdjRNaKNqwg/xwxhSu5V4gxFhous b0AN27y/hMdg7Vegumb4ZlxZEqBhJhYp/kNODjWSA93lCz8wOhDVN7a3MME6XBV87yaITtUrD b7gd9I8b2Gq5nJT8VosBpQQ84pIUstG7+PGHkwVlw6IHVhBfemZFOryVHlNSjoUCjephjoVwP yj2pzRXdzMSG8cN8eKvlOpmRLSrDZzq/VpOSMnHZ+XAdJPkjBgwh4hYkW+wLAFaxUC5sYEM38 rHN4trTg2dNhxQ9PH1sPgY6qQmrKiZfUDph2+fR4nbRfHMtxYSxXcW+LR6AaEQN+oq1MRoELY Z/KwTHx0AQYJqJO6zzoVeKBtoGM3DZd/EZNANso5ddXfLxbaSC/j5eClu0vvXXh2RUgPPCWNI KZFltKVncvT0bcFcDcCZJUumr4aLcDm/90kk4JA1hqimTBoM79itU2kruRXrIN+yOcMY0bNvC UAK6iDkGvF9gu15Ll9aPHBgb7g9Osrbf+5aXQJY7rK3xgLueKajJkycoM73IIirR6T9A8XGfI kQrwrANh+jXVbgMsdM9qN3l3BSDc5bK9s46fgEpzohSRlcr4rJhbl7ohrCUNXZajS7mErKoTT rOKWRTV+0W6KNlD/ZTytt5tLq8UW2grRXplM24/ODGbv+sJ/7U/CHbJI9J9v8bfQZX5vpOmNE xV3HmoarU+n0NyCn0iDfxkEY1dcLdUU0iz0y1X9QKLa1lDIp/Y+LDL8vI4gIkXGg64euXGLd9 duyBZHwGu/gPhVZq50l4vBrUVEMH1c5GqK7 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Commit 4f0278dac56a ("net: sun8i-emac: Lower MDIO frequency") leads to network failure on the OrangePi PC. => dhcp sun8i_emac_eth_start: Timeout According to the commit message the change of the MDIO frequency is only required for external PHYs. Fixes: 4f0278dac56a ("net: sun8i-emac: Lower MDIO frequency") Signed-off-by: Heinrich Schuchardt Reviewed-by: Ramon Fried --- drivers/net/sun8i_emac.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.31.0 diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c index 5a1b38bf80..d7553fe163 100644 --- a/drivers/net/sun8i_emac.c +++ b/drivers/net/sun8i_emac.c @@ -211,7 +211,9 @@ static int sun8i_mdio_read(struct mii_dev *bus, int addr, int devad, int reg) * The EMAC clock is either 200 or 300 MHz, so we need a divider * of 128 to get the MDIO frequency below the required 2.5 MHz. */ - mii_cmd |= MDIO_CMD_MII_CLK_CSR_DIV_128 << MDIO_CMD_MII_CLK_CSR_SHIFT; + if (!priv->use_internal_phy) + mii_cmd |= MDIO_CMD_MII_CLK_CSR_DIV_128 << + MDIO_CMD_MII_CLK_CSR_SHIFT; mii_cmd |= MDIO_CMD_MII_BUSY; @@ -242,7 +244,9 @@ static int sun8i_mdio_write(struct mii_dev *bus, int addr, int devad, int reg, * The EMAC clock is either 200 or 300 MHz, so we need a divider * of 128 to get the MDIO frequency below the required 2.5 MHz. */ - mii_cmd |= MDIO_CMD_MII_CLK_CSR_DIV_128 << MDIO_CMD_MII_CLK_CSR_SHIFT; + if (!priv->use_internal_phy) + mii_cmd |= MDIO_CMD_MII_CLK_CSR_DIV_128 << + MDIO_CMD_MII_CLK_CSR_SHIFT; mii_cmd |= MDIO_CMD_MII_WRITE; mii_cmd |= MDIO_CMD_MII_BUSY;