From patchwork Sat May 29 06:02:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 1485336 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=X3GWSeqv; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FsWF96DfYz9sSn for ; Sat, 29 May 2021 16:03:08 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 72595385701E; Sat, 29 May 2021 06:03:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72595385701E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1622268185; bh=LXuDdZAlEAORV8s4J5mMR/F6gp7ZNpCxwsidZUNdkf8=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=X3GWSeqvMBD9k9nrGriFGGrMv9URNVBnSZfFZHKX2lu8J60kr7LPEWcuW6WL/nNDN /sYc/jRpeC6PY3KWP6sxA/wksUj3tDyfUFgpgd7/lerKyOtwKqPMm75aj4TDtj9Q78 t7EZygtAj8YAbdcWtt9idPTJIFOWpc16hy/LizFY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by sourceware.org (Postfix) with ESMTPS id A077E385782A for ; Sat, 29 May 2021 06:02:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A077E385782A Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14T61pM1033308 for ; Sat, 29 May 2021 06:02:58 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 38ue8p81sx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 29 May 2021 06:02:57 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14T60FvC159206 for ; Sat, 29 May 2021 06:02:57 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2103.outbound.protection.outlook.com [104.47.70.103]) by aserp3030.oracle.com with ESMTP id 38ubnb47et-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 29 May 2021 06:02:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E8xnJqduRjwU4wgDrT3/P4FjakP0hx7C5vE/c3Ahb7VqOtuOJlFc43hJMH1ca+bUQGRy97C7eo8zhFjW/Aye7cDgLVOIywQYvVVo6VUmv7QFGaksJmckidXrGCsWzZSD9TgJGo6DTCJK6IIdy5zMGkIQYte01UI0+v4PnYhhNjDjKm4MsVTi0wt5BDS9rJqpWb806tXcCXdLKikQ3/B6gJ+mPK3WFMbw9n0Jo7QjqMgjXSIy7oEsCZ4pR5cAGC6GnDPuRXSYkd17FTORxTWdKmB/4g67bWp+4cgVbkkUhX4zzSyr9nwsgEUogrFGh4Ko1C7SBZqDmNxGuzUrgZkKbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LXuDdZAlEAORV8s4J5mMR/F6gp7ZNpCxwsidZUNdkf8=; b=O5yL4MzFuGN3XWSAJxiC2zOEQNLqCg2s7VVSUjYP2UGLHKKL+Lk5T3rPh5CKskKMYlSD7SmZesAD2+kMUrWp9ZCkSNHqSKk8zl6TOOxjzcyOmeVK3LFcKMfMCpaGsY8k+1JCTFl62PkQUWojYAX48Vrm4YywVTkmcjTT3z+Scyh5hnJz4C+yW1qIfXnpB/wJ8sJLXEmxMyfeDHOZbWc+aBtY8MP0kGEOc4CUMLQdOkj9OQsl8ul+utDhVB5BsgB0JlUlsf2bOHrOV+zKc/yJmnTiWrkjee+ppR8JuDEnzxTn+PntRCKCAvsFpmFExkMhbxgUudwCXDzpoLn78tvm1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CO1PR10MB4706.namprd10.prod.outlook.com (2603:10b6:303:9d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.24; Sat, 29 May 2021 06:02:55 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::1076:c9ce:4957:e3f3]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::1076:c9ce:4957:e3f3%5]) with mapi id 15.20.4173.024; Sat, 29 May 2021 06:02:55 +0000 To: gcc-patches@gcc.gnu.org Subject: [PATCH] PR testsuite/100749 - gcc.dg/pch/valid-1.c fails after r12-949 Date: Fri, 28 May 2021 23:02:44 -0700 Message-Id: <1622268164-24041-1-git-send-email-indu.bhagat@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-Originating-IP: [24.80.24.133] X-ClientProxiedBy: MW4PR04CA0390.namprd04.prod.outlook.com (2603:10b6:303:81::35) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ibhagatpc.hitronhub.home (24.80.24.133) by MW4PR04CA0390.namprd04.prod.outlook.com (2603:10b6:303:81::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Sat, 29 May 2021 06:02:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ccc59243-c537-42a7-da27-08d9226766a4 X-MS-TrafficTypeDiagnostic: CO1PR10MB4706: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: psq0vngiZpyU/ZdfKxTtXQ+2+fr7wdWv7mK2yY+nTMxOXJjEqYoy3fpznOSKPLCpinkBQ1vMsInbdufymqa2pkaPEAMf8T9qIuUwiE1z1Ywnc/Y+jNCDcSQvk0q/aMvHdjf3DZyai/YA+OB7fhVObcW2E9PQbsWFkZNopd8o8rwpLaajVT7FTzkUJyoiMuXsSgpkIDa0ApPgsnJzlrF1KPGq7Fk3zd12H88QMtfyDd2oMSr/FBpH6/IZ3Y1LyQVEXaDYsC8NNqdwm7eD0XUvVyCNdlD00FqlzpV7/Cca4e1EtqIfcG5gn8qJgRbLLK42RBhXk+P8mMer7mKM0bkJBH9QBWf5YVxIQinzPFEUnAKS/5i+W8iKOWF96h6poxBWP673ARbI8xZfj8t75IOHjU9Pw2pTv7bVG4CK3GFDKS5h/HemaE49aEYKs9u7swABbzy57nazovSgfAxMMv0dAlfSkQjdAWPznmAKE5i5aeEsiTaxRBMOlr4Vy2yfC8nzn0zXbDKXBlm07wDjOwO/rh8kFmHjH9rOMBTHkhsfaPVjUsZS02HPThIMx5TfwVkHeUqt8nEPLIx6W1AQDO5Jx3d6GN37m8sp5hL4We8sW2arattc/q9GodbNEP8W2rh3hbkCzObCwHWA+7HZ2TMKEg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(39860400002)(136003)(366004)(376002)(478600001)(956004)(83380400001)(26005)(316002)(2616005)(16526019)(86362001)(8676002)(6666004)(8936002)(36756003)(2906002)(186003)(52116002)(38100700002)(6506007)(38350700002)(6486002)(44832011)(5660300002)(6512007)(6916009)(66556008)(66476007)(66946007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: jZNPXqROsZBs+UlprNevDBQ4cOZgLn5QE7TmKwcnuwKnc7DWoTGUhUJf2xf5/Un6fWMk0fZLHf9c7EXcA8K04+lrtGUIJF7sbgZ1mPPOS3SvBBuwRWD23l8NMG/MOJvsGepOMjrwDEtufV7l3vp6kbZeMPVUjppbmpKO+nAlE7Rz77t99HxWhHKddvHCuTdofXR1B7krJBs1nIWKzUmx/Mq/9aa9uHYutDPMHJjvgNCu9Cy5y6jKFQAR7u+oeAJt8C4TCxLdSfSgkFczf81/ErwoOFxPAzBkVvxqobiLEQlMgZ0nM4V7/Sejlppq8IKycKzx/qjsGn070j5icIZ+lQYNlFyydEocPTtAmEyjZmp9XL3/X9Lb93I6qhrKXPAumQfZO5OGgkCRGEVIdLYlnPSOOfa4x26Eezhl/sxawdFB7IilnvrmM0WlnSB47ZN+UEYBQoS2bWW0+4AxwyvKFuzrXL8wGNbfDs2mp3m3kVGp6qoHgABE/r/Pgv10jX4V8bqbneARunKTYESwhtXND5NXTjt3HXpoeteAVtl60VUQf0kdIxfRgt9DdPPSjGAzaJcHvL2PA5K7f9uZxy5Xf9G1ujFAznJlUAj5Y8Bj6BGBdAExhpLkZ+P1yo7A220gSFtIaHk04ZjabXASZXkPHnNIp/7CGQQjv0SzGS2ajls73J9Uz2L6fJanipr7VV+4TmHgcWJPg6dotuwXE9VIB2Az99p6bLuEia8p8pdHm1nEPIXZu7GWLhnJE8T9ytKKpqJrVw+bhYK51gBYe/H6OWRlE/GZXoxGUhbDLkh/laDe3OQZRnKm8W3XCj0IKGopwvW3vj3AdBRSq0d5+z0IDDCT/Euz746uabe11YSD1iO6iGTFY0VwmRDOMbnVbO5a03sbaCC8sdpJFRCA9VKvc47SGgf95oVVhp40dZQi2qK7iy3BaufxU5f8jQ3GL+G+dYaUXOhQyHNforKA7+V727BYeNwn1xRRwXCFwRFlsa0BNmGHorxqe0VlSv2IFIRH40l/5pe24Hes1ijjTaE1gh3Ysxeth3Z1eOi2W5ThJdPFioebWrsB4cDWXDqr0ytKhPBi0Xe8TpZokVlY3Jc+mOa6dul8TyGyuQF45Gmh5ysZ3QC0q0/2zCxPouNQYek6kUfOrvUpP1F9yjeV3TvjYP+qOPWcvAeQUTlZf5Lt9O2DW11wNmdK1YJ6hGCSlVMWO9tVNRQFrK+ctIWC+cjbWOcnDNi4PgDBJ9m37yQyUQeOv0erCJfAvufLDfgZ15Csyzs+21b/cLthtGEjelIFmu12bSrhlKxcjlSIrOky/IvMZ3MKHB2fkWGOmhY/6ZLl X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccc59243-c537-42a7-da27-08d9226766a4 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2021 06:02:55.1200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OwoRTE/pU+DjAGG97Zi2cwp21kSeQwOYRuvA6ljMcynayYglWNkcaxZOMfNxn4XeyijAc++jYYQPiYxPgZY8Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4706 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9998 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105290046 X-Proofpoint-GUID: eDhvK8f4OUfS3qq6xr5AazZ0AF3HxIWP X-Proofpoint-ORIG-GUID: eDhvK8f4OUfS3qq6xr5AazZ0AF3HxIWP X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9998 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 impostorscore=0 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105290045 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, MSGID_FROM_MTA_HEADER, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Gcc-patches From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi, This patch fixes the failing pch testcases as observed in PR testsuite/100749. Although the PR mentions powerpc64, the issue exists on other arches but appears to be latent. The issue causing the failure was that the underlying char[] df_set_names is a static var. Multiple calls to 'debug_set_names' with different write_symbols like the in c-family/c-pch.c must entail the use of xstrdup or such to retain a reliable copy of the debug format str containing the names. Bootstrapped, regression tested on x86_64, powepc64 (make check-gcc). Thanks, Indu ---- PR testsuite/100749 - gcc.dg/pch/valid-1.c fails after r12-949 Fix failing pch testcases. Use xstrdup to retain a reliable copy of the debug format str containing the names (df_set_names is a static string var). 2021-05-28 Indu Bhagat gcc/c-family/ChangeLog: * c-pch.c (c_common_valid_pch): Use xstrdup for debug format set names. --- gcc/c-family/c-pch.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/c-family/c-pch.c b/gcc/c-family/c-pch.c index 8f0f760..5da6042 100644 --- a/gcc/c-family/c-pch.c +++ b/gcc/c-family/c-pch.c @@ -255,10 +255,13 @@ c_common_valid_pch (cpp_reader *pfile, const char *name, int fd) if (v.pch_write_symbols != write_symbols && write_symbols != NO_DEBUG) { + char *created_str = xstrdup (debug_set_names (v.pch_write_symbols)); + char *used_str = xstrdup (debug_set_names (write_symbols)); cpp_warning (pfile, CPP_W_INVALID_PCH, "%s: created with '%s' debug info, but used with '%s'", name, - debug_set_names (v.pch_write_symbols), - debug_set_names (write_symbols)); + created_str, used_str); + free (created_str); + free (used_str); return 2; }