From patchwork Fri May 28 09:04:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485063 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Oj0wzej1; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKh40GFz9sRN for ; Fri, 28 May 2021 19:05:12 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236314AbhE1JGo (ORCPT ); Fri, 28 May 2021 05:06:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235179AbhE1JGm (ORCPT ); Fri, 28 May 2021 05:06:42 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42179C061760 for ; Fri, 28 May 2021 02:05:07 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id x8so2509813wrq.9 for ; Fri, 28 May 2021 02:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JAwi1fvjZmfmHFU/F6uA+Qzc/x3DLxFoaVN4fZrMnzo=; b=Oj0wzej15Xoct5UZ2mjnHXTrGKuTad6tmzynF96sXczOpjSFEMctdQYP6Re9pQfDoG pGUXM+s5rEQNIEv4+iikWel7kkPS60OrTcBdFfce9NtVB2Wk+2DGlvMYIp9ZOYnoFIRf SDxjOdP3Q0WgwhbbeVj+i/bw9QhG5YiJwWDikUelfaSRcCAVra8qO+Q99eI4fOV9uXoo 60AC1elrDytFsZ2Y9cuGqldp7BfJ6BP89w/mU2XzqwrNgzrZXxaftnrGbxBd1gWTGQhP ghs+Qei4HJMl0JaaehcCZjGPITn4ZM5SWN2Dehc+dAIVKmKcPRvDgHWZzx6ZTAW9Xwnk 4vXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JAwi1fvjZmfmHFU/F6uA+Qzc/x3DLxFoaVN4fZrMnzo=; b=XOQsCAhuKukqaYdA82/f11pfhpEdGBLJyI3+pDp1o8HxMLZLXxsnBBYfZK+66ns/kw ZchD/J4ot1yb/1owrJjc6/bMCSUuQ2kDGJ3Pq6y6iyIIcr4CXJQcoXc5vEd06rWZXyTY WQzyLNnISIUwUcmgs2ZpwjhbLhe7YdTe2kZPcBONJJDQKbVcr3dNOJTWBXXfClxNSqeY NYfVRe0OtiDQkGPh5PolAuZgVbPgF4hySX3DzpMPagtAuoDmQU1a9ZzfT6pprMJ0Vptx crFL0APCjqIhWOYI+Dh5ZRfKchlcKoo/rOZchDrLUQ6m/3EzdTU5FiNRMMKvlkcT+oLp tdzw== X-Gm-Message-State: AOAM532i98ctDQ1/I+oWti/Ca1mPhjdgWz9PIu6J3ce199HsJzrytSf5 yAaktIHLvVnE42v9+jzOk3IKhg== X-Google-Smtp-Source: ABdhPJz8sOCHaHAk0qYyz9z+PXHXWTfZ+Im+qFLXOZieArTHZ76zLSgQz8Baq+DN3y11wEPFBpz4cw== X-Received: by 2002:a05:6000:114c:: with SMTP id d12mr7421963wrx.265.1622192705833; Fri, 28 May 2021 02:05:05 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:05 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Mark Lord , Philipp Zabel , Tejun Heo , linux-ide@vger.kernel.org Subject: [PATCH 01/11] ata: include: libata: Move fields commonly over-written to separate MACRO Date: Fri, 28 May 2021 10:04:52 +0100 Message-Id: <20210528090502.1799866-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org This is a pre-cursor to some upcoming W=1 fix-ups. Fixes the following W=1 kernel build warning(s): Cc: Jens Axboe Cc: Mark Lord Cc: Philipp Zabel Cc: Tejun Heo Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- include/linux/libata.h | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/include/linux/libata.h b/include/linux/libata.h index 5f550eb27f811..3fcd24236793e 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -1397,25 +1397,28 @@ extern struct device_attribute *ata_common_sdev_attrs[]; ATA_SCSI_COMPAT_IOCTL \ .queuecommand = ata_scsi_queuecmd, \ .dma_need_drain = ata_scsi_dma_need_drain, \ - .can_queue = ATA_DEF_QUEUE, \ - .tag_alloc_policy = BLK_TAG_ALLOC_RR, \ .this_id = ATA_SHT_THIS_ID, \ .emulated = ATA_SHT_EMULATED, \ .proc_name = drv_name, \ - .slave_configure = ata_scsi_slave_config, \ .slave_destroy = ata_scsi_slave_destroy, \ .bios_param = ata_std_bios_param, \ .unlock_native_capacity = ata_scsi_unlock_native_capacity -#define ATA_BASE_SHT(drv_name) \ +#define ATA_SUBBASE_SHT(drv_name) \ __ATA_BASE_SHT(drv_name), \ + .can_queue = ATA_DEF_QUEUE, \ + .tag_alloc_policy = BLK_TAG_ALLOC_RR, \ + .slave_configure = ata_scsi_slave_config + +#define ATA_BASE_SHT(drv_name) \ + ATA_SUBBASE_SHT(drv_name), \ .sdev_attrs = ata_common_sdev_attrs #ifdef CONFIG_SATA_HOST extern struct device_attribute *ata_ncq_sdev_attrs[]; #define ATA_NCQ_SHT(drv_name) \ - __ATA_BASE_SHT(drv_name), \ + ATA_SUBBASE_SHT(drv_name), \ .sdev_attrs = ata_ncq_sdev_attrs, \ .change_queue_depth = ata_scsi_change_queue_depth #endif From patchwork Fri May 28 09:04:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485065 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=kJXsfDn0; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKk14Hdz9sRN for ; Fri, 28 May 2021 19:05:14 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236344AbhE1JGp (ORCPT ); Fri, 28 May 2021 05:06:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236272AbhE1JGo (ORCPT ); Fri, 28 May 2021 05:06:44 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45ED8C061763 for ; Fri, 28 May 2021 02:05:08 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id q5so2536960wrs.4 for ; Fri, 28 May 2021 02:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cWSksrnLWe4rDC76GwKSgT0nD4m0QGDvpuLUlTafu1Q=; b=kJXsfDn0XaU4cBTj1nb9UvuC8NlYm5WwSe0bvsqxaGAPcWn8DZNl+nxf201jW2NY/j de/HX/HtwUIlDjJwJ1VMJ/G1YciU8SmD2mvCR3xvAmUTYTRcA0fScrb9YwBt0uClAK7U bGnOgHgExwMDlOwD9TmJawkid80aeoc4BJMQ1XYUrvqcy4AGGW32xFUr/KYsoFr8xt96 O/HXuDzhogExJdWWnZcOPpf/vfWByiBbmwp4Mv0D6LoNm2v1Inq8+OpQ39DWPCK+glKI POUq+yAs5ZEH4JRt7lkBPv49cVI+VMg0/Lhbn0zUyJAIwUqS9vWvfu9iCzpvA7IYda+s WR2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cWSksrnLWe4rDC76GwKSgT0nD4m0QGDvpuLUlTafu1Q=; b=RKr8XlB7mddTwBM0orITqb4GBhl+zuCzmnIbzJIjeks7Ndff/cMND6YC/Q4fkTgQsb gVXuwHXZ5ViD6i91sxBpv/8r3nILgbP5Skyn7icmjWNiMa1XUGCREbuC1l29BZqRM09u vidXA9SdPy+z3ITNSAId5pEDiyEFxntAeOyNskG49uqTEZ16MjSxc+2tPUkqeSULTjMY Q5qlzexqtB//ciz5e4CSpeeMVyvoPcAUnam9G+lfFXp+vg7+IIzcbwnym6HC6HbLmDTo XKnKUBOdmi5a7s3dFS60MlMV57arrggptsnutR+T5Bg1S3HaN5s83sCKNTQcCrgC0xsH /yPg== X-Gm-Message-State: AOAM533PF1zqcMXlYsREsAN1QbAVDobdNl+c67tA9oGolP8+jHh2no1r V7Ty9mLj+nKWczdatWhfY2Vouw== X-Google-Smtp-Source: ABdhPJx0FrZCOBPidHiKTi8G58//zi9pKaWjPvkgzW/FrwQMwNICVMXLsnGsFZiRwlRTSCA9b+xAjg== X-Received: by 2002:a5d:514b:: with SMTP id u11mr7541900wrt.350.1622192706896; Fri, 28 May 2021 02:05:06 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:06 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Philipp Zabel , Tejun Heo , ALWAYS copy Subject: [PATCH 02/11] ata: ahci: Ensure initialised fields are not overwritten in AHCI_SHT() Date: Fri, 28 May 2021 10:04:53 +0100 Message-Id: <20210528090502.1799866-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/ahci_platform.c:21: drivers/ata/ahci.h:388:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:388:16: note: (near initialization for ‘ahci_platform_sht.can_queue’) drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:392:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:392:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’) drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’ In file included from drivers/ata/ahci_mtk.c:18: drivers/ata/ahci.h:388:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:388:16: note: (near initialization for ‘ahci_platform_sht.can_queue’) drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:392:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:392:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’) drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’ In file included from drivers/ata/ahci_dm816.c:16: drivers/ata/ahci.h:388:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:388:16: note: (near initialization for ‘ahci_dm816_platform_sht.can_queue’) drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:392:17: warning: initialized field overwritten [-Woverride-init] drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’ drivers/ata/ahci.h:392:17: note: (near initialization for ‘ahci_dm816_platform_sht.sdev_attrs’) drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’ NB: Snipped 150 lines of this for brevity! Cc: Jens Axboe Cc: Philipp Zabel Cc: Tejun Heo Cc: ALWAYS copy Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/ahci.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h index d1f284f0c83d9..2e89499bd9c3d 100644 --- a/drivers/ata/ahci.h +++ b/drivers/ata/ahci.h @@ -384,12 +384,15 @@ extern struct device_attribute *ahci_sdev_attrs[]; * for ATA_BASE_SHT */ #define AHCI_SHT(drv_name) \ - ATA_NCQ_SHT(drv_name), \ + __ATA_BASE_SHT(drv_name), \ .can_queue = AHCI_MAX_CMDS, \ .sg_tablesize = AHCI_MAX_SG, \ .dma_boundary = AHCI_DMA_BOUNDARY, \ .shost_attrs = ahci_shost_attrs, \ - .sdev_attrs = ahci_sdev_attrs + .sdev_attrs = ahci_sdev_attrs, \ + .change_queue_depth = ata_scsi_change_queue_depth, \ + .tag_alloc_policy = BLK_TAG_ALLOC_RR, \ + .slave_configure = ata_scsi_slave_config extern struct ata_port_operations ahci_ops; extern struct ata_port_operations ahci_platform_ops; From patchwork Fri May 28 09:04:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485066 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Du15IUen; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKk5F3Mz9sVb for ; Fri, 28 May 2021 19:05:14 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236345AbhE1JGs (ORCPT ); Fri, 28 May 2021 05:06:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236294AbhE1JGp (ORCPT ); Fri, 28 May 2021 05:06:45 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B49DC06138A for ; Fri, 28 May 2021 02:05:09 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id g17so2478698wrs.13 for ; Fri, 28 May 2021 02:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=baxUJEs65n3xyZIblZq95NtbRVPvoaWnTBTr98e1a+Q=; b=Du15IUenyMTbo9/N8v6OxPcGKX6b5dxlbC12JobH5Gu8kyU0q3L+gg+YrhDXuP60Xx 8bxHY6ePO6u7651R0c4Sj8CWMrI9w+nHj09eNcfxsG7AKIqr+TeAgfQc5YIrYyofe3op 4TOZ52jJPeshmzZ9UMiOBBU6BP8q4WedrMmpeum5Y+LntkfepNyiOyEN4w4dU+5F9iWI s2MpqNLkr+mmnmF3V86K+g0/pzfOLeDPsFy8rhmvwdCeJMrfLrCD5w+8d8HoeBHfLAwM 2MGwxpLagGSVy2kOx2glWfmJRGnlLSjRnriN6UaIYMvzHS1bAB17SJBlfPmyqPjZo4tu rDyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=baxUJEs65n3xyZIblZq95NtbRVPvoaWnTBTr98e1a+Q=; b=NygOt8LdnzSqSQ5mAaY/Q+j7Ead84mEd4odddjSAwxhGjZNrHlj016xholSsVc7fVX P6vtdgIuuU3oTbu4m4JbJ0d7NjjTKwualNfFHFiImoqJ+tgCsA9/91UOhfX3jEFYTY/N wKDz0MhBWrNQug4y8J5fGrCsC8T5AGUWSwDUJX2pNdj+zAsTWHDgH9d9pRmk2+gZponp vCVRc8wtpd/5+KL48YOaYe61MLrQ7621VuUDPkHuuDmILt77u/PBYwfU1pJx2NWuGgV+ OZASMBeVNgo+J2g7tL10sKPCB6yfaiseAjfE7RhIBy3t9+65g+O1uA/Jqq2ovQ8YxW5B tLGA== X-Gm-Message-State: AOAM530qh7gZCyS1NQRrU6RKArLeT45nYUAE+L/UiL72/YU3eyUC4/JU smaZf/puWMhFPGv6r7NqoaEhRouVGpCi2Q== X-Google-Smtp-Source: ABdhPJxydn3DGIetK8bKWaP5UYjhHLw5AYEwpil4WtbAULkPgKmCLhJV4vp+vSv7/v9heKVobgDu+g== X-Received: by 2002:adf:a108:: with SMTP id o8mr6255604wro.290.1622192707653; Fri, 28 May 2021 02:05:07 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:07 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 03/11] ata: sata_sil24: Do not over-write initialise fields in 'sil24_sht' Date: Fri, 28 May 2021 10:04:54 +0100 Message-Id: <20210528090502.1799866-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/ata/sata_sil24.c:14: drivers/ata/sata_sil24.c:378:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/sata_sil24.c:378:16: note: (near initialization for ‘sil24_sht.can_queue’) Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/sata_sil24.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c index 560070d4f1d09..06a1e27c4f84a 100644 --- a/drivers/ata/sata_sil24.c +++ b/drivers/ata/sata_sil24.c @@ -374,11 +374,14 @@ static struct pci_driver sil24_pci_driver = { }; static struct scsi_host_template sil24_sht = { - ATA_NCQ_SHT(DRV_NAME), + __ATA_BASE_SHT(DRV_NAME), .can_queue = SIL24_MAX_CMDS, .sg_tablesize = SIL24_MAX_SGE, .dma_boundary = ATA_DMA_BOUNDARY, .tag_alloc_policy = BLK_TAG_ALLOC_FIFO, + .sdev_attrs = ata_ncq_sdev_attrs, + .change_queue_depth = ata_scsi_change_queue_depth, + .slave_configure = ata_scsi_slave_config }; static struct ata_port_operations sil24_ops = { From patchwork Fri May 28 09:04:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485067 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=wD3jASsK; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKn6Q1bz9sVb for ; Fri, 28 May 2021 19:05:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236392AbhE1JGt (ORCPT ); Fri, 28 May 2021 05:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236347AbhE1JGr (ORCPT ); Fri, 28 May 2021 05:06:47 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BB88C061574 for ; Fri, 28 May 2021 02:05:10 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id m18so1726280wmq.0 for ; Fri, 28 May 2021 02:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZHd78hRSkMzuohg5J3tzRz48OXEcvuzZqwhJwyMkBCw=; b=wD3jASsKf47ADb/cQ6s+gUIahaxifDyockRP1XMmKAeQ3V9G/Zv0IUyryXAVWpO1fy WZ33oMxOFXrMsq/KA5yLUcwHffr1RCh+s4ihw1HTM3D5yKsy0ztllL4DFoXrnaUefWh7 1gkqr331hL0ZEzQW3vV5LAh5xEjJSvmVdig60CGOxevPIH/2zyZOUk4RI36Q3OTnDslP TI9Jd5ZEc9ULvxxJd06SiLGl8bptmpvTJVXgmlV4ra529TBljZjfVrEaPoEQCXa4uNKb WX1itQvfrQtfN7+X5fkJyrImAFIoSnVKY9+n2PkIoYH6BLKIP1W0UeVb121kwwKYd1Nm 8pWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZHd78hRSkMzuohg5J3tzRz48OXEcvuzZqwhJwyMkBCw=; b=jDRCsFppGENVJFmsxbmqPDfrnAcgUWBWjjNLfAZo0BzLlxu1k+kBxk6ojE+vtcokTk XWjoDsfkIUpRCS8QyOxcrs1/19NrOULtGZcfJ88UwEra/mh32PMgo/yOUaxgWPoGZDkV u3UQFgiP91WhA6AJtmFyq7Jj/jwGL5Y0rOOSf5acFRjJ1K1ggg2L4IF05Jkcz4IFTTwZ MUgyyXQanPlX9u/DHMGZvtcBeOyDfHrLYEiWVvJDQ0KTxOByQI7BI0zB1k6C/MrUEeGx 0eDtEoUpQK7UI3VTd0XqlQ0SwiGGXmuNcOOwnAHaY8RK7eN94W4M4dIdE388u1Bcgr+v lr2Q== X-Gm-Message-State: AOAM5337FIh6EofSIY9vYxoxeZwWqoKWLixR5dL2ekDICVV9UYe3XYws p1AyF+4NTQVbUjdAeW0O9FlhUQ== X-Google-Smtp-Source: ABdhPJz7oPUrqLGppxgr5fJU3aFUM3mla0OIMhHa6HERtpy9ScnCBl0ZZyTaytq7qkALkKkjadk8pw== X-Received: by 2002:a05:600c:4f95:: with SMTP id n21mr12358979wmq.74.1622192708815; Fri, 28 May 2021 02:05:08 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:08 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Mark Lord , ALWAYS copy Subject: [PATCH 04/11] ata: sata_mv: Do not over-write initialise fields in 'mv6_sht' Date: Fri, 28 May 2021 10:04:55 +0100 Message-Id: <20210528090502.1799866-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/sata_mv.c:670:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/sata_mv.c:670:16: note: (near initialization for ‘mv6_sht.can_queue’) Cc: Jens Axboe Cc: Mark Lord Cc: ALWAYS copy Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/sata_mv.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index c8867c12c0b86..9d86203e1e7a1 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -666,10 +666,14 @@ static struct scsi_host_template mv5_sht = { }; #endif static struct scsi_host_template mv6_sht = { - ATA_NCQ_SHT(DRV_NAME), + __ATA_BASE_SHT(DRV_NAME), .can_queue = MV_MAX_Q_DEPTH - 1, .sg_tablesize = MV_MAX_SG_CT / 2, .dma_boundary = MV_DMA_BOUNDARY, + .sdev_attrs = ata_ncq_sdev_attrs, + .change_queue_depth = ata_scsi_change_queue_depth, + .tag_alloc_policy = BLK_TAG_ALLOC_RR, + .slave_configure = ata_scsi_slave_config }; static struct ata_port_operations mv5_ops = { From patchwork Fri May 28 09:04:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485068 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=SIcUru8N; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKq337Kz9sVb for ; Fri, 28 May 2021 19:05:19 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236396AbhE1JGu (ORCPT ); Fri, 28 May 2021 05:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236356AbhE1JGr (ORCPT ); Fri, 28 May 2021 05:06:47 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76BF5C06174A for ; Fri, 28 May 2021 02:05:11 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 16so1683607wmj.5 for ; Fri, 28 May 2021 02:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZsHhVHMMYIUUYCsqaGFFBiP85xJeW/vO/rf3whWDDj8=; b=SIcUru8N6ThJ47KmOebae2ZxgyMlirYEl5oYCYXI3f39QL5dEKUq6iGP213gEajmqt vFLw3dvcc0L0Wn/AvCNHCv1uqyZ+RcMndY9vwSI+Bu7Ugrd1PGVPWS9OdzlWjimQDSkM Tz6KWxf/teNDipZndHHzAarn4J+lhG1/K4CzzmvwvC6prVwx++46fca92QMTnlg682QG 6I/lJFQ73Nsm5pLH5oTV2UuD9FOdmdkV+IvVDHv5ukCcEEFAgwJwWObg8+gZlWUufJQR phQZS/ZqEqrlwxvRQKKS9qo4EbcsD0f24h9vsywpBbzsJGIyYFCTZNJyheChmViUuUHc a77Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZsHhVHMMYIUUYCsqaGFFBiP85xJeW/vO/rf3whWDDj8=; b=HhPy68rmicAurPE5l4inm+pzxBqRI4w5sFfr+xQGbEoNBeDSos9ZKtcz9P1siJqa77 mmlzVc+IIgxMwHU89kh4dHvXd1+AVCeM5Yqo5utcBJwbNqDPzPRgFbGiO8tCpkat3AS0 fZunuxwXK1UghjVt8OzGvtYRrZQY+isOwCzclMb45jbJl3x4QY2BhnMJTA18Ok70jI7M DH19XG+ER05kGdlrdYIgv8zTvqc5ciNnwHSr0IkUJ+AgcKyy5yN6A8pSXmhGVAkvwj1d WFAeZ8t71C+Pwxa1o0J0oklK0IK6MBGhQpmVHhfiU9mbpGho5wXtAwJB9aD2fGx2xYNQ hZhg== X-Gm-Message-State: AOAM531rbIrTPxVu8YxfgLD8OzuXw2gs3EkQ9ssE7FN870PUAaUvYhIY hCJeDeY4TvNf1NSPF/R8h3v8LA== X-Google-Smtp-Source: ABdhPJz/Wq66VAjAnT4wZ1Q2aaa/482ptBEHUsF/scU2EIAP/gUhIYAPl6l6JWEn8ew55cOgcTm3Uw== X-Received: by 2002:a1c:4601:: with SMTP id t1mr7514479wma.27.1622192710115; Fri, 28 May 2021 02:05:10 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:09 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 05/11] ata: sata_nv: Do not over-write initialise fields in 'nv_adma_sht' and 'nv_swncq_sht' Date: Fri, 28 May 2021 10:04:56 +0100 Message-Id: <20210528090502.1799866-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/sata_nv.c:379:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/sata_nv.c:379:16: note: (near initialization for ‘nv_adma_sht.can_queue’) drivers/ata/sata_nv.c:382:21: warning: initialized field overwritten [-Woverride-init] drivers/ata/sata_nv.c:382:21: note: (near initialization for ‘nv_adma_sht.slave_configure’) drivers/ata/sata_nv.c:387:16: warning: initialized field overwritten [-Woverride-init] drivers/ata/sata_nv.c:387:16: note: (near initialization for ‘nv_swncq_sht.can_queue’) drivers/ata/sata_nv.c:390:21: warning: initialized field overwritten [-Woverride-init] drivers/ata/sata_nv.c:390:21: note: (near initialization for ‘nv_swncq_sht.slave_configure’) Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/sata_nv.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c index de45045566692..c385d18ce87b7 100644 --- a/drivers/ata/sata_nv.c +++ b/drivers/ata/sata_nv.c @@ -375,19 +375,25 @@ static struct scsi_host_template nv_sht = { }; static struct scsi_host_template nv_adma_sht = { - ATA_NCQ_SHT(DRV_NAME), + __ATA_BASE_SHT(DRV_NAME), .can_queue = NV_ADMA_MAX_CPBS, .sg_tablesize = NV_ADMA_SGTBL_TOTAL_LEN, .dma_boundary = NV_ADMA_DMA_BOUNDARY, .slave_configure = nv_adma_slave_config, + .sdev_attrs = ata_ncq_sdev_attrs, + .change_queue_depth = ata_scsi_change_queue_depth, + .tag_alloc_policy = BLK_TAG_ALLOC_RR, }; static struct scsi_host_template nv_swncq_sht = { - ATA_NCQ_SHT(DRV_NAME), + __ATA_BASE_SHT(DRV_NAME), .can_queue = ATA_MAX_QUEUE - 1, .sg_tablesize = LIBATA_MAX_PRD, .dma_boundary = ATA_DMA_BOUNDARY, .slave_configure = nv_swncq_slave_config, + .sdev_attrs = ata_ncq_sdev_attrs, + .change_queue_depth = ata_scsi_change_queue_depth, + .tag_alloc_policy = BLK_TAG_ALLOC_RR, }; /* From patchwork Fri May 28 09:04:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485069 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=iHU4SmZt; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKt0dgdz9sVb for ; Fri, 28 May 2021 19:05:22 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236404AbhE1JGv (ORCPT ); Fri, 28 May 2021 05:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236381AbhE1JGs (ORCPT ); Fri, 28 May 2021 05:06:48 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43CD7C061763 for ; Fri, 28 May 2021 02:05:12 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id f17so268407wmf.2 for ; Fri, 28 May 2021 02:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q31aHu4d2EyGCNum2ZU2yD6ze38ZUxKCEqsQOMZ06Lw=; b=iHU4SmZtE0qceEDUVqwq0nooHVzMWLGqymHGWYwomhTQJQR+Wh9lEwitqZaNDTujXb YL+eLd3W0ZNq90heaVygzxuMYhQ6ksvqadoN75LjUvZWdHtaR+ZLlbhoz1aE/It5SYWE XnvSsgn+mqTByNkFXZEzNNiGo4wjaWGYrkCgI0XQlyX+yYQCexn6CvTXyt3w6HdSeFD1 cBtAAst4erMizizLtAPP2GJZyadGgzfVEQaluAjV4l1zffplaMFZPKJmsNC49ACOoi5y tpev3tSwpxVBb/ErkeotHdN3dsjj3fkCNWPzCRudvWsotXrg4Jgwg7VA+tPpvf3cuHQv zqvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q31aHu4d2EyGCNum2ZU2yD6ze38ZUxKCEqsQOMZ06Lw=; b=OOiK9+YKFsIPhtTFilkAKXqTl4A2B2B6VK8du3ElOjUuHLIbNweNACq5IYzIbPtROT eQWxv7fP07pkO+CLNf7FAq0Nau7nR0ZA1T/ChC9t7mabJQDwg8z5+vIo3LDxd+igJkuE 8X4B/HxPZKXzequv02JXyLilicHERV4aM7BsUq9LTPi3mGLlZlVXPcUtuLnUe3tjLeOq 8o6Rh568QWCLwdCRGVDWUZ5y4+1yMJ1D77GfHIB2Z1fX6pLxjbS0vkB9ava/09feIep2 wHxYBZXE7DxFdewu/2MwCemI2qDWSHMRAND8aRGQjHgR/VXBH2IdpW9xOT70RJXtRb1L 9iYg== X-Gm-Message-State: AOAM532fmLZ0Zy9r0KvVhNiAOLqklLhlT+OzbZ1IKZz1dscQlN8YGzeL 10/eq6qaIQuVqPxNhCSMdMKqEQ== X-Google-Smtp-Source: ABdhPJztjboOyPvoUhgaD1zdQe8HIPehEzyszSEHX6rN62P1I/Uqy+OvhLlZnpuYvbpKVFAHI4ZfoA== X-Received: by 2002:a7b:cd83:: with SMTP id y3mr7622742wmj.155.1622192710912; Fri, 28 May 2021 02:05:10 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:10 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , ATI Inc , linux-ide@vger.kernel.org Subject: [PATCH 06/11] ata: pata_atiixp: Avoid overwriting initialised field in 'atiixp_sht' Date: Fri, 28 May 2021 10:04:57 +0100 Message-Id: <20210528090502.1799866-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_atiixp.c:256:19: warning: initialized field overwritten [-Woverride-init] drivers/ata/pata_atiixp.c:256:19: note: (near initialization for ‘atiixp_sht.sg_tablesize’) Cc: Jens Axboe Cc: ATI Inc Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_atiixp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c index d671d33ef2874..c3a65ccd4b799 100644 --- a/drivers/ata/pata_atiixp.c +++ b/drivers/ata/pata_atiixp.c @@ -252,8 +252,9 @@ static void atiixp_bmdma_stop(struct ata_queued_cmd *qc) } static struct scsi_host_template atiixp_sht = { - ATA_BMDMA_SHT(DRV_NAME), + ATA_BASE_SHT(DRV_NAME), .sg_tablesize = LIBATA_DUMB_MAX_PRD, + .dma_boundary = ATA_DMA_BOUNDARY, }; static struct ata_port_operations atiixp_port_ops = { From patchwork Fri May 28 09:04:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485070 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=pCHP+eJ9; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKv1T2hz9sW7 for ; Fri, 28 May 2021 19:05:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236420AbhE1JGx (ORCPT ); Fri, 28 May 2021 05:06:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236384AbhE1JGs (ORCPT ); Fri, 28 May 2021 05:06:48 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EB1CC0613ED for ; Fri, 28 May 2021 02:05:13 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id r13so1204739wmq.1 for ; Fri, 28 May 2021 02:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cqNtuLDYrKvRNBVp3VSAfSB/yMTpSme5doamFgIXxy8=; b=pCHP+eJ93Zsu6Jmihy8fbe9klOotG1nugf7P6lL8GCE9XxOxZmDm+bE1SJVZUmmiH7 HE7hjzyIqIo6oROqHxoLcBFhjv5+qjweXEHcDPqa3sALw4F2BhqG1kVAVvAQhbkK3aHl BITJRLKIZnlxy1a59hQKgiXd30jonzTIVQQmWVFKoaoJuUm2kvxNfCE0yDFTjXieB2Kz t+SfOt6Dw74PdI8mAobwKz+qntsal97GxggeGF7S6Oc7dxb4Sms0OBvXFMXIqtzFH7ES 0MHB+JHnzj+iCFTO6287BoQqmcgVvVRr1PaTqykXw4HC4fHIrI+9Ux7xpimwh4PkbMlm 2uMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cqNtuLDYrKvRNBVp3VSAfSB/yMTpSme5doamFgIXxy8=; b=Kfd07pt0uqEIfc0IAjXQg63Go0vhTgOGV6HgQTzDHxyOpbjhIb4oPrdMaHaoEOgA1h DMdTNqNfjWtYhTjkKRwtOVMfyzD3TCAZJpsQ4fPkbCJ70qfwCTn7KAaTBmX0ypCIZ6Gk ax1gAsII1PjpL8d9KndUG1r24Be1SoGX7m1zKpMreTOW24oSYfRuBMATD6aw5vTVI7Kg ykk4Kpm2c+jSbnn/uQIQlp8JJ9qGWdAjaEEYzh/FcGH4V3QitZRSPgUHCZQIESUovKv5 kaRNVrSTxJ2t/TIJK0PBPsZO91cAkjUSwh+6UKSqgZr+7wnKIihSsgyziyg8novy6tVl L1LQ== X-Gm-Message-State: AOAM531j8V+U6YxwAMD9Q6mJSbNdOf+brGf/A8LWakYtwGpb/jyOCQ49 1FNjOb1iyif3GyXoBiPmKjr9Hw== X-Google-Smtp-Source: ABdhPJyFYyV65K75HWrpKoxF/h0k2JdSJZa3XOT1Hbbj2zyfEfXqWZncoCe6ZmvK+oqSz6Auq+lTaw== X-Received: by 2002:a05:600c:218c:: with SMTP id e12mr12657564wme.16.1622192711854; Fri, 28 May 2021 02:05:11 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:11 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 07/11] ata: pata_cs5520: Avoid overwriting initialised field in 'cs5520_sht' Date: Fri, 28 May 2021 10:04:58 +0100 Message-Id: <20210528090502.1799866-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_cs5520.c:99:19: warning: initialized field overwritten [-Woverride-init] drivers/ata/pata_cs5520.c:99:19: note: (near initialization for ‘cs5520_sht.sg_tablesize’) Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_cs5520.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c index d09d432d3c442..247c147026243 100644 --- a/drivers/ata/pata_cs5520.c +++ b/drivers/ata/pata_cs5520.c @@ -95,8 +95,9 @@ static void cs5520_set_piomode(struct ata_port *ap, struct ata_device *adev) } static struct scsi_host_template cs5520_sht = { - ATA_BMDMA_SHT(DRV_NAME), + ATA_BASE_SHT(DRV_NAME), .sg_tablesize = LIBATA_DUMB_MAX_PRD, + .dma_boundary = ATA_DMA_BOUNDARY, }; static struct ata_port_operations cs5520_port_ops = { From patchwork Fri May 28 09:04:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485071 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=qPwRtiIf; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKv64srz9sVb for ; Fri, 28 May 2021 19:05:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236384AbhE1JG4 (ORCPT ); Fri, 28 May 2021 05:06:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236389AbhE1JGu (ORCPT ); Fri, 28 May 2021 05:06:50 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 035CCC06138D for ; Fri, 28 May 2021 02:05:14 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id c3so2516915wrp.8 for ; Fri, 28 May 2021 02:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LMvYDOyB4q/E0pHYpqQ2C8W3ut3TbG5YnHO9reTpRZ8=; b=qPwRtiIf356iO0N+o9+zvphIFonH4vM3b0l/Wm8lkkXPMvtKqTx7RrFhPVxumltpXR VF9TrkdFn28SjLwsutgtc05Tv26h2BxpulbdyjwiP4gmJ+adG0gauJa0WphZ+X1VS1sv 1I5S+ZWRTHIYmss1XIadDgwugFsSHevT3Nd9pIY+98oy3O6Lh6wcn32HVpY1s0gCCd4H BO8VM07NAgAPdUeobdNXSJ8vmTG6swKG3Xuh1vsBWvzpnREcxfP7mt12WNGzMVSRlVie c9jctBZyXuyLvfNIYCTr7UXReGFGA8MSVxace6YmgQJ9d6b2InxEuZm81AU0rYmSG66t yaLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LMvYDOyB4q/E0pHYpqQ2C8W3ut3TbG5YnHO9reTpRZ8=; b=sv/FSNGN75T5kAb67d+brOVMlWx3h/4xBRiiFk+RlR9LHx/akaWoUtiPN5oeEMUoR4 dRej2DYO56Vf0PB5JQXmMvSlf4CR1nGpxiN67gLNQ5neH1bdKfHSb6ZsdIlVof+QSClV yAy34aG+9LCdNpyaYDvcQaW8uuaSjDklpOEZzYp0dFFyolwgB4+i78nK6hI1ho6mRhBK OM3ZPXs3vPkjqOLuBVdwfFiZXRfwqrcj6Y289UjHdTtFANGkbsmj1T+ErB+HsH0eroUr XHWXCqWGI4Idk8Ac4PkcD7LkGOJAk8tfupHzoIRjX6XEFN8mXdWgNk35uZTpoWWfDqXo SiHA== X-Gm-Message-State: AOAM532pSHQqDctkeGJPhAZ/EDmeeX43X+Tuj5Rpvm2RiI2B6AbvwReQ LkkBRYq7U288QcUZ2VNMjsR5xg== X-Google-Smtp-Source: ABdhPJyKTUIMwgZkSCn1R0n+vDSqNCDl85dzoFS0BmFDVM3BYet+SaT4QFvnV2pRfb5VNTpQg8ZnQA== X-Received: by 2002:a5d:4304:: with SMTP id h4mr7872787wrq.210.1622192712642; Fri, 28 May 2021 02:05:12 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:12 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 08/11] ata: pata_cs5530: Avoid overwriting initialised field in 'cs5530_sht' Date: Fri, 28 May 2021 10:04:59 +0100 Message-Id: <20210528090502.1799866-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_cs5530.c:151:18: warning: initialized field overwritten [-Woverride-init] drivers/ata/pata_cs5530.c:151:18: note: (near initialization for ‘cs5530_sht.sg_tablesize’) Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_cs5530.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_cs5530.c b/drivers/ata/pata_cs5530.c index a1b4aaccaa50a..d5b7ac14e78f5 100644 --- a/drivers/ata/pata_cs5530.c +++ b/drivers/ata/pata_cs5530.c @@ -147,8 +147,9 @@ static unsigned int cs5530_qc_issue(struct ata_queued_cmd *qc) } static struct scsi_host_template cs5530_sht = { - ATA_BMDMA_SHT(DRV_NAME), + ATA_BASE_SHT(DRV_NAME), .sg_tablesize = LIBATA_DUMB_MAX_PRD, + .dma_boundary = ATA_DMA_BOUNDARY, }; static struct ata_port_operations cs5530_port_ops = { From patchwork Fri May 28 09:05:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485072 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=V9Y8lSuM; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKw1sf1z9sWB for ; Fri, 28 May 2021 19:05:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236356AbhE1JG5 (ORCPT ); Fri, 28 May 2021 05:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236395AbhE1JGu (ORCPT ); Fri, 28 May 2021 05:06:50 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C7DEC061574 for ; Fri, 28 May 2021 02:05:15 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id m18so1726403wmq.0 for ; Fri, 28 May 2021 02:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qt1whjAB7B3KIqzNP8mB42+ojJZ8NO2eFQdyrF9/Hro=; b=V9Y8lSuMGMU3yqi01V/eDdLodPlG8RMYQHdQ/A3sATPU5XX24HQUwRpK7je3P0+yoR 5BWByiLoRvY1dR6gkHKq82ZCY5A77LgxJRtu+nbANhCEkOlqIisclPj4sot0mrLNvRbI rh8vbGcRhYGSL442S/OKcDaC/poOcmdfwJWF5lsEiuI5ZyT+LMiAXA7rhJYNe9wf3HTX nAFLvMQ3+4psdoUNcEAmYm85yO4rVZBd3k/JmAZGM0fEopn50DG5PQ90sBalhL6TFT9U pXvBtK8XDpGGsiaudS+SSm4tXqe9MuwFGoGoD4mL36I2vDIlGSphVx1WboFN3MyoZPFl z3OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qt1whjAB7B3KIqzNP8mB42+ojJZ8NO2eFQdyrF9/Hro=; b=HJMg8ekv1oJzvyRGLntZhfSOzxTJw5MZ5HBDYODid3K215YazpQdPU2jQi1QbEkKPr PbCFy/5v63524gBwP8K3j+FPpp5tkAGYIwgLix1uJNb5HD0hNgP3lS9gfPvdbhD0Fo0O iYjhi0AbxjTiukKHgNEbuA5ONTYyvpG763qboTcWA+rR1cIQxgG1fwF+Rt3/K0kVyAaE SUbCN6/FJrZEW9iCNcvSHDKBQy2MRjDNRB0kWFOA8JBbJiMLKc1BKcX4bV7ECxLoOmNu ukjTgb28m4hwFnQcnQ1XZofDmW3nrmUpVD1Z33+nWpRG4+fOilva3fNHlm8+HhKnhooY AgDg== X-Gm-Message-State: AOAM531ov9heVkoHlLq1iVnsj2cecTEqtbY9bE6oa9G6ucT138QzThEk 1S2lI1NGE9JuSj4+gYDzUG0TLA== X-Google-Smtp-Source: ABdhPJz3EjGlpVSj2qf61StupfyMAlGqyKg+Maiz1smjHPwzTwf++AsVvBsw5JuEvP31tqKHaqYPwQ== X-Received: by 2002:a05:600c:22cf:: with SMTP id 15mr1111078wmg.144.1622192713662; Fri, 28 May 2021 02:05:13 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:13 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Alan Cox , Mark Lord , linux-ide@vger.kernel.org Subject: [PATCH 09/11] ata: pata_sc1200: sc1200_sht'Avoid overwriting initialised field in ' Date: Fri, 28 May 2021 10:05:00 +0100 Message-Id: <20210528090502.1799866-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_sc1200.c:197:18: warning: initialized field overwritten [-Woverride-init] drivers/ata/pata_sc1200.c:197:18: note: (near initialization for ‘sc1200_sht.sg_tablesize’) Cc: Jens Axboe Cc: Alan Cox Cc: Mark Lord Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_sc1200.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_sc1200.c b/drivers/ata/pata_sc1200.c index 3b8c111140bdb..f28daf62a37df 100644 --- a/drivers/ata/pata_sc1200.c +++ b/drivers/ata/pata_sc1200.c @@ -193,8 +193,9 @@ static int sc1200_qc_defer(struct ata_queued_cmd *qc) } static struct scsi_host_template sc1200_sht = { - ATA_BMDMA_SHT(DRV_NAME), + ATA_BASE_SHT(DRV_NAME), .sg_tablesize = LIBATA_DUMB_MAX_PRD, + .dma_boundary = ATA_DMA_BOUNDARY, }; static struct ata_port_operations sc1200_port_ops = { From patchwork Fri May 28 09:05:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485073 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=cETsOJWQ; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzKx0swGz9sVb for ; Fri, 28 May 2021 19:05:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236395AbhE1JG5 (ORCPT ); Fri, 28 May 2021 05:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236374AbhE1JGv (ORCPT ); Fri, 28 May 2021 05:06:51 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AC2AC061760 for ; Fri, 28 May 2021 02:05:16 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id m18so1726445wmq.0 for ; Fri, 28 May 2021 02:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QKY7Nwt97Wel376ZxrfOUdfc8QT+39QiKI00VWQO/14=; b=cETsOJWQgQVIPEsVJjUzNFQmUWMmPee1hcTqqOuWmu7/ai4R8HMTiT1EfvHP9eHWcK 11FcyFFb/ryknvG1Www6P18bTeFhkrUONNRDhX125P2ruK4but07UxTh0UZ+mlrduB93 ezosoNKqtQRvO0rUlmOQi6uOC17M1fwY9Fz2pnuHAF9w7FrKB2ZNNAH+mA9+VNsbUn7K ScFI2FhpyYl7JuL8fDBP769JDbbcg6p/w3sZnlIKnRvbBxFV3SHLVMRQtkJ6VqY6eJsg xnpZkgQP1Bh/svbdbjSDHq5/YJPTeCjzTrgoQ023Cjb5WoIpv8VY3kNarBFxdd9mbWLI DBeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QKY7Nwt97Wel376ZxrfOUdfc8QT+39QiKI00VWQO/14=; b=Cx4TAuMaLgqhH3IWeXDMCjrFinpSwvdLZaFtwKvvyoT3GlHziJquoqjaj28TeHXFUq fJJz3pj8aFjBgKP4Y43bnGn72FYHtVQTHC/ZnyN6B13nysi1GJIIxjwD73KZjlY7Hutw aIAhiQzTL9vBPqLmUIeh9SfyVWGvSLmAGnoCTsulQovwrHEVAzuPNPKtdeje7lkxebe4 77fSxzgEXmhwZBP4wOouNQvt8WIovSrgp+Jxlw0+UA3a4i+Bg33JfOG38DWwiPQ4ZEVc WDYQzL8DcT3G1cIkSvBWD5aAroez0lCGcxEZsTPy7UsBaqxVh/eqJhJwieYUg3YrTZBz c8Wg== X-Gm-Message-State: AOAM532Mkwfd8ns1ImRuKo2NuwnGCrqA/YlGIytmiHJYXqyoEYvd0NnF plAnIw3W/6iZ1Zo0zj0JxNX0tg== X-Google-Smtp-Source: ABdhPJxUQmT2mCaxsuzt0DkPUWwZBKAAH94RsxoIBGrhQGVgAqC6MnQeY6WnCJam1ZDPv+wuQfDinw== X-Received: by 2002:a05:600c:2e43:: with SMTP id q3mr7404576wmf.75.1622192714749; Fri, 28 May 2021 02:05:14 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:14 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , linux-ide@vger.kernel.org Subject: [PATCH 10/11] ata: pata_serverworks: Avoid overwriting initialised field in 'serverworks_osb4_sht Date: Fri, 28 May 2021 10:05:01 +0100 Message-Id: <20210528090502.1799866-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_serverworks.c:257:18: warning: initialized field overwritten [-Woverride-init] drivers/ata/pata_serverworks.c:257:18: note: (near initialization for ‘serverworks_osb4_sht.sg_tablesize’) Cc: Jens Axboe Cc: Andre Hedrick Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_serverworks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c index 7511e11eef4d6..b602e303fb54c 100644 --- a/drivers/ata/pata_serverworks.c +++ b/drivers/ata/pata_serverworks.c @@ -253,8 +253,9 @@ static void serverworks_set_dmamode(struct ata_port *ap, struct ata_device *adev } static struct scsi_host_template serverworks_osb4_sht = { - ATA_BMDMA_SHT(DRV_NAME), + ATA_BASE_SHT(DRV_NAME), .sg_tablesize = LIBATA_DUMB_MAX_PRD, + .dma_boundary = ATA_DMA_BOUNDARY, }; static struct scsi_host_template serverworks_csb_sht = { From patchwork Fri May 28 09:05:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1485074 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZX38wE3i; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FrzL10MTqz9sVb for ; Fri, 28 May 2021 19:05:29 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236423AbhE1JHB (ORCPT ); Fri, 28 May 2021 05:07:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236424AbhE1JG4 (ORCPT ); Fri, 28 May 2021 05:06:56 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AFE9C061761 for ; Fri, 28 May 2021 02:05:17 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id r10so2489891wrj.11 for ; Fri, 28 May 2021 02:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FYwNHNrhbfh9CANgoPYUUc0JeKX9lP8oPhSc5WFJNEQ=; b=ZX38wE3i7apU5/duc7GW+BMobL+9wKiANk42JZTaCXJrhPeef2VoTcBCpAO37TEazY SU7icxq1P/BracR22EQYxyo47osE2Sps3QSY/1XxKZraPTimTkEc8RpWVJJS/ZFr2drw FjImleBL9XAJ/J402JNy9e2kBL6ZpYjLH56PH9xr89wsceD+wW98Fpe32yhpghexRGJz 2wB9Vw3Xvu1jskZZtBRTgnEGVckIFuN/gBKgMuw6nB11i+RuyIWepbS4jNkRT96rOn/2 FMbxwinxH65FcjBMcVx+s9XnS0UBXDLtcPWIJiPPyiJAyMcmnN3FwQ4yet3zGSlhw18b QBYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FYwNHNrhbfh9CANgoPYUUc0JeKX9lP8oPhSc5WFJNEQ=; b=nUK2ptuk/gKRRkh4Dc6yD5LOYzH5FOd1A2JiBH0s6eefSz+capJEP95qvHKh/jIM71 FIBc5uSl1/iMj1bOgmGVHnG3xqzc8kD7gMpXIJN4490k5BYghyosxFemxh0vqz2rKnrr lU2kpG1w40Xjd68kSKtJUScGul5KSA/AQdZl1geLVCPnszsF0XGuIr9hQmX0VIZDqYmm p65MdR4mS+I8rg1/O5BIs5NxyTXmzhoFdYh/I8nzk28lMPa/V4Rnod80Y+35KE76xDdf zyKsDoPuZ5mbR4n23PjiPVq1L4xQ1v5yI3T41CEmb1C6mPrGbR5gC0xkBPW/gpaTqXw3 Deiw== X-Gm-Message-State: AOAM533yph+lCYetu5v6e/SVCpgCPlNJeAYIGNCJjbMEK6sjSFPt3FNs U3tFIcTRstTW2LRwuo2Rx5OVe4VoXTtEHQ== X-Google-Smtp-Source: ABdhPJxrDRvCtE+DWyEoqHgvQj097Jghqqs+XsQt5bmzubXXdYwa7DpNX15McFcRRHL7TMga/x2aTA== X-Received: by 2002:a5d:5052:: with SMTP id h18mr7483627wrt.365.1622192715897; Fri, 28 May 2021 02:05:15 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id q11sm7193937wrx.80.2021.05.28.02.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 02:05:15 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , benh@kernel.crashing.org, linux-ide@vger.kernel.org Subject: [PATCH 11/11] ata: pata_macio: Avoid overwriting initialised field in 'pata_macio_sht' Date: Fri, 28 May 2021 10:05:02 +0100 Message-Id: <20210528090502.1799866-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210528090502.1799866-1-lee.jones@linaro.org> References: <20210528090502.1799866-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_macio.c:925:21: warning: initialized field overwritten [-Woverride-init] drivers/ata/pata_macio.c:925:21: note: (near initialization for ‘pata_macio_sht.slave_configure’) Cc: Jens Axboe Cc: benh@kernel.crashing.org Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_macio.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c index e47a28271f5bb..be0ca8d5b3452 100644 --- a/drivers/ata/pata_macio.c +++ b/drivers/ata/pata_macio.c @@ -914,7 +914,7 @@ static int pata_macio_do_resume(struct pata_macio_priv *priv) #endif /* CONFIG_PM_SLEEP */ static struct scsi_host_template pata_macio_sht = { - ATA_BASE_SHT(DRV_NAME), + __ATA_BASE_SHT(DRV_NAME), .sg_tablesize = MAX_DCMDS, /* We may not need that strict one */ .dma_boundary = ATA_DMA_BOUNDARY, @@ -923,6 +923,9 @@ static struct scsi_host_template pata_macio_sht = { */ .max_segment_size = MAX_DBDMA_SEG, .slave_configure = pata_macio_slave_config, + .sdev_attrs = ata_common_sdev_attrs, + .can_queue = ATA_DEF_QUEUE, + .tag_alloc_policy = BLK_TAG_ALLOC_RR, }; static struct ata_port_operations pata_macio_ops = {