From patchwork Wed May 19 10:02:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1480808 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=Bru/Uy3B; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FlT2V3fxLz9sPf for ; Wed, 19 May 2021 20:02:58 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9848082D3E; Wed, 19 May 2021 12:02:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Bru/Uy3B"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 60B7082D3E; Wed, 19 May 2021 12:02:53 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 46C9F82CEE for ; Wed, 19 May 2021 12:02:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621418565; bh=r5YTjbbq8YccQ88zmRlrUpbOgKlLoVRFzjQ7XqestDc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Bru/Uy3BSvyEKo13JkFXDPagMKHJ9SchjzU8kMZufpk7iKqT6iCanGwvs46Q6MKN7 /mMkSJrQeBNXt8egrCrRMEH8MdJke98c9BH6ohEFEpXlHDTDI8VkT32f1uGbKcXln6 v7t+m7hFk6OiNvCU84FHXOJKPveBV4rqsa0JOBR0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from workstation4.fritz.box ([62.143.247.63]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1Mt75H-1lTzB61Gy9-00tS5w; Wed, 19 May 2021 12:02:45 +0200 From: Heinrich Schuchardt To: Simon Glass Cc: Ovidiu Panait , Bin Meng , Stefan Roese , Masahiro Yamada , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH v2 1/1] sandbox: don't refer to symbol _init Date: Wed, 19 May 2021 12:02:39 +0200 Message-Id: <20210519100239.8829-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:wuJeTu7sjgb0GSE1Tw9ZMbhAJXC8r20OSZtoG4kZ/RMGrC8rucm gi8rAyXW2mlJQsOuDay6hxO5aRlFRcPqGZfP/CR6vFHCTY4SoRbowhO68GepIUaU7kOTVZG Xejnmfd2n5hawKunTjT6dPzlh6qTkhyLmMDX04BqXLLwWlSuVZSZjcIjvsUVMUTOYi18Vz2 LrQgDuYcXV1o4ip/xNMIw== X-UI-Out-Filterresults: notjunk:1;V03:K0:5nkKaErBaFQ=:Q/jFXUWGbhHWNalnMWMVqg HvdPNQ2nPShNHnRAFA2DPH2bGXTzpEQpbGyZur0hS0E/+QSJf6MRkVwZQ7SvkV7SxwhYgYEER HqsKawoubBjfMY1F+2qG2C3W6WPxRIs4tAQtKW+DCYq9VdoCyuBwQNOTpQpAuVMXuhkN+CLbD 7J9Mn72Y044wr64WcQHbA+XTjrqg4MWVPMr8DbN06IhgGOiuzV4QnYxJ7Ks9r5M5BNI+PCh6/ HDU3xgXOKlIXBARqn5etgFbhCJa/DDik6/05ijQKaie6dqwz+7F9Z7nT8+6aTrnJ+KWq7YjmY NtCHvN9/F2KTHflepCI5L3zD5nePoDI37TUGIH3AUQfSHRqQNNpsnqD1EOzU0U6GigHXSY/E/ v78Rpkffp6LiOOtKo05juKz8VlcJ/TYQ6yILElLcvRAs0SN/KWeEvs+XeL46MZNmDH/Q2VcQ0 OV7+ILYJ7B3t0quXcHCj4pbcQ4xa+RQuwtfecmNREwgMnkjO4O7uSXGOpRxiQADcEUKEbqti3 8HQBdT5SUZnzHgkg9rhPm7R4guxlw6/xg/rwBCYdMOKiD/nzcA8QL6+Q1PfxtTjtIO37WlXgF oMJPXYiU52yWDKTVf49sX7gyJ5LSYmdiWiw3eM5SB8TKwuYw63OwZvrEt6ykSitj19RTBD2GY yAV+pTforunIrF/2wVDrAD4Iud94n3HpFTK+THAlwdmUmTPySFK8a1Q/EzRMEdzLQN7jT5ri8 1n24RDfhybt91701Sc+m3cDrfig0hb/8CdxM+rCD+Ov2alr9TgjTz4fcV00wnwkTmsmOhXNlJ XvD6kPHnRJkPUvHn8wWxQT/ROu5XPuHL6lJfHfHqCksH7kybMKNeZrkY5ecnrq4J7+pgw7rqv qm4LJ4YF9kwUFfThKTV6fKPMGhF6PaERh2HVFT4qYx13urCzWfW5Z51K7iJ5yeoVe15AdwQIc sbeb2sONNqEWmhgxZmsfYxRfPULfzYawrJ26UwAJ0RoGefOY1LbT+qL6F/nC4AuV43tVV9RSo Pb5p5LfYLQnH9rp5zAeTsYiTsCtr+pHATOBIIR6kxlAREPswwzT+p+0LZQRyYb0Brn37VgWy8 j4w0Lo4dN0dC53658uQ7+Qa6jXDiJ0VF/hoTjiyh32CLKeU4Y4rfBh/UTRDezXOAamyR3nbMa uurxWSZWcDRUblMfD21TR4wCAj+t1sTjCFCeraA2GTdTD672s2ea+pj9q4CzAula6TRTY= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean GCC provides a symbol _init in crti.o on x86_64 and aarch64 but not on RISC-V. The following lines leads to a build error for sandbox_defconfig on RISC-V due to the missing symbol: common/board_f.c:269: #elif defined(CONFIG_SANDBOX) || defined(CONFIG_EFI_APP) gd->mon_len = (ulong)&_end - (ulong)_init; The sandbox code is not copied into the memory allocated using mmap(). Hence we can safely use gd->mon_len = 0 to avoid the reference to _init. Signed-off-by: Heinrich Schuchardt Reviewed-by: Bin Meng Reviewed-by: Rick Chen Reviewed-by: Rick Chen --- v2: fix typo in commit message --- common/board_f.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.31.1 diff --git a/common/board_f.c b/common/board_f.c index 203e965799..c1b8e63e56 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -265,7 +265,9 @@ static int setup_mon_len(void) { #if defined(__ARM__) || defined(__MICROBLAZE__) gd->mon_len = (ulong)&__bss_end - (ulong)_start; -#elif defined(CONFIG_SANDBOX) || defined(CONFIG_EFI_APP) +#elif defined(CONFIG_SANDBOX) + gd->mon_len = 0; +#elif defined(CONFIG_EFI_APP) gd->mon_len = (ulong)&_end - (ulong)_init; #elif defined(CONFIG_NIOS2) || defined(CONFIG_XTENSA) gd->mon_len = CONFIG_SYS_MONITOR_LEN;