From patchwork Sat May 15 08:16:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1478820 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=cDOD854J; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=lZNQZciM; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=cHc4fqrs; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fhz9962Nsz9sW8 for ; Sat, 15 May 2021 18:30:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=2TJEi5F+6z7U8lRFbh1ynAa/HBCxynOJucBp0YVferU=; b=cDOD854JQ8ALK6Jw7sfjLN/dLO T7rpXLa8aIpcJQUxdwsXwo/Hjo/RgsOb2qzMsl+zpIrs9OfT69TGfr0kpUCsLf4+/Bgkc+snn/kqR L/Cfk4HEqKsIl48dZSoTjcHs8AxgfBpvnS4SwRvybijyJWyM6jzG5m7SUKP287kmHYn7obMtjTDUz KJJKoVJNvCQQoeBZAyPyfHPkjygKDIzNu32euDMxiEi3Hr0ZnYYHDIhpqwcEtvVAPxr0SaoectnLP G0Rfw3sQ3odWVVwVCylPiLLvc3R3bvgZKB2nD0IxhZBn9C5d9uiIfMAXV3janY37P0BZFTPsMWxB7 K83bVDuw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhpgL-00A0mm-5m; Sat, 15 May 2021 08:29:57 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhpTh-009xu4-8c for opensbi@desiato.infradead.org; Sat, 15 May 2021 08:16:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=UsfpJv1ImgWJCTWitSyYqK3gGWkvTdf691+tIhPoh0U=; b=lZNQZciMCjturWs4zwur/Mj47G fHMNZ3FVnR5hL4PvuqcrMKYxET7mpZS6aEPheDbmxT93yR/RxGehI4VghPpBtzdORidJiZtZNvBAC r3E3IsETYc8AoKdVhHH/vQj+sSp2njIY/ynIpNChK35gVenIKtxPVjf2/q34guOhRYBa9y+35j1TU UB6msFMKJ/n0QUpGDMTputFd4Z2gjgg1EJ6vd4QfWeeVdmFNjij4W2HRuGhPYi8ekHzxOXdrLzTra KO4pOcnu1hZgxPVOihaQVeYbtzN5BP8hw33s88wjaIW/jF8kRXqT+GYmfkqC0OwYwRj14oknxbpo3 YkcvQozA==; Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhpTe-00CRjU-E8 for opensbi@lists.infradead.org; Sat, 15 May 2021 08:16:51 +0000 Received: by mail-wr1-x42f.google.com with SMTP id r12so1383798wrp.1 for ; Sat, 15 May 2021 01:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UsfpJv1ImgWJCTWitSyYqK3gGWkvTdf691+tIhPoh0U=; b=cHc4fqrsBiVVK2heTumb34vO/ozpIqs7Ve0ixAXpqGXznm+9rLctVtO/NiJ/yO/Drq mp30RIMRioygJMUd71uWOjsYRghghqWYxwFJmGxk4Jj+BqX+DPGesyQjSaVDv91KYKh7 BZWYrvAzJ3zFpRSyE3Zxe78Lo6ZkDhT6FUY/qNzls+lLx/QNPGQnFIrr/RT1S9c96fkF 1pWIWmASv9uouTsw+vDks6KFQkWU12Fo0kmz7uEBXUXr1wsMBccOAoMbpV3YdwLmjDFk VmV0syku9xQfFxy+KtRBPPbUmEOqkETwWG6XXgv3nX6nb+/9NDAgCJtDzZoLUCsNyh8J HlCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UsfpJv1ImgWJCTWitSyYqK3gGWkvTdf691+tIhPoh0U=; b=a5L+bU3dGf3qaxfVLY4j5AJLBomtfL+1kccA38sO+c5pbwBVSegC6xB5tejmHNTtB5 PIg3M7nmOCZaoN0/D0DhSwyU5CQfsBlSceCRtAAKRhgCommj4n381J7yvBVlSrk7YBwg NFZ+E4Bcc7DGIKgB7QCaA9MjTqlg8V+Pbx8MnYVe5JeGNudPvaCrpDlBnvnvGjypHeYI WXg/bl0855RXcuRFlPsSpzy1x6F2FbUdr0ja2WI5kK6PbohfWGnK+z/4TKlK4cnMCWUg T47wgCrGRDNryCpjIYoBaudv3Ok+YilPi5asIfrl/4VbdAwOgd/NmhrQ6vj8BTlv2m/Z 64Hw== X-Gm-Message-State: AOAM533floGIDutTvSYHZcNflH3btSw+f5zFuxttkxqr9Z/AgspMM7GC sxca6YW+h8HqAbdGeyxUnTEq9ee/y3M= X-Google-Smtp-Source: ABdhPJw1iyV6vys838mdnWXcalCh4ojd8V4Q4NNdJ+EHymevCRlVqeinjBk0WAV7iUEjMb4VZKEBuw== X-Received: by 2002:a05:6000:52:: with SMTP id k18mr5011510wrx.419.1621066605595; Sat, 15 May 2021 01:16:45 -0700 (PDT) Received: from kali.home (lfbn-ren-1-1383-171.w86-229.abo.wanadoo.fr. [86.229.230.171]) by smtp.gmail.com with ESMTPSA id b12sm8938709wro.28.2021.05.15.01.16.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 01:16:45 -0700 (PDT) From: Fabrice Fontaine To: opensbi@lists.infradead.org Cc: Fabrice Fontaine Subject: [PATCH] Makefile: unconditionally disable SSP Date: Sat, 15 May 2021 10:16:38 +0200 Message-Id: <20210515081638.2361496-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210515_011650_499289_1B45AB23 X-CRM114-Status: UNSURE ( 8.33 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Though -nostdlib is passed in CFLAGS, -fno-stack-protector must also be passed to avoid linking errors related to undefined references to '__stack_chk_guard' and '__stack_chk_fail' if toolchain enforc [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [fontaine.fabrice[at]gmail.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:42f listed in] [list.dnswl.org] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Mailman-Approved-At: Sat, 15 May 2021 09:29:55 +0100 X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Though -nostdlib is passed in CFLAGS, -fno-stack-protector must also be passed to avoid linking errors related to undefined references to '__stack_chk_guard' and '__stack_chk_fail' if toolchain enforces -fstack-protector. Fixes: - https://gitlab.com/kubu93/buildroot/-/jobs/1247043359 Signed-off-by: Fabrice Fontaine Reviewed-by: Bin Meng Reviewed-by: Xiang W --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index eeffe6b..6b64205 100644 --- a/Makefile +++ b/Makefile @@ -203,7 +203,7 @@ GENFLAGS += $(libsbiutils-genflags-y) GENFLAGS += $(platform-genflags-y) GENFLAGS += $(firmware-genflags-y) -CFLAGS = -g -Wall -Werror -ffreestanding -nostdlib -fno-strict-aliasing -O2 +CFLAGS = -g -Wall -Werror -ffreestanding -nostdlib -fno-stack-protector -fno-strict-aliasing -O2 CFLAGS += -fno-omit-frame-pointer -fno-optimize-sibling-calls CFLAGS += -mno-save-restore -mstrict-align CFLAGS += -mabi=$(PLATFORM_RISCV_ABI) -march=$(PLATFORM_RISCV_ISA)