From patchwork Tue May 11 19:03:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1477286 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=Sw9MPLTD; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FfnQ31B9Jz9sRN for ; Wed, 12 May 2021 05:03:39 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C1FF482F50; Tue, 11 May 2021 21:03:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Sw9MPLTD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ED9BE82F6F; Tue, 11 May 2021 21:03:26 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4286982F21 for ; Tue, 11 May 2021 21:03:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620759801; bh=nWcjjm35144es2d0d67Ovb0I6HVTLyeLTK2vr9zvPSU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Sw9MPLTD1ADXG2ZV//VfoRBvsjTtoEs5y1mzJFA6/JeVOLAXQZIh1gnrc0dDkfhT6 45M2XYmL6PBMRoDTpJDFEXXa5w9Tl8vvhkNXTDhhTtcfRdSOkhUaU9Prq6fuD2IqUC 3INCSGQ975XfFY5eioEM0+ulMMSSMivmRP6kuxcc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.247.63]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N3siG-1lXZNp1pwG-00zp9V; Tue, 11 May 2021 21:03:21 +0200 From: Heinrich Schuchardt To: Simon Glass Cc: Patrick Delaunay , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] sandbox: ensure that state->ram_buf is in low memory Date: Tue, 11 May 2021 21:03:16 +0200 Message-Id: <20210511190316.29710-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:VJMmR9zCPM+OM91eYmnmpZXKPvLnsE6l63XtteIoAsLatIdYda6 9c1vgTaBV7BQm56OglAA8kCcDYA14xWrchPwyVzReVE54MVBhXqRhRjtz2q5BWqHCybbTEN Vl9y+pbehj5qzKqS8oXk779L2HrpruVA2wUDU+JrLyzHBoL0NQjdsRbLNsBW0yDxu1w1VD2 FeXFbIeHHY7oJHCxgHYEw== X-UI-Out-Filterresults: notjunk:1;V03:K0:SZ2M8OBgwCs=:QGTcNLvxF+jzELDI3by0kw 5GzbXpYe1ipUjP5e78uiANju/0firACYhxXq+EqoYJG/+K/fXIqmBUDnRTQt4FWAqbX1Ztx7B qK5U7bRo1JyW6XgRVr1D5mUdbzU/QxVADsIZSFo/3FRVVaFLSWz4gae1Ckkja6Kec3nv2yXoG Z1Q71P+4/VwAeiUVmhgn4BRx5R41F0DsNets+4C/jG1mcv7Ddbc6pXEgmKG2PS3x8dMbJDF4n 7J2+dOxMJ5IKrE4C3HyxbKjnTZ/tC62VKjwUJm3IQIQcDqSIkrmcH4Q9P1BmAYDZfL/ZRJ8FZ YE+poxIDsH4tmqP+sln8UNXZcAKdiN/ZYujwLKldTPQFMZthFZwKrbeMAMF68UrsANWSq5oWf 1CyzRvKVbqHbo7Z50vb/LVOto3IcUJPfF3rngA8qi1GXTT5myjOvmcImQM1Fcl1Rt91Axl90D QxJFR8Hj3XDOsBHygboNFxPKzrQTfIsbEhPuoGXTfvpma/xYnJ7ciglYaM7R2YFxus+BZcGJ2 X9uhWvGfXiFZZnxmnYxCP3kbKBmBQi7ZltfPuBo4qVIZw/NlARkDHutGHmhCS9nVSYs1T5YUy 5AQneoeQNBLxoALYvLBgn7vGahBcGTEmz9AiMOpLhBEk+C4anLYBRnUAJaV3iWKmrm+HXYB9K yldr/Ka0retQk64TqpTYmghQ/02qQalavsaG2mJGgvz1uVD06UH34wMgyuHu3zdjfpfJaetZ3 02D4es/iEN4InDmEq25GgGvlEhAK0Cf4ZxRzBESBB9IhgDgXEzjNYUFNDGM8KbIOtzJw9ey9A +a7M0dbYsqE8ES9pPXAgA9oNjJo8giA/0G9zBIVyRajQPSiisPTa0Hd/KaZImm5bbrKl4H8Nu I4JiuiN6OfCC35gQakl3DmQlhiIUpu8SMuOK9kqsswmubiZzmHoANuMyW8qjvXf9vJ8cPoWLN tRnI7cBrGHYRWak4n0/2uTQthFjNj+ahmrX2b7cr8Fw6yF+gmvUVvaZFmPm4Ae+UN3PWXdKd6 7x7EMRuOf3/iBXae9OG2tXnyhRUxDCT9UvsDbHlmKssaW5AfAjaXUDIyCGr+5DV5mZlxkH/0H oecgVpvNGGpIZL4NSPH9bMiY4GuHS2a1/wmIK7eNWmDrsYmUW5TPuA7osuKhva28z5KDh1Mvo FruJZ2VCaGZ309NHwsZKpGkOl2+vVmnEm5XsS510Dna4FLsHbZiAVM90etYKaz0dYX410= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Addresses in state->ram_buf must be in the low 4 GiB of the address space. Otherwise we cannot correctly fill SMBIOS tables. This shows up in warnings like: WARNING: SMBIOS table_address overflow 7f752735e020 Ensure that state->ram_buf is initialized by the first invocation of os_malloc(). Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- arch/sandbox/cpu/start.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) -- 2.30.2 diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c index e87365e800..1388dba895 100644 --- a/arch/sandbox/cpu/start.c +++ b/arch/sandbox/cpu/start.c @@ -439,6 +439,14 @@ int main(int argc, char *argv[]) int size; int ret; + /* + * This must be the first invocation of os_malloc() to have + * state->ram_buf in the low 4 GiB. + */ + ret = state_init(); + if (ret) + goto err; + /* * Copy argv[] so that we can pass the arguments in the original * sequence when resetting the sandbox. @@ -453,10 +461,6 @@ int main(int argc, char *argv[]) gd = &data; gd->arch.text_base = os_find_text_base(); - ret = state_init(); - if (ret) - goto err; - state = state_get_current(); if (os_parse_args(state, argc, argv)) return 1;