From patchwork Thu Jan 18 16:41:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 863013 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-471601-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="s/8wSzDo"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zMqVV3TYCz9sBd for ; Fri, 19 Jan 2018 03:41:53 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; q=dns; s=default; b=puE C1qOC0GWK7IbWJKglu4wNkrEPmbmxROPJkQTM/bj6CC6RDEmptCMWshyerm5e6XE Y+qnSuhKu5Evchy8o+Fp6uUta4Z+h35ZprlxqgU5kkryTaRSp/8EFkqw7rJB4+In ythP1ic4n23t6l6+AKDIbPi14KjjJl8InZJ9YrVs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; s=default; bh=WpWd8DAfi ujlXl3pwVLOa0K8ecY=; b=s/8wSzDohw87o6OS/bxCOuFbgqMp9TlqvepZSo0ud EYFoQ3hM5DLmhjAm97Zx2T87yEM0e5cZQam07OfgRrWuynia/Ob8HWPkMN9g6gHP QApO6MOWJo5jFyXKw0ZTlJyJMNXO8419qzNCIPwP2Qt5I4P25Ey1Ktv4Hwn4KslJ mc= Received: (qmail 4197 invoked by alias); 18 Jan 2018 16:41:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 4183 invoked by uid 89); 18 Jan 2018 16:41:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr60060.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (40.107.6.60) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jan 2018 16:41:42 +0000 Received: from DB6PR0801MB2053.eurprd08.prod.outlook.com (10.168.86.22) by DB6PR0801MB2056.eurprd08.prod.outlook.com (10.168.86.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Thu, 18 Jan 2018 16:41:39 +0000 Received: from DB6PR0801MB2053.eurprd08.prod.outlook.com ([fe80::3cba:f6a6:c08c:8f0e]) by DB6PR0801MB2053.eurprd08.prod.outlook.com ([fe80::3cba:f6a6:c08c:8f0e%18]) with mapi id 15.20.0428.014; Thu, 18 Jan 2018 16:41:39 +0000 From: Wilco Dijkstra To: GCC Patches CC: nd , Christophe Lyon Subject: [Committed][AArch64] Fix fp16 test failures after PR82964 fix Date: Thu, 18 Jan 2018 16:41:39 +0000 Message-ID: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0801MB2056; 7:IvFsMPhFGqOsLdk+xiYPGdr9KSJvGeHfcu4MWnPLkQW/4JA+UMfaXeecyofkSicE+VlYY4WeB7xJgUDhmI5RMburUXR1ow3bJ0EzCzbWVRZM/m0Sc5NDRtoUBWQLLPQgrfUWpVvcLbbPIjrC9uOLdKoj9WjuycxCD8A+RsQNZ6Wl1HQEB3jjVq4uSXaPy/9b1E4TELOkKPOnUpdmk1/8ScGl+EF+7g07GkUkcSXXsQdeIOaeHxCROUANT4ZrqFud x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 4c724da6-beb4-4724-cf09-08d55e9258e7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060)(7193020); SRVR:DB6PR0801MB2056; x-ms-traffictypediagnostic: DB6PR0801MB2056: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(22074186197030)(183786458502308); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231023)(2400064)(944501161)(6055026)(6041268)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR0801MB2056; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DB6PR0801MB2056; x-forefront-prvs: 05568D1FF7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(346002)(39860400002)(366004)(376002)(189003)(199004)(54534003)(377424004)(3660700001)(4326008)(7696005)(478600001)(102836004)(99286004)(3280700002)(68736007)(105586002)(5660300001)(6116002)(3846002)(26005)(6506007)(25786009)(72206003)(2900100001)(5250100002)(86362001)(6916009)(14454004)(6306002)(66066001)(316002)(55016002)(6436002)(54906003)(8936002)(9686003)(305945005)(8676002)(81156014)(7736002)(2906002)(81166006)(106356001)(33656002)(74316002)(97736004)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0801MB2056; H:DB6PR0801MB2053.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /s9WjC/fB3zzJMtxMxC2ktnzqDoruCVelH4fcffHqrjCnB2u/o32RLebyWurocQqnGAQa8TUGHg5LppirBizNg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c724da6-beb4-4724-cf09-08d55e9258e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2018 16:41:39.1834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2056 This fixes test failures in gcc.target/aarch64/f16_mov_immediate_*.c after fixing PR82964 (https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01636.html). The check for a scalar floating point constant didn't include 16-bit floating point modes, so use GET_MODE_CLASS instead. This fixes the failures and has no effect otherwise. Committed as trivial fix. ChangeLog: 2018-01-18 Wilco Dijkstra gcc/ PR target/82964 * config/aarch64/aarch64.c (aarch64_legitimate_constant_p): Use GET_MODE_CLASS for scalar floating point. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 671168cc3f32ac3f2669fc79835435fdf618a56d..c6a83c881038873d8b68e36f906783be63ddde56 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -11813,8 +11813,7 @@ aarch64_legitimate_constant_p (machine_mode mode, rtx x) { /* Support CSE and rematerialization of common constants. */ if (CONST_INT_P (x) - || (CONST_DOUBLE_P (x) - && (mode == SFmode || mode == DFmode || mode == TFmode)) + || (CONST_DOUBLE_P (x) && GET_MODE_CLASS (mode) == MODE_FLOAT) || GET_CODE (x) == CONST_VECTOR) return true;