From patchwork Thu Apr 29 08:45:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1471609 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Hqp1cNzh; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FW8GW2rBnz9sWW; Thu, 29 Apr 2021 18:45:39 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lc2Ii-0007PL-IY; Thu, 29 Apr 2021 08:45:36 +0000 Received: from mail-pl1-f171.google.com ([209.85.214.171]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lc2Ig-0007NW-ID for kernel-team@lists.ubuntu.com; Thu, 29 Apr 2021 08:45:34 +0000 Received: by mail-pl1-f171.google.com with SMTP id y1so18731722plg.11 for ; Thu, 29 Apr 2021 01:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZJJ5PNtVY8bUnuygm6uOeOoTrdIRd/ttyx+Zm2lTDI4=; b=Hqp1cNzhN4+nlimi7d3XRMzfQXPpoUqjQYT0SAXx6hXQe9Me9ARUxpOcVqWhfr/BG0 SXYW88AhYgt/A/f7fFZVy3fyYR44Wyjkyu8oX7kgxcDa2D8aEsBPxlaVWaSKoYBFhhVf 3b/0uwg8YGkYoN6reea0u7ydlzx8sj9tPhz3lHiBX5Kf+wNNZzx0HUwUnt/k+tNlzq1r vqLbUWsZ1g8cUQEPuHST4Gi6S8Tov3QEh0gxJLve2ootd7kAsYAnxbyKa2XGDXXL1wxk IMDjVXvDeMfMOzmr0/44LmZiQ+lZPCSMqbO0R8PTkaku/CKKtgM8zXtKRiH+75fgE3dk gMyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZJJ5PNtVY8bUnuygm6uOeOoTrdIRd/ttyx+Zm2lTDI4=; b=ZItKyROALqEiuWr1ko6v8sYIVintOTea3SRlNDfGXuvDYtxnx+8Hm6xg1Clt2+2S7H 9vm9JgQrblECv/MuDzCFqT2AqzpcXGdVS1OX/iuwQVRgTJhy1z//3n9wm6YT8dKTPYV3 og63O0nxfb7tkaue4TNJSa2rCLiBZTNKzEHFFoo9PeI3cuyBVxONdqHjCSkLGsLEoWI8 1N1T/RcDTi9qRQY+gktvI9p6KnpDVQslLah8IXQTJPGB3eAjVgwJ+BgL6P/oMa4qH4HV itITz7o81YEIcBWh02OMKhxLS2zCIlKXatKZpx1rQ1vpSLt6sOUv09cmMQbCW5YhBQRw 8NAg== X-Gm-Message-State: AOAM533Yjx58EXd7gz2Jm/c3vYuO17wid8l+tk7vcZqKYrWdDtE3dlrb mMw4jrQy/qDG5xqIM0rriWs9dU4DOeY= X-Google-Smtp-Source: ABdhPJxuj8hYjzMs1PYPf+TvVzOtwLkQeEKgdqrqxwyXIWG5s9yGCeXkThYlAqfn7lW6b0VJBehTcQ== X-Received: by 2002:a17:90a:af91:: with SMTP id w17mr8458327pjq.205.1619685931569; Thu, 29 Apr 2021 01:45:31 -0700 (PDT) Received: from localhost (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id 187sm1834344pff.139.2021.04.29.01.45.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Apr 2021 01:45:30 -0700 (PDT) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][SRU][G][H][Unstable][OEM-5.10] UBUNTU: SAUCE: drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0 Date: Thu, 29 Apr 2021 16:45:26 +0800 Message-Id: <20210429084526.409635-2-acelan.kao@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210429084526.409635-1-acelan.kao@canonical.com> References: <20210429084526.409635-1-acelan.kao@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.214.171; envelope-from=acelan@gmail.com; helo=mail-pl1-f171.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Gwan-gyeong Mun BugLink: https://bugs.launchpad.net/bugs/1926579 TGL PSR2 hardware tracking shows momentary flicker and screen shift if TGL Display stepping is B1 from A0. It has been fixed from TGL Display stepping C0. HSDES: 18015970021 HSDES: 2209313811 BSpec: 55378 Cc: José Roberto de Souza Signed-off-by: Gwan-gyeong Mun (backported from https://patchwork.freedesktop.org/patch/430153/) Signed-off-by: Chia-Lin Kao (AceLan) Acked-by: Stefan Bader Acked-by: Tim Gardner --- drivers/gpu/drm/i915/display/intel_psr.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 61fb8fdcb5e81..0eaa6f8364138 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -812,6 +812,26 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp, return false; } + /* + * Symbolic steppings that do not match the hardware. These are valid both as gt + * and display steppings as symbolic names. + */ + enum intel_step { + STEP_NONE = 0, + STEP_A0, + STEP_A2, + STEP_B0, + STEP_B1, + STEP_C0, + STEP_D0, + }; + + /* Wa_2209313811 */ + if (IS_TGL_DISP_REVID(dev_priv, STEP_A0, STEP_B1)) { + drm_dbg_kms(&dev_priv->drm, "PSR2 is not supported this Display stepping\n"); + return false; + } + tgl_dc3co_exitline_compute_config(intel_dp, crtc_state); return true; }