From patchwork Thu Apr 15 17:06:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1466735 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-secospa-onmicrosoft-com header.b=UHduq9RJ; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FLm346v6rz9sW5 for ; Fri, 16 Apr 2021 03:06:40 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA2B281FD5; Thu, 15 Apr 2021 19:06:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="UHduq9RJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 278A081FE2; Thu, 15 Apr 2021 19:06:30 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on062a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::62a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CBFB981FD5 for ; Thu, 15 Apr 2021 19:06:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lplIbXfTFTCxy/6md/y/SgdCAynpZrDrWUTwWnCGYMrzOnVVW9/s3FuB5k5R7jER6bRt5c7wjCTpaJkZLfzAouESbWridPjF3C2hpHQ0lUpo/ofp73JmNm2uU7IdCWtxrQrqphrQd/A8ZyZJCCxgbzZZCsi9p8z3YTvAKqnLb+W5l/ku7LT6xpxG7DDTTh2f8LpXdrZ0WD3t+deaor9QPSndRtrPaucEtX3HroCw5dALKMeZh6Ka/mE8UalHeGCZn2F/nL4is1oFuN9RzanwwgRoVQE/SG0qqnP6UyUm/ux+7+3ds2LbqhSQ4Qru3sD2joftjJFQ0q9HPVYSoXW1jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MsTV50bMyVjqy8vlz+p3IEe+aFyCsKc3zTaZwa98hc=; b=GUmlwClq/asDvEZ+FC0NEKLsoghsK9V3KmQXeJDO9ru58UiL5aYkQfuuZGeuA3vlhMv7QaQvFeqE3XEyzjtZlf87JRc8XWABhWxfUFe55cuenft+dV5anS9gOgzNm4MVXybyg3BE7lc4tlTkAlYPbch5gHjzp5qZF7+ZB/TSD9YIxgrwLjtcyOCNHc924owRVuvzCDiyLvT5r4czJJvIfcCZ769sEnPiFOZOqLrnUWCgmQTY0emLyJTPLsFC74UMPYKfdkM1MBjoTF1E5fDYc265uVzROR8zsMq1pc4q5KkI6xDtsZP0/IdgkmeOqhNJ8b0dCZ9IJJWZk8+TSkNpEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MsTV50bMyVjqy8vlz+p3IEe+aFyCsKc3zTaZwa98hc=; b=UHduq9RJDrEvto3Y8l8CJcs+eWXXHITC0J2uoG00cQQSl2FG9ZcKvhjle2vqvJGMtkPG15tsVg0oV8vIUdK89bwkPSCDTdh6oXM6+KMMaFoUtKfnDK3VVhtOXOr6avtzGgAMvyiH+fUhRVRRUDg8hWRhFky9MK3HHmReBTJFIFI= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB3PR0302MB3354.eurprd03.prod.outlook.com (2603:10a6:8:a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 17:06:25 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9181:c45f:b367:9bdc]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9181:c45f:b367:9bdc%5]) with mapi id 15.20.4042.018; Thu, 15 Apr 2021 17:06:25 +0000 From: Sean Anderson To: u-boot@lists.denx.de, Ramon Fried Cc: Ye Li , Fabio Estevam , Joe Hershberger , Peng Fan , Sean Anderson Subject: [PATCH v2 1/2] net: fec: Don't use disabled phys Date: Thu, 15 Apr 2021 13:06:08 -0400 Message-Id: <20210415170609.3399111-1-sean.anderson@seco.com> X-Mailer: git-send-email 2.25.1 X-Originating-IP: [50.195.82.171] X-ClientProxiedBy: MN2PR01CA0023.prod.exchangelabs.com (2603:10b6:208:10c::36) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from plantagenet.inhand.com (50.195.82.171) by MN2PR01CA0023.prod.exchangelabs.com (2603:10b6:208:10c::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 17:06:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6bbeb37e-3b11-40d3-d0d1-08d90030cd10 X-MS-TrafficTypeDiagnostic: DB3PR0302MB3354: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RnAju7BaT32JzaaSV9YXRMFFNQSWSasq/3FBTlwbNR6j5OPhOm2E3qgAxqN3LQo9TfZaMGtzecifwbLCYLWzUIrTYqGU6nwyZ3CAAytEgZZp7+IhBIXgyQ+k9PCgJohZG+awibKBxu6A+4EpfE1NSN0OWJtKHFcAxD81mo+rDaRCsQ/8QrTn40Yn3lRikn5zljZaGNz2b0Vu+0+yWquR1tYaXSSNqjH0qUW5bk49x3JZGMVonNxqe6yTQ02RbNhO5qRkP2XWZ8QQOjMklwfoq5piXG9xXtym75wOHu8aRg6zNnEM1dzPDDhy3TocCMvGaIKDyqHvAUHVMH72ueQN7n+C6iE2T9ky8e69vqmVTzwDL1lmovlhm3ICKGW+shoEyNfxLgoRj7btDahFnsXMO2JHIy1QvOZ/uxUwfaXoH6TA7LItX6yeq5ZTUFtlQIBnTm+ZY5+0pgWDvGAb5l0HocjhhMOiggBri2J1DrgW5xCO46tG+COoz2dIVZEORC8N9DgW90YMi69fLLCmtMQtqcZhZEDGY7K6PEWJnznXyXtyRrDKtW7GTak/okyj1f0sNwn8sNFBfmHaCQdC3abPsoTYqvR8fdM0rTkED6vOClmomLSJbskTGEi4hFaxACNPk3YlYYUe6nl4Y4KT4mY5kw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(44832011)(8936002)(1076003)(6666004)(36756003)(5660300002)(498600001)(6916009)(107886003)(66556008)(2906002)(83380400001)(38350700002)(4326008)(6486002)(38100700002)(26005)(66476007)(66946007)(86362001)(16526019)(186003)(2616005)(8676002)(52116002)(6512007)(956004)(6506007)(54906003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: B/2sXrSNWWjhtPLmFOyiKt3iuaGiN8NRCK2TKZ9GhHzQKssLKG1P4yZQjL1TpyWOlnQwZL1ZcHsUAR2ncIhtrUxtdTDFmkPmOuXkjwgLIiUILddLp6Vqv6bxJJAQj2/yLKKVw4qbLtyi6TuPbAVPkT9ZU70rAiRcZ3xsHbLs6uwfZGjOi/NdaQF/vXtvmCJ/rrgnWNU1zKHryVpC0/iTCozkF/QrBWFKSPtXNiM+0AFlvqaLLpaRGsxj994lCFOtuz4+OsDkqPUhSAwoA3+zB+9w7SMPknB/W6e77eIXaeK2GVovum9j6JSTsx4DVQD42ZdYbtZNUhNQNH/ZBGYKluQsqHohSHYR+bnMXYsdE2WbDfuWvbNZlrKFkCA72tOYRsR25A3sH7HqM0Kuf7eNVyiRM3qOGFMZWP0Eh/lSJZKCzBJzHCh5EnzSpkz8hPht2QUMa7tKhMza1S1KTjCYrlp0mOQmulnJn/tJFRvDJGSDqtZ1tS6Horz8N+m819MauNEOrYwU3vlKVeHBDmOtBXRm8xC/Exbud9MH9lI2RT4Al8oGSGcey5gvo9qzEVlUxxsawF+dvTkPyZWLosPGZRlU7zj7Z9jrmdQcKpLZn5gz5KgMS/+HDtOUY0o2PP/Vw5do72P0b6BM2EKR4pd7rDZwc39ZbYaGiUbgjlbBR2kPFAJMTaMhsHxYSFEzGGC9RetqwMOidFcxrtHhGzqbbPYU84GskAsD/Zxv18MQL+JuXrSw5NHPl4gjiUFAVPqUG8LFw4a6hF/JSwOx9rUJ7wsQo4rVm8Y2WzBZRWg+FzdlSiusyNBfAYjnxg9urznHIf6x7giIUjbHJGA919QvIf6jHqWWgqhnsroDuU4yEmOzZ0cTJOWyY5eWVJRWYgVOtVwsaqA3r2rnzuKBw482g+mDxC1x28n8MjH8zm7vW72oiht4yWcqiVrztNfmbB84/WWCSU5cht9ob7XHGkbQgLhRoNLynpmyBHe9O79ltDP9y6rYawfgda0D5r05jBYGFzSNE5rLlEVeOjRvD8/1WuNJ88SiCa9Y0Jhj25aowQ4mVMjxFze3M6SYCrifNW/q+96E2MAfhE+HwIy1Fia628pmEricJWFaPZaxY7v9zz/iKQaIn2ZnBmHTj3SFq3+ToO5a/VbTh6b4YVHTki01r4z5Vi8iTijNidRnqN5BZ2Js4jdwVuCHSCT0aKt6sOsKGArHL/sfdeYAUMnef+sD1X8CLuwa5crOGXZBZJhr9garCPmL8vPJK8BMjkxBwIJOfj8IYcXns0j6z3FTNd2sxFMREbapPNLQDTxZfPwVPLfiJR3Um246dPLgqDgoPDkn X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bbeb37e-3b11-40d3-d0d1-08d90030cd10 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2021 17:06:25.0526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b3iKqFaZH1uXQmT9xGABC9B9ka84t/GSGVUq4+MubcdE/NU4eUikjIWOgWg/Ermq8B7rKj0G5gpyamVa8BkjaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0302MB3354 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean If a phy is disabled, don't use it. This matches Linux's behavior. Signed-off-by: Sean Anderson Reviewed-by: Ramon Fried --- Changes in v2: - Fix debug statement missing a parameter. - Assign phy_of_node only after we determine if the node is available. drivers/net/fec_mxc.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index ec21157d71..59f5a14e54 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -1299,16 +1299,19 @@ static const struct eth_ops fecmxc_ops = { static int device_get_phy_addr(struct fec_priv *priv, struct udevice *dev) { struct ofnode_phandle_args phandle_args; - int reg; + int reg, ret; - if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0, - &phandle_args)) { - debug("Failed to find phy-handle"); - return -ENODEV; + ret = dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0, + &phandle_args); + if (ret) { + debug("Failed to find phy-handle (err = %d\n)", ret); + return ret; } - priv->phy_of_node = phandle_args.node; + if (!ofnode_is_available(phandle_args.node)) + return -ENOENT; + priv->phy_of_node = phandle_args.node; reg = ofnode_read_u32_default(phandle_args.node, "reg", 0); return reg; From patchwork Thu Apr 15 17:06:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1466736 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-secospa-onmicrosoft-com header.b=R1A8miqb; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FLm3L5dQ5z9sW1 for ; Fri, 16 Apr 2021 03:06:54 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BA56A81FF3; Thu, 15 Apr 2021 19:06:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="R1A8miqb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EBACA81FE0; Thu, 15 Apr 2021 19:06:32 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on060b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe02::60b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E5EB81FE0 for ; Thu, 15 Apr 2021 19:06:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KQeW4fC2n9pVTby2RiWYw5f4RrhrSZQ6rUKT3fGR/CVm5DZfvRr+7I+3lXjwhTsi9EvVV+PYtQVP9zfPshm8ExH4gEM1uZjrbxScOzYWnVZ2BK0SR8pzIt9RxWxwxCJYTbvTkK930phFhaeJxlV/rstTnPDeAYxAFPQYdKknmAXAFflGIF7TbOjJRaB/iQcvc2XbYVuv9OHZvJXiiuldNqVE4jgtAx3Zhemz0Zm9RVJ4m++j756VRvVK4l9A6jymTMBCrhjNBEBkyvWKq78/q9lV8qkyiKpeSjzQXw4XOUZzCDMHncTLCVa3hFBnOnEMSE+5ngw/sDnDKwFDH5ujew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z7mH3dtORm7sQih4HGDnPLM6UsykqnmIohkS47SaTtw=; b=Kp4jh4Q+5PY5eTs8lz6GmalDthoaGtFYAacRcvZC1hCTQUkKRFzI38hgHTQCnLW8TYNz8ZieBDcbrYIx7+siyUAVQLmNzxk10DoaoZikJgEKVUy2pM6aRCPQgGHX50pp4Oz9cB7ERZxLtyhCkH88Yv3ebbrkGFuawVBgLtorWVCEJaQPapp3YkN1qbqGUSHqKCJnkQgKEpc5Erb6RZcfZDwaUPbZhzjCixxyNPznLdLrE/eZerCvPrEurq0DtRycoc6LxVyfWsAG9kdUPTS+S3fqDwIZuD/RquhJ6hoIhg3PDwjNnLHpbBBqFDga/ze8fhKPjjISMlotTtAffWbqVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z7mH3dtORm7sQih4HGDnPLM6UsykqnmIohkS47SaTtw=; b=R1A8miqbyBli9DaxS5z+CRpJchqPoEraC7LCTfNA7Ngpgh9xxo6i1049LTxES3YjoQRDuFGd9GJJV65cT/NTNyzQqaDTx5DRLDMVUGoD7BWG15HS803azwx1XlJakDwDnNDU7PwELcAuZ+ZLqIEUS1Ab/c3l2qYE72nASQ6LT4Q= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB3PR0302MB3354.eurprd03.prod.outlook.com (2603:10a6:8:a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 17:06:28 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9181:c45f:b367:9bdc]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9181:c45f:b367:9bdc%5]) with mapi id 15.20.4042.018; Thu, 15 Apr 2021 17:06:28 +0000 From: Sean Anderson To: u-boot@lists.denx.de, Ramon Fried Cc: Ye Li , Fabio Estevam , Joe Hershberger , Peng Fan , Sean Anderson Subject: [PATCH v2 2/2] net: fec: Only unregister MII bus if we registered it Date: Thu, 15 Apr 2021 13:06:09 -0400 Message-Id: <20210415170609.3399111-2-sean.anderson@seco.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210415170609.3399111-1-sean.anderson@seco.com> References: <20210415170609.3399111-1-sean.anderson@seco.com> X-Originating-IP: [50.195.82.171] X-ClientProxiedBy: MN2PR01CA0023.prod.exchangelabs.com (2603:10b6:208:10c::36) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from plantagenet.inhand.com (50.195.82.171) by MN2PR01CA0023.prod.exchangelabs.com (2603:10b6:208:10c::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Thu, 15 Apr 2021 17:06:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 843709c6-e315-49c2-c2e7-08d90030cf10 X-MS-TrafficTypeDiagnostic: DB3PR0302MB3354: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xX1ItJmoQExiwIX45i1vnZ8qqlKkUcemUH4OW4rG6YZXWQQRx09JkJi5R/UYkc76N5uX7nLSxYvGxurtYQNoA/5K4oQR5MS15n6c0S/Yc8InUmAh8iKX+JZO9eZPU9ugWKz8sMJ7eonB1o3EBzY/orXj3uU+svV+0Uw3Y8ZjnIgelzychdkC7dSEs5cP0XIV3vBy8zbCixJAInrAlWDMtH0ZNPVngWsxzpuAhtq1w28sfJw2yI67HgVxcMvrJgJ2aAGcR8+6c/4bLPkXoCLtWMSkLX4X/1hLGmRqfn+hUnJ4Mmrq36AIt6dlbYeIRVkc8K1J9t8wYjp/Cmdfo/WFhcv5yS6RsLn5ZDTjAAWYskkXkrmxrZe3fRhuKqsp/vaVjd83Tn6/sP7+44X5Mtfp/9cRDF416qf0aq/yW77eTC4qKI/sDA1jRht2iTVrYVo/9ezMdaN2S5slttR2g3J+8GhhsvIM769+eEA3AI/W0YCYYVh6P1ojEw4zoxO4FbZ+W4uyl4t8QPhWQWopFpsQk6uFxEofNzfrGm74n9FO5tZbFcm8P2p/J0DSJE2bQA1ulkuf6jZ+xWfJ/oK1lCGusZy+DzEg7575Wh/Mu2x2rWOmBPaZGBvj8MpWVqE2WFgrwUBVv7rM2ytWDyq0CwxHbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(44832011)(8936002)(1076003)(6666004)(36756003)(5660300002)(498600001)(6916009)(107886003)(66556008)(2906002)(83380400001)(38350700002)(4326008)(6486002)(38100700002)(26005)(66476007)(66946007)(86362001)(16526019)(186003)(2616005)(8676002)(52116002)(6512007)(956004)(6506007)(54906003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: O8c0zrfXcA7ws4YVohXpCeGcpoZaoAKnxpRmgNgIjFNqASRJZjuYbIIqkszX/jWecGPUL70/VryGVjs1UENEDahWQNBjQL2MzTsswZtY1rhxsszzzPPqiOEllM7kZUc5LIiCfhgyVpLjupTc/d4e4Mttuh6T3e3c95HshBNCanCtidMaGiLw2yAizZS1Tn61dhSC8anFxZgqCr669YyrRQocWauoA2R+2fyGt5MSM/76MHFhhQuTFGqRDqkt/YiqMF0vCk7NCFrg2IvBTrvALx8dU2o6KlpvZk23dJKE2lFCmddRu1ZSsB3suUCVGTrebxA5veVycAHBQqIuzym3OjkSWrc4Qd/6X6d5EUPPmbORdM33BwMedXPNrDNe8rPhTxKDkT+kZypW8v3G9JVNFutDCNgxMK8yNskvFV/l+fxLVhn5E27xRr7dNguPFtuVEzbwaWHysLpDoh9Mhai6kZ+za7iR0zsuBSFyfRkU/MeZwHjdDhhufRXgVhiCMxD6SHkUSUx3TQHpJ0icCGdxglpCAyHSzXnXfLfSuOT6xZoaENDa2LVfGlalvWnomMyPxA7H5aiacQRmhJuCRnaYG51rbHaDqcJj85zolxcpxHdKDIEeQODMsiiDq74rH7+8p1pD++blz+XpTAjp2ZdMkTa7lmgxRnSP9HoZnRBbOQ9mYrtV25LdBZxXMrTJQIlorklJkHsNjFMsCTg9lwn3atFCDMhAGnjmemmLxYpFz5jCF06v2y+g+KkCEd6i5B4tWyKBUW4WFopxRSZfMndgMK9lWN1e9Pc68n/seVwxPv+KQbeAF1znbf/0B6LDeKoUi8aVkPjZ/T9jEaut+CwwqtTNi5WPYK2F1hAdQ39BpQJq3fG4TA+tVcm9k1HmrSWpHFEzd71ZVzGhItMcbi8NanEeMjtStZFoSkn+ZossBQYZeSuw7TYRoIyDyazPd3c1XCeuOyZiLg2YZxvXodSerFgQFVUC+43m7i8YG9XDFSwG6VHXJoGJxLhDEuv5OU56kF+teY9t/YQq5CSSHUEoAz2s6SL5s8P3yFFHXpBZX5PVyvjjs4YvqEaSgTAs+V8TezVzIlKKvgZjsDCLWE8+RwsgAPF9Lds5kYQCeFkhNwsaM4QdPShKaueGCTQb09z5qmSFGuJVus2IcY+sDQVnNor+6vANsoBWoL3XGfq0u/jsr+eW37/x73N7y98qHankmq8XUDYoNjogISlioBH8ZiFD+JfwaJCHP8DdDBTy8h3FlRSXTjOQ+ViAcxC9u/jiNtt7HMRwL+gtDRq5eWQe1MaPd6duUCy44mdhOgjo37Xn9ybdhYVaOUUjTsixB7rc X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 843709c6-e315-49c2-c2e7-08d90030cf10 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2021 17:06:28.3197 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W73guCtZEr1F763P9E1j/wL33oPuoXUIUJ60Ulao7OfSH3Lbrt0S2/swkY5LNi/yCw9oP56QYSxBy8vAG0GwWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0302MB3354 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean If we fail to probe for whatever reason, we cannot unregister/free the MII bus unless we registered it with fec_get_miibus. This fixes FECs sharing an MDIO bus from destroying it, preventing the other FEC from using it. Fixes: 6a895d039b ("net: Update eQos driver and FEC driver to use eth phy interfaces") Signed-off-by: Sean Anderson Reviewed-by: Ramon Fried --- (no changes since v1) drivers/net/fec_mxc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 59f5a14e54..4fd5c01b4a 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -1355,6 +1355,7 @@ static void fec_gpio_reset(struct fec_priv *priv) static int fecmxc_probe(struct udevice *dev) { + bool dm_mii_bus = true; struct eth_pdata *pdata = dev_get_plat(dev); struct fec_priv *priv = dev_get_priv(dev); struct mii_dev *bus = NULL; @@ -1462,6 +1463,7 @@ static int fecmxc_probe(struct udevice *dev) #endif if (!bus) { + dm_mii_bus = false; #ifdef CONFIG_FEC_MXC_MDIO_BASE bus = fec_get_miibus((ulong)CONFIG_FEC_MXC_MDIO_BASE, dev_seq(dev)); @@ -1507,8 +1509,10 @@ static int fecmxc_probe(struct udevice *dev) return 0; err_phy: - mdio_unregister(bus); - free(bus); + if (!dm_mii_bus) { + mdio_unregister(bus); + free(bus); + } err_mii: err_timeout: fec_free_descs(priv);