From patchwork Mon Apr 12 12:16:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1465210 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=h6QCOqh7; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=dT21KZeY; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=iREHUNOc; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=RtGmc13H; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJnmq5hqWz9sX3 for ; Mon, 12 Apr 2021 22:17:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LLdtodU4pMSzyezX89OOKgC4KuapaSnWr3xKCviVUe4=; b=h6QCOqh7PW8vsw7Q2fSLZ6kBV YsXe/WHRbTj0ymlBauJS035dsqiF0UN8YG3U3qgyfrYmmWFEOdE9+7i10493jln2BIhvWaQ5vgScR YYt/AMvFIync8Ie/Sj/ZW9lr5qnNiXZfC/b/humsOfNbN8hXGkThF6gceSypmIwGRb0Q/u36Ga3ir xtWz0uYV1YmY9g0CL8JYOIIULTxy+8kOe2zxmXk0BxJptOJdcLggVVns3304njhIUdqs1GXH0ABeo WNOD3CMWwsd5j32s7FKOVb5/XSPMv9Fpl11yLyL0vdzEVbAEIedXQx7HqQnzAIuNts638mg4yICPI WybicxEBA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVN-006fBh-Kx; Mon, 12 Apr 2021 12:17:25 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVI-006fBF-Ux for opensbi@desiato.infradead.org; Mon, 12 Apr 2021 12:17:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=Q0X1qh9RU0qhCN7n9pwcMXREBLRvFqQi8UaYJufTJ9s=; b=dT21KZeYuOg8KHkFz/g5IGdjfh JjHaBpogEuP/TyOTzTDjIFIP9+HNrHazbf9X3fWQUOKiwMN2YRWKOpvbygu0A+AWRRCA4RwCuPpYa gjFXR5X1ei8FnPAu2YSThSILjrpesMwP5/pn4XdAPNSVIKoVjWkYewDJFXy4Bk1aMG7lrrb9sHfxd 940jQzijhvo7CjBTAZgHrkA1gK7xkSOe4SqLchpFop/xjXmHFyhAtPpUF0czDTtmNYd2Ca4+eIYSx J4dyo+O+kdr6/e+8LDXgBNy26mifGfVWPc2QJ/3YEvEREXm/IxZAAPjBPjuW+01hXbCYx01t0QcfA xdqK62iw==; Received: from esa6.hgst.iphmx.com ([216.71.154.45]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVG-006DBR-Es for opensbi@lists.infradead.org; Mon, 12 Apr 2021 12:17:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618229839; x=1649765839; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=oomudzASR14C9/ag8+b2FlNVwwl2hYoBbye2Lzdm5VE=; b=iREHUNOczm44WfsJZi8zoTp2QMUTHKBOEMOetVIhTzZ2tpd/6cI+EJ8i CRA2W7w2FH04yUkJNuIglNV1wE+0f/D7xXlCUSeSsqZcP0vAyR536IfRo 25xh72bQCN/WaR8uZgJoSLNdyvoHeTMA9XjbLXrurQ8Ax3Vl3ZLDn0cN9 OzV4APHxrlqAtPjebA3A6Ta3aJAj/obZqp2C3o6V06OApRY1/IuIGjgYb oafmLGC7zvEtBFAFIGw/Tf9uxc4Z4gxPedCwXbLplkqdt8E9+7HM4XnsN RBeigxcY41ETbnDkNpCSgwnY8WiNiGMnw2YMlVa/Yk12MEB5MraATBrCW A==; IronPort-SDR: ejBAnkysgreFM8nuP03eWlWCOXXsC182/zcsZb3xhaysULOPk5Nt/AXyCeEXLeGWNyExTGWguQ PpJnPofJSIlkkNC3AotNcQFL1hkjK3P8vu18cqKofEgGtXa94zXBpSLvoGB2ixc5TG8HdAdagi 6VEqN2+0ACdIxDPRy7ush+MOBFX3I3xUh+ZelNv40BCXlF8rIUHDfwoHR1zpbHR8jIcFm8swML llmib5clLWXWP1gNkTZGzevpa31AYOYz/s4sgYC9pFEHppPZ1T0jy9IglEK00C6PQYUzDQiRBZ 6gc= X-IronPort-AV: E=Sophos;i="5.82,216,1613404800"; d="scan'208";a="165314310" Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hgst.iphmx.com with ESMTP; 12 Apr 2021 20:17:05 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZfFjuE5+8iQahw3S6O/geuYA+lsTArC29sD6oeapCGSwC500j9u3HV24LPAirvwsua2mHXl7uXK9LxLFxlDVqMc1Zlt2w38hV/fcUfh8fyIDQhETRGIVf11Mwvra9Gh34h5aaoJ9B+1Lr4+SwVuz5mTrGJrTukGuzWXqjKqrH/2OA1qkrkaGS44YJnHzgT39KR+j2TNQ1HhrFXGERvjjRZSXkHczhMEqB5ADwqn79WUUSzTUNUAJ8cIaedom2ZEv0XKqRc+e5lpwqI36Qwix7e+nASBp2AfmkcucmnsN1QcBktI0fa4BRXsIywgUw/lM6FQjqKtVWCasi6MRb/2v4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q0X1qh9RU0qhCN7n9pwcMXREBLRvFqQi8UaYJufTJ9s=; b=RgZR/x5gIFyfbs1CwoviSl8docrGPamjz9vxE7mZf9lJ7hqBJgMWZlhDGIdQ5PIYd5G8piDgr9J99iOKXWUZR6DizJ5BD9QfHXBZg+if2vYWv4QSatM20NjpZ/oYNdAC1TE8vKwE8lN9S07MRxW14EGAjY6FWtLY6uWX8vH0G7DMgZyQ9zArl2xzhbXNV+AG/dhB8JNGyJgBAyTfl+E/sWfSAfEFuiBQVawYkIa8fY1r7TEU3kIC30t5+qGafU1K8b3AROp03E7bI93KJHHyzSI1jthNyXOuwQQARzxNYNQxcWF/6sDHVbvOiPN+fMk6Az+Q1Iy6xO7EKIrupqeN2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q0X1qh9RU0qhCN7n9pwcMXREBLRvFqQi8UaYJufTJ9s=; b=RtGmc13HclJEpQwW/D83gQB563/eQbkzZp3WE/DATDowRRu1Ui34PNPHN8FjhZcD/F+y5EBv70W8YHbgqXg0pVvRM90xxUXcYslK8RaLHYt3mY0YfAqbTE+9vu8xKAJHb7r4j4C3gon+TXBACRLYKFPlIe1s5LwQ7dqwu6K1gvE= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB4394.namprd04.prod.outlook.com (2603:10b6:5:9d::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Mon, 12 Apr 2021 12:16:58 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 12:16:58 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel , Xiang W , Alistair Francis Subject: [PATCH v2 1/7] lib: sbi: Domains can be registered only before finalizing domains Date: Mon, 12 Apr 2021 17:46:11 +0530 Message-Id: <20210412121617.933493-2-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412121617.933493-1-anup.patel@wdc.com> References: <20210412121617.933493-1-anup.patel@wdc.com> X-Originating-IP: [122.166.88.44] X-ClientProxiedBy: MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.166.88.44) by MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 12:16:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de70eec4-0ae9-4724-13c4-08d8fdacde37 X-MS-TrafficTypeDiagnostic: DM6PR04MB4394: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4nfaRYeGnmuKwX6qQ4EvnPSIe6zKL6QPsa++z0oiAxFtPFaDpez/esLblxB0Pza2OCHzgkQhbA8LDM7VmU2/NAn6XpEErMi+NKoBCPXyAjUxK/EXjzgGxyKBovx0BVfsr5Mt39EoRbK3LGEBpW0kf9qzxUlcwCCRYGhg1RTFTGM0Tb+jsJ3XcVekYMkwsQEjngtBc8fHt7etDgqeb3a5GXxTHt1RE0tsoTw406nnCD7RgNAMXBhoGmrZLDdLVjAgssRypLvjj/zarC6pe1c+n6hUMUKXf2YWJ8eMxvPlknsuDXdJlnc3nxdlIqZNiIqVskYQnzKI6+4yBZRNNETIbXCx65hdb7wHC5gyY4EgVRMbQRkWaqdGNCTyMSfVEnTpqDu7f3w98rOva2BftnU9yja/AFmyktqtPuRj1p1QcpivTT1uhNyduBCcyJxr/fQva8Y7ZHZTFWdaLl28t/n3vyNpQA0sdAAjZ4Y4ssl37NzIPcJOaKRPsvD0dCJUJk/1toas9SkG4ceokWx7Pu9hmJDtcawacX+WnSB6xhzbpv3FnYQxaYhW93RFW8anDcVLy5vft3hNsBskGRM3vBnZDW4RShAw9dnuFof2T8GUe76dtv7zPqJYUqHIRzuBNRUSgtFtu01/X3pzvtCkKnbtf8pL4hfq6Z9OSdZ1fwHwPDyvQI/4swplSLXPmzu1BiSC X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(366004)(346002)(376002)(39860400002)(55016002)(66556008)(66946007)(4326008)(186003)(66476007)(16526019)(478600001)(2906002)(1076003)(5660300002)(36756003)(8886007)(8676002)(8936002)(52116002)(38100700002)(6636002)(110136005)(54906003)(6666004)(316002)(83380400001)(26005)(956004)(2616005)(38350700002)(7696005)(44832011)(86362001)(525324003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: xYWqtr8oyx0xn6S5mW1RaeIQEsWLt/UwDbH2uBLKL+HYjM6QR/SPbHEPHo67sAOLvW2kqzBIBA4x2q+hpWcWaNT9fSzLd8HpGAMF3HgJocWz2wLPm46A+wcT8JIHyagMZZ4XhSzYBDT4qUAnB+toh5NH+/5K5gIuqsjucX72JpRePV0ajhxqlNqQtAvk4qLFcaGGqUAKznC9xKXvhSi3exzGqeBO2shQQo4vGom9sILwvzZhDzq7mGm9b9x6sxMLplZJdvKlX7XGh2T/h+escQ54F8GeyTZwfhq3EB3tKbvom88e+sITvUgJbVOvwA72RPyXhW4tgi5WAoQC4fkYqCSgXHX5MCCRGxoAQZSWG2jaO5C//VdvF4+/56O1VudHyfjMgT9pkZ2Pg760ggZVhAwoLT0ppZaZ/Gbl3tj4gnRDYR9/LgYFZV8nrg+fmv5BBMk+cKCQb3CfGY5+xiZn65xfODadqlRbFw/yodQdIAE/OEiu+MBFt5CVgfkFZNA/zqf/Zffqq60WWq+/SWR8BWUa5+sPeGN1RQtbDLEjHh5cK7CSmu+Fewx144RBMSXzZI7aBspXRCrTTIA35AKGMwWzHmI9i3WrympYdJOa09xN+8hQk0ZIODTvingp0T99jr9M1Hq8uEMj6JD9nRqR7gnLuuZtmkjpDH2WBYdobMY9DAyZ7AgHLZwMM5edgVlEolVN6G0rC5pMbCA+9+Onn+9T9OYOL7NcMWE0JOcs69HI0YTukIUmjsn7+8h+U1cYW2jd/QPe74df4dNV3hYJkfZN1DCOrAtvNpGdfLnLb1CWt7VKj+s+ZRkzkeHilnkMtqMRrQeH20sXEv0oy1bj/710Nfmqprc6fL0znz2c7Q5cq5HpYozO2lr8t+ZFjm+ckjhaBXAWSbsKisrNfpSNqPRzP/1O0ZA60Tb2VZiJgqcH4L9JSEWmP3n4vUUV6JcxP2sBI/rHCE8+hDttMAMjoA6EWw66NRv+Rz7Ec7hAX2HSpE/2KcsJa9D9WTfftswIg2PXmSTOQgFkQ+yHkdK1QELc1bNyisBMxlq8qz0Vp6bWJaf24cmVsFomu3xuA+48L0ca3sWwLgAhSlqE+nQeAAH0plb5JZM50nYDQzsf/ZA06YZbD/XuxeskDmzzUtC3d7ZMPBgm/O8FesmnMsoocLQI+FUp20N57w5dW6idsXkfA4DAuO+3IBj1EZThmro18m67VV5H0oIRhw/GeuVW9R8dgGfA3Y+ndKVjVAQkeAXjdVa/csdAALvZVvSM/YHX+utjNk/TSjRlGN9usASI4vrj7btTCTT0sF72BsXnMune+MOYSXzlj2cBq14ULk56 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: de70eec4-0ae9-4724-13c4-08d8fdacde37 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2021 12:16:57.8708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0lCc49UkueUWE63474WUp8wxyfu50aZWTJqC5c7F41JKH50bFKLkp6L+lpQq0KkWPnONxb4fH6AKSStHtTShwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4394 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_051718_584701_04A3B16B X-CRM114-Status: GOOD ( 14.65 ) X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The domains are boot-time system-level partitions so we should allow platform support to register domains only before hart domain assignments are finalized. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- lib/sbi/sbi_domain.c | 11 +++++++++-- 1 file changed, [...] Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [216.71.154.45 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The domains are boot-time system-level partitions so we should allow platform support to register domains only before hart domain assignments are finalized. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- lib/sbi/sbi_domain.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c index 195c941..2849241 100644 --- a/lib/sbi/sbi_domain.c +++ b/lib/sbi/sbi_domain.c @@ -19,8 +19,8 @@ struct sbi_domain *hartid_to_domain_table[SBI_HARTMASK_MAX_BITS] = { 0 }; struct sbi_domain *domidx_to_domain_table[SBI_DOMAIN_MAX_INDEX] = { 0 }; - static u32 domain_count = 0; +static bool domain_finalized = false; static struct sbi_hartmask root_hmask = { 0 }; @@ -376,7 +376,8 @@ int sbi_domain_register(struct sbi_domain *dom, u32 cold_hartid = current_hartid(); const struct sbi_platform *plat = sbi_platform_thishart_ptr(); - if (!dom || !assign_mask) + /* Sanity checks */ + if (!dom || !assign_mask || domain_finalized) return SBI_EINVAL; /* Check if domain already discovered */ @@ -490,6 +491,12 @@ int sbi_domain_finalize(struct sbi_scratch *scratch, u32 cold_hartid) } } + /* + * Set the finalized flag so that the root domain + * regions can't be changed. + */ + domain_finalized = true; + return 0; } From patchwork Mon Apr 12 12:16:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1465211 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=qbcO636I; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fTafyk0i; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=Cco+Ozyi; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=txZaS7bz; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJnn83xqyz9sXh for ; Mon, 12 Apr 2021 22:17:48 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zT4YEp3IRnf9hNLZyYQcLGR/vIDjPgihD2PY2iEJbno=; b=qbcO636IxXkyk146pYeKgsQk5 trX23Z24j+cUM6QTMaAnjrC/VLpqvGUL76w/NeH/DfCAdAQVSLPrppefYFSCVsNCwsR415a+mYatv 0TETc3ugO0uhjDoRh3BExVGXhEW7sdEjVVOewdCP74XA811fvCNv3JyoXqWocbhKMePDaaT/lRsfs VDIPiA62AN6hlrIcL9AxcbLAVyzdBvYHjxo+vugYQaUl1AjxEDlc22x+HBOZsqrl6OTCtGSAlgtvD UDUJr0oi5Tt0NqSEvSxCdlsK3ktqXzO4veVSXR8bbiXdPmUQerVBUXxaMe51O2FhL78Xb85D0CFOy C1bC9sH9g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVe-006fDi-IL; Mon, 12 Apr 2021 12:17:42 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVc-006fDV-7i for opensbi@desiato.infradead.org; Mon, 12 Apr 2021 12:17:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=VDvD8W5YqDHAoDYfYtL41TVJNdXPq7J2O6UZMkiEBCE=; b=fTafyk0iji2XvgHF+R3WrtFcek hw0SQEWVtgmIkZZlLIL4721QoE3q50tRTxLVrclunqfJ/SIIZFhgw4tDKLbZHGnCJDxjfLHwh+Et5 4zAjKSTDdKP7D7rjkS8jXHgGW7ZGeNjzrUozVVS1zqMc4U15aao+eJYWqUIDvNDRd9MbtY4mwjdDI 7wITCbIWIWx3FKk03kj00+rYm67LwRnwy17REuSitMwIj2409xFgU5d5ClJcS2VyAg7z9hi7e/ong OX9frhRmxa0I/TbImi/WKtA8lkSzlDH/5O3cMUl3pE0bJAps0YIS/CW+u5gb+j1uYJ6EjTYLklh3k lALDUJRw==; Received: from esa2.hgst.iphmx.com ([68.232.143.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVZ-006DCT-Jx for opensbi@lists.infradead.org; Mon, 12 Apr 2021 12:17:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618229858; x=1649765858; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=8I12k0B78MhqqYGdHJMr+0Kqf1iPEFTxBvreNCBBaWs=; b=Cco+OzyiVRqBsxPe4Sag2rQ0V0N/Mojk4znPeFdVAofyl0d2eLY8GqE1 4X55UDchbaBSGbDVu4LYP9rrrK05vvbgvGBzsG2+cgclOr380p1Tv7JW1 vrtFrS0x1qGdhLjSEQqU2s6G3qtnLb6FaQ4jqgRskI9a8xJNbErzeWwfE OMogM9wy+NPScpFrqehtsNGer2zjK6nFHpR30iIFcybImqAj16udAcpQV wkVxIo/tK/1utty+BpJw9bruBkEkZFKCoX8dNLh174L/Lqz1nJkK59wsZ tn+rNUwuN/KRXU5sgHwTelygbPLnC8CxQvsx8FB9UrqQpuWZD+Gr54CaK A==; IronPort-SDR: r6e1u12QwCxuOtWn491/ngtR+zC5tqmu+dNLvi6V6q4oneVE+MFUfHOof0sNjY+KoMZmB83eIq 4kmrNwiS7OI9hd3I3S+07GLuf57D4nJwN4VjYg8Xn3hgyttVaC3AaZ2h2J8Wzx00Hac7jHFF4B sIueFde1w5DTAxfRZOe6NE+uzfv6VhW1xHIgbVTY/qKffOQrd33evxwLToVcPBeps7qV0VeEUw A3MOYDAfTRfHDakRXff1xJXjqtsClyUJmLb3X/DdmMhGydeyVNcSTz3fA+9euyiV4w5Gjg4jTM rpc= X-IronPort-AV: E=Sophos;i="5.82,216,1613404800"; d="scan'208";a="268747603" Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175]) by ob1.hgst.iphmx.com with ESMTP; 12 Apr 2021 20:17:00 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IQODHcOzh4Y4Sf7/KzCFnebfhu80b2PipZOB3qhDoxGa4whMGNBlDitLzq6lKqrnCQ0O7N1CIoDO9ug/JvqzMF/a929Hj0rWQX1bm1+fqaUs7ZMoVpCQZrcjC9vUT3lW0lIF1ijQH21MKb3/Vf5E3e1WcYK2MdepkFpLtxy6lJtXB9OguRgX1PXqOQ3PtybVpijrGnAEoZ3/LPxd4eUllWLBgAkUACColprLXDi/OxGWU7XbUCQ171oPghXp3pyiCGCSxZo2xvCLLuCphlJ5PaU4jSmbUVQ3mdSUlDKiY9Hp58n50+nkCzRkli4ffG0uDwUjP7HIKztWR3YZVr6lGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDvD8W5YqDHAoDYfYtL41TVJNdXPq7J2O6UZMkiEBCE=; b=EoD+5J415xqW+ZxUW0zOW6KfN+zHeVmS1QgjC/GeKRdjL5MipO3t1AIpmqyU4XV5Ir4WRAnaxIuoHYf5X/CoP9wtV2eeq0xCrJAR7Ssu735AshJ4Bw8juFIi9IxHbGOkfeiuO92UqdrOz2iIn6Of3bGvnafb8GMXPJDJeD9XEfjg3ip6rxpyVkV0DVjfIPlcT6j7h2O7DbVWqJ3IEsml7XOUnNIbe2SuzaMRVlrE9JrTst6OnSvWNYgm4mjRiFpy68zc74dEzXe3YRF5rVof8/U4cwpxTeyvPlavtYGCQ2wLalfw+aSJwQ2sgMC4PKlo3Bwt/lTrWN0EWayZq9s0jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDvD8W5YqDHAoDYfYtL41TVJNdXPq7J2O6UZMkiEBCE=; b=txZaS7bztwW8iQ1kWX7kvlIbc+Ge6EQL6aEr/w0W0YuRBydF1NZAXpJc3HonfjUCHDOcC2/N/VBQT1CtqfsKBLJAQEvSB7Ka5/BvUb/Qk7xf7d2QkMux0hMbT7Ig+vuDath8v0q0OmFnUBnVTXnHJX4E8Jh2t63OLj3Ms48CMeo= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Mon, 12 Apr 2021 12:17:01 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 12:17:01 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel , Xiang W , Alistair Francis Subject: [PATCH v2 2/7] lib: sbi: Add sbi_domain_memregion_init() API Date: Mon, 12 Apr 2021 17:46:12 +0530 Message-Id: <20210412121617.933493-3-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412121617.933493-1-anup.patel@wdc.com> References: <20210412121617.933493-1-anup.patel@wdc.com> X-Originating-IP: [122.166.88.44] X-ClientProxiedBy: MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.166.88.44) by MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 12:16:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b99937f-7603-414e-3475-08d8fdacdfd9 X-MS-TrafficTypeDiagnostic: DM6PR04MB6201: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ije0PArveXNTsgslRHVqkwLqasb7KkMikoMTHDy3Lwp4eanvbf9czVGaAXqSJTqbDKkhdLe30tcyYZnWLip8vJjRH9I4TWUOl+n12Kdx9ALfGQvgQt7OLw3vxFJmh1zx5g67wbsWsavuxhr6Q0g/j2pG5GK5j7eZgdV1Q+kUIjiFoJ+S0cV1OAZgakG/hAAKlFXcKqDCwvxgsb2I+r3tGEr5/s5p0uen5uH/WVbeAqBINxLa4AkEEUgd9JestRV1QgLuTbFHy+CR9VJkYQQDe88Y/TtBiZbCZ0J9n+cE0GAmbqENKIn/gRy0TpWc3ORHFJjh9VCmiyL28IW5rqYj80qVu0SJxkwPz6GN4OmIXnwDTc929NNMkHg6UcC2V+A2jkP2JQPUbkfxbVLRL86wNeH5c8gwkUg6qlQeAZa5UbBjT9OxlZ+P9fB7FrAVho5LpVjCPhkKHFsiVdStBMHauZJ0UluIKV6vWfcg3jplgVIcYrq6oCA+rTBLf9L0W4s1ULTGqQ13XmgzYvGGez3OKpEnJkBHTWDeCV/RBYIJ0c/f6EfEDP0N9rW//bW41hN4bbcu8IVAO8ZJmGTMHfxD2V6Br5tJiv03R2qN84ZtLZJakmmlaIYsm2otlWCqWm5/jXiH06aNfbqabajhd0UuFxzNVkwMigg1QZn1B6k19GdMASfmojg4ssV8fbs2i1cB X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(316002)(8886007)(38350700002)(38100700002)(86362001)(83380400001)(2906002)(5660300002)(8936002)(4326008)(26005)(16526019)(478600001)(6666004)(66476007)(66556008)(66946007)(186003)(55016002)(44832011)(36756003)(110136005)(2616005)(956004)(54906003)(8676002)(1076003)(6636002)(52116002)(7696005)(525324003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: eZdi8a7O1o2TZEVx5D/9mcqupz+QZfmJqgGFwduBpStZqQtZLlcbjPbg2tBsN53zFyaKQeSs30iDNG07Ks9vNjVC+CR2f2zweF5OOKKl4x8ySyLUufKioRb9zXenn9evZ0Z4MBASRqm2JXEpNcg5eS5In4YenDq+keg+6YRRzibzefblxNB0Ls0TUFVCs7Q9ZCgfzGKWv8/0gjY+KhWBxD4zkNi/Psh0mEXH2/NTb6Kzymuu3BHNUlsEIeX9qMY9OTFFsqujeivdSGeFs/5X8okvF1XT6D6Zvq7MDWdxlHo3LGUBU6tC/9Rbu3p6p3CT6ioLEeITlqPQM3ciADjIARDno2aiSLgBG5qorGJlFrOVusWO1QF4c81jpuCoKFjUfLVigJZf/lzWOXeiHhWysMGYDZCnjSLA9+jBGuME01bHsazmxtTorOzl6ATo3twOdqx/iaQq0e5qQaHkm4ZbiEKH2RqBgFSY2GxoJDwpX53QaYTM3reTYNeJCvwblYE/zUzqZkXFP3TdHIYNZNpX2Tx5DdsIe/jNIixOZJ7zsfI4BmFrr0MVliBtB0eyt5rxn0XbZBa8zOpI8TVGOGzC0lcmMaWrChBYuiryOebR9ihgHZBNI18aUQl/qCnK+8mn5WkkuMPMT64YsqJTimmF99mYjaLCoBzYWyLQBObeR8PjmotFTH/BhVSHTjO95vZbQcez+DjvjlF6OmMtaRUtdhx4A+QvvCZmSKlrVVnlSDZjDYpGqucQ7bOjqWQxqaV67KA4XrWBB4wmWJH9feAwbYU8RcyUcZqSbnoX66YJtRMeZ7btTBUPQh5TfznBfuMLrDdKxJlufk9J5URGJM0LkJLLVl77N6nfmIsptWaqWNhbjEKuGFW3stMvETqaNLuVwc8I4zuxWB51XWksn0b4rVazd8Kn0irFDYbrsjb79YVNT92gTAzc5wxnIWA4K3pmBNaXcbQgDeW0q3FQZ1fUWi8f3LifeOKMM0rWHK3s3nF6ZpMW4vCqXFktCONs/YjFR77lk6uxMuZud+iVo2sLHFfofdYfO86LS7p2/HnME5kZYUNTdKbilZU/EtXpGbWVJK4B5dUM78spnYqkqDKdENolahO0ZkCWMHqlzgGQopmR266GWzHtn+Zb7npltcbzfEf0Wr07DhRGZ2Qb1JLDowwmaghHll1RhsXuJWi1aEoZxnH2L1l+t5qprWkn/YyRx6/mt6sf9bxp+hbEpuYReevmiOjKuwIsYw3iy2EeRDeyE865hc5IniK1EVsSubUNq8gbQ0KuYdvYIQEKEgSZkGOfn2NzQceJioFmc/NAmEAB482fLdG0I+JjN9R2rUd+ X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b99937f-7603-414e-3475-08d8fdacdfd9 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2021 12:17:00.9028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ekA5hyoGqttvZubzJeUqmarZSRiF0WbFrvU+8ujVDDxLgcOcUDxok0ECTP8v2jIPl1lejK9zPs2mtZ8gP9aT8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6201 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_051737_739822_7BDB401F X-CRM114-Status: GOOD ( 16.55 ) X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This patch adds sbi_domain_memregion_init() helper API which can be used by platform support to initialize a domain memory region before adding it to the root domain. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- include/sbi/sbi_domain.h | 14 +++++++++++++ lib/sbi/sb [...] Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.143.124 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This patch adds sbi_domain_memregion_init() helper API which can be used by platform support to initialize a domain memory region before adding it to the root domain. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- include/sbi/sbi_domain.h | 14 +++++++++++++ lib/sbi/sbi_domain.c | 45 ++++++++++++++++++++++++++++++++-------- 2 files changed, 50 insertions(+), 9 deletions(-) diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h index 1f8b942..f9f4f7d 100644 --- a/include/sbi/sbi_domain.h +++ b/include/sbi/sbi_domain.h @@ -127,6 +127,20 @@ ulong sbi_domain_get_assigned_hartmask(const struct sbi_domain *dom, /** Initialize a domain memory region as firmware region */ void sbi_domain_memregion_initfw(struct sbi_domain_memregion *reg); +/** + * Initialize a domain memory region based on it's physical + * address and size. + * + * @param addr start physical address of memory region + * @param size physical size of memory region + * @param flags memory region flags + * @param reg pointer to memory region being initialized + */ +void sbi_domain_memregion_init(unsigned long addr, + unsigned long size, + unsigned long flags, + struct sbi_domain_memregion *reg); + /** * Check whether we can access specified address for given mode and * memory region flags under a domain diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c index 2849241..164f35c 100644 --- a/lib/sbi/sbi_domain.c +++ b/lib/sbi/sbi_domain.c @@ -72,6 +72,35 @@ void sbi_domain_memregion_initfw(struct sbi_domain_memregion *reg) sbi_memcpy(reg, &root_memregs[ROOT_FW_REGION], sizeof(*reg)); } +void sbi_domain_memregion_init(unsigned long addr, + unsigned long size, + unsigned long flags, + struct sbi_domain_memregion *reg) +{ + unsigned long base = 0, order; + + for (order = log2roundup(size) ; order <= __riscv_xlen; order++) { + if (order < __riscv_xlen) { + base = addr & ~((1UL << order) - 1UL); + if ((base <= addr) && + (addr < (base + (1UL << order))) && + (base <= (addr + size - 1UL)) && + ((addr + size - 1UL) < (base + (1UL << order)))) + break; + } else { + base = 0; + break; + } + + } + + if (reg) { + reg->base = base; + reg->order = order; + reg->flags = flags; + } +} + bool sbi_domain_check_addr(const struct sbi_domain *dom, unsigned long addr, unsigned long mode, unsigned long access_flags) @@ -507,17 +536,15 @@ int sbi_domain_init(struct sbi_scratch *scratch, u32 cold_hartid) const struct sbi_platform *plat = sbi_platform_ptr(scratch); /* Root domain firmware memory region */ - root_memregs[ROOT_FW_REGION].order = log2roundup(scratch->fw_size); - root_memregs[ROOT_FW_REGION].base = scratch->fw_start & - ~((1UL << root_memregs[0].order) - 1UL); - root_memregs[ROOT_FW_REGION].flags = 0; + sbi_domain_memregion_init(scratch->fw_start, scratch->fw_size, 0, + &root_memregs[ROOT_FW_REGION]); /* Root domain allow everything memory region */ - root_memregs[ROOT_ALL_REGION].order = __riscv_xlen; - root_memregs[ROOT_ALL_REGION].base = 0; - root_memregs[ROOT_ALL_REGION].flags = (SBI_DOMAIN_MEMREGION_READABLE | - SBI_DOMAIN_MEMREGION_WRITEABLE | - SBI_DOMAIN_MEMREGION_EXECUTABLE); + sbi_domain_memregion_init(0, ~0UL, + (SBI_DOMAIN_MEMREGION_READABLE | + SBI_DOMAIN_MEMREGION_WRITEABLE | + SBI_DOMAIN_MEMREGION_EXECUTABLE), + &root_memregs[ROOT_ALL_REGION]); /* Root domain memory region end */ root_memregs[ROOT_END_REGION].order = 0; From patchwork Mon Apr 12 12:16:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1465215 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=ds5VSBNY; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1OTsMTCG; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=lpSNA9gy; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=uWMe0TaE; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJnnb5Xcmz9sWl for ; Mon, 12 Apr 2021 22:18:11 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Dyg9wWunAwCjStH+MngEQehh30jreI2DA+rDPsdR3j0=; b=ds5VSBNY7q7EeVZewxYUEsCaK omgUZC8rIrnqJL8P7Nn2kNhh0lEuTOk23UTuQmk4OGm7rcy8HeJNYN4zWZnhVL6uOeV2Cbz69GmVY Gx+/OjucmnlPBxtRHKP0k8mI6XkORdaHImv9LGdFm3Pgf3qfkmlYYpjse3ToaJvjYaltMoGrq4ekd DSLvRaC9PFD8qeArJHbJmsy4pyBKWNS4J8Cpy0uheWs/ujUqZCSalX9JpqbjsNNWVDMs1CGTYqIPR gKUwiXejNlHjBJdo1jL9m2sYqaYvqUTUdrAHBbvgd3ZSQFM0VM1vWScMN9jZWSlvBSkfScxbo21IH kdXSNtbSg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVvW0-006fGr-Kw; Mon, 12 Apr 2021 12:18:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVx-006fGf-VI for opensbi@desiato.infradead.org; Mon, 12 Apr 2021 12:18:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=2n1y55yAcT6kRxF8JllxgrDE5mRU/1y8/CJ0+CpZ2KA=; b=1OTsMTCGYWbOqzscJLxzVqCMsW I6NYF1qau//ToC/zY+geRHbFCeLd8n81uA9V316YHPddXWG98Kf5F073Vo1G9NFJvkih0petSQJKF lr4BiR/k+yI8eNHcqIVN7fgustvOAg/9fqnHqLV63RDN9ikO91c0Gfl5gY+2/noDN2IJnB7djchbh oiEd04GWXScmlU7idsYfYeRqRL0V4ltGUoq+v8tfnMr6yYByW6t9dWLbVR98V79ThdGq1kni0F+2T v5ChpeWxg/uBc37Kg14dlzNfLDeZ48e5Dp/VXvpLNC+1y6cV0IB94OzfBlwfrwu/yz3vwehWnkl6c n1OuQ+5g==; Received: from esa2.hgst.iphmx.com ([68.232.143.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVv-006DDS-3l for opensbi@lists.infradead.org; Mon, 12 Apr 2021 12:18:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618229891; x=1649765891; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=Xtowb5s8MmR/GUQdjan40alIcmxoWx7iuNJB0jvMvsw=; b=lpSNA9gypSFirY/8855XuIUnFd3vy3jPKDQpoqE2RnhLud5FarQ9kiro fgBkW9cMGrWRzO4PaH88865C8LQlIafuelRQCbkUvjSkzjmeHC9n+Hrlf nQqedOZmGm2fA1kAe/r4rxTMSie+gHZYVFrzRUkfRJoEaBvBXgTDLczwT TiTN+tL3baAWADczRH/68/G+rCK5cZ0QMRIsVnh1rt9JCGI4RnoK7hrb2 uTDyUvK5EUerjgu3l3uyBVAN7Qs0hpj18JYs81bi2vcnAPwPtr2MWIrFs j4pptXJsCyfxOeF2iO/y8o1tJppLOJKxN2Cr9jz7mnDR252xjMDP7M9F2 w==; IronPort-SDR: nxqJO7SsbE2Ft69BSjEdwOSdVHKNje3WKF85w3yXfzCW7FcGgMC0LQxysg1mFxhwdmPGSPdj95 ZUlEjRm2mhicG+umltIhPvIXeIzvjZop3JDifXdarudegICNfmuQpZaf8mDx2VBWV3JDE/6TYL WbLyk8JBg1M1ueFko6Nw+DXm+DXtSQ19PRIUs0sndLPIDR21PDiEwpkH+eKNekuGUvUSSNYKp+ Jr+F2nbUA1XNuYPxrY86fHZQUtgrp61e4xLF7rj8EqYjN0oSkkyg1eTFHhgX9HpCwUQFkVFfkX 4jY= X-IronPort-AV: E=Sophos;i="5.82,216,1613404800"; d="scan'208";a="268747619" Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175]) by ob1.hgst.iphmx.com with ESMTP; 12 Apr 2021 20:17:46 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HwgeHdyYn7Rb7XFkB/e6ZHRnDtYo5tqhbMmGE2EJOHwNFdEBJgLJfpGnpCYyvEbSS/aHJwdeajsVAQMh4Z0GI9ogus8AIwGpgRam5Wk1XGmxZXKstZTktf4yWZ9HAuMRZRWHhjgvRF7O7iUIQnrm9hjIj2nJRmeth+89ZgqKmMscFuhZZsR+rnrQr3QaQ2bgqkAw7AtyGu/o20a7gFadXZgWMpLEcrb0U86eewEV/YfHwb7zxMy5Nn6XBDtRJvgusTFZPP1wOPYmaVpayOzc59koKsfYYMvmr/Xvm481+DFlXH3S/9HKzzCnZUgPMIIe9ABn/KaKKqS6KmrtnzL/SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2n1y55yAcT6kRxF8JllxgrDE5mRU/1y8/CJ0+CpZ2KA=; b=P1Ftg5rjewAOVZparPPnavfjbVL2tgsmpOH6EJz1wIjF4/1Wu8ygAIHxKtylamqBIHJyMXzxHJemkmfVW/t/0ePhCjCpFyQeWil89wXRrHp2Br/aX6cTOmQIj3i+4jySKG/uozfJjfuVb43v0h6jZY3qRoWyIjJ9yLdE2yPHBllgKAnDoamHDRZ0VMH1brXyGQSvhQ41mpzwWDH9+EcuUV2kMQipH+rFq3Gy4WMJ+nyFm6gHvkcZphHR4Q8VPJ1t9qSamUyjsEV5+Qc2Bm5A3uSL6Su1cFRwlOompZ9VURTJBITH4rHsMNYuecgu/BXHkzyvRZdY7WdQFK176FKdcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2n1y55yAcT6kRxF8JllxgrDE5mRU/1y8/CJ0+CpZ2KA=; b=uWMe0TaETqbNoK8tg//atIaY8GPP3a5KlaGrvyMsFy2YKTstlGjMHyL8EvTexADXKrwugcWyCX3LmeVXCW4mICgXzF1uFyUcHD8y7kT4bhEHnyBifOA7/FAbcoH6Q+mz7qWo9WZMylJzkHdIm2fvZUFV5q22SIu+GDIiYgla4iw= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Mon, 12 Apr 2021 12:17:03 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 12:17:03 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v2 3/7] lib: sbi: Add sbi_domain_root_add_memregion() API Date: Mon, 12 Apr 2021 17:46:13 +0530 Message-Id: <20210412121617.933493-4-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412121617.933493-1-anup.patel@wdc.com> References: <20210412121617.933493-1-anup.patel@wdc.com> X-Originating-IP: [122.166.88.44] X-ClientProxiedBy: MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.166.88.44) by MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 12:17:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4509afd8-9a3c-4f9c-1cd6-08d8fdace17a X-MS-TrafficTypeDiagnostic: DM6PR04MB6201: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:849; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: st5t1p/MNG4KUBexdaUtiNEBIfY6wc7bRyerxV4IhH/+kRUgo73b5wqBmBgSP+3fbhuguVOtSBBJRyPf/ih5kcMCFb6eXpXIF6JqQlm9ChueG+XsIudALcYnK4kzvmKAmqEiarcd8Mh3GyaRYYPxsIbAa3Z1uvT0CpJvBGnP7IkNZf+6kglZ8st0eGB9uiCORGxsZwFFuLY9OYmM4yyvCg2O4QV8Dz3K+gjGgLuBjgvvkOPzlKoo1lFahG8pMbJmR3ShOC+IKk3MpXoimcLya89M90aJFYvl7SiOTFtb9ocJDS6wBWj7VcORzn9YouAigSNUGugf3lUp5y82DNm2ZXYTZTdb/j1dSMzWwEKCuiKGmTUYGed5PxKisuqEbCi7mgPORwPEO0rNuC8Rv8xibj4ztgPfqVqBbQJQd3qGPlpLIiIs/hpAp2MJY5zpeuEVwWsGkNqcc8IlbbAN3/LuxPBDC9wvDApkKhurRvFKRD88tLfV2iZ4sDsQouIw2P7v77SA4c1VxzA1eLcrFdS3DaAOZesz6Imn1gaQ87pNKIkCWF2P9tPLKOIeGXFp3HKSZUdilGHwwBaFT7f0/vjUeFoHoOwxVGLi1TEizur6NyfMNNAaVj8x4+FVhYv0yt4RJ7RvjKzDfXb5/7G4E2ul6ncAZlERYku5Cg4/wryrlHA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(316002)(8886007)(38350700002)(38100700002)(86362001)(83380400001)(2906002)(5660300002)(8936002)(4326008)(26005)(16526019)(478600001)(6666004)(66476007)(66556008)(66946007)(186003)(55016002)(44832011)(36756003)(110136005)(2616005)(956004)(54906003)(8676002)(1076003)(6636002)(52116002)(7696005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: rQhltFXcxNfI4l4cS9Ipk0w7061wiTFazWA8WnIviJAsZDKtMj6xfgUJw36/KndnHW8HVz0lzyJ7SowEdRp+4uK2UdfapfY3d4xo8uUiGCULv3U3fHktkehdBWVDopaCF5Ih7oh5AkXCubOhbMATdm57oTQtn6K5dp79Zz/wtS7eoLRi+4CB9E1QM+6J/fRQtHmP3KhApTnQ79bNC/8t5/VoALB0D1C30HuiAP4fkkwpSdC0AJurrLQb9zgENaV84S33aWTkDc0CQuFrJnV6FJzyIX2Jb90cAgy+6t+x/hb0VL4xUmq3MQmfTGPYHusQY2gIytRhcoIklg/GzCTf+uiwNuinky/W6GwpCSlk5AHXq7rxBkHJVSRYsifc75EYgCuSfIrWCVl6dW02lujgWD2sso/p8Os55gFcu+XOzXeIKI+EeVAjeZddpqgO3VpHVhGKWFvOoNu32USo6JbPF4vDoh7tcO6Tse4t0nsfiJprXV1UCIbO8xAlZC0Gso4CvbQ8weuP3hSGkz+kypOstCC/aX6oWsA7wjD7+FZErNX4dlzVLGOCJs9HjbnjcSvlaqV6o90kuqyL8AV4/wCL4KQsml2s295QimtucuQCOmQRdTv81e/TH2rYEC9zdlylA03oOeJedXHvfOhjFCVX0z/HN0r9YXGFM/9DJ08DTX9n4VPDU7DsWdrjzj64qGMZyPhIovDnH+PG5X9JE7cm3lla98rXmXyeanZ0JTtlxtybA2fUKNN5auFx0PG+7WYrfWXUwng00H/RQjxvzQiJcq+62icTrFcfiJN8mTs7pKheyvD3qwiL8DlYqW275yizvWY7ibvIM4xVczqBcH5LKxKYZhZhXuX3s6vHshklWC0YR9Sp3NHtSRc2CMyUMoOSvCqbYakDdoWmX/hkIHn9igRWTGwKX83lZtkvLEa/9NL92IitgUkupnlc+ANOpddF4F8MIdb9QQomxw2wzJYpQrOdkS+Y+QzH0Z836kpASpUbx85fYK2V3DUt6H13uOdL9FxZvZSiDxPWmQFouwkgwTVm22qK0JbQjwgQnpRfBz3VAmM/zU+skoOTxznTcN9hkbkLsZOi+LtLYB1rOEJR+A3X50u3akRmSQ9vcmjh7saxlZnIXn7wnDe3lJoloJtiLZN3JCTMFivXIVzmM8xP+c+V7Fp4SmfX8QKcsMMxw1hd+NQhgcARFQ8u1xirDj4RBGeh4B/HzXUVSBrukyMl4JiTm9Y00Qg8WZH8YoPzjO1dmhGpIRpULXKrcGJ6DLUeiCPiIpEpnhi98BpFdX49OCIfY58MzV0DCRBjRuE0KQhY2JwrANmIG2XfCMYhQv// X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4509afd8-9a3c-4f9c-1cd6-08d8fdace17a X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2021 12:17:03.3912 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JndzKLtNkFc5t5yxCDO5AqZOA/ZAFRTtziiztYchT9VUlX3G8YyHsyz0T3+lQWMCfGWg4MquCY1GiguCZ+beYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6201 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_051759_315451_AD03FFD9 X-CRM114-Status: GOOD ( 22.99 ) X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: We should allow platform support to add more root memory regions before domains are finalized. This will help platform support to protect critical M-mode only resources. This patch adds sbi_domain_root_add_memregion() API for above described purpose. Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.143.124 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We should allow platform support to add more root memory regions before domains are finalized. This will help platform support to protect critical M-mode only resources. This patch adds sbi_domain_root_add_memregion() API for above described purpose. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- include/sbi/sbi_domain.h | 8 ++++ lib/sbi/sbi_domain.c | 83 ++++++++++++++++++++++++++++++++++------ 2 files changed, 80 insertions(+), 11 deletions(-) diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h index f9f4f7d..84d17da 100644 --- a/include/sbi/sbi_domain.h +++ b/include/sbi/sbi_domain.h @@ -170,6 +170,14 @@ void sbi_domain_dump_all(const char *suffix); int sbi_domain_register(struct sbi_domain *dom, const struct sbi_hartmask *assign_mask); +/** + * Add a memory region to the root domain + * @param reg pointer to the memory region to be added + * + * @return 0 on success and negative error code on failure + */ +int sbi_domain_root_add_memregion(const struct sbi_domain_memregion *reg); + /** Finalize domain tables and startup non-root domains */ int sbi_domain_finalize(struct sbi_scratch *scratch, u32 cold_hartid); diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c index 164f35c..4b5a89f 100644 --- a/lib/sbi/sbi_domain.c +++ b/lib/sbi/sbi_domain.c @@ -24,10 +24,10 @@ static bool domain_finalized = false; static struct sbi_hartmask root_hmask = { 0 }; -#define ROOT_FW_REGION 0 -#define ROOT_ALL_REGION 1 -#define ROOT_END_REGION 2 -static struct sbi_domain_memregion root_memregs[ROOT_END_REGION + 1] = { 0 }; +#define ROOT_REGION_MAX 16 +static u32 root_memregs_count = 0; +static struct sbi_domain_memregion root_fw_region; +static struct sbi_domain_memregion root_memregs[ROOT_REGION_MAX + 1] = { 0 }; static struct sbi_domain root = { .name = "root", @@ -69,7 +69,7 @@ void sbi_domain_memregion_initfw(struct sbi_domain_memregion *reg) if (!reg) return; - sbi_memcpy(reg, &root_memregs[ROOT_FW_REGION], sizeof(*reg)); + sbi_memcpy(reg, &root_fw_region, sizeof(*reg)); } void sbi_domain_memregion_init(unsigned long addr, @@ -236,9 +236,9 @@ static int sanitize_domain(const struct sbi_platform *plat, count = 0; have_fw_reg = FALSE; sbi_domain_for_each_memregion(dom, reg) { - if (reg->order == root_memregs[ROOT_FW_REGION].order && - reg->base == root_memregs[ROOT_FW_REGION].base && - reg->flags == root_memregs[ROOT_FW_REGION].flags) + if (reg->order == root_fw_region.order && + reg->base == root_fw_region.base && + reg->flags == root_fw_region.flags) have_fw_reg = TRUE; count++; } @@ -468,6 +468,66 @@ int sbi_domain_register(struct sbi_domain *dom, return 0; } +int sbi_domain_root_add_memregion(const struct sbi_domain_memregion *reg) +{ + int rc; + bool reg_merged; + struct sbi_domain_memregion *nreg, *nreg1, *nreg2; + const struct sbi_platform *plat = sbi_platform_thishart_ptr(); + + /* Sanity checks */ + if (!reg || domain_finalized || + (root.regions != root_memregs) || + (ROOT_REGION_MAX <= root_memregs_count)) + return SBI_EINVAL; + + /* Check for conflicts */ + sbi_domain_for_each_memregion(&root, nreg) { + if (is_region_conflict(reg, nreg)) + return SBI_EINVAL; + } + + /* Append the memregion to root memregions */ + nreg = &root_memregs[root_memregs_count]; + sbi_memcpy(nreg, reg, sizeof(*reg)); + root_memregs_count++; + root_memregs[root_memregs_count].order = 0; + + /* Sort and optimize root regions */ + do { + /* Sanitize the root domain so that memregions are sorted */ + rc = sanitize_domain(plat, &root); + if (rc) { + sbi_printf("%s: sanity checks failed for" + " %s (error %d)\n", __func__, + root.name, rc); + return rc; + } + + /* Merge consecutive memregions with same order and flags */ + reg_merged = false; + sbi_domain_for_each_memregion(&root, nreg) { + nreg1 = nreg + 1; + if (!nreg1->order) + continue; + + if ((nreg->base + BIT(nreg->order)) == nreg1->base && + nreg->order == nreg1->order && + nreg->flags == nreg1->flags) { + nreg->order++; + while (nreg1->order) { + nreg2 = nreg1 + 1; + sbi_memcpy(nreg1, nreg2, sizeof(*nreg1)); + nreg1++; + } + reg_merged = true; + } + } + } while (reg_merged); + + return 0; +} + int sbi_domain_finalize(struct sbi_scratch *scratch, u32 cold_hartid) { int rc; @@ -537,17 +597,18 @@ int sbi_domain_init(struct sbi_scratch *scratch, u32 cold_hartid) /* Root domain firmware memory region */ sbi_domain_memregion_init(scratch->fw_start, scratch->fw_size, 0, - &root_memregs[ROOT_FW_REGION]); + &root_fw_region); + sbi_domain_memregion_initfw(&root_memregs[root_memregs_count++]); /* Root domain allow everything memory region */ sbi_domain_memregion_init(0, ~0UL, (SBI_DOMAIN_MEMREGION_READABLE | SBI_DOMAIN_MEMREGION_WRITEABLE | SBI_DOMAIN_MEMREGION_EXECUTABLE), - &root_memregs[ROOT_ALL_REGION]); + &root_memregs[root_memregs_count++]); /* Root domain memory region end */ - root_memregs[ROOT_END_REGION].order = 0; + root_memregs[root_memregs_count].order = 0; /* Use platform specific root memory regions when available */ memregs = sbi_platform_domains_root_regions(plat); From patchwork Mon Apr 12 12:16:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1465219 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=C7YzwI2g; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=e3b3cTg/; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=TQaMoHl1; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=Bilpq8Tb; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJnp722qgz9sWP for ; Mon, 12 Apr 2021 22:18:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y4OCo7i3FEUlLiX9dyqgSZIef3aAOY+1WkOGWTmVW1M=; b=C7YzwI2gOd2dIHZyBgUKDLsKV yEFCk94PtxvhCT41ph7A/rVZeFTmdHEcOstZebV2ngK33+QI6VzVdzfr9Qldns++XSlN84NOAhSH/ AEJf7RE42Z63LoWT0f4gpab9rz3dT+MDGoNqQp2qotYatjBWMAq1+3tzVXwITwtsDFv7MStxqGhHV OPBUcJ8OEn17zVovucFncUpFjyRgb4IDjxcFuG7am3QCp7DpWRb79ozc5UtdDbgiwQIPEbeFLUgfL 7A/4Dze3uZesaXrTEv85oNEEU3Rs1gt9DJtplZWYEj64sZz9kpkJjxhNS0aux140AScaGjawaFWAj vQS0XrLlg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVvWS-006fKC-AQ; Mon, 12 Apr 2021 12:18:32 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvWN-006fJn-P8 for opensbi@desiato.infradead.org; Mon, 12 Apr 2021 12:18:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=Tb8p4pvIooFaKOOjWoeCLoam9jkK9nxaxvvstK2qs6s=; b=e3b3cTg/slcluoIJYSItad4VLq kmniOlUqOImrexviy9wPAyiDQfOyXckWHXT8AUNdq/d9KUeLIpuio+ErboJ240yKpBRMZfKOF9X8q +Pp7bOQOWTjgNUgfdWw1JYECUC+tyX3HjwTiyMs50CczcnQtD22QhqDG1gFk+rbXXBERcR+uO1UXk wp7g1WNyV0umg9sK6CTh3l5v9zDlu4mYJgcA7l+IOEIAxjDhFXfF93BzKY4HpNIwnzypDzig1MLuh l5wGq2TJMrcIAaBQ7tj5XLm8Afq76ORvh06huA4UCONMTExX47JqIDZbFR1CPhngFdv8dml4UtMFs v2X2PbEw==; Received: from esa2.hgst.iphmx.com ([68.232.143.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvWL-006DEU-55 for opensbi@lists.infradead.org; Mon, 12 Apr 2021 12:18:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618229907; x=1649765907; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=sndDFZjRJfq/wsWDmlRkluOyjPTadjNhycgUpggpL8g=; b=TQaMoHl1QXpdj2jDdw55Q+ggvCn2VkrfSPINQZL/ca7sDON8zF8csvd2 iuJkOOTTE2dxwfoyCrYNgW3uE5kFpGFO5u6t8XcVA8gjqdzcR0rJIbAKI hl8vhrtk1rCMPVfEbIR6XvSR+9IHeNq3yaHyXLa3I8k6R+KzWCSPCcMza HowBAKBH09zc5BK0U2zMPR3YXQ4frKx82d8K9wLBxqbFNFgkeLnTC5N00 +y/tumbh4imIt5CEYW+riV27ieivZRDLV4Vs8yUZSf8zcY2XBh+PuM4/t sQepQtnuyMFZ3Xpq+96eA3YQo6HydVHfjQDxTNEPJldFwgsVJsoev1qxg g==; IronPort-SDR: oouAdBCmviRMXZEqK1xZBUzVlydAuLH/q2ix+/YYCTgnsU42+5c5Rsi0lirlC0gBvniFP5glTn m/Rm99ZlnaFMfbO7NuLi+yx695C0cDRyUvvX2akmEWmvVlcaoZ/2SkjUpMN0k8GclpFK9yVdXu oaxwFTbAdC5hHvU3PToxMlyYFeomvwTIltg6WMPPbZasv7HyyVynA3X0iN0DPntnzpiLJQ92Bi jZVpsEs5Z8iOVl5cteNiIVSIclGwBpIxuMHOkHDjiMnZVw1HNOVSGrRLPJUtdfG8ulyw3GHiWX mE0= X-IronPort-AV: E=Sophos;i="5.82,216,1613404800"; d="scan'208";a="268747639" Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175]) by ob1.hgst.iphmx.com with ESMTP; 12 Apr 2021 20:18:01 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E3jPBZRW3zo4IaD5VBBo/hMKtSHZUwPzUOnnsp82Oe50dRmMT2w+8cMdl15sziYKm4fFMTbV+QnOVWYsoYiuMxZSMjqDQ/PXm3N0Nuy8zsTuvhPjw0HXQc+6mz3d7MRjoWFfWZF9Q+gXGd3Y2OAQAwKgpIyoMZXn0DaOtIhDwW9brgMKgZAngAehM4zBkYhul5d6ANMPYe56jfyaPu2G5wCsiA3pMCdnqLH352hANiCcZw476oZyuFxK3l2YXVClqoSySrMTaItcBnEw3LuknAC1hlldizw2XQxCUs+r96+jVms2jbL4DAw3kCkpLOmNvuAo8xAMGgqwnKKFoLY6TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tb8p4pvIooFaKOOjWoeCLoam9jkK9nxaxvvstK2qs6s=; b=AjQs9tDFRcXl6IzunxY0RpxTIPKuixcHfjZrRLXUkk9P1+b3EXnGc/vZqtjiw5EIP9ZuatpFv6jqNPxGqAIO3U3/cl9xy62eZ5yqIAP3gZGj5cwz5fKmrgMRNkATnJOzJt9dSzarX1zJgm5RdmQCmdr/O7CJ/TwJCvreeqA4BJjOqvv7OALxVNR9XovtoCY41V9KTNwWJ2lbZmReDSC82IhiH3A0BZTOo9dca9Mf13WYSs9JGO16sRPu/h/hXT+HYs3h6I5SH/WEKeZe25cMn5z+LcMKxSzT3LuSGuEYi5BD2QZxqqaVBKI6jYmSnT5QaIFUBrGQVH3+Sw2VnWevLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tb8p4pvIooFaKOOjWoeCLoam9jkK9nxaxvvstK2qs6s=; b=Bilpq8TbWhLNhMusc/B/AivWlA82UzgU+Nm29xvWF8eE5pQWVvFE7rMEAANQuVW7LjZLWeeTY/M5vUUOObhPDuVRfLi5+7UuxqT5ZqfhgvGm1PxZ5tMBmEXKG344L7oJPZyp5oK29TmrCp8g5z5Am7QHyTP3TWKCHCncoQGMIYE= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Mon, 12 Apr 2021 12:17:06 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 12:17:05 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v2 4/7] lib: utils/sys: Add CLINT memregion in the root domain Date: Mon, 12 Apr 2021 17:46:14 +0530 Message-Id: <20210412121617.933493-5-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412121617.933493-1-anup.patel@wdc.com> References: <20210412121617.933493-1-anup.patel@wdc.com> X-Originating-IP: [122.166.88.44] X-ClientProxiedBy: MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.166.88.44) by MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 12:17:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 858662ae-2e5a-4678-9ead-08d8fdace2d7 X-MS-TrafficTypeDiagnostic: DM6PR04MB6201: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:2150; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IGAIO0tZ3yLRaXE0Uc/Dex0s8dIDgG34t1X+S8RW+qKQjKM2Bxk39ThVK5el9mfKOEuTdUaVNotV3q1jk7HTvOnlHW01evLSQWY0wIcQElhYqyMbYxBYcEcYX+C1HYRv8KvkxUiSj0ZxNBKN2FqT+hq0s/r0tPi9IpPfBmqM7gkaxqVTvuqnJJASJHIOyHPlPnt3ykM7II2XgaieUwfcd5PU/6wOP9+l53q33vIwrqN9NBOb/p1Zb2QYhtPQd1j9UMI7cItTHFkXVm2WlixQilDHrPhKiQeRAQcL8DO+3kktl4sMPuxGQxOpjp3B65BHy/6xYKTB223wOsxSzkxo4op9ZTbdCEaFVGk6DbLsBpqQiBmHAriF+fLc1qMOtCa2QLbvw+c7OqvDsXCApw9WM1QgbDN11nW3uyUZcKLRk6ppiISceVrMXuTsD4/pMyiPYD45dNi0h9Bmpj8psd7/A6ee/Qid0Xza1ubzP0i9+7cMiao8ePBQF7Mm5UFwc/jti56tKf3BHxcKd03l07vM/P/hRdhmubLs6NHwvmQZqFIXzeILaOdn3EjAIrcETXwdkA9DMPIuO8c0RaSi13I96e+4Zn7j3WACtyIZeMiJJ5PqyUE6xixfWY7pK7PNQUE2BAHCIu4GIwHFnHnDDngSRA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(316002)(8886007)(38350700002)(38100700002)(86362001)(83380400001)(2906002)(5660300002)(8936002)(4326008)(26005)(16526019)(478600001)(6666004)(66476007)(66556008)(66946007)(186003)(55016002)(44832011)(36756003)(110136005)(2616005)(956004)(54906003)(8676002)(1076003)(6636002)(52116002)(7696005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: 57GU6unjl0lbe3n/00AtjCYFBKjLDrfpc6hD9SstaDYSCw6vOn8WsYj4qsbauxXknOob5xKdb7k/6b95crMeEfId85aUNJbBbcDGcOrpzNdnWxEA461Uk5lRyLkLH5xtpcuDSz0BNQzr81c1PkVzk/PjQ/90Zpja+YCqiZzFBAnqp3QK80I1yjvXBJ+SZo3Be2TFNVf+/oJCk5O5Aip7tP35UEB7JT7x2xaoCyQPqM4wqnAfGTE9a3aT/unNv2QwidMphoicTV89RWIux81Ms0C8SOjUuT0mYB9Z5N6qFZTDtWKc2y3ljI5P2N2DKj5uT1QMYcajSEKXpNComrnxKhEpyiu/tULCf/0ifbhsllz5iX2EqIyIv0HwwPy11EjK77NkXcbn/bNL4soSy+A/YbP/tlVzsJ9JUPJf/MYWI6u3GWRoNa05CIauUAly2Lgldg89SE28wtTV6SO55Im3sfsEOT/Pv0AMUJxbaeYDVJ4Vf0TswfHwnQaozk1iGhwBqI6a2OMEKyK9zt1qZeOJtH+uGaT4x9OPBeNDtpOWoAXqZj0H7puf7DMSJT1/efbbOiuF11w8ThNeK53XRK0lgW9UDjHrezAtJErtAlk/SGWVfBxNify0EsMoWXaOYYjbd3lg+q3Ff+02pGXf/aM1OgdnmYHnTfszBxoFJbCPNYMXh1fetIrZA2qpOUP6q3qXMWSooo9V9vJgGhZY571ZeWBZBgdHMkRP2WVJJixbdV4MQVgICw/rwZH/tTa06jjBmMwN5+7pff/ugteMpZcsL6Hjpfxo/omIhzbiXeknRzsB8oJvDkiafR4Zc0fgfFvYUHINPbVTVeAbbs1YBTH/ki9thgytPdqL8iaMi+/qy3+oaaQ+2ac7lJISywJ6oFTihDEICAO/HSTBW0Lm/7F1hsgyoUf5bO+GZR+LoXEKCnj22VtlBVgE8BWRQKfp5LXeFkIidyeU4ZfEel9VHIglwzvKESlOZjFkf5h95j8l8+iVGoa54bG6FAMNUm+pej4JYr5ro7Q22SSV1PziyEczUwh5sFf50m8HyhAjjh1B4d1QBYDn8EgbKuT/b4VhbADFT4F70+cO59Y8Z7ptIJGtVwfUzPedjTD3KOv2PWl/v7tsUxm0V3Xo7XQuhwI3gzDR4nNYZKlW5DN8DqzZSJNOiTViJMJ1X7RCcSghjsOeg4E01+1M4sO4pmvrkeIz9gWNVoI7Q2VoNCnDfIFQESrZg/7pqQITE/oT+OslmZxsg6r72qlGE9fHhLTEU39I0IzEUULADM2k7M+3FUe6qHRD3nKIzQJFhWARVOkjgCXw7PRWppx0Y43epANrWY1GpoLA X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 858662ae-2e5a-4678-9ead-08d8fdace2d7 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2021 12:17:05.8406 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8ySUkGj6/SePzbyF1wGfwYhBvQuRBehUUSc0CaDicuggXWcyYlMSPjrh7tT3hirc6uDWPdZsURJfDgsnRN8Hbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6201 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_051825_321233_A0F8D125 X-CRM114-Status: GOOD ( 16.51 ) X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The CLINT memory should not be accessed by the supervisor-mode software so let's protect it by adding CLINT memregion to the root domain. Signed-off-by: Anup Patel --- lib/utils/sys/clint.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.143.124 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The CLINT memory should not be accessed by the supervisor-mode software so let's protect it by adding CLINT memregion to the root domain. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- lib/utils/sys/clint.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/lib/utils/sys/clint.c b/lib/utils/sys/clint.c index 7a392aa..80e04fb 100644 --- a/lib/utils/sys/clint.c +++ b/lib/utils/sys/clint.c @@ -10,13 +10,19 @@ #include #include #include +#include #include #include #include #define CLINT_IPI_OFF 0 +#define CLINT_IPI_SIZE 0x4000 + #define CLINT_TIME_CMP_OFF 0x4000 +#define CLINT_TIME_CMP_SIZE 0x4000 + #define CLINT_TIME_VAL_OFF 0xbff8 +#define CLINT_TIME_VAL_SIZE 0x4000 static struct clint_data *clint_ipi_hartid2data[SBI_HARTMASK_MAX_BITS]; @@ -59,6 +65,7 @@ int clint_warm_ipi_init(void) int clint_cold_ipi_init(struct clint_data *clint) { u32 i; + struct sbi_domain_memregion reg; if (!clint) return SBI_EINVAL; @@ -70,7 +77,11 @@ int clint_cold_ipi_init(struct clint_data *clint) for (i = 0; i < clint->hart_count; i++) clint_ipi_hartid2data[clint->first_hartid + i] = clint; - return 0; + /* Add CLINT ipi region to the root domain */ + sbi_domain_memregion_init(clint->addr + CLINT_IPI_OFF, + CLINT_IPI_SIZE, + SBI_DOMAIN_MEMREGION_MMIO, ®); + return sbi_domain_root_add_memregion(®); } static struct clint_data *clint_timer_hartid2data[SBI_HARTMASK_MAX_BITS]; @@ -174,6 +185,8 @@ int clint_cold_timer_init(struct clint_data *clint, struct clint_data *reference) { u32 i; + int rc; + struct sbi_domain_memregion reg; if (!clint) return SBI_EINVAL; @@ -199,5 +212,17 @@ int clint_cold_timer_init(struct clint_data *clint, for (i = 0; i < clint->hart_count; i++) clint_timer_hartid2data[clint->first_hartid + i] = clint; - return 0; + /* Add CLINT mtime region to the root domain */ + sbi_domain_memregion_init(clint->addr + CLINT_TIME_VAL_OFF, + CLINT_TIME_VAL_SIZE, + SBI_DOMAIN_MEMREGION_MMIO, ®); + rc = sbi_domain_root_add_memregion(®); + if (rc) + return rc; + + /* Add CLINT timecmp region to the root domain */ + sbi_domain_memregion_init(clint->addr + CLINT_TIME_CMP_OFF, + CLINT_TIME_CMP_SIZE, + SBI_DOMAIN_MEMREGION_MMIO, ®); + return sbi_domain_root_add_memregion(®); } From patchwork Mon Apr 12 12:16:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1465209 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=KKLMyXGM; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=2KlKGGE5; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=dFt6MEUm; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=AfP/CUpu; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJnmg2Ytyz9sX3 for ; Mon, 12 Apr 2021 22:17:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AVSJDmWBjLgA9laG0cVgT1KM+O3Dnt6oD6oOkKoFXf0=; b=KKLMyXGMNuJg4/dOhBeQMpO7d SMM4voAWziU8Pr0Vgm96lLsLy/S31JQOxvmIdtyD6OwvZXPU/x1spJyXvRAdJL0dK2aHunZOThEja rfSwmxXxm9n0tbYNWoeK7qVr/12vRmrv7YABLnDc7w27okJWGi+q2AdXqMPHncB7v7LbjKEwFXppn 4C/xTKB9Z2yI8UMe/LFWwNdxQdHgYSMh2HUFl+2ZQ+9WDYEtWU3p80AULITlvxUPgNI9F9E6KFkcv 6rESc86HqoD86PyNM3fhi55dausOaoYwzJq48EZotqfl7MuyDyK8LbyKPG5PAxp6Jp9/jLxVC8K0E OEBWSJckA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVF-006fAM-9o; Mon, 12 Apr 2021 12:17:17 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVD-006fAE-Bl for opensbi@desiato.infradead.org; Mon, 12 Apr 2021 12:17:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=6CRdXipTUT8gvLq8mdaC6kKOVv2wnXux+wehioF0w+s=; b=2KlKGGE504fGu+9PdorTPbLJMO jQPfNpehbM5tXGV4OCDZ0Z6A7aiQ+15XPsRlryPq5c1JpEwrnIFebqIsK7K/O3Xf/loGdySUOotr1 9pyFU5Ud+MxABQRAqfZeMqohNRekMF6oSTayUgL81hl6BfUGOaaUkiBWZ0+PMVgEoLFvUCrjrzlxv /qAC0pBig1zCURhCYMrCF2XeHjCdRuiI/POAfcWuZrg1LjL9FKmT+mdVO8f1aDgrqXrS/vyX4n5DO /PanMrlKoCGSNBrd7t3igrgsujkpAd+H1/g9PzE7EWsmy/M5E8+mN16dxpkBBDINqssejFXW9O64E Dqt5Khkw==; Received: from esa3.hgst.iphmx.com ([216.71.153.141]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvVA-006DAt-TV for opensbi@lists.infradead.org; Mon, 12 Apr 2021 12:17:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618229832; x=1649765832; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=/APsnHPx1xyKgUIq/uVfnwWewnPm24kGSgHxYrdTaGU=; b=dFt6MEUmJrZAN/bo118LfDG2+FZIrdEZhnJL9UNDdOzQJMvJA/tG9y55 oSJo0SVUD9+Wtz5P5P6JHHFM06KjKfOHTaICVL9/ecqekWTCcBuPTVDAq N4HESABNrmwLyv3YPo8krM9CwtfpwChW5uydg5nMk+KPDrsz9ygCf66Re aH5HJyapz4ivY3JMDLtO5MFqQh4TgFb7N6bTdUGWYxK5GdvLPWo21sbv9 NHw7AmeVCRKXDwpkPf8Bkr5e+jwwIlNvxXnojneZs2OF/68WrKiT/hRU1 pmGATv/+x8+LLyn9vxeP0PGpnB3t0Pc7wIOYixfD3HxOoQKwJ8RwPnWLH g==; IronPort-SDR: SenJrRSP657l/qPIDkVoI7ntiqrKxt43X2JQ3Kj3zk8B8+/cGuNdkCSTgofmaD1KQMVC9rq5Vf I+/kpKFGUKGo4aylzKVfZdxsdfFXa5YN/0VLSZqb52Bf2aWzTDh6LJqlXvsvHvWAfYF82rLw5j nRkESgIvAa/dP6m6tf7tXq4QumWcDWdo8McK9zrTBxQmFmtu3mLvzJZ43psv62rTRjIg8oT2+E fap8Kxk0jSv0g85KtscYpp/Xzf2WZd3wmPdoqwoMa4hckk9fP+49Ih2MErsc+9WlyPT+LzIZvK PkI= X-IronPort-AV: E=Sophos;i="5.82,216,1613404800"; d="scan'208";a="168985977" Received: from mail-bl2nam02lp2058.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) ([104.47.38.58]) by ob1.hgst.iphmx.com with ESMTP; 12 Apr 2021 20:17:10 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KUbBVXHwXT0QgjTx9g4OE1CozP4g0izzal4LNgYF+h+z9qz386phAve+xXc82njhCAaH4v766970aWBdXfPs7389EX2RELlwx4t6IN4XXCzfFZJ8ag1A1yrFodEZUDlHaon9XaLMH4yCVLKMasnIZOcD5ZOD4SHYircqdCkoN5JJizOPRu1ueshjE5LnhC8h6neAtbAJ0mLknLS4hLvhFdZ06091Ge5ICL5CzEqW3KKO9YamDWx15ouC34vJDwIxe+9Uu1qw58Pjd78hSMsoTsyEc3c7tH1lcZQDvhR00Fr/wXYDgMYJXLa0lTstj5MV3DQYlGgjRq0CuesFcNVY1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6CRdXipTUT8gvLq8mdaC6kKOVv2wnXux+wehioF0w+s=; b=h9G836q6z6mmnYRly4dwBaz52Pe+uRifVoMRRD/rtYhXSNNuvksHOcL+aNWSJQUm2XG4bFGntT+y0zlaThi/puwHgEMWTgqyOU0WP5WG5gM8u8Ga59YOkRRpMrtkMbIS2TDIAJYrIRkicg584Hn8I60q7+BPLs8zGP/NJFHbT3n08YY2i/g9ViHGtvev5gvsA6+dSrHaEeNbbFNht5GAA4BPTY9tNqWLaz9UwJBsJ3IZaCUvSt0k4szKaSqL4z4bnoyl3vMHwFG/4L0MWJma8oNlLraKUOuIEx04etfOdSiJaL9TVZtmg72zXZC1fPcqZO6jvbTTEFU7lx+CQi4aCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6CRdXipTUT8gvLq8mdaC6kKOVv2wnXux+wehioF0w+s=; b=AfP/CUputuc61/giF4Qz1Yh3qpBPHjQ7odYkKHOcBrp7L+39QiWn/kIEaF06OvSCMr8TbjB8wt5Xnui+LpR8qziXrsg+7MCaq8iaOAv2hUhY3Fvdzt/noXvrGVTxB4GCuN5J/o/+NqpcGuD079iPXiEUqgsUUlsfKbJEti9eZg0= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM5PR04MB0459.namprd04.prod.outlook.com (2603:10b6:3:9d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Mon, 12 Apr 2021 12:17:09 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 12:17:09 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel , Xiang W , Alistair Francis Subject: [PATCH v2 5/7] lib: sbi: Make the root domain instance global variable Date: Mon, 12 Apr 2021 17:46:15 +0530 Message-Id: <20210412121617.933493-6-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412121617.933493-1-anup.patel@wdc.com> References: <20210412121617.933493-1-anup.patel@wdc.com> X-Originating-IP: [122.166.88.44] X-ClientProxiedBy: MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.166.88.44) by MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 12:17:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f89353b3-9101-4cc0-0bf6-08d8fdace51f X-MS-TrafficTypeDiagnostic: DM5PR04MB0459: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oun1G7FuKQUYEOT0fbd9cIWpyeyq4gwLxvqNe49ReVei9/IVjQkwbvDBXm3LUFFRDvI3yT7MT7pTvLOoUCatSM8BVSA1XD5J3Xv+qlaALBpDoWgPiiefcKhKM6vAuf2mOwCNbqRMHVK5T/JzkxNIoIM7Q2D+XpDwyWy0YmSz1YbeRvRUNjsFWiYTOLzsuzLt+94TEOpFPNKnBk26/2LYUOzt8Pp8h6Dl/7HrqufCdboCKtw78GwiX+CfqjAhVNIvXaS0DLFIyE8Cg4eQblHb63BROA7bBbF8mswu+Lapz0Qy717E1XsYlEeFRZ6OzD3wkctySH6njFWyjriQSSdi9JkxTv7VtRWeuNuxty9XXDgBjguDL9IDshQfYJAycUZxyIZLfsT55WiBy4TAvLvd+thEXGfNLAJO8e5dFfMGH+YDoe5vs+j13OvoGVayR8bq01N68K5cnsuKoyg4U5hAVgHCy9iFvjYaYW7xfNSDxiPrAN97OZ3V4R2Wy75zvP86acjcJw+fAe9cJafyZElO7XaPkvE4+/uM6EdpHwzj2hWMAysJxUQJa9qyUCNiHZzGQLxxtkN/vSuy6ih/P1p9HdAgyOwme5FIdEO3bKpdkDUzIrbLv7QVQqVTcq+DxnHrWAy50yuHmReBbZiDT5Eu0XzHnWemHuxbOCxm+lKVsbIKnaXXFutjUMU+yCAQRI7B X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(346002)(396003)(376002)(39860400002)(8886007)(83380400001)(186003)(16526019)(66476007)(1076003)(26005)(66946007)(44832011)(38100700002)(478600001)(8936002)(54906003)(4326008)(956004)(52116002)(6666004)(6636002)(316002)(110136005)(2616005)(55016002)(86362001)(8676002)(7696005)(66556008)(38350700002)(5660300002)(2906002)(36756003)(525324003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: tpEdm57kXfnTf6lYlsBnkztRH1udry4P2PsDxM6wDX42YqM5QwbtEg05YzA1Ev732cs+Ht/3ZAaOokDC+0cSUYBtFzQYJE0UZFKF8cz6auH8D4qBCFt1ZNMY32vyDOTAzoiH/oQCMy1jpWWV0wUUhAJrSW4N+r9GhopFNZNjFwvTqRlh0l5SyH7Zm2KSNoJWIgdtJY6jrF13ENGwhGLFz+G5PfdM0EPly/tkKGY74sACTx7W6g8AdKP/2iq1ilHuftoIanxuADdXjyQXEVjwQ9ajrg9mM8PniFguA1+HehSyHcCVOySXf0HQbY3A6XKUJFF6o3t7/B1J/ms74q1Kx+AVwDDulONTcVhA65XkTLv2Th5rd9VNhlFsqGXHCuJVDc5qwcNnxEinqvF2FKUdAePRnCRUxX3zz/GXqgHXpvxvd/33deogBx33NYnhy7wwDAFjF1tk5E2CCJwWZgYHVSGRpd217LQERA9fU/7JgRfJzkLjmbmk2Rr2Vzl5Ae3Z7BR4OH/hCkv4GlxKg8moBQmp0SGrv867NlELTw9lJEtPXr8GBC2AqzErvUToFV+n3e/KQyP7gqk97AQl91QpvuB74F0YsQaynuYJQ0ms+LpaI2FF7TEshi8JQDhxCxck+uER/YWeenyLY6AA850iCNMl70SuWqS99jNriGZWMml3yfpGKdzaKtsez+Ryqg+9W6kt3CtWNq+GvinRAejT647gLeC1L2fVTeRgaXCm0Ku4OLabEoW0ztCQzKxOEhmA83TJKDV09uluBbYU0LzQMeh0l91wlY2EwRF6TNL91C90Cw+LaNHJrj301F7w0q7k6MDtiGtbhKOFQqKB/BKGjiqWc4bVP6wIo75medxztuOhKoC/8f/ESyLd7u72kqEv+ag+v5f1AaDKIeLIzD9GN/xhM7+6uiggf3Cy8v6ugJIhOxBdtoVyUYOL3CgfTZUnHvhLk7LXZ4KcgoCDHICuVKty2qd9WS4vwMLjs/n9Sv4i8Pw8XfpttZG0l1jnpgrPOJw+42WEdehILv1ahdcjLZ6NFXPDSEKSRvse2MNfNnpFVpl9AmV120L3MKontLI2M5Eyy8t/jfC44iHQ1NztyQvtKtYzHwpvdciWd0LIdQ0L0ssEIabSIpS5h3w89fatLTdkvWJjJlmrGl8gCBgyZYI94bTb7Xd6VgJwMe1RZyATANEFfvc/XAxkTaL/TkZBNS+ckle8PPuBDjDWs2J76UAEybAHvuThjZZvWHmM3eWr7LSBirMFR8Fmv5wJsB5UxWaj7HqQYKRsSBXMphPy/TDWCOgiCOmuaADk/97jXPO5eZpPL6OEojbqN31ZAoI4 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: f89353b3-9101-4cc0-0bf6-08d8fdace51f X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2021 12:17:09.4383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I8gDVpuRe8Gz16gvgxx4xaXcFMwj9hghKyPwaFbzp1QGtsNnaRpJWMQ5BXN3NkiqvEPxh0lKwdmpjmAmcRlbTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0459 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_051712_982820_106AC0B5 X-CRM114-Status: GOOD ( 13.71 ) X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: We make the the root domain instance global variable so that platform support and drivers can iterate over the root domain regions. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- include/sbi/sbi_domain.h | 3 +++ lib/sbi/sbi_domain.c [...] Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [216.71.153.141 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We make the the root domain instance global variable so that platform support and drivers can iterate over the root domain regions. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- include/sbi/sbi_domain.h | 3 +++ lib/sbi/sbi_domain.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h index 84d17da..27316de 100644 --- a/include/sbi/sbi_domain.h +++ b/include/sbi/sbi_domain.h @@ -80,6 +80,9 @@ struct sbi_domain { bool system_reset_allowed; }; +/** The root domain instance */ +extern struct sbi_domain root; + /** HART id to domain table */ extern struct sbi_domain *hartid_to_domain_table[]; diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c index 4b5a89f..c95c3c3 100644 --- a/lib/sbi/sbi_domain.c +++ b/lib/sbi/sbi_domain.c @@ -29,7 +29,7 @@ static u32 root_memregs_count = 0; static struct sbi_domain_memregion root_fw_region; static struct sbi_domain_memregion root_memregs[ROOT_REGION_MAX + 1] = { 0 }; -static struct sbi_domain root = { +struct sbi_domain root = { .name = "root", .possible_harts = &root_hmask, .regions = root_memregs, From patchwork Mon Apr 12 12:16:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1465220 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=FJyddWbr; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=N9+Tqqjb; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=RCSiNTfI; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=yhilbCjg; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJnpj6Ml2z9sTD for ; Mon, 12 Apr 2021 22:19:09 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tEJAcmqMLHmM+ULzNMlzAZbgsauxyTLzow9Ihj+esOI=; b=FJyddWbrX7xI4HmwSACB91dty +HuaFqiuIiMMXwdM8+QUU1Z3Mqh2Si8Egmj4psFXk7CDR38LKhj+xVtVBQB0elBvFC4zi3L0jbHuO +7yPvpEJpJOWjzp/z1TuJrlLupVZ3RMgSIg2u/0S2fS9tvfBfGS2uONgTr0l3JCBxgrghDpKtcovB qDiooXx1hTBfHt0j7IidQM6FxPCS9Rb4rmfSi7NiY5hC5wU1xTMNt2EZIiEyV9mro84PuT+7Ty46K bu+msJIqJuof21w3FvJdF5Y3r5Yu/1z0OC4qTJfVo7cgST48YekZNkyne0PiU08Ia4nQnCepMguDR NBNc5WZAQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVvWx-006fNO-PC; Mon, 12 Apr 2021 12:19:03 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvWu-006fN4-7z for opensbi@desiato.infradead.org; Mon, 12 Apr 2021 12:19:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=FMroVw9EZVEXQd+UveYTZppxBuTO0endMYEoLZ264EI=; b=N9+TqqjbPC+8mmwiB/eqSRVHuu cJ4OtI/K+8SRKcL8At5U2pS9IQm93zTYDzewJjBbKb5dTCHGz5sOgcvlx0VfW3zgrz6LcWI2HhRxc sMlH0QssxhCuykIi9/tgiF1u0Sh+Znm/xHfQNalCYferUaS+ytS1Ose9y8F2PPyWLwwl/i+iHE1ay J24QWd01VJhWiBnk26i9C1oOsC+BlLFa4rZ/ktOheV+IUvsQe55jk+gas+o6q7vOrMzYcvcPACzKz p7PYNn+XUe341mVkRQ2kDQWvIJYvsEA3APnAhV5qlOYBXt1UgZkIqNrdEda3XST0eYlsxnZqKjr51 HVTwteFQ==; Received: from esa2.hgst.iphmx.com ([68.232.143.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvWr-006DGe-Kn for opensbi@lists.infradead.org; Mon, 12 Apr 2021 12:18:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618229939; x=1649765939; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=SbUJoRrwAEP0TeOh1x0MFPR3k1+rZ+s1oXEvkdsPvic=; b=RCSiNTfIXnSH6GTKt8sVdSzIFnylcqb5uOPD6luFJZAdqQoyTGphlQR6 5wmRy3fTVyEX8j3eyxrqZaTKzC7DXfROG4KSylMrFgO2riaM3e3uAuuAy cR1g8n/cB2aNfLuccsnkmXtFRllZl0mwvahjWmpnXEfJBFGrs6FmefY9I K7QXzjJth6scwUBarhn5FweKcNJGC0+/Tp7EZMy57pe5oQzj/K4eTCJl7 NCPekrsa1po9yNisZz6CucEdZ+9WAZdwm2TfQvb91eX1cmw0wa0zUDuDF HvnORy+hoFUJyftSxxniYv1DPzp8e0M9PAUMaStztx9Z3dWkufPG2UOv1 g==; IronPort-SDR: tiB1dToxM+j6EmWki8EFJLjdB9GD1ZfOSQBd6abxpB2BTggz2Eqct1s6rfpjq6Ftu+oqsuEI3x IBszYpjBor4QcU2Gll3hm1BpvQdl2P8VMhi/putsS0+IXNLiiZ8yCqNvp6FOTD5yT/bShD35Dv UsCAcnHWX9QhnyVLr28Bq8DDIHZ+n75RVSMout0TM/Htko6PjSWUJiYdytrT8IfhSGxcyQOfUW YzvzmrZ2xRh4AcZLdPkErRkDk38HTGgisi8HmboRcHJSd9QyHvBb8hp/oQBc1XJjK6dc9pFe7S Fqc= X-IronPort-AV: E=Sophos;i="5.82,216,1613404800"; d="scan'208";a="268747656" Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175]) by ob1.hgst.iphmx.com with ESMTP; 12 Apr 2021 20:18:21 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XYHEtMoD8PZZcfYFzMKBm3tVWBXC/ClMK4FgbE0GzFtRM2XD2iOAQLD0dfxkg1abyPjY/kSBXT1Mf/6wKfyAUmABcQ+8m7Ie0UHxVF4RHi90PwJIgQNQStcckmqLiSat6lk2nEQWnR7Sg0ppbS7FZGH8UMj67b3kIJp6CBdQCCJ6bqVhrwCgXMzOJPx2kl0OjQKUxe13MIRehum29Dfl3iM5p2OWfabZd0R+rSc17xpXtncxf2uQIympQlVD6AuylIjniGnDLWNA9aIwKG4BxiSRWYcBp7+U79Cg1eIK3gXY64riND9etF4x9OcCPG3U3KvHk1N9HekxmjFS5wn4jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FMroVw9EZVEXQd+UveYTZppxBuTO0endMYEoLZ264EI=; b=U9h6h0/j7yRgg2nj5iZso+H3DLzOzQzXEC+1eztNyLDLLvkguIgry8K64noC4UerV6Cm8E8r7u0k/nnvZVU++5mjnOmeEr43tfPD0ucrb9+k+/zFS4s7KaZw/dN3C/gAhUnSKingmZEVjGdQlQBs6zwLqMXqAiroz6xOC2VTqVa2/kvtPuYIe1JMh/2QTM/qfJOKBbfRObB85+N/2f+Clg7CoxT0ukQTbYrHrp5psLlMZfjbdcQUjyI5/VtFAjSGDMIR5cUlIuJNCuWfWw8ct38GGGn/gTzh+RjGR46rjTfzj9WEp0hycCzUj+TT4OfGv3c5zwZpQOHPUxDvM0/cNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FMroVw9EZVEXQd+UveYTZppxBuTO0endMYEoLZ264EI=; b=yhilbCjgJ+XgT/RFA2OOf/Mg55oJvoHkl7gAXMZR3iNfYgUXSnUrsnq9ch4mKRMWRZd6tD0Z0HKZVGtOArFVcbP2gVdux9qEykCDhY+v2VABhYUB8w8f7ncAO57AXYiQra2A6yJqp87jIzJRWHdtJ57GeagOfxNktjKvDBc/h2k= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Mon, 12 Apr 2021 12:17:12 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 12:17:12 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel , Xiang W , Alistair Francis Subject: [PATCH v2 6/7] lib: utils: Copy over restricted root domain memregions to FDT domains Date: Mon, 12 Apr 2021 17:46:16 +0530 Message-Id: <20210412121617.933493-7-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412121617.933493-1-anup.patel@wdc.com> References: <20210412121617.933493-1-anup.patel@wdc.com> X-Originating-IP: [122.166.88.44] X-ClientProxiedBy: MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.166.88.44) by MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 12:17:10 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 073c5365-8e0f-4b58-2076-08d8fdace6e9 X-MS-TrafficTypeDiagnostic: DM6PR04MB6201: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2a935TWAbVqzeTVPJtqf8h/V3Nf9WgicW/q1SbUaog/7LV/QqFvU3TTCIMnVZmrQO0vjURpiBV6w9HaFxeQJ1aNNSC4JrJxC85zWTiZ/0ssesrFv0zx0/SHi1KBqK0mkpA5bfhzf6eJa6fDG8PQKTKb9/dHHyaYLm0E5wC1ipthzg8TPuczYVuOtoNd4k108J3T0ygThlGOQw/tcNDn0C9phS76L9WNz+i1Z/aOtNXBNvih1LnuylJUrpM2Ie2EQZQfX1fiZed4+ox/p01hT5Kwb16/EBYIlbGaWf2mcsMbz5mP/0vRNQftwleKR4TRs1JIUKHGfBllEzVGXz+cwZBhpFGKUUPs5rO12Cl3OfciCbpGrhqiGNtmf1VhAcPIdkfgl9q/byl44e62Pib9Kq08OoMDbhszeQJdwD0usGf6YdBrxZTCZohpqRhJI4PdPAoMRiLtTaOMwioD1BcnpKuorDj7BfCxc+LpJMsnBHv95qRlqLuQCNqmPM+6lpIajhyaaAQTk20MuuhOg6/rnyDgzNLjss+NS7+aF5sV5yBDTrGV4Oaqhwe4yCrHfQkKIeYK9QjS+yrB/WTbiDGONyWGTnE5Y5ZYY+zIZGOIos934Z9auXotrB2Wqgy83b+UHUqtmtvbCspKnaPeJccP1XlcPHVgLEx76+svsP99rck0jRPdmVo+GLBHpPSfct5wN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(316002)(8886007)(38350700002)(38100700002)(86362001)(83380400001)(2906002)(5660300002)(8936002)(4326008)(26005)(16526019)(478600001)(66476007)(66556008)(66946007)(186003)(55016002)(44832011)(36756003)(110136005)(2616005)(956004)(54906003)(8676002)(1076003)(6636002)(52116002)(7696005)(525324003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: HabAyxciP/80jJseRKiBOtvJ0nM1ulWvxAqJtGzcJxYpMZGJHI3y7MEHsiX3kIUUP9kohk1LCH9e7Is7OKFonUSry4kMk27QSN0cJuWsfhhFITMNv73hieMs8jIqQza0ty2OHuYZDSbFBu3czJKWdd80nj8GpBOyyy0mLPrIfHpL1sUUQVQBpBud4QUXt4suGSGvyQFBTV+dfJFSSILP/iBA3m8dOMEwpHSRWysHo/AKJf+y36StQIhsw/E8zLQTKWZ+LJ20/cQejJEa0NcTkDQAU4PoAdLwu85VV0oR6JkPXdSXVFJXQeeeRt5m0PY3A0zm+6z0lsj2RybQ4HIp5DmoIl61w4XDixKJbY/KeWAUwLZmDglu+TacLNI5CvZF7o+2bvAyqpp22m2W/yy4B7MTeBw1Ik99RldSEp+ssKF6ziFBQVJqs42fKxq9uMYopNo5I1esskZPWK4j8Vv8lTuF6Z2quYn5AKkxHfv5g3j/L2f8w1kxWs/r9ByFF3/NxjvuuqH9e1H45JZEI6uopLR+6kDX139cXxnGgsXQifheIhSWW2FvU9qmWX/d7PnUu/Hjs8dPqqbCWDBYLUGlewhfRlNZZzMt/wdHNnWEXr5mgWqTPfsa6wjYyvtIrLUkY8nE36RyDC3W9wmMJ3/xfIYWXUKbJxDSaven9UnjtSSMw0ftU5Vp3vw7PluQBuDgLGWbuV/iSMhwMMBTtgzCjnSWO1GzVnavr3rEinlFH+zdCTpuIt559dZIL8Ap3KSk5++sKak7RNKthpwlTW9PteQ5J8WO2GpRANB/shjMZq0MYbSTy71Ze14tDFUY/gQFK+3nFCWGb9hfyPP/QSoVy57ATXFbj44xH4yCN/k83jnr2Xjgv1V2ZPgnp+pMgDC0dgk4zzJioQS3C4X9rX6IngEeANx57xhGP4BkXlhHTEJyKa1IiUBZSzMYn0Dhwee28H1ISkjFU87UasZ5uSvGvBKuSbflpHp/Em24i2qgUzXwa666SCD+QIvSc83cWlnW7CuS8yy+P3RlCTlc5iLGvs968W9UT2+EBhyfR4v0Gbicv9SalOvUjF/WbskBNRmATjnVi6m2RCvgivYJU7jd6ExDXs62de+69/mEwqh+MEU/KODNNwr2ROmcIU5kaGTKjxxWZfGnRwKsRP4Of8rWNA7wJqwZO9dMh9cNkmJrz7tCgG8L5QViDo7ONc8RfMy2dfx2+9mn02GtBo8BDPt+H/npA+q5f1dtXXYW5sTZUen4le7iwHmqQjNOeAyq5HyQp7t+hVZiqEw+rM2AV3wOodzhIyrWb5uDEaBPlC8K9YhXbL0wew996dheQG+22w7b X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 073c5365-8e0f-4b58-2076-08d8fdace6e9 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2021 12:17:12.4564 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zzelR7UYwO52VTK6GBfKwT0Zgt2XhgyonG7IXrsJpW/zAVXg74le7N4CiYw9G6eyG6bwPpsNkz6F4VhJq8GQeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6201 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_051857_827876_CB1A106F X-CRM114-Status: GOOD ( 13.98 ) X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: We should copy over all restricted memregions from the root domain to the domains populated from FDT. These restricted root memregions are typically firmware memregion and M-mode only mmio memregions. Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.143.124 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We should copy over all restricted memregions from the root domain to the domains populated from FDT. These restricted root memregions are typically firmware memregion and M-mode only mmio memregions. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- lib/utils/fdt/fdt_domain.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/lib/utils/fdt/fdt_domain.c b/lib/utils/fdt/fdt_domain.c index 09615e5..95c195d 100644 --- a/lib/utils/fdt/fdt_domain.c +++ b/lib/utils/fdt/fdt_domain.c @@ -222,7 +222,7 @@ static u32 fdt_domains_count; static struct sbi_domain fdt_domains[FDT_DOMAIN_MAX_COUNT]; static struct sbi_hartmask fdt_masks[FDT_DOMAIN_MAX_COUNT]; static struct sbi_domain_memregion - fdt_regions[FDT_DOMAIN_MAX_COUNT][FDT_DOMAIN_REGION_MAX_COUNT + 2]; + fdt_regions[FDT_DOMAIN_MAX_COUNT][FDT_DOMAIN_REGION_MAX_COUNT + 1]; static int __fdt_parse_region(void *fdt, int domain_offset, int region_offset, u32 region_access, @@ -276,7 +276,7 @@ static int __fdt_parse_domain(void *fdt, int domain_offset, void *opaque) struct sbi_hartmask *mask; struct sbi_hartmask assign_mask; int *cold_domain_offset = opaque; - struct sbi_domain_memregion *regions; + struct sbi_domain_memregion *reg, *regions; int i, err, len, cpus_offset, cpu_offset, doffset; /* Sanity check on maximum domains we can handle */ @@ -314,13 +314,31 @@ static int __fdt_parse_domain(void *fdt, int domain_offset, void *opaque) /* Setup memregions from DT */ val32 = 0; sbi_memset(regions, 0, - sizeof(*regions) * (FDT_DOMAIN_REGION_MAX_COUNT + 2)); + sizeof(*regions) * (FDT_DOMAIN_REGION_MAX_COUNT + 1)); dom->regions = regions; err = fdt_iterate_each_memregion(fdt, domain_offset, &val32, __fdt_parse_region); if (err) return err; - sbi_domain_memregion_initfw(®ions[val32]); + + /* + * Copy over root domain memregions which don't allow + * read, write and execute from lower privilege modes. + * + * These root domain memregions without read, write, + * and execute permissions include: + * 1) firmware region protecting the firmware memory + * 2) mmio regions protecting M-mode only mmio devices + */ + sbi_domain_for_each_memregion(&root, reg) { + if ((reg->flags & SBI_DOMAIN_MEMREGION_READABLE) || + (reg->flags & SBI_DOMAIN_MEMREGION_WRITEABLE) || + (reg->flags & SBI_DOMAIN_MEMREGION_EXECUTABLE)) + continue; + if (FDT_DOMAIN_REGION_MAX_COUNT <= val32) + return SBI_EINVAL; + sbi_memcpy(®ions[val32++], reg, sizeof(*reg)); + } /* Read "boot-hart" DT property */ val32 = -1U; From patchwork Mon Apr 12 12:16:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1465221 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=mc0YEJ5J; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Rml1h404; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=WYA6ckK6; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=yvX4ggYL; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJnpk3Ty7z9sW0 for ; Mon, 12 Apr 2021 22:19:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6bvDEZdusWcYGx7V/yCVAxCnTgkbrFf3ZqsPVesVsQs=; b=mc0YEJ5JOvrrAR13BfsJWwAkT kzo1ayTNfIGKhvQ/c/3yeBMU/tumFgyUx9yvDWHhXi83zd/XlmYOchdS6rWibNgN2HB/+0VjH3Hgk MWc1druhYiKxWKzvM22A6EGoLDSeMUJet7bcGOU/Tl/OP0uB5Wo0g/Rd8EWiZQmfJEL9vKqPv86kW ArKO7qMqL9yAjWgsaJetTzfuiJrfyKFq/W0sLdQ0/8we/PVBRt8TUxNK+mkQur3p0q9YbUxGGtmOW 5+htn9FHnXSEHFDQyWqfvXhL2QJQa7zI8CqkeZutaZXLjJTFjHvDWBo7ymU93gOPj7KPPg73J4us/ R+C1jJlfw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVvWz-006fNa-4M; Mon, 12 Apr 2021 12:19:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvWv-006fN7-S8 for opensbi@desiato.infradead.org; Mon, 12 Apr 2021 12:19:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=lY1Rqi+yVb7EJZ5SLor5sf8to5FocmqCR7F9k+Z9BXw=; b=Rml1h404SxxE5N0DsoXPjEnF44 fzbAhDqT74GSdY7VTjYJA6NEGqwUBCt+qM3eo/S7a5kcBGQeRrR973PVrotSPE6Q5k7+mT3syZnJs T7geH/BEKcYJ+4wAiKadpJmn02mANLz2KS2iyQcXAiLYlegzxX3wyhqASpp/thfko+I577GJ/82Od pzm3n+7oFQYe+OQQ4WTqsRyRtn0JEvoeC82ATQyEoHbXEgt4Ec9BvfbQJDskFMDOQRkyAx/EnVc79 bubwO6PnSUhG2p2LsdyieBo+BCoxa9uAfib+dfTSq4ZMfee7uNsFcDTrJoMiCLwhBypeP1HH2gmky qZH7hW+Q==; Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVvWt-006DGs-Ds for opensbi@lists.infradead.org; Mon, 12 Apr 2021 12:19:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618229939; x=1649765939; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=hqq71iMDGmgJALptJYpMwDqMA2h96UFUDdAnmqmLNzI=; b=WYA6ckK6K7wDq9sds1wTMUzhqwMz0mHa2Q5HB9WPmgNUQiUP9+RDeYjR KS/9s0BXRBxHpdc/WlCXu6DfbVWN4av3aAo96tvZR38dJg7FHipQEMwwY 0j0z05FDV6ApjspQs3lguYQKSoOWaa2cR2tRgYQs+JPCAe9J2Au1IwZEf MRszBdCum5IuTuG58p0mYsq1Hg217sFmU/k+W00FQFcX6DbVhzKdHhykd kY/Ccsw6X0SluAlhkuvR+R1FB/dqkhj0kF3LTIIp0DUipQ597QMXWmx3y Ec/LlEH+8gHrCN09Y7xGS7ofeezOriiP7fk73/qDALLqrhZ/gRhm6eiQM A==; IronPort-SDR: fimIzs7U2mMWMBqMHudo+ENSKNa11UHTwZjJv/rzrXDfzeS6nNCAD8SUXrWnMetr24WKJuzM5n 2/gPIA2Ck5mWKJxA5TCC0RHW0PcnYDPUS74POYgzxZCuW/Mag71QQutrhV8QA3jcrMwl6M9XGh GASrySRH8aPeUkkc6gMy/fspB90EGy5G2Jyk4BksHvJq+4xcD/K2uaR3GygdL2o2hg/TFssCJj ZqYCxYdvEkOq303649IdEg/hxWcdcVmIW2zYwDhuXKBEXcapqI0ByU7QTZxZ3JjW4J9CYMn7wG mbs= X-IronPort-AV: E=Sophos;i="5.82,216,1613404800"; d="scan'208";a="164483075" Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hgst.iphmx.com with ESMTP; 12 Apr 2021 20:18:56 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pnwtpe9HandakabUQTNGF88WGl999ofAYVFYo8diKCwgKrWJIeXn2+Wx7hG4hNEWEjiEvqiAqsaJx6zx/avItf1UbdTyevwG68WR10VjuLvQjzkYnipXNLsGNXtkTPLe5zkNPKvvwxqPIn/Sligubm5t/7EO6qRaoqz+Dl5/cMrML13ExVH7L2ujADqy6f4OWGhx8jccffux4Pkk/vgLgt8oq4Zp8RKEIIARenv1DXA/qH7flrijuramRnZIjOgIae9R3HvGUgPZrzRsEr5fLkP7zu2QegByA9EKyhqT2T8+3SiG4J7fszklOKVeez12qFexkFMjFCFlgmXHgbZzag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lY1Rqi+yVb7EJZ5SLor5sf8to5FocmqCR7F9k+Z9BXw=; b=J+5d1ap9lYo5m5ZfdDLst3ZDA9CmDB6qeSjG1wdQWFWbzA2G/wPRpYhKdX+wEiaImjlKu1HZB8Ya3zN9AhQH+g1G2kPCuYRmTLLmD5Q4jI97MZycpLgqGn1pDDBrf/OanS6OTycE7edBoZ0rNuH8LZ5GUj5aNgIi0PJcrlDpBkKhbLUx6uj6GiRMk6Px3YQ7fCTh1Uks2wlJSiT6la+TxDid7c1b9XqR38xy7FJ4tIWaUjnShySJsZPrQPHBmHI2rApEKP3enKMNl1ohSvMor1F3sPqEXJKyUbf3uUL4QyK3YEFmJxotL6F1zndlXoAwAGHkhX3npt8zEA2BiMZwLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lY1Rqi+yVb7EJZ5SLor5sf8to5FocmqCR7F9k+Z9BXw=; b=yvX4ggYLztz6vWG0SDudTXR7haS6hs7Glsw+jb5mmDfqzu/fj0efax1Y5I8M0DT27LiOMVARpPu6y7OEv9ShuTvoKlxGgg1HzKwLRR7VyUZ/AtZyyOQA/g8WVuEN6y4IgeY+pkRTpe7il1I+485XfAXiBE2B1V9V5bLQk0Du34o= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Mon, 12 Apr 2021 12:17:15 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 12:17:15 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel , Xiang W , Alistair Francis Subject: [PATCH v2 7/7] lib: sbi: Make sbi_domain_memregion_initfw() a local function Date: Mon, 12 Apr 2021 17:46:17 +0530 Message-Id: <20210412121617.933493-8-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412121617.933493-1-anup.patel@wdc.com> References: <20210412121617.933493-1-anup.patel@wdc.com> X-Originating-IP: [122.166.88.44] X-ClientProxiedBy: MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.166.88.44) by MAXPR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 12:17:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 331f207e-ac1c-471e-6765-08d8fdace894 X-MS-TrafficTypeDiagnostic: DM6PR04MB6201: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:972; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S2N1frss7pMDgLYr+XHft03Yb3qQN4bjwAYw1us8Ef6c8zK57JoS5D+EKaMajaP0f8U6+RN2KJ0tfZTXGY/2aWE/jb/9S1EX0pHa5KvbGFU8+63o4tSZu2cnq1FODgWwTzKKRRJWXHwHiM+fcyPFQHls9d+4qQ5vEoIUR46Y9DfDa3NIaP8TC1k1BCek6L/lYJFBvRkQb7c3/cbbktHmJVRJxbbFk05fvifm0cLAyA5fdIAouoYobLi99O3ynxhp2BJkYm/c6BjVE1tTXMWk+YsLOOoLwKBjr3Zg3gPs2fvNAICJg8IUP790bguKxXcSXUEUeVzhMlKoFq+uac3Vu0qT3zhVY0lj/9aLfLq2+Mbjipp/mrpMwTaWeNO1pkzNM59obFs9YMcQ5J6kUU4PMUMF45NkZypliAQ6IdKgUnnwT9MyxDSr2aCMm2KsaYFVVfX+wOUSiw39k598zh0ATSuwErPWp+1i+R6ROexK0C8fXM9YJuOEC8pt2vPW+6SCDo1OGh37aP4EXWpWG2/XpyGxV0sr262HqqOchK4YrLgtQKpYTd4F5AuJf3Llkg0iFarUJ0ccTS/RQkuG4YvySWwTEv+BMSzjytb5/939zf1psaHqDLV2PVIRiaFak0eGJSNSIhvg4avvAj6vXHzUYRm4VPNHuyd36LYq+650s+uK9Lsoin5ztydblBVfNZM3 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(316002)(8886007)(38350700002)(38100700002)(86362001)(83380400001)(2906002)(5660300002)(8936002)(4326008)(26005)(16526019)(478600001)(66476007)(66556008)(66946007)(186003)(55016002)(44832011)(36756003)(110136005)(2616005)(956004)(54906003)(8676002)(1076003)(6636002)(52116002)(7696005)(525324003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: wqC3O4q5w9mPkEsZM2+1YwHuuweMYBt7YKySG0OGJyFJoh7Dm6z9IF2YWJtTxzSLea/kf9EQOMFqtTGBwjStUvZrvgJZEO6RTZAEhp4PwCRdwT7dPL9uKgL/Oc7z9QumQ23qcIIq8XaOEcjEV+rx139jyor9a6QwwSfzkc9KLjlItPCMPrs5zERsjBCoSF+8IbyTfb8GzRgyB4fQqhG/rcZfy82XjtSWiJfi/apZDdYWCcMiVCzaiZGc7lZ0sGxdIF2Msbdn66HesnrSvxKgktzZDK+DW7NcJbGxOKH1gtKB+eYDlyCItAdHyn2G6U5RlfowyK/zcks8oLnJTMr+DecUW/rtdATEa9OGqAh+LjuJlW3DrLN0Afypqunt27BBLt9fvFzC8YcUmuuzLMDfujsgV0Tz3ScseufD2SZ3/FmJFbudDAMb4A7pHGPp9SvPcXcRHgNfQPSLQ6i11CY0+LIlN8JVdNYIg+vswKDkbPhsdaxYfONx59jPSoHESTs0SqIzlmhmnFXVk5/Lap7x8B6Y4UBm4OjMK077CarCYHmmr2gqm0PH+dP3LU4mXUNMbuiH9Bh2hnUVjbcJ5oIDkHorNTi7fWBtFop3LH+oswPG5wTw3U6LZJm4Cqg+5uuB70wTd2MuKJURS8X/mpJY311eg8TyzXB7YXksHsAXghj/DSJkDUqTpoTyN/KPUbXVtsbl+/zl1ospor3QC3xbjIux8+Y5D6/F78SWYZC8tjgy8piw8dXpZj5yxHe1vntD1UOgKT6QAIMm03hLnRZ6Q3nQGQIj2Z8CfRdnqvumi2naHKa1nhGDn3nmtHZ0cWjPE8ci7GWxzHWLKFa+eQWH/Ub3CuNANdHBJvKjtTN38mEylx7+GOosWYpwpSqUrLyxq/8woE6+9nZSg1yt1yaB6VaouMKxqsdBdqlWJVPLGLXzH2bPnYFpwhymqOE3PFCX/p1wOd3dgiSmsG4A/jn+MZN91RIZCVGXoKPH5rx6Dl3miFy21gFadC/PdqJuIPCvHq03jgNcFraYMg/GFjP/HjXpND0NcVW4B6yMP4v/xhZz6LsziQZXvdqLZ1EQkPeAgXPmhmg/wV9ly6AyaieD6Yn6RSJ+VLjODdx6S1MpXoYQnGIsuUQkIt3WETy3BGHLxclzO7zf7N38/ux/Wmgr+nMTO3GYN+jkvkAeBBHBUGdNwzdFBJeFYx2Bo7PQtYFrL3uW7ggVGVgzy+UhsdSZi44y9Btx3wvc3pMUFlu+Fbhw5N+aW7caT3L1T0qSeymeJANXW9vTj3K1IcEXzatfL3tXJh3G525fss7I84AxCKH0QVNJnvYcBioER+DDNbqq X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 331f207e-ac1c-471e-6765-08d8fdace894 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2021 12:17:15.3196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7CI8OpWrUEvl7njDTP0ynTHuJkAISTR80lIRnDs+SumgNhMiMHr8RfB+goL2Ob1gTid/mwC5mK7HseVafx4ZZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6201 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_051859_495237_CE02BC39 X-CRM114-Status: GOOD ( 11.54 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The sbi_domain_memregion_initfw() is no longer used outside sbi_domain.c so let's make it a local function. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- include/sbi/sbi_domain.h | 3 --- lib/sbi/sbi_domain.c [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [216.71.153.144 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The sbi_domain_memregion_initfw() is no longer used outside sbi_domain.c so let's make it a local function. Signed-off-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Alistair Francis --- include/sbi/sbi_domain.h | 3 --- lib/sbi/sbi_domain.c | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h index 27316de..15e3a53 100644 --- a/include/sbi/sbi_domain.h +++ b/include/sbi/sbi_domain.h @@ -127,9 +127,6 @@ bool sbi_domain_is_assigned_hart(const struct sbi_domain *dom, u32 hartid); ulong sbi_domain_get_assigned_hartmask(const struct sbi_domain *dom, ulong hbase); -/** Initialize a domain memory region as firmware region */ -void sbi_domain_memregion_initfw(struct sbi_domain_memregion *reg); - /** * Initialize a domain memory region based on it's physical * address and size. diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c index c95c3c3..69a3795 100644 --- a/lib/sbi/sbi_domain.c +++ b/lib/sbi/sbi_domain.c @@ -64,7 +64,7 @@ ulong sbi_domain_get_assigned_hartmask(const struct sbi_domain *dom, return ret; } -void sbi_domain_memregion_initfw(struct sbi_domain_memregion *reg) +static void domain_memregion_initfw(struct sbi_domain_memregion *reg) { if (!reg) return; @@ -598,7 +598,7 @@ int sbi_domain_init(struct sbi_scratch *scratch, u32 cold_hartid) /* Root domain firmware memory region */ sbi_domain_memregion_init(scratch->fw_start, scratch->fw_size, 0, &root_fw_region); - sbi_domain_memregion_initfw(&root_memregs[root_memregs_count++]); + domain_memregion_initfw(&root_memregs[root_memregs_count++]); /* Root domain allow everything memory region */ sbi_domain_memregion_init(0, ~0UL,