From patchwork Thu Apr 8 21:15:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1464067 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-secospa-onmicrosoft-com header.b=F2U9QyHc; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FGYvG5ST3z9sSC for ; Fri, 9 Apr 2021 07:15:22 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B20BB81B52; Thu, 8 Apr 2021 23:15:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="F2U9QyHc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A3F8A81C64; Thu, 8 Apr 2021 23:15:16 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0605.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::605]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A1A1780C6D for ; Thu, 8 Apr 2021 23:15:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DzU7Hqrw8o3U/rbItG9rUX09UsT33SOFRJ7cSAszO0bnKpSdyIavldm1DQjuC6qO4AIh7xcCbLbWVSQEXWt3zLtezFDRZCEWWbrDcx4/KqEfyrVbdHz5rwRpWYve75/2HfSeYOysES5KH3mX+i6TlxgrtpNu4BK98/zgzB8uZUsBS/FNnG+NVk9bb5iVc4Dcgsv6+23MTWaeNZQfEvqhCC2xBoEcV50mvuDdkRN1EK6HY22jZgH6Chm9Av4QmibJb7l+yzVIl3bPaBQCblCF829/AAX7yDSPiLTMohzNz+mXdL1jugnS9bhUV2pKYBY2+SUteODPwqOOayN9PyS4ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F7jT340hDPdhFFVzJTEATbFvYGiaUXqJ5+FVawXVDPc=; b=ht+yFweFgZsjIcC8sHfojcwSjEUqdTD0Ft5Y1qAWHOM2BV1BHNxG/qn07bkXZCyXGk2pydpkOfDjBdnRilq/N/gzEm9iD+G1tjiqFk2YAD6soaQgLuS4YguX8D4R6ZEn3xPYvTDh6Vg8oUQqZA/sBjfvMOzelvTS44nwssSJ/SNFHonbHm2X4qVQvuXw8tYuaS7tLVQpjSLQLifxwUJMptGitIomUfqrPI2KctXqIg9xaleTxXVdw5msVi8/yoPaGOp47zLzx9LX3FxKyNHwLC0sT5XsqkajNpD10qRA7XmkPdd6fXDgeYdxwRptBceclzFn9u6lk74niz1K49M8Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F7jT340hDPdhFFVzJTEATbFvYGiaUXqJ5+FVawXVDPc=; b=F2U9QyHcaX3kHJw1MUF9aNy7vxZT8DJRN4sIPTu+/TuaYaNWJI9MNRd1KEi09jXuBrEMyBVaChWt2LVNG7UivQS6s0Kht1GT1ciHT1euhurF6NjHYqtqg6PLU8shAGH4xCwbuwWs9fjHDG8/RGto7ph3uBHN6sDk30aOCxLZM+U= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB9PR03MB7515.eurprd03.prod.outlook.com (2603:10a6:10:22a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27; Thu, 8 Apr 2021 21:15:12 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::a102:77c6:a933:8922]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::a102:77c6:a933:8922%7]) with mapi id 15.20.4020.018; Thu, 8 Apr 2021 21:15:12 +0000 From: Sean Anderson To: u-boot@lists.denx.de, Simon Glass Cc: Sean Anderson Subject: [PATCH] dm: core: Fix uninitialized return value from dm_scan_fdt_node Date: Thu, 8 Apr 2021 17:15:00 -0400 Message-Id: <20210408211500.2843290-1-sean.anderson@seco.com> X-Mailer: git-send-email 2.25.1 X-Originating-IP: [50.195.82.171] X-ClientProxiedBy: BL1PR13CA0204.namprd13.prod.outlook.com (2603:10b6:208:2be::29) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from plantagenet.inhand.com (50.195.82.171) by BL1PR13CA0204.namprd13.prod.outlook.com (2603:10b6:208:2be::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.6 via Frontend Transport; Thu, 8 Apr 2021 21:15:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a2b1079-0e86-4be2-4360-08d8fad3655c X-MS-TrafficTypeDiagnostic: DB9PR03MB7515: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:820; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7ca0KEf64p8LNOrhm63tlaLqmCf7ruFqIoUV5gb2bOoF75RIKgNw0DhuZ1yKc2r/1PY3o6MhCC7zAWSOAm6Xli9y9vfWGWy0l61oJZyyYC/CeeLFEghObRZVwoRFgr7H9sGsZlRKQ5t6h+RyJ72dmigHALRsd92Ohpj0PRJnaNuNbSY1e0nRRue8dFfi631AGSlL4/yVVv7lG7z83mcJQpgcYtU/GWilRgmGDJTnQBoZQDKsfFlp0almpwDS6eOq6JBBUBhTs9xdyhO+uSYiIsxodpRNDZSb7jnX7kMG2ZGWxMZki8MWHhhkhBubqBqu+mT+g7XQXsMXry0FHMNyU2HJ0AdSFErGC5QrO1SA70UJPLF1nPToXGvyt9w/3mFmgD/JSYqoLeqPYOWiVmLto34JLvzzqQv/B77ONzaTyHlQIRWkQsto4/QQRp/1CPK4cg+yityRgLYWgWKqRCWriP01gmNEOqqiueN28k4tMA86hWfk64kyVN1zWff7rU2lu06U4/qS6lXvnTkD2ZnGkV1kLzthfYGwCwRvfh6MWk0vPM5YEjdT0vXCXa3xg+qBFJo0vXZmUiKP+EgT5M+HQMjBjPW9P8r7GP3UKXwml52zga0asl+P8EGhovzN3NYg0a1N+tNFG5GCKC2tG25RopUXelXcHbf0jfKiItfuVH2Vzw+nOO8FNnwTFOhTzsrO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(136003)(346002)(39830400003)(366004)(376002)(8936002)(8676002)(38100700001)(44832011)(107886003)(478600001)(4326008)(66476007)(1076003)(6666004)(86362001)(66946007)(5660300002)(52116002)(6506007)(6512007)(38350700001)(36756003)(2906002)(186003)(956004)(16526019)(4744005)(2616005)(6486002)(26005)(316002)(6916009)(66556008)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: nuoW9dkIOoMAjYLRIV2XXy0cH8DwaYtbijbsy2cHphXSJlb1fxygDLOqf7+YzySO29h+99ggX/MaYjk7rT8307YCydeVPz8e9JQyOwZBBN0Xxp/O52is6LFPG5Vjp+2e2Lqe+T1iZq1m1YFALSCNO3XYHuYlX8uJuneaf69T+XXkp4ng0si9Tg5nIJjmnWZvg7jEFfGTyaMYEBoh3t7a4lKjUrO8iZskEwRiteJ2FXnxszoNW8pWLslWA2nUeLFFZr7aUi9s1XFaL/y1xTobtUtALWddohX+oh5ZEhxfANnfa4My8HnvRuYXmlHcq/LrYXBJ3IMv4v/peMrKLdemQfHWyPLrNBN3V3vRWT7j9xuM60CFdb0NsMWHB7Cq/DU0lnGBhqK+4w6VBfnOo7ghN97m1DXYazu6F8lwFgpLj3ODGDpW/qlF2GkUHa5CpOXJTRr5gxhYxfeiFIlxk4pNNqIr6iNm048m3/TmAQzD2btCnUYdezHLAs8PwtF8+aiuk9bYM9XQn+qAQ1fAMRw/Bz+Uuc/+cafM6hR+xOUjv3bbf4GDPUIkQOiylsFagy5oc5Ud8tU0bCObCIiNOw5NG7+R8aN16yH0JaEUZILf3InO5fsrBR9i7f5DIEszIbtp42G7kndRyCPxcJx+YjnOkzdUi7YAM7Jv+lufaD7EqEJGTCCsioCjSmgcq8Q6HHxS5NX9giQ0hmU+ZOl58gLkYpezVpGQdBgPJuWId5CS/SNitX2jCH62RbSRujw/lMJi9JomPVQP++8oIMOoEG9+mfpPn0IJfPqLqJKRVNbj064t07PR0kFcswRZU1DCswekOdVzQOia6LhFWizk9CVjbBfjbS8EgI8qM3DHX5LH8BNDNFc4yy1GZ5NssgNPUR+Mjs7ZqgHhjAElkn7lpshVQDZ5i+gt6fsU38EL9cG2NtKv8Hss9RYyY/G9TvG+dcpEQNePo7g+rpuGlNTPinza4mUy1xW7PYqnub16rxUR+I14kfHD2ET1xG+N6Itue0vsSuFu0QouqT4opK8qAYS6fVa1jT1ZPHWPiM8eGq/fG2iolrW5m+Ed38vaPJvCnAM5Qv1fTnKkDxh4jCNhIZMrKion68pXZWJ6bUcDP8XUb3gdgdwPt964ZG88O7+4gYL8EQIGOO5b3yL7HuidGmkwhqV7vdi6rw/qUpf2Qya25sM8ES0baF73V+ohK1KP5VfptfkrESU6aCvWQKkQmc8pUchhRFbcOlH9vk8R5UkiGe9rfCEMcYPqQ320gWU+i+gUgmne3ezNyZXjKOctZzuQw9Fs9rezgd8XNzk0UyaWJnT8TpnTI7wOCVFc1nartg4w X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a2b1079-0e86-4be2-4360-08d8fad3655c X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 21:15:12.0680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gWkCe5NVNb8olj31w5A3q9OQ8l+4foiMUguigvvgZjI+Bzt9x7rJvVUK0Y4Cp94JoX2LGgz1g+bQ30aJ2nxY6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7515 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean If there are no nodes or if all nodes are disabled, this function would return err without setting it first. Fix this by initializing err to zero. Fixes: 94f7afdf7e ("dm: core: Ignore disabled devices when binding") Signed-off-by: Sean Anderson Reviewed-by: Simon Glass Reviewed-by: Simon Glass --- drivers/core/root.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/root.c b/drivers/core/root.c index d9a19c5e6b..f852d867db 100644 --- a/drivers/core/root.c +++ b/drivers/core/root.c @@ -265,7 +265,7 @@ int dm_scan_plat(bool pre_reloc_only) static int dm_scan_fdt_node(struct udevice *parent, ofnode parent_node, bool pre_reloc_only) { - int ret = 0, err; + int ret = 0, err = 0; ofnode node; if (!ofnode_valid(parent_node))