From patchwork Wed Mar 31 18:15:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ravik Hasija X-Patchwork-Id: 1460672 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.a=rsa-sha256 header.s=default header.b=oiwpKAJ2; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F9ZJ46v8Hz9sVt for ; Thu, 1 Apr 2021 05:16:04 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4B3FC81FBA; Wed, 31 Mar 2021 20:15:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="oiwpKAJ2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C596782898; Wed, 31 Mar 2021 20:15:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by phobos.denx.de (Postfix) with ESMTP id 3916A80462 for ; Wed, 31 Mar 2021 20:15:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rahasij@linux.microsoft.com Received: by linux.microsoft.com (Postfix, from userid 1062) id 35C3820B5680; Wed, 31 Mar 2021 11:15:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 35C3820B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1617214554; bh=p83dxh36Li5gZhZEZBCJv+qIDykLYpZkCWZ1viVHEgc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oiwpKAJ2gRKhrBEbKpi1H4fBkAJbzNhcqx5VOguOhjUiGLdlKfgmGSRLN9t2N36+F eJLZjZymPd6heMqK13LjUoYYLdLsx5M1wXsmEYMSnXHlB6pUBKwTAEARWU/UqRDOR7 D03WS6zbkuz9G5nkPwwj9y06OGoABDvFi1jfqEbs= From: Ravik Hasija To: u-boot@lists.denx.de Cc: sjg@chromium.org, patrick.delaunay@st.com, swarren@nvidia.com, Ravik Hasija Subject: [PATCH v2] cmd: gpt: remove redundant print messages Date: Wed, 31 Mar 2021 11:15:49 -0700 Message-Id: <1617214549-26153-1-git-send-email-rahasij@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1617140080-24756-1-git-send-email-rahasij@linux.microsoft.com> References: <1617140080-24756-1-git-send-email-rahasij@linux.microsoft.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Removing printfs from do_gpt API as the messages are generic and does not specify error codes for failure cases. Signed-off-by: Ravik Hasija Reviewed-by: Patrick Delaunay --- Changes for v2: - Updated usage message for gpt read - Added removed printfs for write & verify - Rearranged verify printf --- cmd/gpt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/gpt.c b/cmd/gpt.c index 76a95ade6c..ba0fa4c69c 100644 --- a/cmd/gpt.c +++ b/cmd/gpt.c @@ -971,9 +971,11 @@ static int do_gpt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) if ((strcmp(argv[1], "write") == 0) && (argc == 5)) { printf("Writing GPT: "); ret = gpt_default(blk_dev_desc, argv[4]); + ret ? printf("error!\n") : printf("success!\n"); } else if ((strcmp(argv[1], "verify") == 0)) { - ret = gpt_verify(blk_dev_desc, argv[4]); printf("Verify GPT: "); + ret = gpt_verify(blk_dev_desc, argv[4]); + ret ? printf("error!\n") : printf("success!\n"); } else if ((strcmp(argv[1], "setenv") == 0)) { ret = gpt_setenv(blk_dev_desc, argv[4]); } else if ((strcmp(argv[1], "enumerate") == 0)) { @@ -992,11 +994,9 @@ static int do_gpt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) } if (ret) { - printf("error!\n"); return CMD_RET_FAILURE; } - printf("success!\n"); return CMD_RET_SUCCESS; } @@ -1017,7 +1017,7 @@ U_BOOT_CMD(gpt, CONFIG_SYS_MAXARGS, 1, do_gpt, " gpt_partition_name, gpt_partition_entry\n" " gpt enumerate mmc 0\n" " - store list of partitions to gpt_partition_list environment variable\n" - " read \n" + " gpt read \n" " - read GPT into a data structure for manipulation\n" " gpt guid \n" " - print disk GUID\n"