From patchwork Thu Mar 18 08:51:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455170 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=WvZ4yc83; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQ74nLqz9sWb for ; Thu, 18 Mar 2021 19:52:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229558AbhCRIwM (ORCPT ); Thu, 18 Mar 2021 04:52:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229843AbhCRIvz (ORCPT ); Thu, 18 Mar 2021 04:51:55 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9139C061762 for ; Thu, 18 Mar 2021 01:51:54 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id v4so4593042wrp.13 for ; Thu, 18 Mar 2021 01:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ystH3myeToYGZd9BOxHc1y/jrK48gikwMGVDRc5Ve78=; b=WvZ4yc83cLyyR8aCuTFUcfCIK/bNibqruWRisk+DMhXqt/psnvrO5+YG+tRKf+5Aot GsZxB3nikqN3W1lknbIYCXEW9JHbPu5KMAida6CNgoG0tCR2of0UuMlgHNPCJnmEjysz jOpTvluwFF3ERzUJCtNtbyqtxjEYFUPSNvH5Te+ykWyNgi8k4Rid7nX+qj9CsNZwnYEZ fsQocuR+ElhekSUXRkwdEJZ/7C857jYelmfjGrbgD+l35eOesr7+06mgJjZesbY/qGoY 1uph666BM+419FSsvemt7gyjVOON5MToMYyyluQrV6yqrAzy91RVDzNKRZMngMmDTQUg MduQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ystH3myeToYGZd9BOxHc1y/jrK48gikwMGVDRc5Ve78=; b=LiEEFDGBKTNddD7GcgNoIQk1Gcys0N0lxjwGNPkRHTyd47Jx4bS2LtQronR9puh919 oKC/v0tUJIWSNbFaSh4pkOdyHWPVdLGLjxtfidx7Fuw3CKnP5KGhucakqCkVuMXbHcW6 pSEiEUxV1gNiKR10rhzoekTBIzN6p3IbcR3+wIj578PT6IIC3C0rbIwMtQl8j2c9UCzL ClgJoFgrp8TZhQUJe8XacWiAYYTRl6Zf6Jw089MNQof/+1zLkm7zLdOn72SszayR+Mfh bIDbIl/H8CGfvvWlBeJq6j5COjIePWSpNvLW3p81pz6k57n5mLSrYYNXlh2O+uPqnwRw MtHw== X-Gm-Message-State: AOAM531AwtvIKOdgT6nKjHduvi59KMGlCCbiD60Oxlk/D2gkssj9Chau Cx1a5ncbSIiBlLmhRCLVG91Bpw== X-Google-Smtp-Source: ABdhPJxo8bV03/lAPsmphEXIb5LOtTF/A8T+YRXITJthCNS8OTQ2s0J5hMPfg+088GXYb3TJUXSkKA== X-Received: by 2002:a5d:560e:: with SMTP id l14mr8436423wrv.10.1616057513665; Thu, 18 Mar 2021 01:51:53 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:51:53 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Alan Cox , linux-ide@vger.kernel.org Subject: [PATCH 01/15] ata: pata_pdc202xx_old: Fix some incorrectly named functions Date: Thu, 18 Mar 2021 08:51:36 +0000 Message-Id: <20210318085150.3131936-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_pdc202xx_old.c:127: warning: expecting prototype for pdc202xx_configure_dmamode(). Prototype was for pdc202xx_set_dmamode() instead drivers/ata/pata_pdc202xx_old.c:228: warning: expecting prototype for pdc2026x_bmdma_end(). Prototype was for pdc2026x_bmdma_stop() instead Cc: Jens Axboe Cc: Alan Cox Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_pdc202xx_old.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_pdc202xx_old.c b/drivers/ata/pata_pdc202xx_old.c index 378ed9ea97e90..0c5cbcd28d0db 100644 --- a/drivers/ata/pata_pdc202xx_old.c +++ b/drivers/ata/pata_pdc202xx_old.c @@ -115,7 +115,7 @@ static void pdc202xx_set_piomode(struct ata_port *ap, struct ata_device *adev) } /** - * pdc202xx_configure_dmamode - set DMA mode in chip + * pdc202xx_set_dmamode - set DMA mode in chip * @ap: ATA interface * @adev: ATA device * @@ -214,7 +214,7 @@ static void pdc2026x_bmdma_start(struct ata_queued_cmd *qc) } /** - * pdc2026x_bmdma_end - DMA engine stop + * pdc2026x_bmdma_stop - DMA engine stop * @qc: ATA command * * After a DMA completes we need to put the clock back to 33MHz for From patchwork Thu Mar 18 08:51:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455169 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Vjptvur9; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQ72BNPz9sW5 for ; Thu, 18 Mar 2021 19:52:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229743AbhCRIwO (ORCPT ); Thu, 18 Mar 2021 04:52:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbhCRIv4 (ORCPT ); Thu, 18 Mar 2021 04:51:56 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A40FFC06174A for ; Thu, 18 Mar 2021 01:51:55 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id d8-20020a1c1d080000b029010f15546281so2590632wmd.4 for ; Thu, 18 Mar 2021 01:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dghe4e16SoJZePTTMhtOr9zN57JVN2TBb3j+pyrYZnI=; b=Vjptvur9A8fg9s/eoxmP7Ulmub4Ep9QpudaaWLCAfYjedBY84hELNAPgRRZ0vclPGq bZYj1i5znJ3n1+qkMIS+7EWfc3TkaW8D4he2a11w6PdcXmVc6anyErtgCoZC0dXMY57c I5ZwJACiZW1UyCCQrQScKEmBEteBPtaucq4g4YQG40ePt4zrj59kUKQurTyik5BfsKUb nWWUGXlabTfxvGDadFuiPy8A5xGQmnBu9dNPBSEmRjvsKkEWakZM9WOYcIMFaWm8YSn5 fHGD80Ey5Aa2d1C69g3PEKMMC2jqk1AkjJC4n05cvNn9xqqglh9wY+aUZZ8psBc2gh8b NiIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dghe4e16SoJZePTTMhtOr9zN57JVN2TBb3j+pyrYZnI=; b=At0HIZtb8Ee6d4OzpJ9RpHYXeN8JnirvktpnmljRefV+hvML0/PPDACDPQC1OdzZEF pmYpltcjEI3dmE8Fk/EUUHjIsQySrofMBmtlptyZu4li4Q/acLK1h7cAO64JvKHr7M2O vn4pNrEfNTuYTKfugJbvZW4HWfKVdT7Xs7q8NpaXKB5YpUjAj6L1f4X4GzkFQWVy7131 rk/FlDHIrfHnFATOWOXlCj7bl9Sfa8ye8+Ni5l5scT+X924HwjPuBDfJBnex2bzWthYj MLGlfqXMuIX+3rj1raJq65HqdFAznFLUmz4xa/tNJIDA7Urviqj9e1I3JYiWtjpj88Iz QNtQ== X-Gm-Message-State: AOAM532bxsiHKBojCNeKzaa7JJH0ujKf3sc19ROo+dW1cZTmOP0gPIlz 2cDIRUONHliX2Qy27APlmq1UzA== X-Google-Smtp-Source: ABdhPJxV4SOmkvtOxdAg2Q9kzeDxw8pQQHQKkfLqG0n/47BzITWxw2YlmX/9vL/ntqDPgzeImTqpeA== X-Received: by 2002:a05:600c:4f55:: with SMTP id m21mr2506388wmq.11.1616057514464; Thu, 18 Mar 2021 01:51:54 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:51:54 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , Red Hat , linux-ide@vger.kernel.org Subject: [PATCH 02/15] ata: pata_sil680: Add some missing function parameter docs Date: Thu, 18 Mar 2021 08:51:37 +0000 Message-Id: <20210318085150.3131936-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_sil680.c:68: warning: Function parameter or member 'adev' not described in 'sil680_seldev' drivers/ata/pata_sil680.c:254: warning: Function parameter or member 'try_mmio' not described in 'sil680_init_chip' Cc: Jens Axboe Cc: Andre Hedrick Cc: Red Hat Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_sil680.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/pata_sil680.c b/drivers/ata/pata_sil680.c index 7ab9aea3b6305..43215a664b960 100644 --- a/drivers/ata/pata_sil680.c +++ b/drivers/ata/pata_sil680.c @@ -57,6 +57,7 @@ static unsigned long sil680_selreg(struct ata_port *ap, int r) /** * sil680_seldev - return register base * @ap: ATA interface + * @adev: ATA device * @r: config offset * * Turn a config register offset into the right address in PCI space @@ -244,6 +245,7 @@ static struct ata_port_operations sil680_port_ops = { /** * sil680_init_chip - chip setup * @pdev: PCI device + * @try_mmio: Indicates to caller whether MMIO should be attempted * * Perform all the chip setup which must be done both when the device * is powered up on boot and when we resume in case we resumed from RAM. From patchwork Thu Mar 18 08:51:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455173 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=jgT7ilJ8; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQ85GVYz9sWw for ; Thu, 18 Mar 2021 19:52:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbhCRIwP (ORCPT ); Thu, 18 Mar 2021 04:52:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbhCRIv5 (ORCPT ); Thu, 18 Mar 2021 04:51:57 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F38FC06174A for ; Thu, 18 Mar 2021 01:51:56 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id b2-20020a7bc2420000b029010be1081172so2849761wmj.1 for ; Thu, 18 Mar 2021 01:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oxZxF4hq2WUxPEWONl0C36ILOQnwGtK5Kgu+3CdOvGE=; b=jgT7ilJ84tK2lz/jYCrcTsFWXdIQqjFrcSZO+wuwNCAxhhzUVWginn5lDvgg4pwc77 Rv44k5Pr08EeK23LgoIfQplCHraMOTZq4MGNYwJwEDTpECcqWBMrIXyRj+f6gqjCyyzC TeY59hmaF6eLpObK8nZyr6KDNHHTELki6neenOBxx6cJgBqLnQ1Bl1nFsAVx6gQFLp57 W0kyqEL1cvI7M0lpJoOkLrpkRCClWTmBvCu8wYJTo/wY9hlGkh2MA8kj/CmDn9kP8YX3 rCPNVUEZTA76WCIoyPgXBnxdushlS2CsOGQtZwLohO4WTDZJ/zrt5HYaDAn3pQ+U0LCt AMSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oxZxF4hq2WUxPEWONl0C36ILOQnwGtK5Kgu+3CdOvGE=; b=AyJD8jIzBfvmk6gjy4qnVFcubT/siAEx9J2R/StnI+hQq37QSfGa7tjzUVvE+1csNe y04JDGo1AkL3HoaeAM6JTQ86uxtQz9RXeHktQL5ZcnC6Qzid48AmMb3hMAXvwB3YYDx7 cJoq2BMLjGKRIDSNfn8t6VtS4XCig27o++3YEkv+Bq7oeGcCHpPbswsL71bQK8Aw0ggm C0XCwvmAqMd7hMWEP6m18UQAG6BKmwicDAtRyOdp4Hz0CjWTWw7luy24R319wEDlLoaf YniilwtUhZC4URJXgN3nur8GvlQgIe20Vtw7Ur587179bcD5y2MxpuPK64yH4mI3XwSR o5Ag== X-Gm-Message-State: AOAM532JEuPuEzxANjC/g/qKR9VdFQ0MTpgJVfJWNNzHSku3ZHL1opx+ 23WZtI9e0TLSvf1NRuukLFX13w== X-Google-Smtp-Source: ABdhPJwgIahBU2bvMS81hRPmVLgu9kQbD/3kXrFawRNphy1r7IwfrJ1vt+mGHm7VMPVbrmjhqKuc9g== X-Received: by 2002:a7b:cb89:: with SMTP id m9mr2554933wmi.27.1616057515445; Thu, 18 Mar 2021 01:51:55 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:51:55 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , Lionel Bouton , Vojtech Pavlik , "L.C. Chang" , linux-ide@vger.kernel.org Subject: [PATCH 03/15] ata: pata_sis: Remove superfluous param description and supply another Date: Thu, 18 Mar 2021 08:51:38 +0000 Message-Id: <20210318085150.3131936-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_sis.c:124: warning: Excess function parameter 'deadline' description in 'sis_133_cable_detect' drivers/ata/pata_sis.c:529: warning: Function parameter or member 'mask' not described in 'sis_133_mode_filter' Cc: Jens Axboe Cc: Andre Hedrick Cc: Lionel Bouton Cc: Vojtech Pavlik Cc: "L.C. Chang" Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_sis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c index d7cd39a9888a9..b5b764e18adfc 100644 --- a/drivers/ata/pata_sis.c +++ b/drivers/ata/pata_sis.c @@ -114,7 +114,6 @@ static int sis_port_base(struct ata_device *adev) /** * sis_133_cable_detect - check for 40/80 pin * @ap: Port - * @deadline: deadline jiffies for the operation * * Perform cable detection for the later UDMA133 capable * SiS chipset. @@ -521,6 +520,7 @@ static void sis_133_set_dmamode (struct ata_port *ap, struct ata_device *adev) /** * sis_133_mode_filter - mode selection filter * @adev: ATA device + * @mask: received mask to manipulate and pass back * * Block UDMA6 on devices that do not support it. */ From patchwork Thu Mar 18 08:51:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455172 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=P7fYXWgg; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQ82N5qz9sWj for ; Thu, 18 Mar 2021 19:52:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbhCRIwP (ORCPT ); Thu, 18 Mar 2021 04:52:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbhCRIv5 (ORCPT ); Thu, 18 Mar 2021 04:51:57 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8763DC06175F for ; Thu, 18 Mar 2021 01:51:57 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id r15-20020a05600c35cfb029010e639ca09eso4913260wmq.1 for ; Thu, 18 Mar 2021 01:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aoLGrjaA86gEYNhPzBdhJFKTeunMjqb/nCBdLbMyrRo=; b=P7fYXWggStTWJ87VH6ccWK9NEZNIsOaKORnKXyLJTqXez6COXfwcLnSnSE+ursORem W2K+IED0ZIE7OoVpSVjUgHyif+UXHFSe/vVCviNpSRD5VdN4nxhNlXQchP5VBu8WOmqx ViY3LKbNm3J3iDcxt1KfmQ/K9pirPDC93Ml1ualQCpOsII0L/dZ6cCXdpRy17M1DDDc8 ZIz1EhyDpnx4aD+irzAB3Lh9Yhwgt4WfWxnovtsk/Yjubor6xTWmTW5hlvgMk32Z1a5y JywumIFxihRXZPJ3fpW5wWSLMncKmHSn+qsTcastNFZmgW62JUeaKxRhTxqCPGWi1EtX LUOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aoLGrjaA86gEYNhPzBdhJFKTeunMjqb/nCBdLbMyrRo=; b=pEAXovLbSUe+vhS3AU3mTKs4PwK/XDm3qrFhOIbROanRhvxbGXOgAsOvdPNSWKtMf3 PHp3fCtGABI3z7Gy8g0qWSXlc0RoY5Ik9SSX5i84zPgH/9p8+iQhRFZkKgeHZ1t8bq+7 ljFXR2k3Mhg+Pt9owGUPnxqduO43FPCDikiUkZKuvkV1NPbjbr1npotXRKSKJTwvk29G hMgBnaMkbYQYenr6Mae2GmoP3727wAKInOYU+lRZ2u/A1a2UFKapMgvTT5PsAeZiEGeP RLlKQoZehN2erIEecmzqV/pPLx21FspzsE9deUeJsLo/WSlps8e5h2wF7dsj8CcxnhXk /CjA== X-Gm-Message-State: AOAM533TdassQ9o/VCBPWGeqaaG5owocmxRyOfd/JnpDu/9v4ffo+ijp 22OB6H4k+cods7hVmMbfDINwXosApuowvA== X-Google-Smtp-Source: ABdhPJwSvksHLUPPKG5u0cLbB8259uYmWTJcgL4zfB+XBygfRMGsA3fYXZfFeHbUs+uqn4X5byrctw== X-Received: by 2002:a1c:6309:: with SMTP id x9mr2547884wmb.62.1616057516258; Thu, 18 Mar 2021 01:51:56 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:51:55 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Alan Cox , Torben Mathiasen , linux-ide@vger.kernel.org Subject: [PATCH 04/15] ata: pata_triflex: Repair some misnamed functions and fix some param descriptions Date: Thu, 18 Mar 2021 08:51:39 +0000 Message-Id: <20210318085150.3131936-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_triflex.c:143: warning: expecting prototype for triflex_dma_start(). Prototype was for triflex_bmdma_start() instead drivers/ata/pata_triflex.c:159: warning: Function parameter or member 'qc' not described in 'triflex_bmdma_stop' drivers/ata/pata_triflex.c:159: warning: expecting prototype for triflex_dma_stop(). Prototype was for triflex_bmdma_stop() instead Cc: Jens Axboe Cc: Alan Cox Cc: Torben Mathiasen Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_triflex.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/ata/pata_triflex.c b/drivers/ata/pata_triflex.c index 2a4d38b980261..8a033598e7e17 100644 --- a/drivers/ata/pata_triflex.c +++ b/drivers/ata/pata_triflex.c @@ -129,7 +129,7 @@ static void triflex_set_piomode(struct ata_port *ap, struct ata_device *adev) } /** - * triflex_dma_start - DMA start callback + * triflex_bmdma_start - DMA start callback * @qc: Command in progress * * Usually drivers set the DMA timing at the point the set_dmamode call @@ -146,9 +146,8 @@ static void triflex_bmdma_start(struct ata_queued_cmd *qc) } /** - * triflex_dma_stop - DMA stop callback - * @ap: ATA interface - * @adev: ATA device + * triflex_bmdma_stop - DMA stop callback + * @qc: ATA command * * We loaded new timings in dma_start, as a result we need to restore * the PIO timings in dma_stop so that the next command issue gets the From patchwork Thu Mar 18 08:51:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455171 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=g+524pjB; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQ804Q1z9sWd for ; Thu, 18 Mar 2021 19:52:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbhCRIwQ (ORCPT ); Thu, 18 Mar 2021 04:52:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbhCRIv6 (ORCPT ); Thu, 18 Mar 2021 04:51:58 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 477B6C061760 for ; Thu, 18 Mar 2021 01:51:58 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id x13so4608666wrs.9 for ; Thu, 18 Mar 2021 01:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZhbJedmQUxP+5l1CY/WvdMVn4GmUSphVJyAa3aPfYeY=; b=g+524pjB68OpStk2UTz5JvSpTr+nqBKHyf+sbLG5h3xinlzB1qYw/BDf0CV5IJB7f3 Je6HUBlzu8AGeogtjbF+4M3Lx9k38MBfudzqwwzyjK7DcUuewOKhqZSNDCiFtUUoilkc Z1T7/eKcGfrbBTktlmmyMS3bTqEzcjP6/TjrqcHDh06V82+833PLPGehUpvySSbdb/fU IcHyiD4WOB+hPF0OJd3nyBQGl/psuEsnOwuvmhrJxSkAmWHSmnBSWZNOiUsbAHMcE00r 0xa/0CMbAPbwSlPH6IgZPo3ujcXka+oHRaa1Dd1fZvOV147iXX7K5HyTIwzzOqXgaV/q 30eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZhbJedmQUxP+5l1CY/WvdMVn4GmUSphVJyAa3aPfYeY=; b=BZtVls8zoHo8Q6OTbUJkTrJw9Qvd9wY/SSkYgE8eF7HctzoCyyqFR8hZVqAr8TpAMY U4hdVo6MV9vgj/EHPGs8DnUUIccW6/i73FIiho8rkkbrrqEgGOoNUOkAYZ0l3K6+++Dz OMTXjTLA/mf3NWb6XixucaFqngzGzLAcVsgdDb9BzGKuySY+YMQOV5IfgwJRaZALb4LX ji7OL+LCOX5NwVnt7rIJo4j26FcjTHQRoEQFDJnqbvZnDqiA1R3hLC56lyMcs4cwj/XT LDaQi39EindGVh61oRpqs4XQ9AO0NTlANIa5+vmoGdyw/bYgCWGDhiMH4Nb0Im02gPnX FkGQ== X-Gm-Message-State: AOAM532vgTuSfSatDFSpKtkh9DA4Ce/mAE+tgqrokee4+EFzAX5IboCY hMMiWvoL2o76KJXwO5JlxUwJ/g== X-Google-Smtp-Source: ABdhPJz/I4x45NEO7/hE6qMgwqk8vHb2i0yKi8wYMdR5K6R/bTbkCOE7MNAMxfoKdLVMiIix8y3Z8w== X-Received: by 2002:a5d:468e:: with SMTP id u14mr8554111wrq.359.1616057517086; Thu, 18 Mar 2021 01:51:57 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:51:56 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Alan Cox , linux-ide@vger.kernel.org Subject: [PATCH 05/15] ata: pata_it821x: Fix possible doc-rotted function names Date: Thu, 18 Mar 2021 08:51:40 +0000 Message-Id: <20210318085150.3131936-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_it821x.c:346: warning: expecting prototype for it821x_passthru_dma_start(). Prototype was for it821x_passthru_bmdma_start() instead drivers/ata/pata_it821x.c:369: warning: expecting prototype for it821x_passthru_dma_stop(). Prototype was for it821x_passthru_bmdma_stop() instead Cc: Jens Axboe Cc: Alan Cox Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_it821x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c index 9bac79edbc2ce..0e2265978a34e 100644 --- a/drivers/ata/pata_it821x.c +++ b/drivers/ata/pata_it821x.c @@ -334,7 +334,7 @@ static void it821x_passthru_set_dmamode(struct ata_port *ap, struct ata_device * } /** - * it821x_passthru_dma_start - DMA start callback + * it821x_passthru_bmdma_start - DMA start callback * @qc: Command in progress * * Usually drivers set the DMA timing at the point the set_dmamode call @@ -357,7 +357,7 @@ static void it821x_passthru_bmdma_start(struct ata_queued_cmd *qc) } /** - * it821x_passthru_dma_stop - DMA stop callback + * it821x_passthru_bmdma_stop - DMA stop callback * @qc: ATA command * * We loaded new timings in dma_start, as a result we need to restore From patchwork Thu Mar 18 08:51:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455176 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=FhDE3pfD; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQ96HBVz9sSC for ; Thu, 18 Mar 2021 19:52:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbhCRIwQ (ORCPT ); Thu, 18 Mar 2021 04:52:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbhCRIv7 (ORCPT ); Thu, 18 Mar 2021 04:51:59 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23BD1C06175F for ; Thu, 18 Mar 2021 01:51:59 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id t5-20020a1c77050000b029010e62cea9deso2862552wmi.0 for ; Thu, 18 Mar 2021 01:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ww/weUvcZaIAW1/4IpRQWiCV/q1/L856MjOkNuPC5RA=; b=FhDE3pfDksVXYUzEAGqiZS7G/a/+SpHaqrnIPtUgrDi7hdV61S1cwwFL6WibH4DVQA 7BYLoK7xBgnnaaP3+FWe5Hx1ZSFbe0tB3LfaFiEBebsk859pSyITDQVX+R8WXg6OFWJR WMroLtrHgqmabUKp8sMZ9k7h6cQA+N+6QmL1e42KvPqFkT51/V4/BY2am8yYv8shTfA3 jlGnlEPSO5cObJFOlKN+7u3g3RaqtppW57ikKS4C4nh60k2kn4HZyX/LuKLmWBeR0o/a focEbvW9E3SfdgGhbW2y5cput/Td7tTJH8s7WCvsgvDpwZL77dZfrOszNjEfmrlEi787 bTgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ww/weUvcZaIAW1/4IpRQWiCV/q1/L856MjOkNuPC5RA=; b=YNAcdZuLqYNnLr3ANRLAjV21NFfV4nRXvNSxbQfhmAmapUGGqs5M/WQrgaAsZBN8KX XYRLHoKsfaGWgyy/hrK0EgfqXgCvU+v2RhdKwUlicl7dM9ZUA/s5+VxhTEGgQyURB+uN LhP+KE6wvO1OlxiCTVx5YRqoTA7MDYIWW14BitqotbcjWMHJwQoOIbl0QGvN+2jx4mBd G/3jRCD5NBxGxl7u+MgG+8gjweDkd6diQ7UyTyaFaqaiv5ZqVaJRyiAy+bVhQLXc9ZRF XQ+OzP6bf6QZx5UpLV9hEQQmJKQx0IPA5bh7Uu0rAxD5NNr3PctjYA7CwetjCNNUxbnj TOEA== X-Gm-Message-State: AOAM531A2c2Yl/4KnRVHXDzDMwN9p1SUeX4p3eOgWjN4fifUk8epqMb4 Thk++eFSV68KWc8ab+Q/k+0kyXKm8P02Mg== X-Google-Smtp-Source: ABdhPJyolUMm6pIu0p+Uaj0fKL7mW2TP2e9kaIVExOqOtxpFxB3CiGiRHpoOpYTwD5PBccU6tDJZdw== X-Received: by 2002:a1c:c282:: with SMTP id s124mr2515271wmf.99.1616057517906; Thu, 18 Mar 2021 01:51:57 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:51:57 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 06/15] ata: pata_via: Fix a kernel-doc formatting issue Date: Thu, 18 Mar 2021 08:51:41 +0000 Message-Id: <20210318085150.3131936-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_via.c:675: warning: Function parameter or member 'pdev' not described in 'via_reinit_one' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_via.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_via.c b/drivers/ata/pata_via.c index 38044e6797951..4750320489843 100644 --- a/drivers/ata/pata_via.c +++ b/drivers/ata/pata_via.c @@ -663,7 +663,7 @@ static int via_init_one(struct pci_dev *pdev, const struct pci_device_id *id) #ifdef CONFIG_PM_SLEEP /** * via_reinit_one - reinit after resume - * @pdev; PCI device + * @pdev: PCI device * * Called when the VIA PATA device is resumed. We must then * reconfigure the fifo and other setup we may have altered. In From patchwork Thu Mar 18 08:51:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455175 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=y6Bd33NP; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQ93hDlz9sW1 for ; Thu, 18 Mar 2021 19:52:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229884AbhCRIwQ (ORCPT ); Thu, 18 Mar 2021 04:52:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbhCRIwA (ORCPT ); Thu, 18 Mar 2021 04:52:00 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19E8FC061762 for ; Thu, 18 Mar 2021 01:52:00 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id z2so4598795wrl.5 for ; Thu, 18 Mar 2021 01:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qBw5nJooq34YS/jxcj30RML2GTr2FUzleakjhCquzqA=; b=y6Bd33NPTlbrNrDNk5ltgxDfqEu0YSGOTuMoUR/1UIjYmrZYLJlAWNrU1Kji+onJFN JZlNNLamvo6yZuyOIOxIIHkCxXNVENB12TaV8AtSTH04T3LeDaNwngt+LtB8VbfnbFWd RgPClcK0v0wmyVHRHHnp26/0tuLBlpjb0p2At/D1FK0Q7bvn7U+s7ccmnxX9xmnXGlRq 54CsgzbbI60bJVuc2od8/tCuFyEchLxML+jJYCoMeQ8ghmgo0JDRUYPYdOK81luLQdAA lAlyub2xO6vdYol6boQGUEj2MmSPFGiyosjp+QdjBaKkQeMmUuVdt3aYiIfv8y0uE3Fy pTow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qBw5nJooq34YS/jxcj30RML2GTr2FUzleakjhCquzqA=; b=JFSIynnsaKstlNzBgyx/WzXG3Co5S0lPwolfb1s2dYyh3QTDdnybQBYm0KJOC0Bb6j oR96IhKyhWjm8ucmqfUImYQhHJ7TY5xMhOVorl1qw6Ysh9NXO+oKzKjw319+kjWEz0mU BssLRwKMCVEQf8YFszUvFig3t6vI4S1BE0t1rMKzDyEpZ65fGJabBWZzHNJlO6qn6qVq sub64YnB6zodxVmm49wOQBp4aw9QjISGA91iMuCTauih3mgp3XOu+SEq1UxpucaHAJ2M wgTYkzHnHn4esUpU3fbMQweHHPVB31vy0uZ5yOdr0414HDJvDssoRBInQ/gG3AcMW9jQ 1qCw== X-Gm-Message-State: AOAM5318lvf8VNSbwOWc2f1FwPqKHk9BUQuEfkYyv+fTevFKiG5v/L1d EOhScc6QAr113SCU1UoVF9fBrA== X-Google-Smtp-Source: ABdhPJwLSz3XO+Lumh3wZ6Y75pm80hiRCK36mLGAazKBoInU/8OojCpv+2FWnoiz3qOtUJTUp+nQNw== X-Received: by 2002:a5d:526b:: with SMTP id l11mr8299694wrc.385.1616057518854; Thu, 18 Mar 2021 01:51:58 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:51:58 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , Hat Inc , linux-ide@vger.kernel.org Subject: [PATCH 07/15] ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header Date: Thu, 18 Mar 2021 08:51:42 +0000 Message-Id: <20210318085150.3131936-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_piccolo.c:87: warning: expecting prototype for ata_tosh_init(). Prototype was for ata_tosh_init_one() instead Cc: Jens Axboe Cc: Andre Hedrick Cc: Hat Inc Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_piccolo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_piccolo.c b/drivers/ata/pata_piccolo.c index 35cb0e2632379..389b63b13c706 100644 --- a/drivers/ata/pata_piccolo.c +++ b/drivers/ata/pata_piccolo.c @@ -74,7 +74,7 @@ static struct ata_port_operations tosh_port_ops = { }; /** - * ata_tosh_init - attach generic IDE + * ata_tosh_init_one - attach generic IDE * @dev: PCI device found * @id: match entry * From patchwork Thu Mar 18 08:51:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455174 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=CA700hUJ; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQ91Mckz9sWV for ; Thu, 18 Mar 2021 19:52:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229886AbhCRIwR (ORCPT ); Thu, 18 Mar 2021 04:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229880AbhCRIwB (ORCPT ); Thu, 18 Mar 2021 04:52:01 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECEAFC06175F for ; Thu, 18 Mar 2021 01:52:00 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id j18so4608146wra.2 for ; Thu, 18 Mar 2021 01:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DSIM2KKFr13N10pkFzbCvVsAAb9CD2J/MyFkt7g9szU=; b=CA700hUJYglYphG7hWhs+QWaHdDggOUb4ENo9IZTXiOYWDmEKwmIZ6iaZ7orORhxJc ApqyUHWhUmdY9go/HZ3dUEgcSMgUFFcd138H/EbLKjPzmBrWXuag6JF+49iiCdDZ49me fYi5r3tooDhkTFYTEeMSAwJ223ReivQzTuKtB/Jharx2Rq1EE54u/rPq1CrllGe7KV+e Ha1qBqsB34mHiH+wcPAfGSCb395h0mW3I4qrLpALGELxE8rz1hCOolaXSX25Fqa9ETgb 6a8SUNpDVZhcrCORzCH6ailvSHY+lMXFOQIRuWVSWNlq1R1gSQXjIUuF9wyINGos/A+6 RPRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DSIM2KKFr13N10pkFzbCvVsAAb9CD2J/MyFkt7g9szU=; b=RzvUsKb4qQnQuyT9KeW7lEib3KR5JsF6l5mdykTYq4mZqNsmUSJrw5B8ovm6j/Qwjv Fj4t22rhKouHrBxEH0M5muYyVR18HIWjF3xQgxFyADE8D8OUHZnbOVuSKIHxZkrKAORa xj6rlCuntoOJBZw7te1WvGe2dZgYpGaq8X1llp5A0HOPAmGlLzFZJtGKr9elStAAxkx6 f1rTXE1o9zdwL9SpBrnGJdCmDQAOdOLgR+8IAxlAlcGqjPrBNqB5iRM5KsB5U8oV0aTH 0VU1hBCCzHblq89xgxWR/c7E+xYXVaWFwuni3zxHwMu0nFieeQwgqyQa3KakGYyvnL1H MzzA== X-Gm-Message-State: AOAM531zi/ruf2439oNMAx2xVI7wPdbunB5g1NwFcndu4iMDBOe89dSI D2ipQhE2dxkwxDoDMSL9secOMg== X-Google-Smtp-Source: ABdhPJzEPYgbRNUAwcuzE78GENH1iH412dXX0gAwXiEmKzjEbfvmuU6qm40gguyTgpxrotpWTqRWUw== X-Received: by 2002:adf:83c2:: with SMTP id 60mr8375626wre.386.1616057519679; Thu, 18 Mar 2021 01:51:59 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:51:59 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 08/15] ata: pata_sl82c105: Fix potential doc-rot Date: Thu, 18 Mar 2021 08:51:43 +0000 Message-Id: <20210318085150.3131936-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_sl82c105.c:191: warning: expecting prototype for sl82c105_bmdma_end(). Prototype was for sl82c105_bmdma_stop() instead Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_sl82c105.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_sl82c105.c b/drivers/ata/pata_sl82c105.c index ac7ddd87f188d..8487470e2e01e 100644 --- a/drivers/ata/pata_sl82c105.c +++ b/drivers/ata/pata_sl82c105.c @@ -173,7 +173,7 @@ static void sl82c105_bmdma_start(struct ata_queued_cmd *qc) } /** - * sl82c105_bmdma_end - DMA engine stop + * sl82c105_bmdma_stop - DMA engine stop * @qc: ATA command * * Reset the DMA engine each use as recommended by the errata From patchwork Thu Mar 18 08:51:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455178 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=PNjjaiEo; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQB3xyBz9sWV for ; Thu, 18 Mar 2021 19:52:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbhCRIwR (ORCPT ); Thu, 18 Mar 2021 04:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229872AbhCRIwC (ORCPT ); Thu, 18 Mar 2021 04:52:02 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BECB9C06175F for ; Thu, 18 Mar 2021 01:52:01 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id b2-20020a7bc2420000b029010be1081172so2849920wmj.1 for ; Thu, 18 Mar 2021 01:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1LSRu3B7vTOehIF+pPi+UNH/SrfnJ26bQ8jJ9MYE7/g=; b=PNjjaiEovLZUonRxnIGR3ImVloNSF8ldt8dyaCxBC28aqjKAs/a5DKAZ+N59fzdauZ y6m3IBNONcOWwWtX8Fby+/P2l/Pzh0OFUZeiiW9CQH1yr4WlbgVD2vCa+Dja8GFVkU5p i6TPratcgwrM0szQJuHbqAxm/n6prU8nimMjbSp9CZGAmS01oZIGuqpqtIdZWAlKPRy6 9Q9zfsRROdM6T+jFl/dKas9kSn8n9Ugn2zLgJixA80jYp8fQ6Cwl4fwSyfuY13hn7KxS 4U37PDUXSpSvP28vQm+1lAUpqPoi4abMoRdlD5DfjR2SgkNTDxq49dyIulJT2pzIsi95 l23A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1LSRu3B7vTOehIF+pPi+UNH/SrfnJ26bQ8jJ9MYE7/g=; b=IuejPGyjyaCrUYP1prDfQKnqqy/FUId1QNSZr7kqDJ3dL9U8tByAs+h/+d0gEtC2Aj lONILk2nub12wGQit6W1H7uprnN4t7InzlxJVfDHzEwnwuGy79e8gYjxN38O6DH4IwW2 Sxa0P7igZBZ3Fza9asLINDx3G8z7+AXqF0MuDtMs3x6aDWkSfRc+iLV22LWb23TVR9/1 +Gpu8bdknl1pw37+vnGMRQmvKEblz55kV3B8ops8tkvTuxKjBWju72/jrHVKpk8S1Tfp /Lb+Q6mSE7bphFJU95VpAqkVpdBqg5yiRYSLK7p5MPIG8e2COMtzSTkcEHKX5Fqhf1c+ T3XQ== X-Gm-Message-State: AOAM533LCUcFKKxOUFR6Z1Wfgv5AyQnU23P276YRGT2x6SKWMjsnUWZh pRHJpQffis+fI1f1jOI2FhqztdjbkAZWmQ== X-Google-Smtp-Source: ABdhPJwxfsmQo8LTvurXnGpxqnAHfbVwXbRto0zZJmZy7QI/jBR+MV+eJWV7QIMprPIybvud/h50pQ== X-Received: by 2002:a05:600c:4ca9:: with SMTP id g41mr2556836wmp.150.1616057520550; Thu, 18 Mar 2021 01:52:00 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:52:00 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Jaromir Koutek , Jan Harkes , Mark Lord , linux-ide@vger.kernel.org Subject: [PATCH 09/15] ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()' Date: Thu, 18 Mar 2021 08:51:44 +0000 Message-Id: <20210318085150.3131936-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_opti.c:82: warning: Function parameter or member 'val' not described in 'opti_write_reg' drivers/ata/pata_opti.c:82: warning: Excess function parameter 'value' description in 'opti_write_reg' Cc: Jens Axboe Cc: Jaromir Koutek Cc: Jan Harkes Cc: Mark Lord Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_opti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_opti.c b/drivers/ata/pata_opti.c index 06a800a3b0706..01976c4e40330 100644 --- a/drivers/ata/pata_opti.c +++ b/drivers/ata/pata_opti.c @@ -69,7 +69,7 @@ static int opti_pre_reset(struct ata_link *link, unsigned long deadline) /** * opti_write_reg - control register setup * @ap: ATA port - * @value: value + * @val: value * @reg: control register number * * The Opti uses magic 'trapdoor' register accesses to do configuration From patchwork Thu Mar 18 08:51:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455177 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=n6g2xois; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQB1cF7z9sXL for ; Thu, 18 Mar 2021 19:52:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbhCRIwS (ORCPT ); Thu, 18 Mar 2021 04:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229803AbhCRIwD (ORCPT ); Thu, 18 Mar 2021 04:52:03 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6B47C06175F for ; Thu, 18 Mar 2021 01:52:02 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id k8so4602640wrc.3 for ; Thu, 18 Mar 2021 01:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u5wivGTr87AFeSVjq+RPxAGgUPqftM9xBrGW+nIjIr0=; b=n6g2xoisS0ymTmWPWtvMfF3pktpNrRfc38MouzDXCl2G9wZiRyN1IJDDU0DrjekF0f G6GW9SmWZmmnoBQvbNepQYyYcSCHHGzUAYyvZMoV+ZCkn3JmPYfu78sXT9V/9RgyJysU peE/74Rml5/Me/rthJLUdzQALRajCSfLvmYbHPx2/WTIWIJcWv3nfCM+jKTeAIPKo5je LVvrFLkcdxQdiZG3XNhChfZMIVlqo2KyOAEeOTguUbezO6Pq3LWjYpMTM8fvpdn+q2pU rRISqXuHy+MgDpbwz2LNQ63udW8Wewm/TO/uZyJqCeCUNzKER6TGJsbtHu+4FqBH0+Cr 0d6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u5wivGTr87AFeSVjq+RPxAGgUPqftM9xBrGW+nIjIr0=; b=h/IrhzefGUZuQx6kZqIAld5ojG7BNCyvyYiM4mvYyTYNYY2oXq3L8diNh5vHNkzHMs TDTc33rnsga8aKo7p+xrQdGmn1n4vu0sXpsRTpmUuC95jAntY/zcjrzrFpaoFadmhGzu P++pfOR01U6o9gNc6qGGUKKs7r99RAevQF57HiD+UrnyStUinV+65KF76vG1mIRtK3Z7 84BUHKhFqSCsuqs7+Cp5q1ZE7gR53cqaX//tcnbICzAMWzvGBWAYYUmXAi+yqc5NtiWJ tEf4S81nDBvvhytgUm0563Uhzf5KoVjfiRjGDTkeUcNk8qTCbnMt8jOIt2O08j323a7V aBzw== X-Gm-Message-State: AOAM532dBbbZjzx/0pgcISed/iHDUkF6TO4OdGo6QbbNrAfRM//lcgJG kBjj4MQzJmwhZRy8JDDrDJuLXA== X-Google-Smtp-Source: ABdhPJw2Na7Ak0qwm6kHBbG3Of6Eg8McOWqQOjJsj4cpF+pgsUQWGQ4wyl9sDf8tJEBgBkCkLW+Riw== X-Received: by 2002:a5d:424c:: with SMTP id s12mr8629682wrr.161.1616057521488; Thu, 18 Mar 2021 01:52:01 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:52:01 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Andre Hedrick , Hat Inc , linux-ide@vger.kernel.org Subject: [PATCH 10/15] ata: ata_generic: Fix misspelling of 'ata_generic_init_one()' Date: Thu, 18 Mar 2021 08:51:45 +0000 Message-Id: <20210318085150.3131936-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/ata_generic.c:164: warning: expecting prototype for ata_generic_init(). Prototype was for ata_generic_init_one() instead Cc: Jens Axboe Cc: Andre Hedrick Cc: Hat Inc Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/ata_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/ata_generic.c b/drivers/ata/ata_generic.c index 9ff545ce8da3e..20a32e4d501d3 100644 --- a/drivers/ata/ata_generic.c +++ b/drivers/ata/ata_generic.c @@ -151,7 +151,7 @@ static int is_intel_ider(struct pci_dev *dev) } /** - * ata_generic_init - attach generic IDE + * ata_generic_init_one - attach generic IDE * @dev: PCI device found * @id: match entry * From patchwork Thu Mar 18 08:51:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455180 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=hOaFBnS1; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQC2Dt3z9sXb for ; Thu, 18 Mar 2021 19:52:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbhCRIwS (ORCPT ); Thu, 18 Mar 2021 04:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbhCRIwE (ORCPT ); Thu, 18 Mar 2021 04:52:04 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C736C061762 for ; Thu, 18 Mar 2021 01:52:03 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id w203-20020a1c49d40000b029010c706d0642so6516858wma.0 for ; Thu, 18 Mar 2021 01:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GaackZ/z/LereQfTWx6EZY6YyaXRiP4t4NnTncEoRCA=; b=hOaFBnS1qL4EZR4viHQwVJgMva2mOeGRvIL4fuUMRhTF5KlXTL27cypHXcqyLPU9ym ptdWABTJunZmopbdxFY3/uyiRuUeA3/Q3UEN80dQm1oAGG49y9/rHmtT7WO3d+psKtIW 4Wo9VIBg0fX6g9AnuIt18/iI+tv+gBWlBhyXS+hlNi+aLHsijUkLw3BrOUaLxh9SxQuV 60+NQBDb9bQUXgG60CAZM6YSRq7WwpTT8gOFnLvS7dDyaQ/K4PwYAiaFZaQHjncg+ZjY I9puisGMIqbK3GatIdPjfeiOHp4t9xQN748FETqDNEtbHMcYlfVs2JhY0w2VtLpEZsHT kEfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GaackZ/z/LereQfTWx6EZY6YyaXRiP4t4NnTncEoRCA=; b=aajLE93o+TgmJWgCD6DW9n/8c1T0hENnTFBpe/LF6oBFLFPDLd0rH+N1YvNETug4jA CNpDz5H5LNT267RH2Ip+xmM0RseL7K6nUn3T7NTwLeGs1Lr7XMbUs2WR2w7ttKm2fo0p xsJbwxG8hZzl9Pf9ZcX+/aESddfpzxj5SfK3zr8Upf0J20HYr4NPiKg/o4gnW3bpZ6nI Ul1B4YQEYie++LJps7SPGsTmISrpnXO1rge3/F5Ez8kuH3rlrbdlY4yFbzxPY/zWi4Ya 8Lw+h6M04reUtAXHZ559iBdfaGUSq17hMPi9BP/rs8A/kQOs8HFmOchsYzQRS+XaM4UG zH5Q== X-Gm-Message-State: AOAM533FyMGdb1+o6foJ0RCZ4CvOxqGl6SUa4B+u0OgNHHGvJb+HG5eM tix3nYoHnmNWjdbtnpTNxC2iYQ== X-Google-Smtp-Source: ABdhPJxyXMICdkigPOOwmxZ9OVNAiEXw7pw+/JSuD26xTSpiSRESPA5e655cnDxb8hRfkdI6Or5ojg== X-Received: by 2002:a05:600c:b57:: with SMTP id k23mr2456756wmr.145.1616057522356; Thu, 18 Mar 2021 01:52:02 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.52.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:52:01 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Colten Edwards , Samuel Thibault , linux-ide@vger.kernel.org Subject: [PATCH 11/15] ata: pata_legacy: Repair a couple kernel-doc problems Date: Thu, 18 Mar 2021 08:51:46 +0000 Message-Id: <20210318085150.3131936-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_legacy.c:606: warning: expecting prototype for opt82c465mv_qc_issue(). Prototype was for opti82c46x_qc_issue() instead drivers/ata/pata_legacy.c:933: warning: Function parameter or member 'probe' not described in 'legacy_init_one' drivers/ata/pata_legacy.c:933: warning: Excess function parameter 'pl' description in 'legacy_init_one' drivers/ata/pata_legacy.c:1024: warning: Function parameter or member 'primary' not described in 'legacy_check_special_cases' drivers/ata/pata_legacy.c:1024: warning: Function parameter or member 'secondary' not described in 'legacy_check_special_cases' drivers/ata/pata_legacy.c:1024: warning: Excess function parameter 'master' description in 'legacy_check_special_cases' drivers/ata/pata_legacy.c:1024: warning: Excess function parameter 'master' description in 'legacy_check_special_cases' Cc: Jens Axboe Cc: Colten Edwards Cc: Samuel Thibault Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_legacy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c index 4fd12b20df239..a7235bde6ae87 100644 --- a/drivers/ata/pata_legacy.c +++ b/drivers/ata/pata_legacy.c @@ -588,7 +588,7 @@ static void opti82c46x_set_piomode(struct ata_port *ap, struct ata_device *adev) } /** - * opt82c465mv_qc_issue - command issue + * opti82c46x_qc_issue - command issue * @qc: command pending * * Called when the libata layer is about to issue a command. We wrap @@ -923,7 +923,7 @@ static __init int probe_chip_type(struct legacy_probe *probe) /** * legacy_init_one - attach a legacy interface - * @pl: probe record + * @probe: probe record * * Register an ISA bus IDE interface. Such interfaces are PIO and we * assume do not support IRQ sharing. @@ -1009,8 +1009,8 @@ static __init int legacy_init_one(struct legacy_probe *probe) /** * legacy_check_special_cases - ATA special cases * @p: PCI device to check - * @master: set this if we find an ATA master - * @master: set this if we find an ATA secondary + * @primary: set this if we find an ATA master + * @secondary: set this if we find an ATA secondary * * A small number of vendors implemented early PCI ATA interfaces * on bridge logic without the ATA interface being PCI visible. From patchwork Thu Mar 18 08:51:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455183 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=UFMJn5wd; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQD2LVvz9sj1 for ; Thu, 18 Mar 2021 19:52:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbhCRIwT (ORCPT ); Thu, 18 Mar 2021 04:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229903AbhCRIwF (ORCPT ); Thu, 18 Mar 2021 04:52:05 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D3D7C06175F for ; Thu, 18 Mar 2021 01:52:04 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id x16so4605034wrn.4 for ; Thu, 18 Mar 2021 01:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LyiarI8XI+wr4cdrUP10jrX5TiM2u+Q08u5Edv+SeZQ=; b=UFMJn5wdi36JaAz2Mtjh0Yn3v4pMvV51lK4rgktPR83seHiknusOzEY081nZ0utH9E XsBjfmNGLBWwL3IwX/rHlehaL5IOMB2hwQ93D6exxnriB3HyIzgE/6VqvH6oizTh6sIa 3zJ0kloQGxi/vSZOQejyRMLGFC+hURMKXakf5Dt96K3XV+uhioLxhl6QZXadfVAPX4p1 /AlXszKtCNVLnxxMgOWXc7FPboidwGsAsm/8HIGZ2si/gIL55PqndogUsMPaKFiH3Tcs 87tSbTDNEz6f7vxk1Iq+05iVhdNmxWoIBxRAWK5T6riqKsGZgshzwgBsU83NAyR4rO9f TzRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LyiarI8XI+wr4cdrUP10jrX5TiM2u+Q08u5Edv+SeZQ=; b=ku2CSo52c8bJXe+5rUeeVQBqSdOmcyuFLHLaNZ58y9nrLUTSew9rBWpN1J7bxFjeUW 15a0LBSfE+Z6ePuAr0jpRsNh2Br+Q51BqFyfwvNU+O/NU80f9b9cWGgbfyDNsQdFlVFy FdIA5QzaDQQHpeBdMoSoyIbc1Bd/YWsLQK26Sv8CeGiSdQ7LuopWdDUpEqEv1wUxYFwE 9BrLGfaSzU1q/iTXfc/NCyKMO/reXfQMNe7mZODVQ4GPEyqjmSCaBHnmMYoeAYoGHEYa 5vlwrKRM4zQ1O11xfz7moQvWz2hIJKAaEw2rtBJndrysPEuNUET9dmqGVVxOe8RTPebl w8+w== X-Gm-Message-State: AOAM5331kmNbjZfCh9ZZkkKAgh058DWkR8LHUW+KkAk6n+ZvF0dNKz9a m5WBi+jtEEYCUNXazMHyurhe5g== X-Google-Smtp-Source: ABdhPJyxfLSduApCEQu/3N3aXkvQ4WqyvhVfStfESZlS6GN8wfK8Blsp+2pYr2Wqw5RKEWPWEdVMVg== X-Received: by 2002:a05:6000:11cd:: with SMTP id i13mr8292296wrx.417.1616057523266; Thu, 18 Mar 2021 01:52:03 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:52:02 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 12/15] ata: pata_cs5530: Fix misspelling of 'cs5530_init_one()'s 'pdev' param Date: Thu, 18 Mar 2021 08:51:47 +0000 Message-Id: <20210318085150.3131936-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_cs5530.c:283: warning: Function parameter or member 'pdev' not described in 'cs5530_init_one' drivers/ata/pata_cs5530.c:283: warning: Excess function parameter 'dev' description in 'cs5530_init_one' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_cs5530.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_cs5530.c b/drivers/ata/pata_cs5530.c index ad75d02b6dacf..a1b4aaccaa50a 100644 --- a/drivers/ata/pata_cs5530.c +++ b/drivers/ata/pata_cs5530.c @@ -271,7 +271,7 @@ static int cs5530_init_chip(void) /** * cs5530_init_one - Initialise a CS5530 - * @dev: PCI device + * @pdev: PCI device * @id: Entry in match table * * Install a driver for the newly found CS5530 companion chip. Most of From patchwork Thu Mar 18 08:51:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455179 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZNLc1rms; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQB6Xzjz9sW1 for ; Thu, 18 Mar 2021 19:52:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbhCRIwT (ORCPT ); Thu, 18 Mar 2021 04:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229905AbhCRIwF (ORCPT ); Thu, 18 Mar 2021 04:52:05 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A123C06175F for ; Thu, 18 Mar 2021 01:52:05 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo2828415wmq.4 for ; Thu, 18 Mar 2021 01:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VwGRt156EdlfIcuKCMjM9ajk7y2qH3FZ5j2kkdApNlI=; b=ZNLc1rmscy9Ufcs8ax9kjjJYActKRhTxjQl+CJeo5Z+wXmHIWr58HGrFeIxK17WLNJ ZZeK53R+VbzfyDMJroa4R25E4EsQ0NM3ceZsYj9Uul2llUlIGdqxNXtVJB1EWhOKRiyX k8qcxjdbyr5LrkIVK6p6HYGTDydAtDRS4WfYTWX4d4qw4bNn9WYXvx6S0Bnurw3OhgHt vhNWDgyWjTGMXTVl4EZKOe3yhXtKspvt1mxQvcicD0f3XINahUn+xk5OTZRifJX6Z0SW MgKXZAERdMrA8OeQ4FwLFeOZ5RjOYiw34gObUDKFthl24OsaLgffdrVbOMtVm1E96KQk c8LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VwGRt156EdlfIcuKCMjM9ajk7y2qH3FZ5j2kkdApNlI=; b=GjJPx1vcFSC8NW4R3KK+M0jZDYDxW8gai+7HzI6/WMc5BB/H4CILwImolVcqQfKUOV 8yNseRgJ5W0UPxvWiYIDcWorUwzQipmM+LsVu+5t7DDr+M4vn53s08DFQPT34Ef8aMxv HJNAwTAXbbjlPYBWoHYU/u3EVmP0lqJ37R+1r0+78QraEWYiD+ua7tG9fDKeqIxmuwRG QIVuBMoKldaEILO456qyBJxCc8SeAJok0Adk4kGgKW1FsIczx10piCrXwqPmKjHpl0cb 8i9BbGzllx7c/NDbWw8JjAVfRVAPd/G9wMo/dwuf0aNmcpHMthMY7GLTyteokX0qvxvZ MWqw== X-Gm-Message-State: AOAM531b5W6iFcGorJRvvBRS8mTKbDb51jfX5Gm5yeVhxs2YTS2hGLuX R3sfW2cY074QBAAVUJKysEJhig== X-Google-Smtp-Source: ABdhPJxZI+GUVBWWZ9xe0iTVmppX9sAmLpMzxVjISl/r1/8XtXHftByBvBuu6UbNTJ2x/RvJ+HvC8g== X-Received: by 2002:a05:600c:4fc2:: with SMTP id o2mr2467016wmq.25.1616057524149; Thu, 18 Mar 2021 01:52:04 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.52.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:52:03 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Mark Lord , ALWAYS copy Subject: [PATCH 13/15] ata: sata_mv: Fix misnaming of 'mv_bmdma_stop()' Date: Thu, 18 Mar 2021 08:51:48 +0000 Message-Id: <20210318085150.3131936-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/sata_mv.c:1929: warning: expecting prototype for mv_bmdma_stop(). Prototype was for mv_bmdma_stop_ap() instead Cc: Jens Axboe Cc: Mark Lord Cc: ALWAYS copy Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/sata_mv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index eafca46d8feb4..bd23d63435cb4 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -1917,7 +1917,7 @@ static void mv_bmdma_start(struct ata_queued_cmd *qc) } /** - * mv_bmdma_stop - Stop BMDMA transfer + * mv_bmdma_stop_ap - Stop BMDMA transfer * @ap: port to stop * * Clears the ATA_DMA_START flag in the bmdma control register From patchwork Thu Mar 18 08:51:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455182 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=owBn+xS4; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQD0366z9sW1 for ; Thu, 18 Mar 2021 19:52:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbhCRIwT (ORCPT ); Thu, 18 Mar 2021 04:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbhCRIwG (ORCPT ); Thu, 18 Mar 2021 04:52:06 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CD0CC06174A for ; Thu, 18 Mar 2021 01:52:06 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id b2-20020a7bc2420000b029010be1081172so2850043wmj.1 for ; Thu, 18 Mar 2021 01:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8THP7/U46oj2AdA7yORlA1l0cGJIRsmbqUZT9U01N10=; b=owBn+xS4OiRerAuKPY02l2lKcDg4A7rfCxSZlOaV5n+p4Anewb0qiJgnRGois5rJ53 otiPAUHyB1hiJmM966DeXNQGH3Y/Vl5TNAyPGd9mNWF7yhCRp3LL9z4zkgLNfj40onmH miY9VIe/aPvbVgMkUH65Qgxe8KEtSs9fkM3dMCrXUIpohGmfGfQvnKt/kVI0O8sZ2xDA zVbl/T/SpSUdCh8n5+yuA3OZQfxRIBucBvs9ZHClC/zyv05YgKQla+7hTZLfoegwNwbr 8FDQsG7hBlEd6Fd42wAih5yRSgbFXMGjnHhTEbjb+RqqhmGBio7PbeRT1j4UlWgRWvQ0 tnfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8THP7/U46oj2AdA7yORlA1l0cGJIRsmbqUZT9U01N10=; b=sJaydDKqnRH/NqwbRSeLtcs+JRRQLDpAyL4GU/DVimxeN3fQpR+AkrZ3pJgodqCnEW fhuIpBcGan+YPRX1wDCa2kFxoMqbZtl4hrEVZyl3ytoLKfyoiBIiORNCOeQI6jN6f6wU pwwCmexlj7C6SGknLtknDWb+gZh6AzbhIks9XZnCFdCBN41mtyI7BgNn13/88kR9Hb2w 9Siz3B8EQ+DopAONLjznCR1/e3yLSw8oTPlTmYcORGiWuMssdhGLi0Zwe0x9CkNyWS+r 9yrHsYLTQ0KE0MKDuq0FzFXUp++XMpnEYpVP0uvzw6AYuXPh3zG4FYuGX54F3QycwzoV fGiw== X-Gm-Message-State: AOAM531HVWqyON2/3N1D2KQ961FZx9IIgNTjmT+jBb68AJ4MzyruyVyp ZHl7Inmt8LUL/wG55bknTAyOTA== X-Google-Smtp-Source: ABdhPJx9R9zd3as8Zx677i6YSfsUD2ksgApi6t1IlIfShE3hBRcdI0WVmZkNaqTIURd+qmu0fXnifg== X-Received: by 2002:a05:600c:3541:: with SMTP id i1mr2521821wmq.97.1616057525014; Thu, 18 Mar 2021 01:52:05 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:52:04 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 14/15] ata: libata-acpi: Fix function name and provide description for 'prev_gtf' Date: Thu, 18 Mar 2021 08:51:49 +0000 Message-Id: <20210318085150.3131936-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/libata-acpi.c:493: warning: expecting prototype for ata_acpi_gtm_xfermode(). Prototype was for ata_acpi_gtm_xfermask() instead drivers/ata/libata-acpi.c:648: warning: Function parameter or member 'prev_gtf' not described in 'ata_acpi_run_tf' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/libata-acpi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index 224e3486e9a5d..7a7d6642edcc5 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -476,7 +476,7 @@ static int ata_dev_get_GTF(struct ata_device *dev, struct ata_acpi_gtf **gtf) } /** - * ata_acpi_gtm_xfermode - determine xfermode from GTM parameter + * ata_acpi_gtm_xfermask - determine xfermode from GTM parameter * @dev: target device * @gtm: GTM parameter to use * @@ -624,6 +624,7 @@ static int ata_acpi_filter_tf(struct ata_device *dev, * ata_acpi_run_tf - send taskfile registers to host controller * @dev: target ATA device * @gtf: raw ATA taskfile register set (0x1f1 - 0x1f7) + * @prev_gtf: previous command * * Outputs ATA taskfile to standard ATA host controller. * Writes the control, feature, nsect, lbal, lbam, and lbah registers. From patchwork Thu Mar 18 08:51:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455181 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=DUUigHzi; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQC4ZNtz9sXL for ; Thu, 18 Mar 2021 19:52:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229844AbhCRIwU (ORCPT ); Thu, 18 Mar 2021 04:52:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbhCRIwH (ORCPT ); Thu, 18 Mar 2021 04:52:07 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20BDCC06175F for ; Thu, 18 Mar 2021 01:52:07 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo2828467wmq.4 for ; Thu, 18 Mar 2021 01:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tRryIhNUKwY1QYHRIg2sGv85PaIDusUy0ZBOcz1fZQo=; b=DUUigHziSClduf61W1BDu9G+kg9n3s8DvQle1mFQ4sOdNetVpq5lyMJ7Hq3VbbXz7E y84mzWnh2OP6GNb7qnpSDYgDRCzZdxxIHmeAab6v4OJfhG+gkVZALKG7QTiFr3cofUxU +suMHKqSr8XogTRoVqH+CJi4mPU4nVRA/9h05QkCxEWCjBrn2n4xqq5hadR4ohImtXaH PMcrrZQvS9X+kDxrqAr6JvLKSK3vnMUiZ/9MIw+5AfO0OjWnEjEZThLCtpsBnvqcV1v+ k6i4NiI1PMcFOh14P2ByM5BqyotkR1Ig3mcBCJn7nmF3V6KGZ+uqrIajVVkjxb5jbjpH cZeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tRryIhNUKwY1QYHRIg2sGv85PaIDusUy0ZBOcz1fZQo=; b=F+zeNi+HkM4qvfFknADuZtDJfGkoB8jGG43xgl+3G5ioG8vyXGZcmRktVdTB0U2m6s WE0lab9lXkSeZXdmIlyrnSa9tjAJXu+qYA58/eiaQVsIvsniZF8Kvm6Kppd8avclpkJF R6vAAIkE2svzmXqdOshVd3wg+IdBi4YDlYzvixpXWsE6dGNb5yopcHn1gGr5HNW0RA0/ bYavHQjt8xygo443/Qyee2iv1FR+diwEybVYIYvdwtsgGx55+RJHY4JX0HekQaIAiPV8 0lNKx5VcaNouz/Ixboo6LHOtnNi/DfaUWrk62eGP4m6pxFIKSQaS+dYJuobvTYHjGhtL IgGg== X-Gm-Message-State: AOAM533EqC2gPHlyf8DRAVgg3mZK3KL7TY9l9G1FJ4jfQVZQr41A7EpL JB+VpGcNFuTcbjiOeRDtn4A8ug== X-Google-Smtp-Source: ABdhPJw2I2wmFHMlXj5ytsp5gjkUQJyefdh0nS4u5Qour/ISlcXWVPy5BA7e3K7YbbVUBJruqfZ+SQ== X-Received: by 2002:a05:600c:1553:: with SMTP id f19mr2520548wmg.33.1616057525892; Thu, 18 Mar 2021 01:52:05 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:52:05 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 15/15] ata: pata_acpi: Fix some incorrect function param descriptions Date: Thu, 18 Mar 2021 08:51:50 +0000 Message-Id: <20210318085150.3131936-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_acpi.c:38: warning: Function parameter or member 'link' not described in 'pacpi_pre_reset' drivers/ata/pata_acpi.c:38: warning: Excess function parameter 'ap' description in 'pacpi_pre_reset' drivers/ata/pata_acpi.c:74: warning: Function parameter or member 'ap' not described in 'pacpi_discover_modes' drivers/ata/pata_acpi.c:74: warning: Excess function parameter 'mask' description in 'pacpi_discover_modes' drivers/ata/pata_acpi.c:239: warning: Function parameter or member 'id' not described in 'pacpi_init_one' drivers/ata/pata_acpi.c:239: warning: Excess function parameter 'ent' description in 'pacpi_init_one' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_acpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c index fa2bfc344a976..ade4c3eee2304 100644 --- a/drivers/ata/pata_acpi.c +++ b/drivers/ata/pata_acpi.c @@ -28,7 +28,7 @@ struct pata_acpi { /** * pacpi_pre_reset - check for 40/80 pin - * @ap: Port + * @link: ATA link * @deadline: deadline jiffies for the operation * * Perform the PATA port setup we need. @@ -63,8 +63,8 @@ static int pacpi_cable_detect(struct ata_port *ap) /** * pacpi_discover_modes - filter non ACPI modes + * @ap: ATA port * @adev: ATA device - * @mask: proposed modes * * Try the modes available and see which ones the ACPI method will * set up sensibly. From this we get a mask of ACPI modes we can use @@ -224,7 +224,7 @@ static struct ata_port_operations pacpi_ops = { /** * pacpi_init_one - Register ACPI ATA PCI device with kernel services * @pdev: PCI device to register - * @ent: Entry in pacpi_pci_tbl matching with @pdev + * @id: PCI device ID * * Called from kernel PCI layer. *