From patchwork Wed Mar 3 13:17:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1446645 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=BCWbeM4E; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrF0v695xz9sW1; Thu, 4 Mar 2021 00:17:51 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lHRNs-0002El-Q7; Wed, 03 Mar 2021 13:17:48 +0000 Received: from mail-pj1-f53.google.com ([209.85.216.53]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lHRNq-0002Cs-FE for kernel-team@lists.ubuntu.com; Wed, 03 Mar 2021 13:17:46 +0000 Received: by mail-pj1-f53.google.com with SMTP id u12so4317348pjr.2 for ; Wed, 03 Mar 2021 05:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K7lNhQVoHtH1q1JycAproAEBNfN8TtcHMceOU5KBqno=; b=BCWbeM4EPPb8Yp2tpdL+3f3LLaYB0RvQblCpFMS81/oXoJTXTnbWq8tGVS62n5CVz/ 9n4QjMswrnTRhaVKqMiSVZb+r7dgGiES5xcBTT9xq6ck1E+GpSjdbJMRJh1lgiIGX4CC 9NOHdDvIWiGYMpUtfT2w1oaeSB7VMfabiryS0WsR//Ee3lUO/MgmQdM3TFJrpoVbN6W4 Syw1w2xSMOwfaWScd4kinKUJKKANMKxbQWEDvkCiCwpVi9IGeh12HD3Zl++Z5mhGb0uz +6/UzYw0KCNrAIVM52CwPOIcUT0GPtJMNtgzmEInM8uKrKiDtEmJ1S3RwTO4UNIJXK9q NAGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=K7lNhQVoHtH1q1JycAproAEBNfN8TtcHMceOU5KBqno=; b=EQMEern+YpiSxc25Lh+vyh8H4Yzkr+DxKJTDJb8hTHl3vRRFqygWPd9jtqyNPvRErG 0eN9zr5bky1W/1H2b5xQ+pQ1mhuGMg2eONXWnEnHB2+hQGMaR55On3CJDncEMZJsTzrM JjRfF/VmgtHCkrHl9tgiEvFUcIRF94+z77zL9iB1yEuqRm48hI4O/Qbo/ke05U1qEggu sf9/1POQN2XyRe1xlcg7Y6hNkxQYQs+Uep8oVvTlgm8fRseqjalkN3I6W+qj3HQlH8WK iywkNqFaNkUEIeMSFrPb4cJrj+NFIoCKxJEQouVEHyPPBBMVn0g0znWh2tRsNZA4joTx xbUg== X-Gm-Message-State: AOAM531/09H3Q6f5yIAVCwV+W9nOuolLUi+B+gUE3k2LD6V2zto7yvOW N6RN0AzU/wQqKrX/XByHmtWyGeRIS047xQ== X-Google-Smtp-Source: ABdhPJzMyUfAzOu8eqVaek5TFoqL9D7AidSq2XCnpTZ8jRBIHOagYaA6iHNS3WBrQ/QhcdB7GCF9AA== X-Received: by 2002:a17:902:c317:b029:e4:aecd:8539 with SMTP id k23-20020a170902c317b02900e4aecd8539mr2783122plx.61.1614777464391; Wed, 03 Mar 2021 05:17:44 -0800 (PST) Received: from localhost (61-220-137-34.HINET-IP.hinet.net. [61.220.137.34]) by smtp.gmail.com with ESMTPSA id 144sm3214453pgd.83.2021.03.03.05.17.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:17:43 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH][SRU][H] drm/i915/dp: Program source OUI on eDP panels Date: Wed, 3 Mar 2021 21:17:32 +0800 Message-Id: <20210303131732.8816-4-acelan.kao@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303131732.8816-1-acelan.kao@canonical.com> References: <20210303131732.8816-1-acelan.kao@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.216.53; envelope-from=acelan@gmail.com; helo=mail-pj1-f53.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Lyude Paul BugLink: https://bugs.launchpad.net/bugs/1917419 Since we're about to start adding support for Intel's magic HDR backlight interface over DPCD, we need to ensure we're properly programming this field so that Intel specific sink services are exposed. Otherwise, 0x300-0x3ff will just read zeroes. We also take care not to reprogram the source OUI if it already matches what we expect. This is just to be careful so that we don't accidentally take the panel out of any backlight control modes we found it in. v2: * Add careful parameter to intel_edp_init_source_oui() to avoid re-writing the source OUI if it's already been set during driver initialization Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi Cc: thaytan@noraisin.net Cc: Vasily Khoruzhick Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/20201204223603.249878-2-lyude@redhat.com (cherry picked from commit f12110afee058a2e6e816e315d3291765625cc87) Signed-off-by: Chia-Lin Kao (AceLan) --- drivers/gpu/drm/i915/display/intel_dp.c | 33 +++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 8a26307c4896..d46e48941e00 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -3583,6 +3583,29 @@ void intel_dp_sink_set_decompression_state(struct intel_dp *intel_dp, enable ? "enable" : "disable"); } +static void +intel_edp_init_source_oui(struct intel_dp *intel_dp, bool careful) +{ + struct drm_i915_private *i915 = dp_to_i915(intel_dp); + u8 oui[] = { 0x00, 0xaa, 0x01 }; + u8 buf[3] = { 0 }; + + /* + * During driver init, we want to be careful and avoid changing the source OUI if it's + * already set to what we want, so as to avoid clearing any state by accident + */ + if (careful) { + if (drm_dp_dpcd_read(&intel_dp->aux, DP_SOURCE_OUI, buf, sizeof(buf)) < 0) + drm_err(&i915->drm, "Failed to read source OUI\n"); + + if (memcmp(oui, buf, sizeof(oui)) == 0) + return; + } + + if (drm_dp_dpcd_write(&intel_dp->aux, DP_SOURCE_OUI, oui, sizeof(oui)) < 0) + drm_err(&i915->drm, "Failed to write source OUI\n"); +} + /* If the device supports it, try to set the power state appropriately */ void intel_dp_set_power(struct intel_dp *intel_dp, u8 mode) { @@ -3604,6 +3627,10 @@ void intel_dp_set_power(struct intel_dp *intel_dp, u8 mode) lspcon_resume(dp_to_dig_port(intel_dp)); + /* Write the source OUI as early as possible */ + if (intel_dp_is_edp(intel_dp)) + intel_edp_init_source_oui(intel_dp, false); + /* * When turning on, we need to retry for 1ms to give the sink * time to wake up. @@ -4852,6 +4879,12 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp) if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) intel_dp_get_dsc_sink_cap(intel_dp); + /* + * If needed, program our source OUI so we can make various Intel-specific AUX services + * available (such as HDR backlight controls) + */ + intel_edp_init_source_oui(intel_dp, true); + return true; }