From patchwork Sat Feb 20 09:42:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1442602 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=TLq5o3SK; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DjNmL2w9rz9rx8 for ; Sat, 20 Feb 2021 20:43:14 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2E7F3806C5; Sat, 20 Feb 2021 10:43:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="TLq5o3SK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D657482483; Sat, 20 Feb 2021 10:43:02 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 092DF80404 for ; Sat, 20 Feb 2021 10:43:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1613814175; bh=UbGHI7le2ldq58TUdsE9I7Yrs5oRVmAId6f7b5AGv9k=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=TLq5o3SKpP6STamSQ6w5uERim92J7zl7FO1hcphCx9dkxvJkgQstuhkUwg0klDCO8 aiOHzJdfAFzUvxti1H8GJAllNiyI5JK3bsZ4TpCnMP/tdfipWAp3ofy8zrnOtJC5dq kzXuvAjCU8zWortYme3HyoHvTrC3m9eyUKcrw0BY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from workstation4.fritz.box ([62.143.246.89]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MMGRK-1lWaMa3z9y-00JMs1; Sat, 20 Feb 2021 10:42:55 +0100 From: Heinrich Schuchardt To: Alex Nemirovsky Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] mtd: rawnand: cortina_nand: missing initialization Date: Sat, 20 Feb 2021 10:42:50 +0100 Message-Id: <20210220094250.3291-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:Ktth7DutgkUTpUAuIlsDpdpuiM8IFtbcR8lt9I3xUfTl/BmfejK yHMOWnlVEPTLAdIa/g/MIkzMe5uu2J4BypLeuDNrnoRMEf0ROHtAvwYFjg6967u9PJLOhX2 UYGrcYjQNGmWG1G+4C1yOLe0fut/+mpCmQfRInmL8D5HnAxjkD6O90q6rwdFAUviJma/p52 +sBKEiiBM3FQrzzRox2Rg== X-UI-Out-Filterresults: notjunk:1;V03:K0:4mRg0SywVzY=:58wmA01y4fRuRlMBjWOBvI FtwvqfW+hQ/1tJRhlVC72qDoQ8iLHONyO12LVFY7qFW+7p8pPpda+FHnuytSV6KCf+IoXBywx X59ulFDx3F6kbuBgolSBdY+eAODX5eRSOB2ETtkfZverSkwfeN9nyCAY1+hXvmRJLfHoo5RBI yjlbEEHEebHmZKYxWWJ7eNElF4/0x/VDVhHrMjm/8s0OQueDEWYTvo2nKBcIOywhugzD/7k/T 4U1NlgIZc+DffrlMdjecGUfMDA8U1sMgM0+9f3Ze8suQj9GjpowJ5sm/uvpFutWaY7q+TMoH2 RDbEQuZUqkV0nv3EElUMknM8SKgaJXCzaVu3vqOfxAR53pdiaWgKgj/YjlJe974hV/ZXs8crF MCLBoCAVxk/NLGdSTpbUgEzyJU9Z9yAfnV474et5Inkm4twfgjZ60fG1ZYeCSavGzvxTNR1jJ iMYC45fly5rN9ctZf6eC0joNA7v2ox+6kJs2xl1NdYv5q627ubbpvYK+M9YE0/claHQqQsE8b sr2gEi7K6vL9JJ2gsLpxZZw1HACdc28HHcugz/ZdQeVZwZoN37ljjW1CvnfpFkh1uLv892xGs EXirpdE+qhyuBW+SS9hqN/D+or4V4aT5oQyQIzUW24dQjRGocu8Kd9R+peo401UahJRBBm0Y9 7rgp8CwNrTaze3dEdI73eyFpq1RklNm/BdWSICNC2WQa5SRrnYESNKp65mnc8C3EbqUGr+i8c Mjx2sPoVZF11vI51Ga+6WHCzwySrP+1uBZ478LA0iZSBTMjVhxxHCRptl56Ghd8Y0Abto9PF0 fvgqGNxHkIU4pNGFKzMzfoAmrOZHqv31js7Hwr8Y5XF/92bq7w7rYzbvAuLeRJP+jn7mcTrmp 7+xfFDD9gDnDSejtkpIw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean ca_do_bch_correction() takes a random value from the stack and starts counting bitflips from this value. Initialize the counter. This passed unnoticed as the value is finally ignored in the call hierarchy. Fixes: 161df94b3c43 ("mtd: rawnand: cortina_nand: Add Cortina CAxxxx SoC support") Signed-off-by: Heinrich Schuchardt --- drivers/mtd/nand/raw/cortina_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.0 diff --git a/drivers/mtd/nand/raw/cortina_nand.c b/drivers/mtd/nand/raw/cortina_nand.c index 12bd1ded83..81fa8788a4 100644 --- a/drivers/mtd/nand/raw/cortina_nand.c +++ b/drivers/mtd/nand/raw/cortina_nand.c @@ -546,7 +546,7 @@ static int ca_do_bch_correction(struct nand_chip *chip, struct nand_drv *info = (struct nand_drv *)nand_get_controller_data(chip); unsigned int reg_v, err_loc0, err_loc1; - int k, max_bitflips; + int k, max_bitflips = 0; for (k = 0; k < (err_num + 1) / 2; k++) { reg_v = readl(&info->reg->flash_nf_bch_error_loc01 + k);