From patchwork Fri Feb 19 21:03:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: harshad shirwadkar X-Patchwork-Id: 1442449 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=uwXpt8Ql; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Dj3x90LkKz9sW3 for ; Sat, 20 Feb 2021 08:04:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbhBSVE2 (ORCPT ); Fri, 19 Feb 2021 16:04:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbhBSVE1 (ORCPT ); Fri, 19 Feb 2021 16:04:27 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EBE6C061574 for ; Fri, 19 Feb 2021 13:03:47 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id m2so5749420pgq.5 for ; Fri, 19 Feb 2021 13:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CrnY6Npwb6W1700F7fs11McB1yk4bBHdasXw09wHVUI=; b=uwXpt8QlADhefDb4ozF+N7zHLCtbSpoF+FoGLFWXx8zBVkMMdJ8KlF9ToTR5kCjkC8 ySP1aML11C2bqeV9+iHn8exEx0K5tdPY/R+k8C4Azc8zVnWIDzovmyG5obUkjso1WtZA fIEvr+lPU00+yh6euea8GdFq0ZeWakReT0P2lUsiHdN9n02fB80xk/6LnvoT8JFVpFQ3 cDFKzQfTafA+dbXqaBL3OQoe5yCO/ytzHKk5ROa0gEyh6QBJ44lkTIGGVyDInRjTwa7T VS4pxB6hrcLna2pfIoK7KZCzhKxWOEtwHVW++aUh8Ktia0LAzgXRXZk0WtFacW2XFnJy SXTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CrnY6Npwb6W1700F7fs11McB1yk4bBHdasXw09wHVUI=; b=UTgRwVpptflx6ecgwQ4fVjhEA0dsWBMIp4WdvEzy2GZBYESsg5IqcIBYDbGKwag9BA /oO233hsGBeYswvQa/b/4gWmMvRna73BJYPUIdNr2/zk9wn/b8ntOmI0IuIbEP5d5bg8 FLYoXPVCIftRJ6fx8DjX6BLsJ45SavBvDWZiaqS+UmnFTpAKAIa91YRunOwXaPJpReRZ Xhy7i8j8hRxrTqUSUiQMAFN0CEymvrd9QI2DQuwycttSHO3ANaG5p9O7QJntsgew3vNj qb1L+WDm+B0WzzMF++dA9MNIFRapKlIQK/YZoCLJdRIeCx3YcpvQ/uzVkIExW2PkG14C Tmug== X-Gm-Message-State: AOAM530muH+EmouoXES9de+ZJY141LHG8386eoh6B18cDxfWGQ0a/sAh 3a7xl+F85Wo7y7+akapHAHvpV7P39H8= X-Google-Smtp-Source: ABdhPJzPy9rKeBBGE5vwIi5vT2F68nzgx8k538oAp9dQrhyT2huj75YsoAPdE32He27VYyXurfStAw== X-Received: by 2002:a63:8f4c:: with SMTP id r12mr9980755pgn.311.1613768626160; Fri, 19 Feb 2021 13:03:46 -0800 (PST) Received: from harshads-520.kir.corp.google.com ([2620:15c:17:10:48e6:60ce:73b8:bccd]) by smtp.googlemail.com with ESMTPSA id 30sm10318756pgl.77.2021.02.19.13.03.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 13:03:45 -0800 (PST) From: Harshad Shirwadkar X-Google-Original-From: Harshad Shirwadkar To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, Harshad Shirwadkar Subject: [PATCH 1/4] e2fsck: don't ignore return values in e2fsck_rewrite_extent_tree Date: Fri, 19 Feb 2021 13:03:30 -0800 Message-Id: <20210219210333.1439525-1-harshads@google.com> X-Mailer: git-send-email 2.30.0.617.g56c4b15f3c-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Harshad Shirwadkar Don't ignore return values of ext2fs_read/write_inode_full() in e2fsck_rewrite_extent_tree. Signed-off-by: Harshad Shirwadkar --- e2fsck/extents.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/e2fsck/extents.c b/e2fsck/extents.c index 600dbc97..f48f14ff 100644 --- a/e2fsck/extents.c +++ b/e2fsck/extents.c @@ -290,8 +290,10 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx, struct extent_list *list) errcode_t err; memset(&inode, 0, sizeof(inode)); - ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), - sizeof(inode)); + err = ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), + sizeof(inode)); + if (err) + return err; /* Skip deleted inodes and inline data files */ if (inode.i_flags & EXT4_INLINE_DATA_FL) @@ -306,10 +308,8 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx, struct extent_list *list) if (err) return err; ext2fs_iblk_set(ctx->fs, EXT2_INODE(&inode), blk_count); - ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), - sizeof(inode)); - - return 0; + return ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), + sizeof(inode)); } errcode_t e2fsck_read_extents(e2fsck_t ctx, struct extent_list *extents) From patchwork Fri Feb 19 21:03:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: harshad shirwadkar X-Patchwork-Id: 1442450 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=FVdIy63K; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Dj3x93FzHz9sW4 for ; Sat, 20 Feb 2021 08:04:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbhBSVEb (ORCPT ); Fri, 19 Feb 2021 16:04:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbhBSVE2 (ORCPT ); Fri, 19 Feb 2021 16:04:28 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193FAC061786 for ; Fri, 19 Feb 2021 13:03:48 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id u11so4025222plg.13 for ; Fri, 19 Feb 2021 13:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NJWZzEzNS5vVfW1OyrxYVwHMUBJWStcPfWCrCP2j/8o=; b=FVdIy63KW/nFgp5W5PBcy0IA3kiq8f63H77OnccQrNlT4obd9IRy5w8ESUbhp5TbJi GB7vGl3sxSGd+SGVDX+mk3FQlURT3Ep1CB1wK4/87Jc11CkfO/f5RNTWvbBXXZV3Pw4i QKULP/AwzgZciCtaKH8h5G7pwNr/FZ4LEVz3xTvOTOQcqTq/e2ECU1vCU7DL5WwA7rjY ZXBMwVyl5gD/uFX/xkiNw6PYFvTl1iXMpb/2u8HcUtd412viXliUhdEyYAInn0Xw+g5N tW17JMW8ExPiw9O0Mw+yDkKBJwVdOJ0yFeFXDbG8B6BJ4VVr8ko8MOqCnhsOnqD88y/v NeZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NJWZzEzNS5vVfW1OyrxYVwHMUBJWStcPfWCrCP2j/8o=; b=uM3wTNg1tcuD5sWsftKt1s05EBrpsNrYaNN7/g+C6bpYTTv9gdUzuCTgZgf8tZRkKg wT1jqyZOCZurYTEM737I2i/15F8dK+x94JlIvrmqTz1TMExvtjeZQv9VZuz4vxYguL4S QnXdc19cubHjBCRE184bAuELp5ehttER/vUBVx6nUx7iAyU+w8HyW8jAvr835F71lvg7 1v+7x42PxTtcmNNnfJtycW6lHZUd/4CAbK71Th36mUUBfO6fw27NKoqUckbOByaMxITP D0oX2Xg+9iNozNtpqcHrh5BUafYfEyiwt5F29hpp80Q/mrYtvunn16yRT9q61RwZ/T5s r1aw== X-Gm-Message-State: AOAM533qSj3s/8n9jyFl5Dqw6v1MbsaekQoaO936CgMSjIh4oXICO9zS sq6gL9rToRo1aQ5iMy4aSQtyTsaslLA= X-Google-Smtp-Source: ABdhPJxw6pJuhYf9SAHtpH3B5FTRhnVxBVT3nYnSVLEGWpcaT+mU0P3tCQA3uv3OpxI/BN3xFTOWmw== X-Received: by 2002:a17:90a:588c:: with SMTP id j12mr10791964pji.93.1613768627167; Fri, 19 Feb 2021 13:03:47 -0800 (PST) Received: from harshads-520.kir.corp.google.com ([2620:15c:17:10:48e6:60ce:73b8:bccd]) by smtp.googlemail.com with ESMTPSA id 30sm10318756pgl.77.2021.02.19.13.03.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 13:03:46 -0800 (PST) From: Harshad Shirwadkar X-Google-Original-From: Harshad Shirwadkar To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, Harshad Shirwadkar Subject: [PATCH 2/4] ext2fs: don't ignore return value in ext2fs_count_blocks Date: Fri, 19 Feb 2021 13:03:31 -0800 Message-Id: <20210219210333.1439525-2-harshads@google.com> X-Mailer: git-send-email 2.30.0.617.g56c4b15f3c-goog In-Reply-To: <20210219210333.1439525-1-harshads@google.com> References: <20210219210333.1439525-1-harshads@google.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Harshad Shirwadkar Don't ignore return value of ext2fs_get_array() in ext2fs_count_blocks(). Signed-off-by: Harshad Shirwadkar --- lib/ext2fs/extent.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/ext2fs/extent.c b/lib/ext2fs/extent.c index 1a87e68b..9e611038 100644 --- a/lib/ext2fs/extent.c +++ b/lib/ext2fs/extent.c @@ -1824,8 +1824,11 @@ errcode_t ext2fs_count_blocks(ext2_filsys fs, ext2_ino_t ino, if (errcode) goto out; - ext2fs_get_array(handle->max_depth, sizeof(blk64_t), - &intermediate_nodes); + errcode = ext2fs_get_array(handle->max_depth, sizeof(blk64_t), + &intermediate_nodes); + if (errcode) + goto out; + blkcount = handle->level; while (!errcode) { if (extent.e_flags & EXT2_EXTENT_FLAGS_LEAF) { From patchwork Fri Feb 19 21:03:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: harshad shirwadkar X-Patchwork-Id: 1442451 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=L/ewALtI; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Dj3x95tLfz9sWC for ; Sat, 20 Feb 2021 08:04:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229700AbhBSVEc (ORCPT ); Fri, 19 Feb 2021 16:04:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhBSVE3 (ORCPT ); Fri, 19 Feb 2021 16:04:29 -0500 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC01EC06178A for ; Fri, 19 Feb 2021 13:03:48 -0800 (PST) Received: by mail-pg1-x52e.google.com with SMTP id p21so5720621pgl.12 for ; Fri, 19 Feb 2021 13:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HnzL5gDkqRbD3IsFGdU42evoXK07lViYsNp8FnGdHwo=; b=L/ewALtITUyk9u5XGWUsnSyjySe5CYpjQZq4a9bpTOHmY55S3/r0j5wvKsEJBHgipZ iGs+hheTaJwVy9KK6nHAbq1lw9DCcrtFN/mA/mrFtoqomuSLJg5iZsFsaHipJArKdBJB hrzj0zdZEcziC07mCubwBy650f/Xe9tunFvpvCt1+CFV6qEdTi0pGcNSMil7U6+DSEFI CQZAfiASM+yCWmOuXQStqlHQI0S2KPaMvx5hagXZE5AxH/e1FAyCrqY6spwU6pHwnvsW v/v9cxWmB47OMyWDG99e1PHJS9W8VpnrTdhs/sLojCxEvzYqh7OjkviAGRE0hZFxQScr zJnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HnzL5gDkqRbD3IsFGdU42evoXK07lViYsNp8FnGdHwo=; b=XCRMY/1kJ00ZN4YsBjTfSo3jT9QIx5/FY+9t7awuNKVFtWybMryowP9rKmNaRjxOYy mLY5qDJRjciBa9oiIStBmJZ1f8wLlSLHoTDKcLeWOwT/ulphYdUWSujw3wzBqG+1Oquc WpKBfFJNDY6SI58joBiyy7/leEWoMz0GrLzVn43aqPVjNvZgjxXgjkxDhPnaPXUPbyh+ frJvcbMIAl9uM457F4Iwwg5Kcf3vd43mcHdeBN+ejlsAMIhQZlSTcQK3QqtKF8TMTJ4h yKqa7kZRfc/tQ7iIVap3Fmt50xIOWWNJ4juC9HC66AAHGaJWt02tT/s+3MLA94yTn8OX vWaQ== X-Gm-Message-State: AOAM532F2mu9BoFZ3AXL712awhv8c6069BErGWw8UGVJJmz4en8sxNAf QS3NunWyGwITrwiZfXhQSUt0gd1IKVY= X-Google-Smtp-Source: ABdhPJyLCgicG9y2cjeIUgiajHZzZ7EnhXlJVxvw+s5K0sG2+Sieg6vLRxQw+pqlRpNsuMNpoZ+8Hg== X-Received: by 2002:aa7:8ad5:0:b029:1df:5a5a:80e1 with SMTP id b21-20020aa78ad50000b02901df5a5a80e1mr11281481pfd.52.1613768628153; Fri, 19 Feb 2021 13:03:48 -0800 (PST) Received: from harshads-520.kir.corp.google.com ([2620:15c:17:10:48e6:60ce:73b8:bccd]) by smtp.googlemail.com with ESMTPSA id 30sm10318756pgl.77.2021.02.19.13.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 13:03:47 -0800 (PST) From: Harshad Shirwadkar X-Google-Original-From: Harshad Shirwadkar To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, Harshad Shirwadkar Subject: [PATCH 3/4] e2fsck: add fallthrough comment in fc replay switch case Date: Fri, 19 Feb 2021 13:03:32 -0800 Message-Id: <20210219210333.1439525-3-harshads@google.com> X-Mailer: git-send-email 2.30.0.617.g56c4b15f3c-goog In-Reply-To: <20210219210333.1439525-1-harshads@google.com> References: <20210219210333.1439525-1-harshads@google.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Harshad Shirwadkar During fast commit replay scan phase, in ext4_fc_replay_scan(), we want to fallthrough in switch case for EXT4_FC_TAG_ADD_RANGE case. Add a comment for that. Signed-off-by: Harshad Shirwadkar --- e2fsck/journal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/e2fsck/journal.c b/e2fsck/journal.c index 2708942a..a67ef745 100644 --- a/e2fsck/journal.c +++ b/e2fsck/journal.c @@ -325,6 +325,7 @@ static int ext4_fc_replay_scan(journal_t *j, struct buffer_head *bh, ret = JBD2_FC_REPLAY_STOP; else ret = JBD2_FC_REPLAY_CONTINUE; + /* fallthrough */ case EXT4_FC_TAG_DEL_RANGE: case EXT4_FC_TAG_LINK: case EXT4_FC_TAG_UNLINK: From patchwork Fri Feb 19 21:03:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: harshad shirwadkar X-Patchwork-Id: 1442452 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=oJYQPOEs; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Dj3xC5bnpz9sW2 for ; Sat, 20 Feb 2021 08:04:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229725AbhBSVEd (ORCPT ); Fri, 19 Feb 2021 16:04:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbhBSVEa (ORCPT ); Fri, 19 Feb 2021 16:04:30 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E57CEC06178B for ; Fri, 19 Feb 2021 13:03:49 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id cx11so2290666pjb.4 for ; Fri, 19 Feb 2021 13:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=owN266y34V0ZrUAH82uf3q260Ueenihmw5xY1YY0G5o=; b=oJYQPOEsCpcPYB0W5EaFXgS3MPK83JEGVc7QmL0HOIFOd9EManEud1ktZtIaEa1cvm VYh/NmTJ+bBmrBorbJCfuVKxskZqIwt8XXB5YAk+CKk6Xk7PRIKQ3KpjpzOOPsZGCFks m6mVqO2xUQJfqzfuidxgjO7TGiIAy/VN7/G/iaWgNzQqdKE5c7KzOYKIBMSiBGtDcK7t +vDMtQN6t4k9pVgQZpjjSrv//cFH2toNaOvBS3u27iB93BkRihCWWncDW4wgYLMDkEtr rSlX2rzVgzeszNStjC+XcKiGYgziQ9nrJ2kDLysZ/rV/NHWDWlenvWCa/5CmhTCppCVk Bnqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=owN266y34V0ZrUAH82uf3q260Ueenihmw5xY1YY0G5o=; b=U4K2pzcCy08o9lkL/qXk70YDylHape0AAzlOoQSttqjraEves3vZjLJ/5tZE1CZ7+R cbKPXgiE7V/dr9AYF4RGXglFG+95aPBb9h8/h1ByFRYXM5GRewq7Ig28fD7pDeVB60Kx t3Gcs8BB1ZFANDWZs4j6bWa1gVpYW4QptchedAlyYUpNkTBYjydVDVpy31KX12p2gg1+ hOSE/5rkOm4zI0CifB7XY+gsECDYGwcRJwQrNIr38fCgdOMlKYqm0dyWaIm7EIh2peJZ /Kvhz/ooJfTeXI5PnaBx43kUE0KlVEqobCef7gZgbcUe7B0YAoxOu9HVRK7Uzv8s9J34 +r4A== X-Gm-Message-State: AOAM531+7LS/3VYiGVv1P8etgrrUnZ2lnQxTCI6oTtjHb/++Eup9ywOd ywHQTR5CuptICWt1dolT2U+rT42z74M= X-Google-Smtp-Source: ABdhPJwZa2dMHe+JWYBHJpPtcv0qnRYPg3Vn5sb92CCOpSIEqjVRSiA10vghKe+dlBO4q4Xl54zvZg== X-Received: by 2002:a17:90a:cf82:: with SMTP id i2mr10701748pju.209.1613768629125; Fri, 19 Feb 2021 13:03:49 -0800 (PST) Received: from harshads-520.kir.corp.google.com ([2620:15c:17:10:48e6:60ce:73b8:bccd]) by smtp.googlemail.com with ESMTPSA id 30sm10318756pgl.77.2021.02.19.13.03.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 13:03:48 -0800 (PST) From: Harshad Shirwadkar X-Google-Original-From: Harshad Shirwadkar To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, Harshad Shirwadkar Subject: [PATCH 4/4] e2fsck: initialize variable before first use in fast commit replay Date: Fri, 19 Feb 2021 13:03:33 -0800 Message-Id: <20210219210333.1439525-4-harshads@google.com> X-Mailer: git-send-email 2.30.0.617.g56c4b15f3c-goog In-Reply-To: <20210219210333.1439525-1-harshads@google.com> References: <20210219210333.1439525-1-harshads@google.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Harshad Shirwadkar Initialize ext2fs_ex variable in ext4_fc_replay_scan() before first use. Signed-off-by: Harshad Shirwadkar --- e2fsck/journal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2fsck/journal.c b/e2fsck/journal.c index a67ef745..8e7ba819 100644 --- a/e2fsck/journal.c +++ b/e2fsck/journal.c @@ -289,7 +289,7 @@ static int ext4_fc_replay_scan(journal_t *j, struct buffer_head *bh, struct ext4_fc_tail *tail; __u8 *start, *end; struct ext4_fc_head *head; - struct ext2fs_extent ext2fs_ex; + struct ext2fs_extent ext2fs_ex = {0}; state = &ctx->fc_replay_state;