From patchwork Wed Feb 17 07:44:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B6rg_Krause?= X-Patchwork-Id: 1441188 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="key not found in DNS" header.d=embedded.rocks header.i=@embedded.rocks header.a=rsa-sha256 header.s=default header.b=E58e86ew; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DgVGg4v61z9sBy for ; Wed, 17 Feb 2021 18:44:27 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0C3D96F5F0 for ; Wed, 17 Feb 2021 07:44:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NSHSBXufTUJT for ; Wed, 17 Feb 2021 07:44:25 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id 346286F5DD; Wed, 17 Feb 2021 07:44:25 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 622166F489; Wed, 17 Feb 2021 07:44:14 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 1E04D1BF354 for ; Wed, 17 Feb 2021 07:44:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1AC2E84428 for ; Wed, 17 Feb 2021 07:44:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X3uqbteWr3uc for ; Wed, 17 Feb 2021 07:44:12 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.142]) by fraxinus.osuosl.org (Postfix) with ESMTPS id E6FC2841B3 for ; Wed, 17 Feb 2021 07:44:11 +0000 (UTC) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 2E571240102 for ; Wed, 17 Feb 2021 08:44:09 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DgVGJ36fCz9rxP for ; Wed, 17 Feb 2021 08:44:08 +0100 (CET) Authentication-Results: mail.embedded.rocks (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=embedded.rocks DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embedded.rocks; h=content-transfer-encoding:content-type:content-type :mime-version:x-mailer:message-id:date:date:subject:subject:from :from:received:received; s=default; t=1613547846; x=1614152647; bh=9+YErb5o4n4bX/bdfbDaUzqyvFB5k3GwY0/cw7hLhDY=; b=E58e86ewbWnu SluWHgbJ2WmCMmfUr/YL70zotAYWiq6MciEaWDWoWDBlhr5pur1wBXlcIfx0HC0K AAg7tZpyoI4yb9+YtOugBlRSecN6oOU0P0YtOvLTROZsm4+lm6lMeqERHWDLjOdY pcLKK5fKDZuWlp/yGIYwxXVDD75fjJzgKFwYGlwekzkdSTT5d/C3/6mcPH+U1+2L YtRxvebu5npcbDhJnYcFROcjueS7roSVQvoyIaEYUBTpu5dJEkM6dmOWZo3egNoy 2fq4i9p5aMOApxkUIT6jass0uD2EkfMWGS7KXcPbPIh4zo1Hhl53ra5PU0emywyo fDxDrW6geg== Received: from mail.embedded.rocks ([127.0.0.1]) by localhost (mail.embedded.rocks [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id Vqn6Y7yMfJvp; Wed, 17 Feb 2021 08:44:06 +0100 (CET) Received: from nzxt.localdomain (business-176-095-158-210.static.arcor-ip.net [176.95.158.210]) (Authenticated sender: joerg.krause@embedded.rocks) by mail.embedded.rocks (Postfix) with ESMTPSA; Wed, 17 Feb 2021 08:44:05 +0100 (CET) From: =?utf-8?q?J=C3=B6rg_Krause?= To: buildroot@buildroot.org Date: Wed, 17 Feb 2021 08:44:02 +0100 Message-Id: <20210217074402.20849-1-joerg.krause@embedded.rocks> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2 1/1] package/taglib: drop config options to enable MP4/ASF support X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Both options where removed in git commit dd846904cbc1ef3ee628d77f0c9df88ef8967816 back in year 2011. Signed-off-by: Jörg Krause --- v2: fix missing bool in Config.in.legacy (Oops!) --- Config.in.legacy | 12 ++++++++++++ package/taglib/Config.in | 10 ---------- package/taglib/taglib.mk | 8 -------- 3 files changed, 12 insertions(+), 18 deletions(-) diff --git a/Config.in.legacy b/Config.in.legacy index 9deb67b31f..eeb9738e0a 100644 --- a/Config.in.legacy +++ b/Config.in.legacy @@ -146,6 +146,18 @@ endif comment "Legacy options removed in 2021.02" +config BR2_PACKAGE_TAGLIB_MP4 + bool "taglib mp4 support" + select BR2_LEGACY + help + mp4 support is enabled in TagLib by default since 2011. + +config BR2_PACKAGE_TAGLIB_ASF + bool "taglib wma support" + select BR2_LEGACY + help + asf/wma support is enabled in TagLib by default since 2011. + config BR2_PACKAGE_MPD_AUDIOFILE bool "mpd audiofile support removed" select BR2_LEGACY diff --git a/package/taglib/Config.in b/package/taglib/Config.in index 9e6bb707fc..6a87a13215 100644 --- a/package/taglib/Config.in +++ b/package/taglib/Config.in @@ -11,15 +11,5 @@ config BR2_PACKAGE_TAGLIB http://taglib.org/ -if BR2_PACKAGE_TAGLIB - -config BR2_PACKAGE_TAGLIB_MP4 - bool "taglib mp4 support" - -config BR2_PACKAGE_TAGLIB_ASF - bool "taglib wma support" - -endif - comment "taglib needs a toolchain w/ C++, wchar" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR diff --git a/package/taglib/taglib.mk b/package/taglib/taglib.mk index 9381e16672..738be35756 100644 --- a/package/taglib/taglib.mk +++ b/package/taglib/taglib.mk @@ -20,14 +20,6 @@ ifeq ($(BR2_PACKAGE_ZLIB),y) TAGLIB_DEPENDENCIES += zlib endif -ifeq ($(BR2_PACKAGE_TAGLIB_ASF),y) -TAGLIB_CONF_OPTS += -DWITH_ASF=ON -endif - -ifeq ($(BR2_PACKAGE_TAGLIB_MP4),y) -TAGLIB_CONF_OPTS += -DWITH_MP4=ON -endif - define TAGLIB_REMOVE_DEVFILE rm -f $(TARGET_DIR)/usr/bin/taglib-config endef