From patchwork Tue Feb 16 16:40:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1441003 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-secospa-onmicrosoft-com header.b=zmjdtH2O; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Dg6DP55jQz9sVF for ; Wed, 17 Feb 2021 03:41:00 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2E46A826FB; Tue, 16 Feb 2021 17:40:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="zmjdtH2O"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C29F382717; Tue, 16 Feb 2021 17:40:41 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0602.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::602]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EBE11826E8 for ; Tue, 16 Feb 2021 17:40:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mre9TJoj1IrLpZmhX9+/PRzeZ+JstEeoP0gnvmbLqX9ibeD4RBbIuxAYkZNRE7las6UXHDDRB5VMi7hjGQPniSuWh1jNqnNNi0cbTeacjSfy3gEIWzKO8lTPoYSM8zoRv38b8sKQPWQsR/19tUI74qJ6Se3l5ZTTZ7HHfr2kvdVMKiYwGxMMSF/NV+X24XHFXdgiq9P0PaiMIy/YgcjiH1bzRg0XS3pRmSgiKQdS0BPx6pRWYwYIeeXt9kwIDXhWmMjuuT70DqS096ryaxVG4KXXZ5PannQNn/xFIuBHKOh3q0UuBgTY8gsSMBz94r/s44qszS2D4tisjRLwZv3FQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u7jkIjGs8hIx+6FXt7WtKMKi4GlClOT33JtrINlrq8I=; b=B/XVGVD+z0727BFYBvkbVetxfNbLhVx0pj+LSzMdG/g3a7SkbhUoOm01tzCc5Y55bWC2MhvAZKp2Mf/sgQmrYBjuLSnmMtjfkk0hcwDv7RDosCqIx3BbkP6YsEEh9ne994gBEfslOS+CtSmvOrw0JL4SnLlvkBSlzunrniI8acxkBGiiEMWueFvHgKyQqDh55jXlrQ9kqTJTQVKSbUbL1am1i9w6Y9UMJJRCOPwvIpQrs8OqAoKXl3zOO+CS0ckZ5tXSs/UAIC12Qlv1qjhJzA/hpH2z/zUWU5+FPVW6F5PBXX6T1LerhrGKAmPQ7sie8cbCD/vtybkWBmOoydUEEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u7jkIjGs8hIx+6FXt7WtKMKi4GlClOT33JtrINlrq8I=; b=zmjdtH2OrmpFcU8dkFyFqGyQcRWOKCqX9yGRRw19FuFt2lc9d2BiUc3GCSDYGPV3o3V90lE+HEslDY4gNJvqvyTbhwN3V4Zie6qHBVuQFLb86iDW81LFw/WtJdHHornWyV8Y2MDtDROq/8rrlt5QtkKwAbaiCtMj+VOOEJCj1ys= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=seco.com; Received: from DB9PR03MB7260.eurprd03.prod.outlook.com (2603:10a6:10:1ff::11) by DB7PR03MB4025.eurprd03.prod.outlook.com (2603:10a6:5:30::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.38; Tue, 16 Feb 2021 16:40:37 +0000 Received: from DB9PR03MB7260.eurprd03.prod.outlook.com ([fe80::b1cc:42d1:ae12:c53e]) by DB9PR03MB7260.eurprd03.prod.outlook.com ([fe80::b1cc:42d1:ae12:c53e%6]) with mapi id 15.20.3846.042; Tue, 16 Feb 2021 16:40:37 +0000 From: Sean Anderson To: u-boot@lists.denx.de Cc: Sean Anderson , AKASHI Takahiro , Heiko Stuebner , Heinrich Schuchardt , Jan Kiszka , Simon Glass Subject: [PATCH] lib: rsa: Add debug message on algo mismatch Date: Tue, 16 Feb 2021 11:40:15 -0500 Message-Id: <20210216164016.635125-1-sean.anderson@seco.com> X-Mailer: git-send-email 2.25.1 X-Originating-IP: [50.195.82.171] X-ClientProxiedBy: MN2PR01CA0062.prod.exchangelabs.com (2603:10b6:208:23f::31) To DB9PR03MB7260.eurprd03.prod.outlook.com (2603:10a6:10:1ff::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from plantagenet.inhand.com (50.195.82.171) by MN2PR01CA0062.prod.exchangelabs.com (2603:10b6:208:23f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Tue, 16 Feb 2021 16:40:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 238bdafd-ca87-4d7a-e544-08d8d299968a X-MS-TrafficTypeDiagnostic: DB7PR03MB4025: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:114; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WL3GiyE48ckwJBfLtORGvXb4QJVCu26Ulh+hulK10Dbw30/5ISyr9GngfVa8URAU/2qB/NoveDcG15Tf8ghlFep5a2FwrABKx4So8PZ6p9m/BUBeYv2h+Wp61RFTI8rwSBvk7QF1CWRK66fej93qlNgHXrcJh39n2QzmESVsoqUPIoUShWxpDSO6nWTgl8RrAnkdFQ7YZ+u6ibhx4Ym8Brt31UTF/duMkWQqhlAQuCdULWotaxzfxy4OLqZPDM3cqcwLSVquZwgAMP85fzDuFWTCVeMMG8bpIRtoFlqYClZYW9E6J436Q5cfp1f8gqSXPIyxNe+BzXjbk9L90iPRJIVBjyr/E/UyjMeP3TnSgHJtn/OuwSHC2o5lZZLIRGB+JwbQG4NIprOVBzpT5i4hv65EP22iO7J0oIBhmO84wxzrGDzN3vemRw5JFvSUF+arqj0KTN6nZH2oLXlamXQUULldfCEhQB/PlZfIa0F9jdWEV9sy46V5Dmk93Q1iroedXpUADz8qkQJHMrpGeLmmPg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR03MB7260.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(39840400004)(346002)(136003)(396003)(366004)(4326008)(16526019)(1076003)(956004)(4744005)(2616005)(6486002)(66556008)(86362001)(6666004)(6512007)(6916009)(52116002)(6506007)(186003)(5660300002)(36756003)(83380400001)(26005)(66946007)(66476007)(44832011)(2906002)(478600001)(54906003)(8936002)(8676002)(316002)(15650500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: D7cJotd52tr9y0FJHVJGC6M7wJ6hJn/Tsok7Ykzo/OrjttbNsd0E8F/B5e+kVtI7RsskbqjawUxhbMZoiqteNRdTGbpIL8uxTkDyGlxDZUoB4YBYdNYnmUX/UA8gkLX2UaFvIzsekZ+bpVSTmcYenSfj7rwgGzNsq5S11kP+auBNetCjWyeLKCGEoyAwAIxk+t6ohQiRn2UwQNHvWVoqUAUwaZMKWc6rkjcbYHl7vwwcptXeYDlpKjmiYCbE/mSGYLjhGw7gyEdntmriJ4/SLdwuE99ujr5iABtKeNYu2/uukpCw884nJjtOqQ1N0EihBMaqP4bgZM6zHJlC9lvXuHqw2YU5FXl9mSD9OYgVKQgx27lGCQhgIfrQaiGdMi+ygMscyRtEtoriRMqghfKphRxzgyt7I2Q9qJ29GeCDmIHjVC02ewyyj+fEmlCyYPm0h5vX/1R1/WYmJTD2AKfNVKi9kM31wZQQjsiitJYrj05VNkyiP+a2jq/56eyDNwM1xmJ873yRF5XUbyErC6ePPxSboEHtqDFSPJYVdH42XXpNLIXpoCI2F0lar42NcC1K9S9UzuTkS+3wj7UwAjDGU1/ldWbj7Wuo6lJh2M6MJ1dRAoESPVnkHriJuHb9MmrQMMDauF8v0wVYGR+F4XQyH12mK6NbdEQNhdVOSlqOgZPg0IOy6UXaqjFHu4DeTqkYMR6mH9P3eYKC4caNdHPlK21j4aqQwyAGkxHts8S0VN0AqFDCiaXddyUSBEyN1CCROGeKnpcBCCyZ5ohgkohLweLU2nhPdg8d41HkMqHZd+Iq1GxwVQPSXzz8rnVj3hzikG1ouR4WB9bjXvyx1PEQY0TJ4D5RUP62AHrAAJWogfTTFa1uaRqmXi4KzHNvyVqNvSOhn7j3FYkcAGEC9obu/Zkk1/g0n18k/MGYep9cPQ/+9YTiPl9EK66//7EKomLpgxoi7BwSW671YnVJuYem1o1NnYgN+W6E8A2ok/eIi01/agc/UJ8CioskWoFdhdSaSjdT70rvq15f3ZH7UUJRc1ICvQ6zASQBOg2m11+5tDOJl2Xn21EL5SUxOXOYrvWsdqkGgAhJYZPDx7yspDWYQ8jc1oMJOORVMQDwMVsg44AhOQtH99zRQtbkPG7lv4N62tqS5tWlpXxh+J3pmU1CzTxXMtQb+/RNuTrpExpoVqhidAlMolprvs6G4F8mg3QTfaoatsL9K01DRWx66LUDgUQi7CuLk5L+wBgk9cKbQyt69ekwysL3hZie7AW24K21eVD/XH+s6VBxwz5Zo/MnhopqMzMvP208A4Tdtw7GP/V6XW0ld+IHVHHznhwE9Z8R X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 238bdafd-ca87-4d7a-e544-08d8d299968a X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB7260.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2021 16:40:37.2918 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F2bK7KRAO6yoiaq7EZ495irjJDsnqi5xaACeCqk6+c1idKngRGUMhMVK7l2IGuNBVsxxFsIYSTkkR5TcvVZnLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4025 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Currently we fail silently if there is an algorithm mismatch. To help distinguish this failure condition. Signed-off-by: Sean Anderson --- lib/rsa/rsa-verify.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c index e34d3293d1..aee76f42d5 100644 --- a/lib/rsa/rsa-verify.c +++ b/lib/rsa/rsa-verify.c @@ -447,8 +447,11 @@ static int rsa_verify_with_keynode(struct image_sign_info *info, } algo = fdt_getprop(blob, node, "algo", NULL); - if (strcmp(info->name, algo)) + if (strcmp(info->name, algo)) { + debug("%s: Wrong algo: have %s, expected %s", __func__, + info->name, algo); return -EFAULT; + } prop.num_bits = fdtdec_get_int(blob, node, "rsa,num-bits", 0);