From patchwork Thu Jan 14 22:12:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Ruffell X-Patchwork-Id: 1426708 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DGz8Z3qxdz9sWQ; Fri, 15 Jan 2021 09:13:02 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1l0ArT-0001oU-GA; Thu, 14 Jan 2021 22:12:59 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l0ArR-0001oG-Q8 for kernel-team@lists.ubuntu.com; Thu, 14 Jan 2021 22:12:57 +0000 Received: from mail-pf1-f197.google.com ([209.85.210.197]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l0ArR-00084t-ES for kernel-team@lists.ubuntu.com; Thu, 14 Jan 2021 22:12:57 +0000 Received: by mail-pf1-f197.google.com with SMTP id x21so4173042pff.14 for ; Thu, 14 Jan 2021 14:12:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xiSIdr0n8OaFkAcvKlY7Kqt30K3gmo1dhfbxYrA78WA=; b=fFHbiW0FStlMXD3oBVOV4dTwGWutSxYCmlKsEm/NTwLadp8aVi4XvJ7r60P05IrN97 ah87wgfnEMP+ZLCuBqIx7NktJof1fANwTvlvNSeHopYdWoaTg9C5qiCbpY9YrSbXtoUu msykXcUTGL/F4BDcEWSusYbq79ZRS33cI6ObxfYCeaPI09VBC4O/qLEZV8aWTFqG1MeI etfuxnohfp2p81i3DkMPUbqe0zb0Svcsl62WVm+uhFwwuqjgl+582SAbsB1ipcT8Ra9w 5U1ZgETvX5KjbxHx9VBsR/D/8jIUuF3VRP2Hw1nI/JOnwAJJ2T91apfRjwcOxjyj2U73 DnyA== X-Gm-Message-State: AOAM532r5/Gy9tVta9p/b1OwLifzR+AYNuS5+W1GAerOJbPxnkLNp9p/ dF1EIa4PH8YF7TootLU7cQJmkmyZJm8ehw8te40dbdcg8rd8HNppG/5qq9dq6W/Rt8QyAgK7/r5 c7n9YUvzR+q4aXORAEmKza6hvYFFQTw+Yg0DLU3uf9A== X-Received: by 2002:a17:902:be02:b029:da:c6c9:c9db with SMTP id r2-20020a170902be02b02900dac6c9c9dbmr9357968pls.69.1610662373216; Thu, 14 Jan 2021 14:12:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxX9ld2r4peavMkTcRjcgI7vXuJOGIpd1q2KhnY5hlBPaWvwAtLv3whaV8sX11ambUojQyOXA== X-Received: by 2002:a17:902:be02:b029:da:c6c9:c9db with SMTP id r2-20020a170902be02b02900dac6c9c9dbmr9357945pls.69.1610662372815; Thu, 14 Jan 2021 14:12:52 -0800 (PST) Received: from localhost.localdomain (222-152-178-139-fibre.sparkbb.co.nz. [222.152.178.139]) by smtp.gmail.com with ESMTPSA id 73sm6500301pga.26.2021.01.14.14.12.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 14:12:52 -0800 (PST) From: Matthew Ruffell To: kernel-team@lists.ubuntu.com Subject: [SRU][F][G][H][PATCH 1/1] qede: fix offload for IPIP tunnel packets Date: Fri, 15 Jan 2021 11:12:43 +1300 Message-Id: <20210114221243.21614-2-matthew.ruffell@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114221243.21614-1-matthew.ruffell@canonical.com> References: <20210114221243.21614-1-matthew.ruffell@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Manish Chopra BugLink: https://bugs.launchpad.net/bugs/1909062 IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time. Signed-off-by: Manish Chopra Signed-off-by: Sudarsana Kalluru Signed-off-by: Igor Russkikh Link: https://lore.kernel.org/r/20201221145530.7771-1-manishc@marvell.com Signed-off-by: Jakub Kicinski (cherry picked from commit 5d5647dad259bb416fd5d3d87012760386d97530) Signed-off-by: Matthew Ruffell --- drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c b/drivers/net/ethernet/qlogic/qede/qede_fp.c index 004c0bfec41d..f310a94e0489 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c @@ -1737,6 +1737,11 @@ netdev_features_t qede_features_check(struct sk_buff *skb, ntohs(udp_hdr(skb)->dest) != gnv_port)) return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); + } else if (l4_proto == IPPROTO_IPIP) { + /* IPIP tunnels are unknown to the device or at least unsupported natively, + * offloads for them can't be done trivially, so disable them for such skb. + */ + return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); } }