From patchwork Sun Dec 27 20:18:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1420765 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=P4Z63bUg; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D3sTy0Ph2z9sWd for ; Mon, 28 Dec 2020 07:19:22 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 381BC80404; Sun, 27 Dec 2020 21:19:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="P4Z63bUg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1B4DD806C5; Sun, 27 Dec 2020 21:19:09 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4AD09801D8 for ; Sun, 27 Dec 2020 21:19:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609100340; bh=E2pw3orZPPbxD2Y/52yRaxG7Htojg0NRvyK83WvlTGM=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=P4Z63bUgyNALsYR9JyiEJk9DLa9DVen0oGZmCPUID+UAkUOW7Z7IXuWf3yP3oxFW/ Ed8RBhNBWSj/CKQd904HIoNT1T3nVhRMwb39pARQCZC+VaJHrs6ExvmqzhRRqxi+0L l0yzBuHf920j4+9XcYDnHNzQmKUsoJ4vFpgyz2VM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.246.89]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MrQEx-1kHnAR0ivv-00oWTn; Sun, 27 Dec 2020 21:19:00 +0100 From: Heinrich Schuchardt To: Ryder Lee , Weijie Gao , Chunfeng Yun Cc: Andy Shevchenko , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH v2 1/1] pinctrl: mediatek: correct error handling Date: Sun, 27 Dec 2020 21:18:26 +0100 Message-Id: <20201227201826.104658-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:0LSqLfiGY9a1m56OusaQiorcQItzfA/hY096mwVAxCoMBAQyiiq fO1d41DxZXEc0wO8AmdHswog29ZrsCRebs8yyr6Hn497F5vpP1vraMLRAtT9RkIWZGPcVz7 hF5pmLA31G0B55uyleLEAKtdUCq3bKfuBViJ+sXCSQionpPa9zmkjWwuyuYSGvM0NpiFQzY 1x8NlKLlibLIwJz3TcVrw== X-UI-Out-Filterresults: notjunk:1;V03:K0:det0k1nZKDA=:ih907mftXhXsbQAXmXmZZk 6SLZJ8kawLPZVa4mytpnefd8oKHi2Ym60tVjfbJXaEGTELI3J3BduC1rzbJqZnl25Jc4ipBBA saxVuKdvPVEAbRORU1WFCaK2qP0KXgvXW2l12nEscPn2c/hC/LXMn0f1AGX+OVsEahGqVch+d SukHwg0J1vHRPsrRAOAHvy+KbwaDkGQdOQFaCKA8KlyWSZ0crCrLhWLIE6OVlVS59XbSYZyYt xsPFoylYWm+zG1SemQ/o7Jn0UonrZZpgez6aCmqKrXTGjzcmgtAElkstWwP7CedpOU4yUVabV LWN/xvkEhzkkoaqeOMYU0h2mEwoVw0ne1EFhuDnNTZNx8Khf20IO3ov5wPHMgnLH69bU7DfzW AcWGJFVpn/TPnh9L7TB3adtU4rfviEW9hu+Y5h42FZXCXswI/yDSsVgMgIbgib2K5dmfDjANM trTpD2NnvZ24NUzNu2Eyelt5cetMbTr7E93xTxupKHIQkAPGqvRzarBiI3XUA76xzIPEdLiGS idpz7CyiZ5jD6mie8WIvNlqtRaBFVPcv/T2cK6tywtHE/jK0pkWIfA9JNo4tSZB2JUPJLmeZx 4qdJho7gzI9j6fmSQMCqeGFUV8UoFobNcgkd1wEg7TPxmjMv/4kLIb6Gwg78g6x1bmKYS81dd cRPMIA3y5JP4NRPy+fQu8mmYWaaCu5I4toUOpErWHVZkMozgxnloZLYX97sMRTkNlSvjzQqdU Sv4qzCvyAWdP/6tSWjBM5pZODPaAovS6PNnMeKBKRildbDrsTj3LGfHnHT8Fb1XnOJby70mtV hEeO3LciMj+qnWQR0w7CzEDLOIqqhWWQNokPdhOv1n/8e4Z9LUeQq+g/+fvlgZMWZrQjUxh5W O5f4HkLjfFw3yg8rSmYA== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean If no GPIO controller is found, the return value should not depend on a random value on the stack. Initialize variable ret. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt Acked-by: Chunfeng Yun --- v2: move the assigment to the certain code-path (Andy) --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 1 + 1 file changed, 1 insertion(+) -- 2.29.2 diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 6553dde45c..4dd3f73ead 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -615,6 +615,7 @@ static int mtk_gpiochip_register(struct udevice *parent) if (!drv) return -ENOENT; + ret = -ENOENT; dev_for_each_subnode(node, parent) if (ofnode_read_bool(node, "gpio-controller")) { ret = 0;