From patchwork Sun Dec 27 10:48:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1420723 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=UGkHzYd4; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D3cr05MDnz9sW0 for ; Sun, 27 Dec 2020 21:49:08 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F00CB825BF; Sun, 27 Dec 2020 11:49:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="UGkHzYd4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 97CA9825D4; Sun, 27 Dec 2020 11:48:58 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0C902825AE for ; Sun, 27 Dec 2020 11:48:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609066133; bh=+tWs1m8t57leTkTk0Yp9MRIztOOmhS+ccFXI/Qep9WY=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=UGkHzYd43mjN0TW4fr9GfuEeEkey4bgpRpKboZgrfmB2xzHNI+S8C8WxLFNDWjRXS b55cF20d8zxXr6j/DPtFpcWN52MB+q42zppRH4Sf9Ju5SNMVNgdvIDAGBAJd47TnPF csF7uG+zNMNqb81bhEAttNInoqr3PExW+kvK9PYM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.246.89]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1M1psI-1krHkT13CS-002GOH; Sun, 27 Dec 2020 11:48:53 +0100 From: Heinrich Schuchardt To: Tom Rini Cc: Heiko Schocher , Priyanka Jain , Simon Glass , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] drivers: qe: avoid double free() Date: Sun, 27 Dec 2020 11:48:49 +0100 Message-Id: <20201227104849.28271-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:HuRNXtdYy+W7E7XlCgc91Z+CuOacymNwERWDVDMSpNC4U+g+pKU MP5z3lymdgIT3fzWj5a5V0pwDHEvWp/fcXGVNkVe2bj97LbUrFh+oosVTAjy9omK+bocnP+ 4TwebLJoaIUDNRRXm/53vD2rjXlmn/bxIXuhqKx9NA3wz+7qlOrSVE0kjsYtnQHCGNIeha3 xsTO4a6LV324irMeJXO3w== X-UI-Out-Filterresults: notjunk:1;V03:K0:k57+gN7c5rM=:JdvIxVpDuTvPeQ1d1qyWrJ GkpSstiKaItnZOFof990xX2sByNVUD7Rf4dg1MpFoyINAYAyXBtHGZtSCXSMF1g+0POzU2vyR B0PWfHTVl7JJHcAYn4PmwIWnYtj+o9LjUpLU+XKtyxvcoSFinoQxBLXdtszvbF4G9vVzI2xDI QsgDVbTPlFSskDgSCGuh2rvS7YT6kbXuKyhvoXfuCfq6rXewcLlkpGgHZTR2Zf03STK/eoegw JhYe/xOEneXMq9vOoNZkfGnVWPlSLcT6Xi0M2V0QgEQVG8YhUdFXS9a8KM3La/InVDdjWfnmU 046ef1HQDaWMlbDyFwSjWQ1YDIW1BAQSsBfmboiiTX59/KbrwjI32LlTz0pFNVc4sXczXDv9z K+TpEbszWtDdVvY2C3yKtTMIs4jOqmVzWaNrzlnucMbMGPqeSwAcOK0W7qASGOjOMzmdm+ieJ kpyrvzWA0n+JZqWtkYtp/xFebFiB8s9a7ImToa6fp1buecfV94OFsRKmulAIpnTHEzSoe4+wV iQLb3F65xvju84yg7OyyR6e77+W/BYVhjYnnYhMQZpJsVKXLm4r3GLUTXb/dxixUH0QpVcOgF 3LHoXQL7WPZBWUqarYwLqhYRfNY1PZQUTCm3/dsYCyO9mcXCxDOCTW45PXUFyjpC9+P+RVCii BnbfGbGpayBsMK8VHPP8BD3nxQE7hW5ooW+su7073UMpR1tTNJRIkG2LVfsnG4PWMaepl7JB/ 5S9juhx47Kj1he0vHckji/kEAEGpFRwl8Xc6ZXwp8/csO6kg3WE5TbxFvBh8mWzv2J64WFu7I Qq4pc//JpBNkva4YSRDfnQfB1rPAe6JjUA3sr+qy12HZRA91VxwZN0z+asEqB5nUM+ImaIuu2 KNqf1Ff92P1QpmICvx7A== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Avoid calling free(addr) twice if the device for ucode is not found. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/qe/qe.c | 1 - 1 file changed, 1 deletion(-) -- 2.29.2 diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c index 1a829b5a4c..259e4e3e67 100644 --- a/drivers/qe/qe.c +++ b/drivers/qe/qe.c @@ -288,7 +288,6 @@ void u_qe_init(void) struct mmc *mmc = find_mmc_device(CONFIG_SYS_MMC_ENV_DEV); if (!mmc) { - free(addr); printf("\nMMC cannot find device for ucode\n"); } else { printf("\nMMC read: dev # %u, block # %u, count %u ...\n",