From patchwork Sun Dec 27 10:39:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1420721 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=g7Lr/X/F; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D3cdS2L9sz9sW0 for ; Sun, 27 Dec 2020 21:40:12 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 20F82825AE; Sun, 27 Dec 2020 11:40:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="g7Lr/X/F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 819B4825BF; Sun, 27 Dec 2020 11:40:03 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 770528236C for ; Sun, 27 Dec 2020 11:40:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609065594; bh=HKQw0o1ZHN50BPbQxFfgxR3SbYrbtqhY6n5edn7iJTs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=g7Lr/X/FRmf8xThVTgdwhbH8ntKhbv+RTkVH3IeJHMsfa4J32HklEze7/BPsED589 Q/1/MG6Eqw2GkdYlAcftXONcUbR2ANqpT1IuRql2A4MhRgN6PRlksSE1S1qXaHdlFC ciGik6JLdD0sRhRHJSy1sE0Yzkw4LxTP2u16Ytwk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.246.89]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MNKhm-1keaGm1KP4-00OmyB; Sun, 27 Dec 2020 11:39:54 +0100 From: Heinrich Schuchardt To: Ryder Lee Cc: Weijie Gao , Chunfeng Yun , GSS_MTK_Uboot_upstream , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] pinctrl: mediatek: correct error handling Date: Sun, 27 Dec 2020 11:39:49 +0100 Message-Id: <20201227103949.28014-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:oiGMDebsIit/UisSZVs3/IPCbF0D72VNslyGI7YwZTT4qXCji8n OKhuFUjNsVlN4BUpaPAeddznU4HbquWzRC0D25saP4umNsvDKLMuGkUxDQM9B2gVuWyvVJ6 imAzLhVFv/sPz9BMMTUg5Wr/qJRh3FTZxcmQGe+UFU9Iz9ZcXcPcFAhe39YVfxjwi7Hw75y LtcvjscQ4vQulYhtnSsHw== X-UI-Out-Filterresults: notjunk:1;V03:K0:aLOFVIFV3Ss=:OMI7fVIVhdVG2YS+riJkDg JabWSsSGQ2+S6Drr0bZB4iKyu/TxzY/Nt+BOSS8AbmV9pO5n84ddEhzcf6bWaOEA7rRY2l+99 NIDITFTaDI5IeVxG74KJc6Li06juLva7/efPvRwvd4KQk1/XhYdzyj8FZdKXxmIhRxLJXbSGi fXMkP246Mv8heM+0kyageCYLJlzWQQQ+jJdYUK/Kb22wjc7wvcqUNVr7U1TboDHEFq/Zs4i6b /MaRTnBVbzIsHQkWbEmBOVd8Ju+c/uReLX1V9aTaZgT/NLF2vb+T8uVxExeEZD0ceGlVWAKyB rTivjcTgxSMTSEdBd+Pt3np5s87jGALtWeRPaxPeSKWpcjR8ezMhZeDYH8dbvk8G0U/PnpQAh m3ack/rsodtLsRA47ZWP/TPcVsjZ4xIe1UcrJxZZg67sg9A5SiOYEO16MqRG6bBx3o2Lrg2VK iTPU7TSB1TOCgTGTQ0OUipoGnrZQ78E2T4128y3aSjsOsTKZHlHb9PFug6/dltOPv2ceoF2nb cIHebkNi4eaEzlvz8HNJ8O9tbOF5xA8pVSftXb92HOib0Jg2E2eC+cSD80pfYw8/bRwAgfMLf 8hLLow7TlYV2jXBz+X5tpvR5GqI2LPxeNURL/hc/FHuhdUXuxfDg2UmWSxQOvs4kYggzf8b5F TV3L1drURIJWg5iBHd2xyLRvp8VRjSbMjvk2oGcsl4MCRvPQLM3XvytcrZsjVCEXkCAMAvowP UwvJgvGm5EovIaMg+ZoQZnPeF6c6FxjIU4M+ytcorL2G8mwCxmFMWabVmseQBPN6I0FjmiLnM qAnLRTgENchP8v0qr2/qGoU2+QR3fA0tYDlpTOI8pQnvMjs5kV8qWzgxfRUk3f/7RpEVWhafw XsFHT03yA7bj8MeNmOQg== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean If no GPIO controller is found, the return value should not depend on a random value on the stack. Initialize variable ret. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2 diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 6553dde45c..8b4e0e32c5 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -608,7 +608,7 @@ static int mtk_gpiochip_register(struct udevice *parent) { struct uclass_driver *drv; struct udevice *dev; - int ret; + int ret = -ENOENT; ofnode node; drv = lists_uclass_lookup(UCLASS_GPIO);