From patchwork Sun Dec 27 10:28:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1420720 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=CW+6/GgX; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D3cMy596hz9sW0 for ; Sun, 27 Dec 2020 21:28:30 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 10918825AE; Sun, 27 Dec 2020 11:28:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="CW+6/GgX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B6D7D825BF; Sun, 27 Dec 2020 11:28:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 293AD82578 for ; Sun, 27 Dec 2020 11:28:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609064896; bh=MgwgZkYzVwvoqJJ3FSSU/YWvUu6rmyZ+zlVJV9YwIkc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=CW+6/GgXPGT37+HoIT/Ncae5+H8A40SJWhktlhrbLDezxTLVNuVn3A4ie34etbNI+ vydUlTdYXXcLP3fpMi3ncIafyJje+HzFezpJfPzFtuEpmwhq7Q9d5kJnWs6m8nS2Zy Lq9ah9wtu1lB60LnO0DXenH9ycq3KqPOSiuXu4Pc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.246.89]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MvbBu-1k4OpV3sOs-00semk; Sun, 27 Dec 2020 11:28:16 +0100 From: Heinrich Schuchardt To: Michal Simek Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] zynq: mtd: nand: remove superfluous if Date: Sun, 27 Dec 2020 11:28:12 +0100 Message-Id: <20201227102812.27699-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:LDuBQab4MR443OaoRuAqgT+yTjhkQNCB9zGm3YBUTY5rtOptDNd XNj9/7zDn0G9EhfUUt3VCp/KKmmT/CMFB87ER+qTY/JxsH7mBhzvn4saLE39F6MgFqbNDik dFdUGAFWkH21U3Zu+3wRYA/lkAITx0rdSW93QcS/EV5WRD8Y+ZnwjKHO33hZWRhccttk+Ep Oi8dN/OQUz8NdtbA4Ai2A== X-UI-Out-Filterresults: notjunk:1;V03:K0:UhKSEbFGSvM=:tXbp0pMyR1AheZGo+n3IvA I89nvg7qWP1iRTGQhmx0sT6L5HVpYc/GreTHYmy/HrVc5tB498ti4yRxmAi4wKKomYb+iuQXV p6htdAguRI6ziAQ4PoT9mId5UGWQxv1hRlcuI9MnSP0ML7/DMIjoIiqk0+k4BRTXlZBx1H2o3 NX/0Gt8Zpp3S54q38hMeUsYbD7j0zCYHTfp+yC9O/NcMWL50XOzpDgVUTlzb6UQeq69FAIsLY PBLdoEjngVus/hNk079dtGhrjYKcYLq+dOsq4rRidUwcPdVS3i08zzy3oVBPRK96D2WPpDK1m oStellFywBVqQUSeJXwPSZwUWMqxzamNI7bOKiSF1N2r1lgJJsuvI63xQ7Tfn3Fs5PwoEG/Bl a3rM3oHPCzq2hDwxgcl716nRMPAqT4n0LCNDBPhFtbihtezON7dRPVYO3ZoIM6+o9T6klVzMd PpyV28nR9zbJmisjTBqo9anIvZ9fgg+elkyI7b/gs0UzXuQTyJT73mtrhnsJEYOY7i/FgO4Xp dD2d6gQn6251q2iWfQexfBDOiHZvzP+NEr6PdD/H6PsqDu0nmmEqXuJjKHxVMZxaSudrJ7cUC xWpxp62hBq80HK87xm/Ntrsyn/7LUmr+77Ra6JTVaRbByi8vwJWZQWJTeTyAdWp4/Vax1W8RN FB+GQguh59uiDyI1WMTi6phigkGgVu1IjtdA0UrhjwVDEcGsJRnVR40D0iK4+pW21TAIeSZOE caPGxoJFEKQ/9I/Tjx8LtE9GzIOJU6f4arlWaF36TS787iHfqbRtKh3UJfoTYFFu+Lk3J+toe /y96EYDRIx8eWkYGhbeBIuW9ucNGmShMwScdISqkugB+bSO43flyTbMrw0Rpxrji1qI/uG4ON 8Jt7iTaJMH7F2vw6dSIw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean This sort of code does not make much sense: if (ondie_ecc_enabled) { if (ondie_ecc_enabled) { Remove the inner if. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/mtd/nand/raw/zynq_nand.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.29.2 diff --git a/drivers/mtd/nand/raw/zynq_nand.c b/drivers/mtd/nand/raw/zynq_nand.c index 92db2aa19c..65817ea7f2 100644 --- a/drivers/mtd/nand/raw/zynq_nand.c +++ b/drivers/mtd/nand/raw/zynq_nand.c @@ -1206,12 +1206,10 @@ static int zynq_nand_probe(struct udevice *dev) nand_chip->options |= NAND_SUBPAGE_READ; /* On-Die ECC spare bytes offset 8 is used for ECC codes */ - if (ondie_ecc_enabled) { - nand_chip->ecc.layout = &ondie_nand_oob_64; - /* Use the BBT pattern descriptors */ - nand_chip->bbt_td = &bbt_main_descr; - nand_chip->bbt_md = &bbt_mirror_descr; - } + nand_chip->ecc.layout = &ondie_nand_oob_64; + /* Use the BBT pattern descriptors */ + nand_chip->bbt_td = &bbt_main_descr; + nand_chip->bbt_md = &bbt_mirror_descr; } else { /* Hardware ECC generates 3 bytes ECC code for each 512 bytes */ nand_chip->ecc.mode = NAND_ECC_HW;