From patchwork Sun Dec 27 09:26:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1420716 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=k3i/p7aO; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D3b0g00ybz9sW8 for ; Sun, 27 Dec 2020 20:26:32 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 717C38232D; Sun, 27 Dec 2020 10:26:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="k3i/p7aO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B3BF980829; Sun, 27 Dec 2020 10:26:14 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 339C580829 for ; Sun, 27 Dec 2020 10:26:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609061166; bh=Y6l4uDT9gr4jEANr4coziS4PIsFVbDdXbsMz4IChmkg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=k3i/p7aOQVdmfOoqKG5RPntKH5nVpu2GHt2Xz3L4x3eenSjHrF/rLUTTUZlD4V1sq fl531jdvXzSg8MxGws1fBSGvdFLgz20Q/9jdtqg8Mmu5mluog0AlAb+TRDQ/sSnuqU RR2oHcPEYmWP6Fr+HXYDA8UQ302099COHMcNtOWQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.246.89]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MVeI2-1kU7xJ3uZY-00RbTC; Sun, 27 Dec 2020 10:26:06 +0100 From: Heinrich Schuchardt To: Tom Rini Cc: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= , Daniel Schwierzeck , Simon Glass , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] dma: bcm6348: incorrect buffer allocation Date: Sun, 27 Dec 2020 10:26:00 +0100 Message-Id: <20201227092600.6000-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:kJH4UfyyKURepUxqPw/bhN+DmxTs3yWt87heE+SZKVl2B2sPpP6 6DNZj9qGOVI3h2iqV7doCdgu4U4NWrHa4Z52vIQpJPLmuJECdKGxBRIJtH81/KhhgS95Onw KZc4FCCIEE2VwW+C7xAIopqs2ltzut+Z9GxOjInKSMwpjevW6y1qxrYdqqQhiOFEeAg1oGc /W61DXCsjCl2y84kEqnMQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:gXJdTUTnS/A=:75hSloIvb50oQ6aOy6TNx4 jJ7pdeoS/XGSq1Q0u+TFQhSXB3JpW5N60REuEaileSytoQk4+S52bR1qV9GLVtd6WE1R5L6sN JWSYAaoL9kk89qEWuYjoKZedkBIfkumEc3qsoweogzLHmnMbHFjnROrkF5v1MZmPhK5QxTd1T kGG6TCQK1iJHQpgFHgbrCbPWX4wH3ElenZqpr/ydDhbJ15IJ1+/BglT4g5k5D8qbhFWab/UfX PBW0r7IlGpRXkllrehekHzdg3u8S2uHvIjGF87qgoAfSS/mgWAFT5/ftcefrQuykdfHRB/Jnn jAPJnmZqnGvokEU3PkXKJf4Drv9tyU/Mez60F0Rdff1UMc64PSHt2u5HTCqgV8HffttQUL6bZ DbwGMkBeLEKiRDtUEnSSrgK/eyhGrBwmiJlcb2V08dhc22/+JyJKbPw02GITfcAnvwON7fzQa CuGrt/F6bogvnqOVG59rZHE/tsdc5qTgortMoRKpCCCy2tnhgi6sb+fXGyDv0ehifg1Vcd1vc SUmvWe3lj49BoljHxk0rwb6Sf9+6kVDODRfv+YkFqEXYjc2XwsDMCT1j2W4hSFkTJm0Bio2uh d1vDk28rIhNIQRELKa9rmqO+UpfRpKoayZALb5tkTy17Dooal5RRmKpSKHlVz3IBaDcQ7eT6t 9/inOsw86G8CHUPm8o4HAvf1Fe2n9UNwdcfvgremMB544cwv7oOSjmcLIshuwgo8NMj3zuUOL tOxI2Hd4zDm2ItlkDT77uAcwp9OkijgbGSC/7N6oBJEEEeggFirqab5CZcsj6EHGhCH3tK3mt UHA79IZJugU0bSJeuhnooxmNdFrqE5IbH3GlO1i1HnmKArKqYNVebkR5mAJVjasY64Y0kJ6nH 5kJE8IZ+pncrKzdEBwiQ== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Calling calloc() for 0 members does not make any sense. Setting ch_priv->busy_desc = NULL for ch_priv->desc_cnt > 0 is equally unreasonable. The current code will lead to a NULL dereference in bcm6348_iudma_enable(). The assignments for ch_priv->busy_desc are obviously swapped. Signed-off-by: Heinrich Schuchardt --- I have no device to actually test the driver. --- drivers/dma/bcm6348-iudma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.29.2 diff --git a/drivers/dma/bcm6348-iudma.c b/drivers/dma/bcm6348-iudma.c index 91172d483c..81597c56a7 100644 --- a/drivers/dma/bcm6348-iudma.c +++ b/drivers/dma/bcm6348-iudma.c @@ -313,10 +313,10 @@ static int bcm6348_iudma_request(struct dma *dma) ch_priv->desc_id = 0; if (bcm6348_iudma_chan_is_rx(dma->id)) { ch_priv->desc_cnt = 0; - ch_priv->busy_desc = calloc(ch_priv->desc_cnt, sizeof(bool)); + ch_priv->busy_desc = NULL; } else { ch_priv->desc_cnt = ch_priv->dma_ring_size; - ch_priv->busy_desc = NULL; + ch_priv->busy_desc = calloc(ch_priv->desc_cnt, sizeof(bool)); } return 0;