From patchwork Fri Dec 18 10:43:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 1418184 X-Patchwork-Delegate: narmstrong@baylibre.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=PwRDL4j6; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Cy58n5TkTz9sVj for ; Fri, 18 Dec 2020 21:44:31 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5745882CAF; Fri, 18 Dec 2020 11:44:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="PwRDL4j6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 322F482CB0; Fri, 18 Dec 2020 11:44:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DA76782CAC for ; Fri, 18 Dec 2020 11:44:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=m.szyprowski@samsung.com Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20201218104359euoutp01827034e2c3a22f1640659e7d238fa3e1~RyaHhPIm82465324653euoutp01g for ; Fri, 18 Dec 2020 10:43:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20201218104359euoutp01827034e2c3a22f1640659e7d238fa3e1~RyaHhPIm82465324653euoutp01g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1608288239; bh=9KezMUUVULx7n4oqVRKifY3dS7bgG4kBi31CM6pwfpE=; h=From:To:Cc:Subject:Date:References:From; b=PwRDL4j6CGU4FFigNfrjpGFCajMoz20vEqLqSCSU4QPDg1CcVNNJsB9saLewudImB 2dvNVonncu2gX+DQMp14fIWH3U/G2ddFymgRfLLdioDUhyjA4dOW72CTDSlShi1UNq cLobUkv+cPuRpRvn4/4uqZU62CAR4b4gcWjxO99c= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20201218104353eucas1p21aede2add43758e71b3ebd9206fd588d~RyaCrRFYe1246512465eucas1p2r; Fri, 18 Dec 2020 10:43:53 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 2F.C4.27958.9E78CDF5; Fri, 18 Dec 2020 10:43:53 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201218104353eucas1p266e5210f6272fc60b316881e3fb3c210~RyaCRg8ao1269612696eucas1p2M; Fri, 18 Dec 2020 10:43:53 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20201218104353eusmtrp175c6c6feff7c6ce689fcc012c0efd081~RyaCQMhU30824308243eusmtrp1G; Fri, 18 Dec 2020 10:43:53 +0000 (GMT) X-AuditID: cbfec7f2-f15ff70000006d36-02-5fdc87e9f75a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 38.17.21957.9E78CDF5; Fri, 18 Dec 2020 10:43:53 +0000 (GMT) Received: from AMDC2765.digital.local (unknown [106.120.51.73]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201218104353eusmtip1b4ad381c7e9013be7cc88aa0c1e29399~RyaB4fuEF0968009680eusmtip1T; Fri, 18 Dec 2020 10:43:52 +0000 (GMT) From: Marek Szyprowski To: u-boot@lists.denx.de, u-boot-amlogic@groups.io Cc: Marek Szyprowski , Neil Armstrong , Jaehoon Chung , Bartlomiej Zolnierkiewicz Subject: [PATCH] ARM: dts: meson: switch TFLASH_VDD_EN pin to open drain on Odroid-C4 Date: Fri, 18 Dec 2020 11:43:45 +0100 Message-Id: <20201218104345.18370-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsWy7djPc7ov2+/EG1y7bWCxccZ6Vosbv9pY LdYeuctucagv2mLShF9sFm/3drI7sHm8v9HK7jG/8zuTx9k7Oxg9+rasYgxgieKySUnNySxL LdK3S+DK2HC9ruAmV8XM/w0sDYyTOLsYOTkkBEwkfp2ZzwpiCwmsYJSYdkayi5ELyP7CKHH/ 3nEmCOczo8TP9peMMB33b61nhOhYzijx5jkHXMfl77+ZQBJsAoYSXW+72EBsEQEjiUtNO1hA ipgFdjNKtF9qYgFJCAuES0w58x6sgUVAVeLhiw6wOK+ArcTXCx1MENvkJVZvOMAMYX9kl5h5 NBTCdpGYvOskVFxY4tXxLewQtozE6ck9YMskBJoZJR6eW8sO4fQAndc0A+oHa4k7534BnccB dJKmxPpd+hBhR4mWrZ9ZQcISAnwSN94KgoSZgcxJ26YzQ4R5JTrahCCq1SRmHV8Ht/bghUtQ 53hIzHv5nQ0SQLESb2/eY57AKDcLYdcCRsZVjOKppcW56anFhnmp5XrFibnFpXnpesn5uZsY gVF/+t/xTzsY5776qHeIkYmD8RCjBAezkghv6IPb8UK8KYmVValF+fFFpTmpxYcYpTlYlMR5 V81eEy8kkJ5YkpqdmlqQWgSTZeLglGpgErKYt1FszXGHWTfWT0m4rDb1VfyUA3brko6r5pYp V1daP1LU27R0If+fKYyNPiWZ+ddufd3zLFM6x5T1/iXVCb0/rjsevSNQJfT7tUrhL/e6sxPW TNmy5f/nN7MT9of6Hpri2sHEtWfGzZ8nu18uNuoTsdvolePHs2bZx9Wil08Zxv7IOHLjSbbv ihvShlX98wxX3WZ5YjBP8Yi9WqoH27kt8xk4lzNcy/n8JXFCTvaP4L0eDBwaSsKr93fe++B6 tt3P67HFrJMsjLZRSrJBOds+Vr29MK3A2KTbPDd9zn7Lv9eLmvwldBZm+BWnhBr3PZZOvcG3 6vVZ1VOr4t1f3Zgzf9KW598SlpT2TElZO1WJpTgj0VCLuag4EQDgmSpsaQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLLMWRmVeSWpSXmKPExsVy+t/xu7ov2+/EG0zaJmyxccZ6Vosbv9pY LdYeuctucagv2mLShF9sFm/3drI7sHm8v9HK7jG/8zuTx9k7Oxg9+rasYgxgidKzKcovLUlV yMgvLrFVija0MNIztLTQMzKx1DM0No+1MjJV0rezSUnNySxLLdK3S9DL2HC9ruAmV8XM/w0s DYyTOLsYOTkkBEwk7t9az9jFyMUhJLCUUWLD95/sEAkZiZPTGlghbGGJP9e62CCKPjFK7Fyy mREkwSZgKNH1FiTBySECNOlk1yWwBmaBvYwSfTs9QWxhgVCJpzM3gNWzCKhKPHzRwQJi8wrY Sny90MEEsUBeYvWGA8wTGHkWMDKsYhRJLS3OTc8tNtQrTswtLs1L10vOz93ECAy3bcd+bt7B OO/VR71DjEwcjIcYJTiYlUR4Qx/cjhfiTUmsrEotyo8vKs1JLT7EaAq0byKzlGhyPjDg80ri Dc0MTA1NzCwNTC3NjJXEebfOXRMvJJCeWJKanZpakFoE08fEwSnVwLQmlnFG55Qbv8WnsYXG 2tlOdsi0j9jk3PtI46LbucMOfw5oNPhp5D8oFdxrcU/r3LHGHbv3TtpjcibkhdaamMATzAdE K1kfXdnt8Oryx24t+a74PcvmbeMQUFC9KiH2TMdM1pJt80+9rf/y9n7aeNL2Eevj5uKNmsK5 t79dOnP2EROz/y/j6SeaIuM/HecxVLnssUNlY/i0vh+Nb46p1DHGPPfodIiPil3z0/SUWVrK r5dsgWx/jy8VvK312I3184o4lpq5TNndoft+y1QHVFvbaHVz+3QlRS7gap6c/afxlqnVmq2z ZaON1A4mlbM+3Lp3yYbb/w9aLTii/vBFxrJnwh36vH0nkk8Gqm9Z1KbEUpyRaKjFXFScCAAV QRGLwAIAAA== X-CMS-MailID: 20201218104353eucas1p266e5210f6272fc60b316881e3fb3c210 X-Msg-Generator: CA X-RootMTR: 20201218104353eucas1p266e5210f6272fc60b316881e3fb3c210 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201218104353eucas1p266e5210f6272fc60b316881e3fb3c210 References: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN pin to the high impedance mode, otherwise the board is stuck in the middle of loading early stages of the bootloader from SD card. This can be achieved by using the OPEN_DRAIN flag instead if the ACTIVE_HIGH, what will leave the pin in input to achieve high state (pin has the pull-up) and solve the issue. Suggested-by: Neil Armstrong Signed-off-by: Marek Szyprowski Acked-by: Neil Armstrong --- This is a result of the discussion in the "[PATCH/RFC] board: amlogic: Fix Odroid-C4 SD card reboot issue" thread: https://lists.denx.de/pipermail/u-boot/2020-December/435295.html Patch for the upstream Linux DTS has been already submitted: https://lore.kernel.org/linux-amlogic/20201218102228.16211-1-m.szyprowski@samsung.com/ --- arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi index c431988075..fbcc8287c5 100644 --- a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi +++ b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi @@ -11,3 +11,7 @@ snps,reset-delays-us = <0 10000 1000000>; snps,reset-active-low; }; + +&tflash_vdd { + gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>; +};