From patchwork Thu Dec 17 14:12:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 1417699 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=1+Jgg8WJ; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CxYqf3yHmz9sW1 for ; Fri, 18 Dec 2020 01:13:02 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F2FBA82BDB; Thu, 17 Dec 2020 15:12:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="1+Jgg8WJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0F1B882BDC; Thu, 17 Dec 2020 15:12:56 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6D70082BCD for ; Thu, 17 Dec 2020 15:12:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=monstr@monstr.eu Received: by mail-ed1-x533.google.com with SMTP id r5so28747290eda.12 for ; Thu, 17 Dec 2020 06:12:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8fMm3q4YBBF0VZGT67tkGr4o0/5SI14PDxVuOwO/I5w=; b=1+Jgg8WJnehIVCvHnDFxXdXiGaCC37FzMhm9Ocw4bE2saWbskqw+ZCO1qhSDeN1YqG 7XrDxjlxAdincunUSmujUVD782ESXsgoBSqfWQs8VveZq7PwxP660ZLWJ0DUO9+11Pey /ExCwErQneAoLPMxCrTPDRvdjk10EbaXDgciFoQEGk4AmyGR+5zLuQ8rZLl3Rmx2WnHB /6IWM1RyZeCBUSHNSpaH/q+J9hHqkjEtT831gmEdZvrkS2lEQ/kHtofHCUMBKKSceIdl jCZwimxdXjNC/fK5HPgOtyl/Ptzkb2wDVpBrYZWtOiGSx1y0UALtvZHL/8KWJFYlM6jp ALLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=8fMm3q4YBBF0VZGT67tkGr4o0/5SI14PDxVuOwO/I5w=; b=OaTfs7yhLZ6wuK+0ivEzvNh3Jv7nLGjfnu4nR9DpdiCKtgWs3hwG8SJ20oUKLPOoRd G6ym3jmcIBTgWDMaHoMiX11VhUuwvWrMqeghRzELQLaPL2DYKIcZkffI59J3o6pucB88 GXa2HaURka1Bt5S6AAFctsVUNr5FEuZ3Wb+Qh8LReBhGxT1LXdxca05w8ibNYnzNnEnH D9Kngex6915z9W/89LBSNk+cKJX94xN21IBzG9M+pXs5iBNzBpi1RfCQJByH1pkXnm9z 3za1099dPcC+n4l1SNrJxxDSxU2ZQvBesxsMelzKuvJ1Pnc3iS38Dis9s5C4nSbOoPvV 5h6w== X-Gm-Message-State: AOAM531rdK65PdE24HZHX1Yppyi14IQaVkHZ1OGj5eTH34VFUuo9Wi5e Titu6wV9J8rMDLQTiNXf5fzAJDlGtr1BUi/u X-Google-Smtp-Source: ABdhPJyTXA7qONVsRBxYFJt9uAD8RimtV9M+AJ5WfRuZhvF0fGfjaJ1bq4ZEiwHsADARyq56Gg2gVA== X-Received: by 2002:a05:6402:1c90:: with SMTP id cy16mr39096772edb.73.1608214372897; Thu, 17 Dec 2020 06:12:52 -0800 (PST) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id l1sm3802321eje.12.2020.12.17.06.12.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Dec 2020 06:12:52 -0800 (PST) From: Michal Simek To: u-boot@lists.denx.de, git@xilinx.com Cc: T Karthik Reddy , Jagan Teki Subject: [PATCH] spi: zynqmp_gqspi: Fix unaligned data writes issue Date: Thu, 17 Dec 2020 15:12:51 +0100 Message-Id: <5eb5b5b81b5d1ff371346c2c56086472ec4501c2.1608214369.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean From: T Karthik Reddy When unaligned 3 bytes data write operation is performed, 3rd byte is being over written by 1st byte of 3 bytes data. This patch fixes it. Signed-off-by: T Karthik Reddy Signed-off-by: Michal Simek --- drivers/spi/zynqmp_gqspi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/zynqmp_gqspi.c b/drivers/spi/zynqmp_gqspi.c index e0e668703776..a56e8b250961 100644 --- a/drivers/spi/zynqmp_gqspi.c +++ b/drivers/spi/zynqmp_gqspi.c @@ -429,10 +429,8 @@ static int zynqmp_qspi_fill_tx_fifo(struct zynqmp_qspi_priv *priv, u32 size) data |= GENMASK(31, 16); break; case 3: - data = *((u16 *)buf); - buf += 2; - data |= (*((u8 *)buf) << 16); - buf += 1; + data = *buf; + buf += 3; data |= GENMASK(31, 24); break; }