From patchwork Sun Jan 7 18:04:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Yeryomin X-Patchwork-Id: 856577 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XbuoHfyy"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zF5t94t7Mz9sBZ for ; Mon, 8 Jan 2018 05:05:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:Date:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cn0NxMiriG0cNHMNw5NnnVMqBCpi/r2No9hSFKvb+Uc=; b=XbuoHfyyooj/wY ixLN+ateXtV+MZEPYY02G3L6esiatWHHng9+9AaOhD/PvlNaPcRCJP4lxciER0skx6SuQ3jKYYF9R spb2O2WvknrGwSzYQF8ySi7A6DrDdIDs79qXBMQiaSj6WkdzG1XGRKs++iAs/Q/TnBPoPZyVsdQRc 9qTojSpgOz0jJ70oPFhCYVe5RNgdL6w7pXqjUFJ3+p1reAZBNmbFx2ZrTiOUFesqDmKBeS+2hyzWs R7fM1IwZWKhhX4x8NlxdARYCMpEl3lplHU3PaWZtXY/roqRQJkn0Js/IohdVXaqa0IdLeILLgSxeU 3RtPLH0G/2Mb4kIQKLjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eYFK2-0005f1-P1; Sun, 07 Jan 2018 18:05:26 +0000 Received: from [213.175.92.62] (helo=mail.pbx.lv) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eYFJO-0004ct-5v for lede-dev@lists.infradead.org; Sun, 07 Jan 2018 18:05:24 +0000 Received: from localhost.localdomain (unknown [213.175.92.61]) by mail.pbx.lv (MailSystem) with ESMTPSA id 532D51A0A3B for ; Sun, 7 Jan 2018 20:04:29 +0200 (EET) From: Roman Yeryomin To: LEDE Development List Date: Sun, 7 Jan 2018 20:04:02 +0200 Message-Id: <20180107180402.14368-1-roman@advem.lv> X-Mailer: git-send-email 2.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180107_100447_227997_99F57C03 X-CRM114-Status: UNSURE ( 6.19 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.1 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS Subject: [LEDE-DEV] [PATCH fstools] overlay: fix compilation with glibc X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org glibc fails with: warn_unused_result [-Wunused-result] system("cp -a /tmp/root/upper/* / 2>/dev/null"); Regression intoroduced with 11efbf3b90f031ce634fc38cad07a4aef2985777 Reported here: https://www.mail-archive.com/lede-dev@lists.infradead.org/msg10502.html Signed-off-by: Roman Yeryomin Acked-by: Florian Fainelli --- libfstools/overlay.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libfstools/overlay.c b/libfstools/overlay.c index 0187a55..1d69f5a 100644 --- a/libfstools/overlay.c +++ b/libfstools/overlay.c @@ -257,7 +257,8 @@ jffs2_switch(struct volume *v) /* try hard to be in sync */ ULOG_INFO("syncronizing overlay\n"); - system("cp -a /tmp/root/upper/* / 2>/dev/null"); + if (system("cp -a /tmp/root/upper/* / 2>/dev/null")) + ULOG_ERR("failed to sync jffs2 overlay\n"); break; case FS_EXT4: