From patchwork Fri Jan 5 22:14:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 856253 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-470277-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="QG5gQBGS"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zD0qf3Zlkz9s1h for ; Sat, 6 Jan 2018 10:14:38 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:reply-to:to:date:content-type :mime-version:content-transfer-encoding; q=dns; s=default; b=Z+M /flmueR98m3hI6+rsqj3/ETQiASYxrrMdf7kRxBzLB4Icrl/AnuAUbttBNBswF9q 4PNYmFxZPhPatqbkcIaRMhOzaYij6TLSm/xXrIXUPAa5EYTFkt4HunwJkCItoT+e qXHZVwxg9L26BlixajcEhje261qwXZa4EkQ2xsuk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:reply-to:to:date:content-type :mime-version:content-transfer-encoding; s=default; bh=3ap3t2fkm fUoIbJW9exbKrTqqWM=; b=QG5gQBGS1lGsMDlmO7G9XxluqbXSoXl+lIntoQJk1 Y5FGlRjwIngWbX1Ruil70JkSp6jPe9+cbuWftiXix4M7EiFjoduZapdQUWSME3Uf TE4uk30rkaWd7Sp3qHZ0V+IEOwKfBmKEP5xC7MMgdZ9l7sZxnDhS3zRO6klv+qZn uE= Received: (qmail 64232 invoked by alias); 5 Jan 2018 22:14:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 64208 invoked by uid 89); 5 Jan 2018 22:14:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1384 X-HELO: NAM02-BL2-obe.outbound.protection.outlook.com Received: from mail-bl2nam02on0079.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) (104.47.38.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Jan 2018 22:14:34 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Received: from sellcey-dt.caveonetworks.com (50.233.148.156) by BLUPR0701MB2034.namprd07.prod.outlook.com (10.163.122.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Fri, 5 Jan 2018 22:14:30 +0000 Message-ID: <1515190466.18339.14.camel@cavium.com> Subject: [Patch][aarch64][PR target/83335] Fix regression, ICE on gcc.target/aarch64/asm-2.c From: Steve Ellcey Reply-To: sellcey@cavium.com To: gcc-patches , "james.greenhalgh" , Marcus Shawcroft , "richard.earnshaw" , Christophe Lyon Date: Fri, 05 Jan 2018 14:14:26 -0800 Mime-Version: 1.0 X-ClientProxiedBy: CO2PR05CA0064.namprd05.prod.outlook.com (10.166.88.160) To BLUPR0701MB2034.namprd07.prod.outlook.com (10.163.122.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9dc2fe56-7d27-4542-a0d0-08d55489b1aa X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060); SRVR:BLUPR0701MB2034; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2034; 3:VhdOBBHoV4/ZqjEojmip1rliGLblAP1ueZaZCNlqdrf86QBbqPKoKT4wvEzUgok5nedDPZxOxl+k6ZN/YmST9Rbhy0+XwWzGXNOWyb0grPRKRYLcqheW+hUzxMi/7PtK19vF3VwcUj87IibK46xOuc8hY6W33xcf8xfySfj3lLt/D/YQ9XSOH7ftWhaae0JhPFcJAQH/7dQoSDrvqfWTaFMPmuo0+1JLjh6oKk/8WNuB8WVl63UUiEnp3oxJ7hkT; 25:3+IiXx1uoqO0mIrrtoJddRtajYxcuWv/MBe/ro8ZDICzvPqi9C+3t3DnFvMcg9hqPvmCdFwj1zWSg10XS0Yv4QozMMMoy418ILgj5J0eX1qqR63dzXYRVErYwkyjkOOUEmdmlViuG87fh602u/D3WREBmDPGZ1cB3YVfTXBbIxhgWRPCdJt0XYEP01d+A3hYufGkp5o/vfXRYduiB/QvlbfgUtADpe9ivyPSt34MM/fhzATlm8vET1D/IYWJqZN8GCFPj/fb5XZbpollORJBkQkEF3moyh8KePB9jfMPt4SQMhpzkOpumncWhMluP2q89RiIvXOyXG3e1fGW6xsaOQ==; 31:XYnopntkt7YeIeXZKIzbzn5qathMjCvR7VMZlwd3YNHHt29oTFdC6nUv/C8Vtu1V2KP7h1LcaM1T9HaWT4MLCEHOgnhMH+sL7W8oXbywSMNkEEzLobhExDHoQLFxS4E5pJS7qMB3EVCRZ1IfndlFxsLmk9u87M+Gs/26UiqlPFdP7UtNFe22KeYnYjTy2Us50uX419OKLow0nkcHO5c3wCHB0AtFB0YZOWQSpS9TRls= X-MS-TrafficTypeDiagnostic: BLUPR0701MB2034: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2034; 20:f1CCNaYMqsxdbg/ZCLpW+YKkWXHH9y9i9m3Uhih4AVd3w8gXZV2aCr8FcZssfjKmIXVSmmznXTh/ozcoMkUDUb0yjyLmpL1ycLCOeG5EtAHjXBX/uled23fRBW7OE6DDCYmE1KiO0GoNA19H1rn4VOHslKzNBcheibioZhf9lRY4FZHLRdC4HTHHh2Yzw4YtOJZ8MFVzYd4q1YG1CCokk5OGlmAOZC+FV4KSXe7IJ1LPDNQmMlyuNBuG3JzGzf88HLYdqfTkooFiuRAlWzpIUaXzPk4XYyHv0Fc0kXQCQK1N/uSYkemFdLl7xUXQa/8aQkd8Dzxt3u5OmJZL66LcJcA+jlZyDIhHObk+Ek3DN8Q4V/yhw0Cd5BisuQJ34kCf7fV/A1smYCOHJtnIXA6WMGuMguWVC2CE36tFZTZfCBF3o4dYCbPwkkBuc60kNyTEyiwsYuBrbPpvUBnzLdxnZEYvokgK6wHnhpIFK2ggDHnvktEKk+cc77pdJ7Bfn+Nt; 4:jhs7U6YSnmGHHJd+oEDfoq2Ga8r+Q2/ygx1U9uEDK9SMEoHCdhisTN1jnn3OejWwzA6lPPgkC4LV8IgDxGbj3YpKQPB+TBV5P1SwJ0jxqP1StV88oSc7EvXbPjdRZvXIAAaodfU9acMpHePh1gELhdd7q4ZBpRlPAm/HUkTTJBkKGovylzDAWB7Tu7EIhQkdlewcjB+ggzkjRNpFVEIb+CFle/MFX0YCPMdXOTHgluBTLDQPMEckvapwk2F+69KpPS5ZbnTfoMyi8SOhBkJXbA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231023)(944501075)(6041268)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:BLUPR0701MB2034; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BLUPR0701MB2034; X-Forefront-PRVS: 05437568AA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(366004)(396003)(39380400002)(376002)(377424004)(189003)(199004)(43066004)(36756003)(25786009)(16526018)(7736002)(103116003)(478600001)(72206003)(305945005)(50466002)(68736007)(5820100001)(23676004)(8676002)(81156014)(5660300001)(52116002)(6506007)(386003)(6486002)(6116002)(6512007)(69596002)(3846002)(66066001)(47776003)(316002)(106356001)(2906002)(105586002)(110136005)(53936002)(6666003)(53416004)(81166006)(2870700001)(97736004)(3450700001)(50226002)(8936002)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB2034; H:sellcey-dt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BBLUPR0701MB2034=3B23=3Aqs?= =?utf-8?q?GWqllZlPIRQxnYUnBGFjh9LbXg9U+W8uZqqTY9ClBcjQzA0QhxYEwwbE?= =?utf-8?q?Myd3/ueYjn4OfrUx+kI5jWJ8OEz4YetrbFr2fWW7OFr79AJ/r3yGrgJY?= =?utf-8?q?pC7Cked6mbdOjaMemi/2ThZCU1WTFnZTxxw1hNK0cUk1Ez5D2QKM/Oi5?= =?utf-8?q?m/wgF/gR2s8UwYZXiG6SZ71eXsuLkW9UpwxnIx3VX1ji06uae+F+Bo4z?= =?utf-8?q?snj2QsOROAaRQtXxYJdAfIFXbqQ+Q5D1F6CpRywtXpKn9Rn2Ki+zIuFn?= =?utf-8?q?IPcgvdk1h6JGKkpq+Ao9QGVcgBvrC0nbwJ9VR+AxbTWFRttEolMxSVOl?= =?utf-8?q?uhhM8c8b3nOUwygXmMgcm5CDlJXtTt8WURGHJ7NfaJRL52KBAFhx/ZyE?= =?utf-8?q?n5hY8c8+EumzmUeqtpR7Ye8rbA5SNpZW3wjmM5m68f78ydwJcuKSIzvw?= =?utf-8?q?SKayZ1FJmCbWmVkePG1k7eWbF3jry062l80X1eXbL1X8yROKrqLjxdSl?= =?utf-8?q?hjb0P9FuW1ri9h7XAteSntq6EFhmI3dYSqGKNvmRRoSdjkcGMDuQyJ6Q?= =?utf-8?q?NiEn6m2En75n3ARPOpXcCzeliGeP55jrEbZ4m1+OS+qxdmS6JmFlkbco?= =?utf-8?q?zUZTbd1BrMpeiGsE3Lf2M3aZ4VJQY25Fi3RxKH+ANfMmh2pLh3uiz3XP?= =?utf-8?q?5LjA+JnZ7EkMsK8QZy9C0VIFGoC2V1FzKBcDTXBCcxkESzZCrd1rdnA+?= =?utf-8?q?kYCbwsOeSXnekViWmwoNpxwjwWqNEH80TYylY6iXLfy+ePqy1ZSf9fYm?= =?utf-8?q?4+PNzJafaW9tB0oU9WuL9A5XqRTmAU4jLLAeEmYOa4U+fIW1D6yb5kjY?= =?utf-8?q?SbI5l9whxlzt4O0Z0uoZ5YScyDxexg3xWN9hnsDVBo+79haUXMO5XPsS?= =?utf-8?q?0u1QekQhjUV8Hz/KydGh5gJEwNh9db4SiF2mXeoLn3tp62lcyrueakQV?= =?utf-8?q?6lX7zb0/rfviDkdWyhskQPTcwLDjg/Lw/zEZdF+H3DYun3e8GUG7XCM8?= =?utf-8?q?5fmDjeb93qmqtisukzF0NaKkWDMbGC5coClG34TCO3V+yEd17kilr2P+?= =?utf-8?q?xg/z7Yh5WGdx+T6x1ET4LTuOkEaevZ2j6/hFAMariYVD5bUYZcL2Iohk?= =?utf-8?q?dsP881ghsQA1Mo1McaR/rdwLFCkoVr1pM1z/Z4zGkGLUG3BqgZIztekq?= =?utf-8?q?8HMD0vyUSEukyVfmU=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2034; 6:Nnmv6BO8lZLIEeexByZA7ddEP7VVRoG72vEHqpmavP0zJk9ZCt+VnhrtIDaigjFIYlEkOikOj9WMGM8gjmImCs/koW1giPHhv4Hm1yO92P7zk/8M5mFEP8/G2Ieln5uhO3QiDoF2d/3DIzpnbT5ga2+9GHwD1Udkm4WSoTutEzA4r5uVOF3A/dttxqtjWA+5a/WViyXifAzMb/EAnFABZy1g/CCw280+VXnkrR4l2m7MDLq3Hf/K6dOjb+HFU4tgyRfOpE8+sJtWJuK8GxQpTkwmg7WQ3BSZgZDO9DjbJz6vo/dcVegUIFjZGW6tTmtpeD5uSj1ORRD6gE94Ze5CwwmzRueZnfzdBoKHSaO+AkE=; 5:vPkX5THbB5LpOh1o4oIP64/7/7zGmc6AunuS519wUkWAgc55x2KsAMwSKIDCPVwZdtNkHKOgR0FeqdcaJmo9h2Y3FPdOIkO7QgNibTCd+4h4qEXhjg1fMzZDdRJtvdgzs/G8xDGSzF8jHeicrS/XWSEF+8+NQHRfU8892sI9PKk=; 24:AtYMEe5Ku44Om5DVQHoWXA6zYsdDDoaf1ju7DVPw7UPibSPRXvx32VTNLGAVjC0umuP3juf8LHI6mwTT003L5B/Ia49DUfbSheqaUznmcHA=; 7:j7EQi64I8TIyT1fpuBSPYZmvV0bw3zXUNDgyGP+opwOsmHobt+nm5kS1UzNB6aJZhhQGfulmL7nxP4w+A4SqQ0jDuoznBxJqNt6eO3FBE7vsAM0ojw6XMxyhmHDuk0xYAqRT1SNZsVILgGGIXw8OjwTBb3PLOEvZa8KQQ+KQ5jJG45tUOMYoJ1TfOcW35lSVmmmywsMKE+aH27HcMMcvWLzZXUroxR59B7n9EGWLZLem0Tw4A1sa4QyFwxAs2vEG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2018 22:14:30.3920 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dc2fe56-7d27-4542-a0d0-08d55489b1aa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB2034 This is a fix for PR target/83335.  We are asserting in aarch64_print_address_internal because we have a non Pmode address coming from an asm instruction.  My fix is to  just allow this by checking this_is_asm_operands. This is what it was doing before the assert was added that caused the ICE. Verified that it fixed gcc.target/aarch64/asm-2.c in ILP32 mode and that it caused no regressions. Steve Ellcey sellcey@cavium.com 2018-01-05  Steve Ellcey   PR target/83335 * config/aarch64/aarch64.c (aarch64_print_address_internal): Allow non Pmode address in asm statements. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index a189605..af74212 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -5670,8 +5670,9 @@ aarch64_print_address_internal (FILE *f, machine_mode mode, rtx x,  {    struct aarch64_address_info addr;   -  /* Check all addresses are Pmode - including ILP32.  */ -  gcc_assert (GET_MODE (x) == Pmode); +  /* Check all addresses are Pmode - including ILP32, +     unless this is coming from an asm statement.  */ +  gcc_assert (GET_MODE (x) == Pmode || this_is_asm_operands);      if (aarch64_classify_address (&addr, x, mode, true, type))      switch (addr.type)