From patchwork Fri Jan 5 14:24:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 856059 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s11eZuEw"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="BFQy+nN7"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zCn4n3h0yz9s75 for ; Sat, 6 Jan 2018 01:25:13 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-Id:Date:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WmjGkcydeqTdp/nyQwJFz623XH063rJjW4IWPvHcoaU=; b=s11eZuEwzaWMRY LG+D9bGQmyo7wvIcXzs1d7edtnS+0HtCr/PE2aC0yH+MW+D67Vyusk1dfBtPQb7x1+WmkklkoAgYE I8VZExvGLvoUW20TSbx2YGA0HEhW7jgYqMXgOHwlLmd3a+QeqhPptzDMcb3/NnrM6A+MSQpShXaTO pYsNXfGsJNgeW9GDSnQmPDxTnQCuJgMoYTsIG30dULNaDuw7styQ3rOED4NdOU9ULdBSm0CjhsCY2 a4JZhClPA6W8JABKGP1cF4e2zWZe7R39HmvuHEOUEIJI2WA2+TRbb8+BqLv6dmKvdrBEeU3qnIoKt 1uXNJyjCJCog8vtgM6Cw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXSva-0004eu-7N; Fri, 05 Jan 2018 14:24:58 +0000 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXSvW-0004eG-TK for lede-dev@lists.infradead.org; Fri, 05 Jan 2018 14:24:56 +0000 Received: by mail-lf0-x241.google.com with SMTP id y71so5288063lfd.12 for ; Fri, 05 Jan 2018 06:24:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=A6AIU6FoEoTEmL6XqXnP0MXPNpD4yfjbYRJzMc3Mkdc=; b=BFQy+nN7GszzENC0n8EhVzFkTZvsARIU7QClyBvkQX4X8XVt2UgeEQOA3rr5rX/viQ aa4HKGaTMsilY0GyDzktDI849MYQDOQj2DIkEsbe3vxJ6QNpB+XzFoDMA+j82fPj23Ow REYT22Zfbv6jxSqB1x3Ccesfwg8NxloLHcOjFWOXFbWs8MtEZRRWcxZQfMK4C72iyqQ1 jwyGZ3XVaG+6gx2JFFi0aeEgUgptgdK6WzADNuSmI0dM4QagWuZXUmT5Glr6fIpKAw0m BE4mAhVd6ikQBuUpiMBjvQci/pQJfgzLevJvqfIDTEJuSJ1VqGSahA7RDk8hjbtNJozk II6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=A6AIU6FoEoTEmL6XqXnP0MXPNpD4yfjbYRJzMc3Mkdc=; b=M/SSa8xD5tzU0B60t4bSJQNfEOLzKk4MFDWVEdgbsQ7QeKrl6k6q3OP0uBffsZnogy oDRsD36Vy2aNFTqxyji6BJRwdp+iELDmDbOgHXZfLGcYZtypcWotSRN0J0Sa7j2M1jVd a+cqcOBwDaLin8uuPIiaU4VomQXdoFQWwZJ7XcnUk4bae6rle1Ga1Q78jrT+VqBmqsOn JbVR3CCcfYsZT+AwUxIhG26hdFbcHn9mnIgjmSmT6keiU/H6bk/KNxB0sduUZhc3FWxb NiHNPSVAqxxjvvcPkIwlKHea2j8HKXEfMDHXCbtlS67Ltdi1ItWHIAlQ8h1u5cZVDA0+ HNRw== X-Gm-Message-State: AKwxyteJii1gg7U7hlH6f0hL4kYswDYcbgdXpfH9ytpr73JQvTDHJrh/ mvyRyHJ8DupwXB2LanimFHY= X-Google-Smtp-Source: ACJfBovIVKQ/pzSrJdpWEffD7iA04iAOTJnfluzpXifVHNuFNhVY03fbpql+Hw7XjKH/DCwlMy8ITw== X-Received: by 10.25.171.10 with SMTP id u10mr1600068lfe.12.1515162282494; Fri, 05 Jan 2018 06:24:42 -0800 (PST) Received: from linux-samsung.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id p62sm1038805lje.67.2018.01.05.06.24.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jan 2018 06:24:41 -0800 (PST) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: John Crispin , Jo-Philipp Wich , lede-dev@lists.infradead.org Date: Fri, 5 Jan 2018 15:24:30 +0100 Message-Id: <20180105142430.17981-1-zajec5@gmail.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180105_062454_950628_685A05D8 X-CRM114-Status: UNSURE ( 7.27 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.8 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:4010:c07:0:0:0:241 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zajec5[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (zajec5[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Subject: [LEDE-DEV] [PATCH fstools] libfstools: optimize building directory string for glob X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Rafał Miłecki glob should handle paths like /foo/bar//* so we probably don't need this extra check & code. Signed-off-by: Rafał Miłecki --- This optimization/simplification was suggested by Jo while reviewing [PATCH] libfstools: support file paths longer than 255 chars --- libfstools/overlay.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libfstools/overlay.c b/libfstools/overlay.c index e610b8d..0187a55 100644 --- a/libfstools/overlay.c +++ b/libfstools/overlay.c @@ -86,10 +86,7 @@ foreachdir(const char *dir, int (*cb)(const char*)) globdirlen = len; } - if (dir[dirlen - 1] == '/') - sprintf(globdir, "%s*", dir); - else - sprintf(globdir, "%s/*", dir); + sprintf(globdir, "%s/*", dir); if (!glob(globdir, GLOB_NOESCAPE | GLOB_MARK | GLOB_ONLYDIR, NULL, &gl)) for (j = 0; j < gl.gl_pathc; j++) {